nilly_vanilly 0.3.0 → 1.0.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: f2b5272e3e32237f05d2b6e7d836a40835cba0af
+  data.tar.gz: 6cff72a1d01d1e30db61ef9bb54606ef284c5d21
+SHA512:
+  metadata.gz: e49c828ef339685a84272c51dc02bcd602c176b8b614496da53d5593ec634d18d1cb0dd37f5c17577f5b0bf639829e5f62a63e13738affc06f9cdf65331be619
+  data.tar.gz: 986199e035615de0f4e3241cfaeca2269101bc2d957e203756d74408e50fcab889397bcf020f905a469a55ee0674181a46fd8c36edea775e4b5215a4685f96b0

data/.gitignore

@@ -1,10 +1,15 @@
-spec/debug.log
-nilly_vanilly.sqlite3
-coverage
-rdoc
-doc
-.yardoc
-.bundle
-spec/db/database.yml
-*.gem
-.ruby-version
+/.bundle/
+/.yardoc
+/_yardoc/
+/coverage/
+/doc/
+/pkg/
+/spec/reports/
+/tmp/
+
+/nilly_vanilly.sqlite3
+/spec/db/database.yml
+/spec/debug.log
+
+# rspec failure tracking
+.rspec_status

data/.rspec

@@ -1,2 +1,3 @@
---color
 --format documentation
+--color
+--require spec_helper

data/.travis.yml

@@ -0,0 +1,5 @@
+sudo: false
+language: ruby
+rvm:
+  - 2.4.2
+before_install: gem install bundler -v 1.16.0

data/CODE_OF_CONDUCT.md

@@ -0,0 +1,74 @@
+# Contributor Covenant Code of Conduct
+
+## Our Pledge
+
+In the interest of fostering an open and welcoming environment, we as
+contributors and maintainers pledge to making participation in our project and
+our community a harassment-free experience for everyone, regardless of age, body
+size, disability, ethnicity, gender identity and expression, level of experience,
+nationality, personal appearance, race, religion, or sexual identity and
+orientation.
+
+## Our Standards
+
+Examples of behavior that contributes to creating a positive environment
+include:
+
+* Using welcoming and inclusive language
+* Being respectful of differing viewpoints and experiences
+* Gracefully accepting constructive criticism
+* Focusing on what is best for the community
+* Showing empathy towards other community members
+
+Examples of unacceptable behavior by participants include:
+
+* The use of sexualized language or imagery and unwelcome sexual attention or
+advances
+* Trolling, insulting/derogatory comments, and personal or political attacks
+* Public or private harassment
+* Publishing others' private information, such as a physical or electronic
+  address, without explicit permission
+* Other conduct which could reasonably be considered inappropriate in a
+  professional setting
+
+## Our Responsibilities
+
+Project maintainers are responsible for clarifying the standards of acceptable
+behavior and are expected to take appropriate and fair corrective action in
+response to any instances of unacceptable behavior.
+
+Project maintainers have the right and responsibility to remove, edit, or
+reject comments, commits, code, wiki edits, issues, and other contributions
+that are not aligned to this Code of Conduct, or to ban temporarily or
+permanently any contributor for other behaviors that they deem inappropriate,
+threatening, offensive, or harmful.
+
+## Scope
+
+This Code of Conduct applies both within project spaces and in public spaces
+when an individual is representing the project or its community. Examples of
+representing a project or community include using an official project e-mail
+address, posting via an official social media account, or acting as an appointed
+representative at an online or offline event. Representation of a project may be
+further defined and clarified by project maintainers.
+
+## Enforcement
+
+Instances of abusive, harassing, or otherwise unacceptable behavior may be
+reported by contacting the project team at joost@spacebabies.nl. All
+complaints will be reviewed and investigated and will result in a response that
+is deemed necessary and appropriate to the circumstances. The project team is
+obligated to maintain confidentiality with regard to the reporter of an incident.
+Further details of specific enforcement policies may be posted separately.
+
+Project maintainers who do not follow or enforce the Code of Conduct in good
+faith may face temporary or permanent repercussions as determined by other
+members of the project's leadership.
+
+## Attribution
+
+This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4,
+available at [http://contributor-covenant.org/version/1/4][version]
+
+[homepage]: http://contributor-covenant.org
+[version]: http://contributor-covenant.org/version/1/4/

data/Gemfile

@@ -1,8 +1,5 @@
-source "http://rubygems.org"
+source "https://rubygems.org"
 
-gemspec
+git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
 
-gem 'activerecord', '>= 2'
-gem 'rspec'
-gem 'sqlite3'
-gem 'rake'
+gemspec

data/Gemfile.lock

@@ -1,32 +1,57 @@
 PATH
   remote: .
   specs:
-    nilly_vanilly (0.3.0)
+    nilly_vanilly (1.0.0)
+      activerecord (>= 4.0.0)
 
 GEM
-  remote: http://rubygems.org/
+  remote: https://rubygems.org/
   specs:
-    activerecord (2.3.12)
-      activesupport (= 2.3.12)
-    activesupport (2.3.12)
-    diff-lcs (1.1.2)
+    activemodel (5.1.5)
+      activesupport (= 5.1.5)
+    activerecord (5.1.5)
+      activemodel (= 5.1.5)
+      activesupport (= 5.1.5)
+      arel (~> 8.0)
+    activesupport (5.1.5)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (~> 0.7)
+      minitest (~> 5.1)
+      tzinfo (~> 1.1)
+    arel (8.0.0)
+    concurrent-ruby (1.0.5)
+    diff-lcs (1.3)
+    i18n (0.9.5)
+      concurrent-ruby (~> 1.0)
+    minitest (5.11.3)
     rake (10.0.3)
-    rspec (2.6.0)
-      rspec-core (~> 2.6.0)
-      rspec-expectations (~> 2.6.0)
-      rspec-mocks (~> 2.6.0)
-    rspec-core (2.6.4)
-    rspec-expectations (2.6.0)
-      diff-lcs (~> 1.1.2)
-    rspec-mocks (2.6.0)
-    sqlite3 (1.3.3)
+    rspec (3.7.0)
+      rspec-core (~> 3.7.0)
+      rspec-expectations (~> 3.7.0)
+      rspec-mocks (~> 3.7.0)
+    rspec-core (3.7.1)
+      rspec-support (~> 3.7.0)
+    rspec-expectations (3.7.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.7.0)
+    rspec-mocks (3.7.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.7.0)
+    rspec-support (3.7.1)
+    sqlite3 (1.3.13)
+    thread_safe (0.3.6)
+    tzinfo (1.2.5)
+      thread_safe (~> 0.1)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
-  activerecord (>= 2)
+  activerecord (= 5.1.5)
   nilly_vanilly!
   rake
-  rspec
-  sqlite3
+  rspec (= 3.7.0)
+  sqlite3 (= 1.3.13)
+
+BUNDLED WITH
+   1.16.0

data/LICENSE.txt

@@ -0,0 +1,21 @@
+The MIT License (MIT)
+
+Copyright (c) 2018 Joost Baaij
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE.

data/README.markdown

@@ -1,5 +1,4 @@
-NillyVanilly
-============
+# NillyVanilly
 
 This Rails gem/plugin stores NULL in your database when you try to store an empty string.
 
@@ -11,47 +10,35 @@ values for which you did not mean to enter any value. This plugin makes sure
 to save NULL in database varchar columns that are defined with DEFAULT NULL.
 
 
-Example
-=======
+## Example
 
-    class Comment < ActiveRecord::Base
-      nillify :author_url
-    end
+``` ruby
+class Comment < ActiveRecord::Base
+  nillify :author_url
+end
 
-    comment = Comment.create :author_url => ""
-    comment.author_url        # -> nil
-  
+comment = Comment.create :author_url => ""
+comment.author_url        # -> nil
+```
 
-Installation
-============
+## Installation
 
-The preferred method of installation is now as a gem.
+Install this gem using Bundler:
 
-    config.gem 'nilly_vanilly'
+``` ruby
+gem 'nilly_vanilly'
+```
 
-or, for Rails 3 with Bundler in your Gemfile:
+and then run `bundle`.
 
-    gem 'nilly_vanilly'
 
-Previous versions of Nilly Vanilly were distributed as a Rails plugin. For Rails
-2 apps this might still work, but is not supported. If you absolutely need the
-Rake task in your Rails 2 app, you can:
-
-    ./script/plugin install git://github.com/tilsammans/nilly_vanilly.git
-
-Installation as a plugin in Rails 2 adds a rake task you can run to find suitable
-columns for nillification. For Rails 3, I will add this task in a future version.
-Until then you can find the same information by running:
-
-    ./script/runner "NillyVanilly::Inspect.print"
-
-
-Inspection
-==========
+## Inspection
 
 To see what columns are eligible for nillification, run the following:
 
-    rake nilly:vanilly:inspect
+```
+rake nilly:vanilly:inspect
+```
 
 This will print a list of all tables in your database, cross-referenced with
 the models in your application. All text columns which may be NULL and are
@@ -60,9 +47,7 @@ This does not take into account any validations you might have.
 
 When a column has already been nillified, it will be indicated with [OK].
 
-
-But WHY?!!
-==========
+## But WHY?!!
 
 You: who cares that empty strings are stored in the database?
 Me: if you don't care, just move along. And would I recommend you nillify
@@ -72,18 +57,27 @@ required if you have a unique index on that column. Unique indexes are the
 fastest you can have, and they deal great with NULL values. Empty strings?
 Not so much so.
 
+## Development
+
+After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
+
+To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
+
+## Contributing
+
+Bug reports and pull requests are welcome on GitHub at https://github.com/tilsammans/nilly_vanilly. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.
+
+## License
 
-Contributing
-============
+The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).
 
-Fork and clone the repo and hack away.
+## Code of Conduct
 
-It is very important you *must* run the specs before sending a pull request.
+Everyone interacting in the NillyVanilly project’s codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/tilsammans/nilly_vanilly/blob/master/CODE_OF_CONDUCT.md).
 
 
-Author
-======
+## Author
 
 Joost Baaij
 <joost@spacebabies.nl>
-[www.spacebabies.nl](http://www.spacebabies.nl/)
+[www.spacebabies.nl](http://www.spacebabies.nl/)

data/Rakefile

@@ -1,5 +1,4 @@
 require 'bundler/gem_tasks'
-
 require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new('spec')

data/bin/console

@@ -0,0 +1,14 @@
+#!/usr/bin/env ruby
+
+require "bundler/setup"
+require "nilly_vanilly"
+
+# You can add fixtures and/or initialization code here to make experimenting
+# with your gem easier. You can also use a different console, if you like.
+
+# (If you use this, don't forget to add pry to your Gemfile!)
+# require "pry"
+# Pry.start
+
+require "irb"
+IRB.start(__FILE__)

data/bin/setup

@@ -0,0 +1,8 @@
+#!/usr/bin/env bash
+set -euo pipefail
+IFS=$'\n\t'
+set -vx
+
+bundle install
+
+# Do any other automated setup that you need to do here

data/lib/nilly_vanilly.rb

@@ -7,3 +7,6 @@ if defined?(ActiveRecord::Base)
 end
 
 require "nilly_vanilly/railtie" if defined?(Rails)
+
+module NillyVanilly
+end

data/lib/nilly_vanilly/inspect.rb

@@ -4,32 +4,32 @@ module NillyVanilly
     def initialize
       @results = []
     end
-    
+
     # A nested array with one row for each column suitable for nillification.
     def results
       ActiveRecord::Base.connection.tables.each do |table|
         model = table.classify.constantize rescue next
-        
+
         model.columns.each do |column|
           present = model.respond_to?(:nillify_attributes) && model.nillify_attributes.include?(column.name.to_sym)
 
           @results << [present, model.name, column.name] if include_column(column)
         end
       end
-      
+
       @results
     end
-    
+
     # Print an inspection report to stdout.
     def self.print
       new.results.each do |result|
         puts [result[0] ? "[OK]" : "[  ]", result[1].ljust(20), result[2]].join(" ")
       end
     end
-    
+
     private
       def include_column(column)
-        column.text? && column.null && column.default.nil?
+        %i(string text).include?(column.type) && column.null && column.default.nil?
       end
   end
-end
+end

data/lib/nilly_vanilly/version.rb

@@ -1,3 +1,3 @@
 module NillyVanilly
-  VERSION = "0.3.0"
+  VERSION = "1.0.0"
 end

data/nilly_vanilly.gemspec

@@ -7,12 +7,21 @@ Gem::Specification.new do |s|
   s.version     = NillyVanilly::VERSION
   s.authors     = ["Joost Baaij"]
   s.email       = ["joost@spacebabies.nl"]
+
   s.homepage    = "https://github.com/tilsammans/nilly_vanilly"
   s.summary     = %q{This plugin stores NULL in your database when you try to store an empty string.}
   s.description = %q{This plugin stores NULL in your database when you try to store an empty string.}
+  s.license     = 'MIT'
 
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
   s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   s.require_paths = ["lib"]
-end
+
+  s.add_dependency 'activerecord', '>= 4.0.0'
+
+  s.add_development_dependency 'activerecord', '5.1.5'
+  s.add_development_dependency 'rspec', '3.7.0'
+  s.add_development_dependency 'sqlite3', '1.3.13'
+  s.add_development_dependency 'rake'
+end

data/spec/nilly_vanilly/inspect_spec.rb

@@ -1,7 +1,5 @@
-require 'spec_helper'
-
-describe NillyVanilly::Inspect do
+RSpec.describe NillyVanilly::Inspect, type: :model do
   it "returns array of models/columns" do
-    subject.results.first.should == [true, "Post", "title"]
+    expect(subject.results.first).to eq([true, "Post", "title"])
   end
 end

data/spec/nilly_vanilly_spec.rb

@@ -1,20 +1,18 @@
-require 'spec_helper'
-
-describe NillyVanilly do
+RSpec.describe NillyVanilly, type: :model do
   describe "model with one column" do
     it "stores class methods" do
-      Post.nillify_attributes.should == [:title]
+      expect(Post.nillify_attributes).to eq [:title]
     end
 
     it "stores nil for empty string" do
       post = Post.create! :title => ""
-      post.title.should be_nil
+      expect(post.title).to be_nil
     end
   end
-  
+
   describe "model with two columns" do
     it "stores class methods" do
-      Comment.nillify_attributes.should == [:author, :author_email]
+      expect(Comment.nillify_attributes).to eq [:author, :author_email]
     end
   end
 end

data/spec/spec_helper.rb

@@ -1,6 +1,4 @@
-require 'rubygems'
 require 'bundler/setup'
-
 require 'nilly_vanilly'
 
 # Requires supporting files with custom matchers and macros, etc,
@@ -8,5 +6,13 @@ require 'nilly_vanilly'
 Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each {|f| require f}
 
 RSpec.configure do |config|
-  # some (optional) config here
-end
+  # Enable flags like --only-failures and --next-failure
+  config.example_status_persistence_file_path = ".rspec_status"
+
+  # Disable RSpec exposing methods globally on `Module` and `main`
+  config.disable_monkey_patching!
+
+  config.expect_with :rspec do |c|
+    c.syntax = :expect
+  end
+end

data/spec/support/database.rb

@@ -1,3 +1,4 @@
+require 'sqlite3'
 require 'yaml'
 
 ENV['DB'] ||= 'sqlite3'
@@ -5,17 +6,13 @@ ENV['DB'] ||= 'sqlite3'
 database_yml = File.expand_path('../../db/database.yml', __FILE__)
 if File.exists?(database_yml)
   active_record_configuration = YAML.load_file(database_yml)[ENV['DB']]
-  
+
   ActiveRecord::Base.establish_connection(active_record_configuration)
   ActiveRecord::Base.logger = Logger.new(File.join(File.dirname(__FILE__), "../debug.log"))
-  
-  ActiveRecord::Base.silence do
-    ActiveRecord::Migration.verbose = false
-    
-    load(File.dirname(__FILE__) + '/../db/schema.rb')
-    load(File.dirname(__FILE__) + '/../db/models.rb')
-  end  
-  
+
+  load(File.dirname(__FILE__) + '/../db/schema.rb')
+  load(File.dirname(__FILE__) + '/../db/models.rb')
+
 else
   raise "Please create #{database_yml} first to configure your database. Take a look at: #{database_yml}.example"
 end
@@ -26,4 +23,4 @@ def clean_database!
   end
 end
 
-clean_database!
+clean_database!

metadata

@@ -1,31 +1,107 @@
 --- !ruby/object:Gem::Specification
 name: nilly_vanilly
 version: !ruby/object:Gem::Version
-  version: 0.3.0
-  prerelease: 
+  version: 1.0.0
 platform: ruby
 authors:
 - Joost Baaij
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-02-12 00:00:00.000000000 Z
-dependencies: []
+date: 2018-03-09 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: activerecord
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 4.0.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 4.0.0
+- !ruby/object:Gem::Dependency
+  name: activerecord
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 5.1.5
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 5.1.5
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 3.7.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 3.7.0
+- !ruby/object:Gem::Dependency
+  name: sqlite3
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 1.3.13
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 1.3.13
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: This plugin stores NULL in your database when you try to store an empty
   string.
 email:
 - joost@spacebabies.nl
-executables: []
+executables:
+- console
+- setup
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
+- ".gitignore"
+- ".rspec"
+- ".travis.yml"
 - CHANGELOG.md
+- CODE_OF_CONDUCT.md
 - Gemfile
 - Gemfile.lock
+- LICENSE.txt
 - README.markdown
 - Rakefile
+- bin/console
+- bin/setup
 - lib/nilly_vanilly.rb
 - lib/nilly_vanilly/inspect.rb
 - lib/nilly_vanilly/nillify.rb
@@ -41,28 +117,28 @@ files:
 - spec/spec_helper.rb
 - spec/support/database.rb
 homepage: https://github.com/tilsammans/nilly_vanilly
-licenses: []
+licenses:
+- MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.6.11
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: This plugin stores NULL in your database when you try to store an empty string.
 test_files:
 - spec/db/database.yml.example