nihaopay-ruby 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8766c2c6e2a61b1ac8c0cd497e8fe871cc0d34c6
-  data.tar.gz: 08aaa9b825ad38032cc436061e09b2d0d3a476db
+  metadata.gz: 793d37f1e49e2b37efecb06a13c62cac1e2ddacf
+  data.tar.gz: 7cbd9cde59ba17ce779fc907e640d9181fa40372
 SHA512:
-  metadata.gz: 980bd29de13afa1d13b0664e5a52f1e2ad6df160900031a402691b832780e2ea8abf59f03fd78dd9828893411f7ffdf3befc15dc72a7408a0ab8d2f27faf36e9
-  data.tar.gz: a818aa490245aa0f9a71ff32c9f667cc14017380d077ccb66cdb9878da19a35129a22293243545c683663a3c8f805e70f35ae3467582fbcb3f4c191549b8dfc3
+  metadata.gz: 21b972bb2b50c3c762318dddc4031c8e86fb37bfa9047f0e8a2682b3fff02c9c2af597634fde833e1dda50cde933a0bea9bc84014759006633b02ffec195adce
+  data.tar.gz: 00947d8dbe1f6277928fc7b3ffcc40b00dd8af5222d3ae9f3cdade7aeb1db4ece12485b729e34015a5dfde2d1d7b00c3e52fa636af589c2c14263a5a6869cfa3

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 0.1.1
+
+* Bug Fix: Add time to Nihaopay response if not present (@JagdeepSingh)
+
 ## 0.1.0
 
 * Initial release (@JagdeepSingh)

data/README.md

@@ -146,6 +146,7 @@ express_pay.reference        # => "3461fcc31aec471780ad1a4dc6111947"
 express_pay.currency         # => "JPY"
 express_pay.amount           # => 1000
 express_pay.captured         # => false
+express_pay.time             # => "2017-01-17T17:51:00+0900"
 ```
 
 Other methods available are `note` and `time`.
@@ -179,6 +180,7 @@ captured.transaction_id           # => "20160718111604002633"
 captured.status                   # => "success"
 captured.captured                 # => true
 captured.capture_transaction_id   # => "20160718111529002632" (id of the transaction that was captured)
+captured.time                     # => "2017-01-17T17:51:00+0900"
 ```
 
 If you want to capture a partial amount, you can do:
@@ -199,6 +201,7 @@ released.transaction_id           # => "20160718111604002633"
 released.status                   # => "success"
 released.released                 # => true
 released.release_transaction_id   # => "20160718111529002632" (id of the transaction that was released)
+released.time                     # => "2017-01-17T17:51:00+0900"
 ```
 
 #### Cancel a transaction
@@ -209,6 +212,7 @@ cancelled.transaction_id            # => "20160718111604002633"
 cancelled.status                    # => "success"
 cancelled.cancelled                 # => true
 cancelled.cancel_transaction_id     # => "20160718111529002632" (id of the transaction that was cancelled)
+cancelled.time                      # => "2017-01-17T17:51:00+0900"
 ```
 
 Transactions can only be cancelled before the daily settlement deadline. Transactions cannot be cancelled if a partial or full refund on the transaction has already been issued.
@@ -285,6 +289,7 @@ refunded.transaction_id            # => "20160718111604002633"
 refunded.status                    # => "success"
 refunded.refunded                  # => true
 refunded.refund_transaction_id     # => "20160718111529002632" (id of the transaction that was refunded)
+refunded.time                      # => "2017-01-17T17:51:00+0900"
 ```
 
 You can pass a `reason` when refunding a transaction:

data/lib/nihaopay/transactions/base.rb

@@ -4,6 +4,8 @@ module Nihaopay
       include ::Nihaopay::Api
       include ::Nihaopay::Queryable
 
+      TIME_FORMAT = '%Y-%m-%dT%H:%M:%S%z'.freeze
+
       attr_accessor :token, :transaction_id, :type, :status
       attr_accessor :captured, :reference, :currency, :amount, :note, :time
 
@@ -55,6 +57,7 @@ module Nihaopay
           options = Nihaopay::HashUtil.symbolize_keys(options)
           attributes = Nihaopay::HashUtil.slice(options, *valid_attributes)
           attributes[:token] ||= merchant_token
+          attributes[:time] ||= Time.now.strftime(TIME_FORMAT)
           response_keys_map.each { |k, v| attributes[v] = options[k] }
           new(attributes)
         end

data/lib/nihaopay/transactions/cancel.rb

@@ -16,7 +16,7 @@ module Nihaopay
         end
 
         def valid_attributes
-          %i(transaction_id status cancelled cancel_transaction_id)
+          %i(transaction_id status cancelled cancel_transaction_id time)
         end
 
         def response_keys_map

data/lib/nihaopay/transactions/capture.rb

@@ -17,7 +17,7 @@ module Nihaopay
         end
 
         def valid_attributes
-          %i(transaction_id status captured capture_transaction_id)
+          %i(transaction_id status captured capture_transaction_id time)
         end
 
         def response_keys_map

data/lib/nihaopay/transactions/refund.rb

@@ -19,7 +19,7 @@ module Nihaopay
         end
 
         def valid_attributes
-          %i(transaction_id status refunded refund_transaction_id)
+          %i(transaction_id status refunded refund_transaction_id time)
         end
 
         def response_keys_map

data/lib/nihaopay/transactions/release.rb

@@ -16,7 +16,7 @@ module Nihaopay
         end
 
         def valid_attributes
-          %i(transaction_id status released release_transaction_id)
+          %i(transaction_id status released release_transaction_id time)
         end
 
         def response_keys_map

data/lib/nihaopay/version.rb

@@ -1,3 +1,3 @@
 module Nihaopay
-  VERSION = '0.1.0'.freeze
+  VERSION = '0.1.1'.freeze
 end

data/spec/mixins/api_spec.rb

@@ -58,7 +58,7 @@ describe Nihaopay::Api do
 
       context 'when parsed_response contains :id' do
         let(:parsed_response) { { 'id' => '20160714132438002485', 'code' => 200 } }
-        it { expect { ApiTest.validate_resource!(response) }.to_not raise_error(Nihaopay::TransactionError) }
+        it { expect { ApiTest.validate_resource!(response) }.to_not raise_error }
       end
     end
 
@@ -74,7 +74,7 @@ describe Nihaopay::Api do
 
       context 'when parsed_response contains :transactions' do
         let(:parsed_response) { { 'transactions' => [{ 'id' => '20160714132438002485', 'code' => 200 }] } }
-        it { expect { ApiTest.validate_collection!(response) }.to_not raise_error(Nihaopay::TransactionError) }
+        it { expect { ApiTest.validate_collection!(response) }.to_not raise_error }
       end
     end
   end

data/spec/transactions/base_spec.rb

@@ -142,6 +142,7 @@ describe Nihaopay::Transactions::Base do
       it { expect(subject.transaction_id).to eq '123456' }
       it { expect(subject.token).to eq 'merchanttoken2' }
       it { expect(subject.captured).to be true }
+      it { expect(subject.time).to eq '2016-06-01T01:00:00Z' }
     end
 
     context 'with options with string keys' do
@@ -168,6 +169,17 @@ describe Nihaopay::Transactions::Base do
       it { is_expected.to be_a Nihaopay::Transactions::Base }
       it { expect(subject.token).to eq 'merchanttoken1' }
     end
+
+    context 'when time not returned in response' do
+      let(:options) do
+        opts = attrs.merge(id: '123456')
+        opts.delete(:time)
+        opts
+      end
+      before { allow(Time).to receive_message_chain(:now, :strftime) { '2017-01-17T16:00:00+0900' } }
+      subject { described_class.build(options) }
+      it { expect(subject.time).to eq '2017-01-17T16:00:00+0900' }
+    end
   end
 
   describe '.valid_attributes' do

data/spec/transactions/cancel_spec.rb

@@ -72,7 +72,7 @@ describe Nihaopay::Transactions::Cancel do
   end
 
   describe '.valid_attributes' do
-    let(:expectation) { %i(transaction_id status cancelled cancel_transaction_id) }
+    let(:expectation) { %i(transaction_id status cancelled cancel_transaction_id time) }
     it { expect(described_class.valid_attributes).to eq expectation }
   end
 

data/spec/transactions/capture_spec.rb

@@ -74,7 +74,7 @@ describe Nihaopay::Transactions::Capture do
   end
 
   describe '.valid_attributes' do
-    let(:expectation) { %i(transaction_id status captured capture_transaction_id) }
+    let(:expectation) { %i(transaction_id status captured capture_transaction_id time) }
     it { expect(described_class.valid_attributes).to eq expectation }
   end
 

data/spec/transactions/refund_spec.rb

@@ -87,7 +87,7 @@ describe Nihaopay::Transactions::Refund do
   end
 
   describe '.valid_attributes' do
-    let(:expectation) { %i(transaction_id status refunded refund_transaction_id) }
+    let(:expectation) { %i(transaction_id status refunded refund_transaction_id time) }
     it { expect(described_class.valid_attributes).to eq expectation }
   end
 

data/spec/transactions/release_spec.rb

@@ -72,7 +72,7 @@ describe Nihaopay::Transactions::Release do
   end
 
   describe '.valid_attributes' do
-    let(:expectation) { %i(transaction_id status released release_transaction_id) }
+    let(:expectation) { %i(transaction_id status released release_transaction_id time) }
     it { expect(described_class.valid_attributes).to eq expectation }
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: nihaopay-ruby
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - JagdeepSingh
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-22 00:00:00.000000000 Z
+date: 2017-01-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty