nifty_services 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fbc637a70ce76172e4046bea262d1e5dc441812e
-  data.tar.gz: b9eab049883acf9e7326016148867c0c2a8d0955
+  metadata.gz: 6ecb01584fa196dbc0885c27d09a913dcad6cb78
+  data.tar.gz: 80eac1cc0ca04a6f16fafd9cc9eff9e29d0079bd
 SHA512:
-  metadata.gz: e7418c345da76821b3d923f4713daad3bad32b3c99ba5e2e1f86984082d97c7e0a1e5b951d3c008a6cc27b6819adafa44198eaac48b8d6e4478b5889b531be7d
-  data.tar.gz: aada69447972ebce79dad95e7e2251907aae2af998973c96040b1c19e4607b5a108e60d49c72810b3e8e3242332d96da812dd5e38bcd54305d5cb558214d1703
+  metadata.gz: 18e82bfb9c763ffdfb00ae3a5a1908a5991b63f9d73bea81693f61a24680036db456db242a582b2cdf1253199cd741377118bf6ff88ba80ce0a1bef4dca3f944
+  data.tar.gz: 174cc9ab744aa6dc8d4cf7dbfca1e6b28ecaf14602172ce5991c6d38142308106c9539adeb4316fe15b1e8bbe6dc40bc02d9d1b07fe67edf6b921bd2600d42fc

data/lib/nifty_services/base_crud_service.rb

@@ -61,15 +61,6 @@ module NiftyServices
     alias :record_safe_params :record_allowed_params
 
     private
-
-    def valid_user?
-      user_class = NiftyServices.config.user_class
-
-      raise 'Invalid User class. Use NitfyService.config.user_class = ClassName' if user_class.blank?
-
-      valid_object?(@user, user_class)
-    end
-
     def array_values_from_hash(options, key, root = nil)
       options = options.symbolize_keys
 

data/lib/nifty_services/base_service.rb

@@ -1,7 +1,7 @@
 module NiftyServices
   class BaseService
 
-    attr_reader :options, :response_status, :errors
+    attr_reader :options, :response_status, :response_status_code, :errors
 
     CALLBACKS = [
       :after_initialize,
@@ -60,9 +60,9 @@ module NiftyServices
 
     def initialize(options = {}, initial_response_status = 400)
       @options = options.to_options!
-      @response_status = initial_response_status
       @errors = []
 
+      set_response_status(initial_response_status)
       initial_callbacks_setup
 
       call_callback(:after_initialize)
@@ -81,13 +81,21 @@ module NiftyServices
     end
 
     def response_status
-      @response_status ||= 400
+      @response_status ||= :bad_request
     end
 
     def changed?
       changed_attributes.any?
     end
 
+    def valid_user?
+      user_class = NiftyServices.config.user_class
+
+      raise 'Invalid User class. Use NitfyService.config.user_class = ClassName' if user_class.blank?
+
+      valid_object?(@user, user_class)
+    end
+
     def callback_fired?(callback_name)
       return (
               callback_fired_in?(@fired_callbacks, callback_name) ||
@@ -133,22 +141,54 @@ module NiftyServices
       @registered_callbacks = Hash.new {|k,v| k[v] = [] }
     end
 
-    def success_response(status = 200)
-      call_callback(:before_success)
-
-      @response_status = status
-      @success = true
+    def success_response(status = :ok)
+      unless Configuration::SUCCESS_RESPONSE_STATUS.key?(status.to_sym)
+        raise "#{status} is not a valid success response status"
+      end
 
-      call_callback(:after_success)
+      with_before_and_after_callbacks(:success) do
+        @success = true
+        set_response_status(status)
+      end
     end
 
     def success_created_response
-      success_response(201)
+      success_response(:created)
+    end
+
+    def set_response_status(status)
+      @response_status = response_status_reason_for(status)
+      @response_status_code = response_status_code_for(status)
+    end
+
+    def response_status_for(status)
+      error_list = Configuration::ERROR_RESPONSE_STATUS
+      success_list = Configuration::SUCCESS_RESPONSE_STATUS
+
+      select_method = [Symbol, String].member?(status.class) ? :key : :value
+
+      response_list = error_list.merge(success_list)
+
+      selected_status = response_list.select do |status_key, status_code|
+        if select_method == :key
+          status_key == status
+        else
+          status_code == status
+        end
+      end
+    end
+
+    def response_status_code_for(status)
+      response_status_for(status).values.first
+    end
+
+    def response_status_reason_for(status)
+      response_status_for(status).keys.first
     end
 
-    def error(status, message_key, options={})
+    def error(status, message_key, options = {})
       with_before_and_after_callbacks(:error) do
-        @response_status = status
+        set_response_status(status)
         error_message = process_error_message_for_key(message_key, options)
 
         add_error(error_message)

data/lib/nifty_services/configuration.rb

@@ -6,7 +6,7 @@ module NiftyServices
     DEFAULT_I18N_NAMESPACE = "nifty_services"
     DEFAULT_SERVICE_CONCERN_NAMESPACE = 'NitfyServices::Concerns'
 
-    RESPONSE_ERRORS_LIST = {
+    ERROR_RESPONSE_STATUS = {
       :bad_request           => 400,
       :not_authorized        => 401,
       :forbidden             => 403,
@@ -16,9 +16,14 @@ module NiftyServices
       :not_implemented       => 501
     }
 
+    SUCCESS_RESPONSE_STATUS = {
+      :ok => 200,
+      :created => 201
+    }
+
     class << self
       def response_errors_list
-        RESPONSE_ERRORS_LIST
+        ERROR_RESPONSE_STATUS
       end
 
       def add_response_error_method(reason, status_code)

data/lib/nifty_services/version.rb

@@ -1,3 +1,3 @@
 module NiftyServices
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: nifty_services
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Rafael Fidelis