niffler 0.0.2 → 0.0.3

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    YjQ1NjY0ODI5NWNiY2U0YTUwYjYwMmJmNzJlZjNmNjkwNjcyYmYzMQ==
+    MjNjMmQwMTE4MDhkYmIwMmZlYmRkOTk3Y2ZmNmQ3MjE1ZTQ1Y2QwMQ==
   data.tar.gz: !binary |-
-    ZTJjZTk1MTM2ZjYyZTA0NzcxYzEzNDQ1YjA5YjgwYTI2ZTc2N2UyNg==
+    NGE5NWQ0MzVmY2FmMmNhZDUxOTIyOTIyM2MzZmQ1ZmQxZjc3MTU3NQ==
 !binary "U0hBNTEy":
   metadata.gz: !binary |-
-    NTU4MTY4YmMxNTcwNzViNjJiMDc3YzViZTU2YjFjZTE0N2I5NzE4OGNjNGI2
-    YTg2YjI5NGY1ZjMxY2NkNjIzYTJjMzFjYmU1N2UzMmZhMDc2MmQyYzRmN2Ri
-    MjBjNzNjYzJjNTMwZmViZjlkNmY1YzI1ZGUwMDliNWNmMTA3OGQ=
+    ZjcwNmM4Zjk4MTc0MDdiYzE4MTRlZTc3M2FmNDQwMjkxODQwYjZiMDlmMTAx
+    NWZlNjgyOTgyMjQ4ZjU0YThlYmQyYjUwMDYyZjBkZDJjNjA0OGU3YjVhNTY1
+    M2M1NDM2MDlkZTU0MTM4NjEwY2FiMzZjNmI4M2NkOTI2Y2VlN2Y=
   data.tar.gz: !binary |-
-    MTg0MzNmMjFjNTBiNDQyYWM5Y2E0MGY0ODA5MWI5YzBjZDRlYjVkMmExYWQ5
-    MmY2NTk5NjlmOWZkYmI0YWUyMzY5YTE3ZWUzNTliNWVlNzU4YTNjM2FmYjA4
-    ZGZlYTZmY2UzNTViNTRiMjBmNTZlYTRiNTIyYmU3NGYwYWVmYTM=
+    YjNmMGE5NTg3OTAzMWE0YjFhZTcwYjhhMDkxMGU0MGI2MjFiODQyZGI1Yjdl
+    MDBlMzc1MGM0ODUwMzljOWUyYmFjNjYyYzg0Yzc3NDliNGI4ZjBkYWVmOWI4
+    MTk0MjQ1NTA1ZWYzZGEwYWMxMWRiMjhmOWQ4ZmIyZjBlYWQyYzA=

data/doc/TODO.md

@@ -6,3 +6,6 @@
 * Search by filepath
 * Search by classname
 * search by fully-qualified classname
+
+## Fixes
+* Specs should use their own, fake server

data/lib/niffler.rb

@@ -0,0 +1,5 @@
+require 'niffler/maven'
+
+class Niffler
+  
+end

data/lib/niffler/maven.rb

@@ -80,9 +80,11 @@ class Niffler
       results = []
       # response docs refers to the portion of the response with the software metadata for each result
       for r in json["response"]["docs"]
-        result = Niffler::Maven.new(group: r["g"], artifact: r["a"], version: r["latestVersion"], 
-          repository: r["repositoryId"], packaging: r["p"])
-        results << result
+        unless r.nil?
+          result = Niffler::Maven.new(group: r["g"], artifact: r["a"], version: r["latestVersion"], 
+            repository: r["repositoryId"], packaging: r["p"])
+          results << result
+        end # unless r.nil?
       end # for result
       
       return results
@@ -93,8 +95,10 @@ class Niffler
       # {"responseHeader"=>{"status"=>0, "QTime"=>1, "params"=>{"spellcheck"=>"true", "fl"=>"id,g,a,latestVersion,p,ec,repositoryId,text,timestamp,versionCount", "sort"=>"score desc,timestamp desc,g asc,a asc", "indent"=>"off", "q"=>"guice", "qf"=>"text^20 g^5 a^10", "spellcheck.count"=>"5", "wt"=>"json", "rows"=>"20", "version"=>"2.2", "defType"=>"dismax"}}, "response"=>{"numFound"=>234, "start"=>0, "docs"=>[{"id"=>"com.jolira:guice", "g"=>"com.jolira", "a"=>"guice", "latestVersion"=>"3.0.0", "repositoryId"=>"central", "p"=>"jar", "timestamp"=>1301724755000, "versionCount"=>8, "text"=>["com.jolira", "guice", "-javadoc.jar", "-sources.jar", ".jar", ".pom"], "ec"=>["-javadoc.jar", "-sources.jar", ".jar", ".pom"]}
       # response docs refers to the portion of the response with the software metadata for each result
       r = json["response"]["docs"].last
-      result = Niffler::Maven.new(group: r["g"], artifact: r["a"], version: r["v"], 
-        repository: r["repositoryId"], packaging: r["p"])
+      unless r.nil?
+        result = Niffler::Maven.new(group: r["g"], artifact: r["a"], version: r["v"], 
+          repository: r["repositoryId"], packaging: r["p"])
+      end
       return result
     end # def parse_response
   end # class Maven

data/lib/niffler/version.rb

@@ -1,3 +1,3 @@
 class Niffler
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/spec/lib/niffler/maven_spec.rb

@@ -3,34 +3,46 @@ require 'json'
 require 'niffler/maven'
 
 describe Niffler::Maven do
-  describe '#group_query' do 
-    before do
-      @result = Niffler::Maven.group_query("guice")
-    end # before
+  describe '#group_query' do
+    context 'with a valid group name' do
+      before do
+        @result = Niffler::Maven.group_query("guice")
+      end # before
     
-    it 'returns a Niffler::Maven object' do
-      @result.should be_kind_of(Niffler::Maven)
-    end # it
+      it 'returns a Niffler::Maven object' do
+        @result.should be_kind_of(Niffler::Maven)
+      end # it
     
-    it 'returns the group name' do
-      @result.group.should eq("org.apache.servicemix.bundles")
-    end # it
+      it 'returns the group name' do
+        @result.group.should eq("org.apache.servicemix.bundles")
+      end # it
     
-    it 'returns the artifact name' do
-      @result.artifact.should eq("org.apache.servicemix.bundles.guice")
-    end # it
+      it 'returns the artifact name' do
+        @result.artifact.should eq("org.apache.servicemix.bundles.guice")
+      end # it
     
-    it 'returns the latest version' do
-      @result.version.should eq("3.0_1")
-    end # it
+      it 'returns the latest version' do
+        @result.version.should eq("3.0_1")
+      end # it
     
-    it 'returns the repository' do
-      @result.repository.should eq("central")
-    end # it
+      it 'returns the repository' do
+        @result.repository.should eq("central")
+      end # it
     
-    it 'returns the packaging' do
-      @result.packaging.should eq("bundle")
-    end # it
+      it 'returns the packaging' do
+        @result.packaging.should eq("bundle")
+      end # it
+    end # context
+  
+    context 'with a fake group name' do
+      before do
+        @result = Niffler::Maven.group_query("thisisafakegroupname")
+      end # before
+      
+      it 'returns nil for a fake name' do
+        @result.should be_nil
+      end # it
+    end # context
   end # describe 
   
   describe '#groups_query' do
@@ -46,6 +58,16 @@ describe Niffler::Maven do
       end # it
     end # context
     
+    context 'with a fake groups name' do
+      before do
+        @result = Niffler::Maven.groups_query("thisisafakegroupsname")
+      end # before
+      
+      it 'returns an empty array for a fake name' do
+        @result.should be_empty
+      end # it
+    end # context
+    
     context 'with a group AND version' do
       pending "returns correctly when a version is also specified"
     end # context
@@ -70,6 +92,16 @@ describe Niffler::Maven do
         @results.last.should be_kind_of(Niffler::Maven)
       end # it
     end # context
+    
+    context 'with a fake artifacts name' do
+      before do
+        @result = Niffler::Maven.artifacts_query("thisisafakeartifactsname")
+      end # before
+      
+      it 'returns an empty array for a fake name' do
+        @result.should be_empty
+      end # it
+    end # context
   end # describe
 
   describe '#artifact_query' do
@@ -87,7 +119,7 @@ describe Niffler::Maven do
       end # it
 
       it 'returns the latest version' do
-        @result.version.should eq("2.10.4")
+        @result.version.should eq("2.11.0")
       end # it
 
       it 'returns the repository' do
@@ -98,6 +130,16 @@ describe Niffler::Maven do
         @result.packaging.should eq("maven-plugin")
       end # it
     end # context
+    
+    context 'with a fake artifact name' do
+      before do
+        @result = Niffler::Maven.artifact_query("thisisafakeartifactname")
+      end # before
+      
+      it 'returns nil for a fake name' do
+        @result.should be_nil
+      end # it
+    end # context
   end # describe
   
   describe '#hash_query' do
@@ -122,5 +164,15 @@ describe Niffler::Maven do
         @result.packaging.should eq("jar")
       end # it
     end # context
+    
+    context 'with a fake hash' do
+      before do
+        @result = Niffler::Maven.hash_query("ffffffffffffffffffffffffffffffffffffffff")
+      end
+      
+      it "returns empty if it doesn't exist" do
+        @result.should be_nil
+      end # it
+    end # context
   end # describe hash
 end # describe Niffler

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: niffler
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Michael Carlson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-20 00:00:00.000000000 Z
+date: 2013-04-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack-client
@@ -137,7 +137,7 @@ files:
 - lib/niffler.rb
 - lib/niffler/maven.rb
 - lib/niffler/version.rb
-- niffler-0.0.1.gem
+- niffler-0.0.2.gem
 - niffler.gemspec
 - spec/lib/niffler/maven_spec.rb
 - spec/lib/niffler_spec.rb