nicoquery 0.1.8.8 → 0.1.8.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 562a498e207c749c1d054b6914178dd2235921a3
-  data.tar.gz: a47deba7f5ec62fa299d0a3489c9c5b4a1b56551
+  metadata.gz: df91616f6bc69aa2027a406cbf7089798147a752
+  data.tar.gz: c534b11e1fb66304aff2ff15c6b776b2d3bc8fc4
 SHA512:
-  metadata.gz: 2e458f9fc86516a133c151fa37324de2a3253d9be775756cf7cd83c060d78a8c59c799bf597e741dc5af9c714bc0ae61c4d26e2f5d241a1cfec4ba8335546c94
-  data.tar.gz: 7282ba6d0dd85c69ebd7eac1d42aaaff8ae54f74738a7ab340f36f5abd92e24540c812bb9ad46454ed2b5f421c1b42b5b896e55db4c45d1a7e6f6ef6854444e2
+  metadata.gz: 2b7128b15c7b6a6dce8e0868fe4e3805076bcf665d0bbb367b40b7dafadbb33eb5fc66bc1c24965a6385f6b3f97211ce4cb6bea5a9e1076addebe1a9b22bea4e
+  data.tar.gz: a6b63aeba94fdd6a95c5c9036af4845f74e91707a896e6494bc3e29293435e854a7fa3f52934da1e85f09d2c870d5181288641ffaf22500fc18c7085b621c509

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    nicoquery (0.1.8.8)
+    nicoquery (0.1.8.9)
       activesupport (~> 4.0.0)
       i18n
       nicoapi

data/lib/nicoquery/object_mapper/video_array.rb

@@ -95,7 +95,9 @@ module NicoQuery
         def tags
           tag_obj = @hash['tags']['tag_info']
 
-          if tag_obj.instance_of? Array
+          if tag_obj.nil?
+            tag_array = []
+          elsif tag_obj.instance_of? Array
             tag_array = tag_obj
           else
             tag_array = [ tag_obj ]

data/lib/nicoquery/version.rb

@@ -1,3 +1,3 @@
 module NicoQuery
-  VERSION = "0.1.8.8"
+  VERSION = "0.1.8.9"
 end

data/spec/fixture/video_array_no_tags.rb

@@ -0,0 +1,9 @@
+module Fixture
+  def self.video_array_no_tags
+    <<-EOS
+<?xml version="1.0" encoding="UTF-8"?>
+<nicovideo_video_response status="ok"><count>1</count><video_info><video><id>sm21130836</id><deleted>0</deleted><title>バイオハザードゆっくリベレーションＵＥ裏の１</title><description>本編とは関係ない動画&lt;br /&gt;コメント返し（二件）が終わったら残りの時間は雑談になっている動画です　mylist/37486541&lt;br /&gt;ガンダムとνのバルカン音も入れたのにマシンガンがうるさくて聞こえないね&lt;br /&gt;※タグを付けてもらえるのは嬉しいのですがこの裏の動画はタグ無しでお願いします&lt;br /&gt;</description><length_in_seconds>488</length_in_seconds><size_low>25940040</size_low><movie_type>mp4</movie_type><thumbnail_url>http://tn-skr1.smilevideo.jp/smile?i=21130836</thumbnail_url><upload_time/><first_retrieve>2013-06-16T19:04:57+09:00</first_retrieve><default_thread>1371377097</default_thread><view_counter>172</view_counter><mylist_counter>3</mylist_counter><option_flag_ichiba>0</option_flag_ichiba><option_flag_community>0</option_flag_community><option_flag_domestic>0</option_flag_domestic><option_flag_comment_type>0</option_flag_comment_type><option_flag_adult>0</option_flag_adult><option_flag_mobile>0</option_flag_mobile><option_flag_economy_mp4>1</option_flag_economy_mp4><option_flag_middle_video>0</option_flag_middle_video><option_flag_mobile_ng_apple>0</option_flag_mobile_ng_apple></video><thread><id>1371377097</id><public>1</public><num_res>13</num_res><community_id/></thread><tags><tag_info/></tags></video_info></nicovideo_video_response>
+    EOS
+  end
+end
+

data/spec/object_mapper/video_array_spec.rb

@@ -1,14 +1,16 @@
 require "nicoquery/object_mapper/video_array"
 require "fixture/video_array_sm20415650_sm9"
+require "fixture/video_array_no_tags"
 
 
 describe "NicoQuery::ObjectMapper::VideoArray" do
-  before do
-    xml = Fixture.video_array_sm20415650_sm9
-    @result = NicoQuery::ObjectMapper::VideoArray.new xml
-  end
 
   context "sm20415650" do
+    before do
+      xml = Fixture.video_array_sm20415650_sm9
+      @result = NicoQuery::ObjectMapper::VideoArray.new xml
+    end
+
     subject { @result.movies[0] }
 
     describe "#title" do
@@ -83,12 +85,35 @@ describe "NicoQuery::ObjectMapper::VideoArray" do
     end
   end
 
-  # context "when a movie doesn't contain more than one tag" do
-  #   describe "#tags" do
-  #     it "returns number of mylist references" do
-  #       expect(subject.tags).to be_a_kind_of Array
-  #     end
-  #   end
-  # end
+  context "when a movie doesn't contain more than one tag" do
+    before do
+      xml = Fixture.video_array_sm20415650_sm9
+      @result = NicoQuery::ObjectMapper::VideoArray.new xml
+    end
+
+    subject { @result.movies[0] }
+
+    describe "#tags" do
+      it "returns number of mylist references" do
+        expect(subject.tags).to be_a_kind_of Array
+      end
+    end
+  end
+
+  context "when a movie contains no tag" do
+    before do
+      xml = Fixture.video_array_no_tags
+      @result = NicoQuery::ObjectMapper::VideoArray.new xml
+    end
+
+    subject { @result.movies[0] }
+
+    describe "#tags" do
+      it "returns empty array" do
+        expect(subject.tags).to be_a_kind_of Array
+        expect(subject.tags).to be_empty
+      end
+    end
+  end
 
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: nicoquery
 version: !ruby/object:Gem::Version
-  version: 0.1.8.8
+  version: 0.1.8.9
 platform: ruby
 authors:
 - Masami Yonehara
@@ -269,6 +269,7 @@ files:
 - spec/fixture/tag_search_yukkuri_page1.rb
 - spec/fixture/tag_search_yukkuri_page2.rb
 - spec/fixture/video_array_community.rb
+- spec/fixture/video_array_no_tags.rb
 - spec/fixture/video_array_sm20415650_sm9.rb
 - spec/nicoquery_spec.rb
 - spec/object/movie_spec.rb
@@ -324,6 +325,7 @@ test_files:
 - spec/fixture/tag_search_yukkuri_page1.rb
 - spec/fixture/tag_search_yukkuri_page2.rb
 - spec/fixture/video_array_community.rb
+- spec/fixture/video_array_no_tags.rb
 - spec/fixture/video_array_sm20415650_sm9.rb
 - spec/nicoquery_spec.rb
 - spec/object/movie_spec.rb