nice_partials 0.1.4 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3275a33c9f1de9e8267042ab36b485297451804bb1c704082576890d800a20cd
-  data.tar.gz: 7b55dd85d2d291eb411b564819c602e039dc412ec8cbb82df7b58f8472d062e4
+  metadata.gz: d42a736129588d106251452b5d8357a54b610105302f7fddd25d4658211f6b1b
+  data.tar.gz: 66788e79de27fbddefaaef582dc4768bb3bd9a4e50eb43dd306c5c39919dac08
 SHA512:
-  metadata.gz: ef49218a25d20bb8b0446b5b0dd975fb173191ea1e236e9dfa6a700fec717ef9b24f8f06fcc114b4e1e731ddf62aed143cd225193cd6ebc64acb4fd06edb0e3b
-  data.tar.gz: 52e0f030102269996e35132ad2ff16bcb94100faca76787b13059a31450c0d65456961b71bf69d2610f46bb8f48a9b410f4a01090c96f946d2d5b1ec6ece9b8c
+  metadata.gz: 0dfd842004c659c711e34675fd57a555e75dba71dd73990f73b1b8a37071c93e0ac8441b4248100b0faf6d930a70216e5d927b5aa9692ee13be9ffc6fc3507ff
+  data.tar.gz: 65c451b1ddca8dab4bc9d523e6d9f14095c33cfe59df34f321b724445c60ab68e4aab23c26fd153929d48d5dfdad351cc230a0a0cb7970de32410e078e380bfd

data/.gitignore

@@ -1,2 +1,3 @@
 Gemfile.lock
 /pkg
+*~

data/README.md

@@ -150,6 +150,14 @@ Then later in the partial you can use the helper method like so:
 <td><%= p.reference_to(user) %></td>
 ```
 
+## Development
+
+### Testing
+
+```sh
+bundle exec rake test
+```
+
 ## MIT License
 
 Copyright (C) 2020 Andrew Culver <https://bullettrain.co> and Dom Christie <https://domchristie.co.uk>. Released under the MIT license.

data/Rakefile

@@ -30,8 +30,8 @@ end
 # # #
 # Run specs
 
-desc "#{gemspec.name} | Spec"
-task :spec do
-  sh "for file in spec/*_spec.rb; do ruby $file; done"
+desc "#{gemspec.name} | Test"
+task :test do
+  sh "for file in test/*_test.rb; do ruby $file; done"
 end
-task default: :spec
+task default: :test

data/lib/nice_partials/helper.rb

@@ -20,6 +20,6 @@ module NicePartials::Helper
       key = "#{@_nice_partials_t_prefixes.last}#{key}"
     end
 
-    super(key, options)
+    super(key, **options)
   end
 end

data/lib/nice_partials/monkey_patch.rb

@@ -20,4 +20,33 @@ class ActionView::PartialRenderer
 
     return result
   end
+
+  # This and ActionView::Template#render below are for compatibility
+  # with Ruby 3, as opposed to altering the original functionality.
+  def render_partial_template(view, locals, template, layout, block)
+    ActiveSupport::Notifications.instrument(
+      "render_partial.action_view",
+      identifier: template.identifier,
+      layout: layout && layout.virtual_path
+    ) do |payload|
+      content = template.render(view, locals, ActionView::OutputBuffer.new, {add_to_stack: !block}) do |*name|
+        view._layout_for(*name, &block)
+      end
+
+      content = layout.render(view, locals) { content } if layout
+      payload[:cache_hit] = view.view_renderer.cache_hits[template.virtual_path]
+      build_rendered_template(content, template)
+    end
+  end
+end
+
+class ActionView::Template
+  def render(view, locals, buffer = ActionView::OutputBuffer.new, flag = {add_to_stack: true}, &block)
+    instrument_render_template do
+      compile!(view)
+      view._run(method_name, self, locals, buffer, **flag, &block)
+    end
+  rescue => e
+    handle_render_error(view, e)
+  end
 end

data/lib/nice_partials/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module NicePartials
-  VERSION = "0.1.4"
+  VERSION = "0.1.5"
 end

data/lib/nice_partials.rb

@@ -3,7 +3,6 @@
 require_relative "nice_partials/version"
 require_relative "nice_partials/helper"
 require_relative "nice_partials/monkey_patch"
-require_relative "partials"
 
 module NicePartials
 end

data/nice_partials.gemspec

@@ -20,4 +20,6 @@ Gem::Specification.new do |gem|
   gem.required_ruby_version = ">= 2.0"
 
   gem.add_dependency "actionview", '>= 4.2.6'
+
+  gem.add_development_dependency "rails"
 end

data/test/fixtures/_basic.html.erb

@@ -0,0 +1,2 @@
+<% yield p = np %>
+<%= p.yield :message %>

data/test/fixtures/_card.html.erb

@@ -0,0 +1,13 @@
+<% yield p = np %>
+
+<div class="card">
+  <%= p.yield :image %>
+  <div class="card-body">
+    <h5 class="card-title"><%= title %></h5>
+    <% if p.content_for? :body %>
+      <p class="card-text">
+        <%= p.content_for :body %>
+      </p>
+    <% end %>
+  </div>
+</div>

data/test/fixtures/card_test.html.erb

@@ -0,0 +1,9 @@
+<%= render "card", title: "Some Title" do |p| %>
+  <% p.content_for :body do %>
+    Lorem Ipsum
+  <% end %>
+
+  <% p.content_for :image do %>
+    <img src="https://example.com/image.jpg" />
+  <% end %>
+<% end %>

data/test/renderer_test.rb

@@ -0,0 +1,57 @@
+require_relative "./test_helper"
+
+class RendererTest < ActiveSupport::TestCase
+  # from actionview/render_test
+  class TestController < ActionController::Base
+  end
+ 
+  def setup_view(paths)
+    ActionView::Base.include(NicePartials::Helper)
+
+    @assigns = { secret: "in the sauce" }
+
+    @view = Class.new(ActionView::Base.with_empty_template_cache) do
+      def view_cache_dependencies; []; end
+
+      def combined_fragment_cache_key(key)
+        [:views, key]
+      end
+    end.with_view_paths(paths, @assigns)
+
+    controller = TestController.new
+    controller.perform_caching = true
+    controller.cache_store = :memory_store
+    @view.controller = controller
+
+    @controller_view = controller.view_context_class.with_empty_template_cache.new(
+      controller.lookup_context,
+      controller.view_assigns,
+      controller)
+  end
+
+  def setup
+    ActionView::LookupContext::DetailsKey.clear
+    path = ActionView::FileSystemResolver.new(FIXTURE_LOAD_PATH)
+    view_paths = ActionView::PathSet.new([path])
+    assert_equal ActionView::FileSystemResolver.new(FIXTURE_LOAD_PATH), view_paths.first
+    setup_view(view_paths)
+  end
+
+  def teardown
+    ActionController::Base.view_paths.map(&:clear_cache)
+  end
+
+  test "render basic nice partial" do
+    rendered = @view.render("basic") { |p| p.content_for :message, "hello from nice partials" }.squish
+
+    assert_equal "hello from nice partials", rendered
+  end
+
+  test "render nice partial in card template" do
+    rendered = @view.render(template: "card_test").squish
+
+    assert_match "Some Title", rendered
+    assert_match "Lorem Ipsum", rendered
+    assert_match "https://example.com/image.jpg", rendered
+  end
+end

data/test/test_helper.rb

@@ -0,0 +1,7 @@
+require "active_support"
+require "active_support/testing/autorun"
+require "action_controller"
+require "action_view"
+require "nice_partials"
+
+FIXTURE_LOAD_PATH = File.expand_path("fixtures", __dir__)

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: nice_partials
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors:
 - Andrew Culver
 - Dom Christie
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-10-05 00:00:00.000000000 Z
+date: 2021-11-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionview
@@ -25,6 +25,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 4.2.6
+- !ruby/object:Gem::Dependency
+  name: rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: A little bit of magic to make partials perfect for components.
 email:
 - andrew.culver@gmail.com
@@ -46,14 +60,17 @@ files:
 - lib/nice_partials/monkey_patch.rb
 - lib/nice_partials/partial.rb
 - lib/nice_partials/version.rb
-- lib/partials.rb
 - nice_partials.gemspec
-- spec/nice_partials_spec.rb
+- test/fixtures/_basic.html.erb
+- test/fixtures/_card.html.erb
+- test/fixtures/card_test.html.erb
+- test/renderer_test.rb
+- test/test_helper.rb
 homepage: https://github.com/bullet-train-co/nice_partials
 licenses:
 - MIT
 metadata: {}
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -68,9 +85,13 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
-signing_key:
+rubygems_version: 3.0.3
+signing_key: 
 specification_version: 4
 summary: A little bit of magic to make partials perfect for components.
 test_files:
-- spec/nice_partials_spec.rb
+- test/fixtures/_basic.html.erb
+- test/fixtures/_card.html.erb
+- test/fixtures/card_test.html.erb
+- test/renderer_test.rb
+- test/test_helper.rb

data/lib/partials.rb

@@ -1,2 +0,0 @@
-module Partials
-end

data/spec/nice_partials_spec.rb

@@ -1,11 +0,0 @@
-# frozen_string_literal: true
-
-require_relative "../lib/nice_partials"
-require "minitest/autorun"
-
-describe NicePartials do
-  it "works" do
-    assert_equal true, false
-  end
-end
-