nhtsa_vin 0.0.7 → 0.0.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9c417b90ce601fa0150143c271fded5fa77e06a9
-  data.tar.gz: a2a5c574e0f4ce6c8761dc363a50dfd6c6ca777b
+  metadata.gz: e8aab96946256f3db71577e6c15ee5b560417dd7
+  data.tar.gz: 602be71041addeaaf958fb5c5f9700061293ea4a
 SHA512:
-  metadata.gz: a5c0100a5a611a127f8fbedd315b28be5580cd33420783c1e7f98b29dd3d82f969a19011ca78ac4d808325520cd0582786a9addab3563f7e00e9459b2e6c1e82
-  data.tar.gz: ca722daf6017b49ce6775249fa666bcff33aa7585b7ac43347b8110d95aa3035236b879d59246e4cf06d1a45a8482230d47f1341199ceb9c7825dfac9acbd920
+  metadata.gz: 48d8b50a590d210e618a889ab1d30ca655cf515017a68cae1af235a3087263084059cec5a6a3d7302fa5780d5681ea28a8b70bd68a2e7ea7a32b8356971af351
+  data.tar.gz: 7aa155cdbf659315daa7a90c9ff5fe347cb22b045e5cc0c712cc1673c5483ec118491df99a42eafcb64a6feb5b31604e527b829c2d0ee85e19aefa8b5d85d271

data/README.md

@@ -7,14 +7,14 @@
 
 A ruby gem for fetching and parsing vehicle identification via the vehicle identification number (VIN) from the [NHTSA webservice](https://vpic.nhtsa.dot.gov/api/Home). Note, this gem is not officially affiliated with the NHTSA.
 
-Please note, this gem is currently in early development. 
+Please note, this gem is currently in early development.
 
 ## Installation
 
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'nhsta_vin'
+gem 'nhtsa_vin'
 ```
 
 And then execute:
@@ -23,9 +23,9 @@ And then execute:
 
 Or install it yourself as:
 
-    gem install nhsta_vin
+    gem install nhtsa_vin
 
-## Usage 
+## Usage
 
 Validation
 ----
@@ -65,7 +65,7 @@ The actual data from the web service is contained in the `response` method. This
 query.response # => <Struct::NhtsaResponse make="Jeep", model="Grand Cherokee", trim="Laredo/Rocky Mountain Edition", type="SUV", year="2008", size=nil, ... doors=4>
 ```
 
-They query object also contains helper methods for error handling. For example, in the result no match is found, the result will be `nil`, and `#valid?` will return `false`. 
+They query object also contains helper methods for error handling. For example, in the result no match is found, the result will be `nil`, and `#valid?` will return `false`.
 
 ```ruby
 query = NhtsaVin.get('SOME_BAD_VIN') # => <NhtsaVin::Query>
@@ -78,7 +78,7 @@ query.error # => "11- Incorrect Model Year, decoded data may not be accurate"
 Vehicle Types
 ----
 
-For brevity, we're reducing the `Vehicle Type` response to an enumerated set of `["Car", "Truck", "Van", "SUV", "Minivan"]`. We're doing a rough parse of the type and body style to achieve this. It's probably not perfect. 
+For brevity, we're reducing the `Vehicle Type` response to an enumerated set of `["Car", "Truck", "Van", "SUV", "Minivan"]`. We're doing a rough parse of the type and body style to achieve this. It's probably not perfect.
 
 
 ## License

data/lib/nhtsa_vin/query.rb

@@ -16,12 +16,14 @@ module NhtsaVin
 
     def get
       @raw_response = fetch
-      return if @raw_response.nil?
       begin
-        parse(JSON.parse(@raw_response))
+        return if @raw_response.nil? || (json_response = JSON.parse(@raw_response)).nil?
+        parse(json_response)
       rescue JSON::ParserError
         @valid = false
         @error = 'Response is not valid JSON'
+      rescue StandardError => ex
+        raise "#{ex.message}: #{@raw_response.inspect}"
       end
     end
 
@@ -30,6 +32,11 @@ module NhtsaVin
     end
 
     def parse(json)
+      if json['Message']&.match(/execution error/i)
+        @valid = false
+        @error = json.dig('Results', 0, 'Message')
+        return
+      end
       @data = json['Results']
 
       # 0 - Good
@@ -101,11 +108,9 @@ module NhtsaVin
           @valid = false
 
           url = URI.parse(@url)
-          Net::HTTP.start(url.host, url.port, use_ssl: (url.scheme == 'https')) do |http|
-            @http_options.each do |key, val|
-              http.send("#{key}=", val) if val
-            end
-
+          http_options = { use_ssl: (url.scheme == 'https') }
+          http_options.update(@http_options)
+          Net::HTTP.start(url.host, url.port, http_options) do |http|
             resp = http.request_get(url)
             case resp
             when Net::HTTPSuccess

data/lib/nhtsa_vin/version.rb

@@ -1,3 +1,3 @@
 module NhtsaVin
-  VERSION = '0.0.7'.freeze
+  VERSION = '0.0.8'.freeze
 end

data/spec/lib/nhtsa_vin/query_spec.rb

@@ -78,6 +78,16 @@ describe NhtsaVin::Query do
         expect(client.error).to eq 'Response is not valid JSON'
       end
     end
+    context 'timeout response' do
+      before do
+        allow(client).to receive(:fetch).and_return('{"Count":0,"Message":"Execution Error","SearchCriteria":null,"Results":[{"Message":"Error encountered retrieving data: Connection Timeout Expired.  The timeout period elapsed while attempting to consume the pre-login handshake acknowledgement.  This could be because the pre-login handshake failed or the server was unable to respond back in time.  The duration spent while attempting to connect to this server was - [Pre-Login] initialization=6; handshake=14988; "}]}')
+        client.get
+      end
+      it 'is not valid' do
+        expect(client).not_to be_valid
+        expect(client.error).to match(/connection timeout expired/i)
+      end
+    end
     context 'HTTP error' do
       it '5xx' do
         resp = Net::HTTPServerError.new(1.1, 503, 'Service unhappy')

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: nhtsa_vin
 version: !ruby/object:Gem::Version
-  version: 0.0.7
+  version: 0.0.8
 platform: ruby
 authors:
 - Barclay Loftus
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-21 00:00:00.000000000 Z
+date: 2019-03-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -101,7 +101,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 2.5.2.2
 signing_key: 
 specification_version: 4
 summary: A ruby library for accessing vin records from the NHTSA