nhtsa 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 536615ab56a8f47955aa3bd6336e558c3b1dd9a1
-  data.tar.gz: 41da4ed80c9d77f85b7e27f20d63d2d5f37e7b71
+  metadata.gz: d095f131e393f03af526c45c80de7ced30e24feb
+  data.tar.gz: e9d853daec69f541758c63335738399beba53e70
 SHA512:
-  metadata.gz: 7dc2a07f2e662a23de75cb6c1f0da5c709e0a912d69e1cd4756d0fa03ad185cd4eb2b480651b0eac17186f848e57e07014a7d0033975fc9eaea246950a549406
-  data.tar.gz: dc882e39342d6341ef5e731216daa5311c2ed0809d3e2a672ac481b1aa721c86c47df4d05e66abb05aeacdf192d493dcd2d3117cc2dc7e7c212ebd0a5f7d3d3f
+  metadata.gz: d8f2559a97a2f8c4ede289c95519ab6423a3b57a37669c5a8663a782031b59a9d118e04c946fc74403ce8ff5557cac6cc7dc161824d3f91854bb2f24d45089f5
+  data.tar.gz: 1bcaa75ae5d3c93127af7535a2247d49d1e495dd69e6d28e04302f4d0a9136e55f4c0f848a7860dbcf759b32e964ca0ca411ec089e9530f2109d0f61a52e23e0

data/CHANGELOG.md

@@ -0,0 +1,15 @@
+# Changelog #
+
+## v0.2.1 June 11 2017 ##
+
+### Features ###
+
+* Moved all calls to the nhtsa api to use https instead of http
+
+### Bug Fixes ###
+
+* Safety Seat Inspection Station Locator was using a hardcoded URL, moving it to use the constants used everywhere else in the project.
+
+### Misc ###
+
+* Slightly better to read string handling when building URIs, going with `#{BASE_URI}/#{END_POINT}` over `BASE_URI + END_POINT`

data/lib/nhtsa.rb

@@ -9,6 +9,6 @@ module Nhtsa
   require 'json'
   require 'open-uri'
 
-  BASE_URI = "http://webapi.nhtsa.gov/api"
+  BASE_URI = "https://webapi.nhtsa.gov/api"
   DEFAULT_PARAMS = "?format=json"
 end

data/lib/nhtsa/child_safety_seat_inspection_station_locator/get_by_geo_location.rb

@@ -8,7 +8,7 @@ module Nhtsa
       end
 
       def url
-        "http://webapi.nhtsa.gov/api/CSSIStation?lat=#{@latitude}&long=#{@longitude}&miles=#{@radius}&format=json"
+        "#{BASE_URI}#{END_POINT}?lat=#{@latitude}&long=#{@longitude}&miles=#{@radius}&format=json"
       end
 
       def inspection_stations

data/lib/nhtsa/child_safety_seat_inspection_station_locator/get_by_state.rb

@@ -8,13 +8,13 @@ module Nhtsa
 
       def url
         if @filters[:spanish] && @filters[:cpsweek]
-          BASE_URI + END_POINT + "/state/#{@state_abbreviation}" + CPS_WEEK + SPANISH + DEFAULT_PARAMS
+          "#{BASE_URI}#{END_POINT}/state/#{@state_abbreviation}#{CPS_WEEK}#{SPANISH}#{DEFAULT_PARAMS}"
         elsif @filters[:spanish]
-          BASE_URI + END_POINT + "/state/#{@state_abbreviation}" + SPANISH + DEFAULT_PARAMS
+          "#{BASE_URI}#{END_POINT}/state/#{@state_abbreviation}#{SPANISH}#{DEFAULT_PARAMS}"
         elsif @filters[:cpsweek]
-          BASE_URI + END_POINT + "/state/#{@state_abbreviation}" + CPS_WEEK + DEFAULT_PARAMS
+          "#{BASE_URI}#{END_POINT}/state/#{@state_abbreviation}#{CPS_WEEK}#{DEFAULT_PARAMS}"
         else
-          BASE_URI + END_POINT + "/state/#{@state_abbreviation}" + DEFAULT_PARAMS
+          "#{BASE_URI}#{END_POINT}/state/#{@state_abbreviation}#{DEFAULT_PARAMS}"
         end
       end
 

data/lib/nhtsa/child_safety_seat_inspection_station_locator/get_by_zip_code.rb

@@ -8,13 +8,13 @@ module Nhtsa
 
       def url
         if @filters[:spanish] && @filters[:cpsweek]
-          BASE_URI + END_POINT + "/zip/#{@zip_code}" + CPS_WEEK + SPANISH + DEFAULT_PARAMS
+          "#{BASE_URI}#{END_POINT}/zip/#{@zip_code}#{CPS_WEEK}#{SPANISH}#{DEFAULT_PARAMS}"
         elsif @filters[:spanish]
-          BASE_URI + END_POINT + "/zip/#{@zip_code}" + SPANISH + DEFAULT_PARAMS
+          "#{BASE_URI}#{END_POINT}/zip/#{@zip_code}#{SPANISH}#{DEFAULT_PARAMS}"
         elsif @filters[:cpsweek]
-          BASE_URI + END_POINT + "/zip/#{@zip_code}" + CPS_WEEK + DEFAULT_PARAMS
+          "#{BASE_URI}#{END_POINT}/zip/#{@zip_code}#{CPS_WEEK}#{DEFAULT_PARAMS}"
         else
-          BASE_URI + END_POINT + "/zip/#{@zip_code}" + DEFAULT_PARAMS
+          "#{BASE_URI}#{END_POINT}/zip/#{@zip_code}#{DEFAULT_PARAMS}"
         end
       end
 

data/lib/nhtsa/civil_penalties/civil_penalties.rb

@@ -2,7 +2,7 @@ module Nhtsa
   module CivilPenalties
     class CivilPenalties
       def url
-        BASE_URI + END_POINT + DEFAULT_PARAMS
+        "#{BASE_URI}#{END_POINT}#{DEFAULT_PARAMS}"
       end
 
       def civil_penalties

data/lib/nhtsa/civil_penalties/civil_penalties_by_year.rb

@@ -6,7 +6,7 @@ module Nhtsa
       end
 
       def url
-        BASE_URI + END_POINT + "/#{@year}" + DEFAULT_PARAMS
+        "#{BASE_URI}#{END_POINT}/#{@year}#{DEFAULT_PARAMS}"
       end
 
       def civil_penalties_by_year

data/lib/nhtsa/complaints/complaints.rb

@@ -8,7 +8,7 @@ module Nhtsa
       end
 
       def url
-        BASE_URI + END_POINT + "/#{@year}/#{@manufacturer}/#{@model}" + DEFAULT_PARAMS
+        "#{BASE_URI}#{END_POINT}/#{@year}/#{@manufacturer}/#{@model}#{DEFAULT_PARAMS}"
       end
 
       def complaints

data/lib/nhtsa/complaints/complaints_by_odi_number.rb

@@ -6,7 +6,7 @@ module Nhtsa
       end
 
       def url
-        BASE_URI + END_POINT + "/odinumber/#{@odi_number}" + DEFAULT_PARAMS
+        "#{BASE_URI}#{END_POINT}/odinumber/#{@odi_number}#{DEFAULT_PARAMS}"
       end
 
       def complaints_by_odi_number

data/lib/nhtsa/complaints/manufacturers.rb

@@ -6,7 +6,7 @@ module Nhtsa
       end
 
       def url
-        BASE_URI + END_POINT + "/#{@year}" + DEFAULT_PARAMS
+        "#{BASE_URI}#{END_POINT}/#{@year}#{DEFAULT_PARAMS}"
       end
 
       def manufacturers

data/lib/nhtsa/complaints/models.rb

@@ -7,7 +7,7 @@ module Nhtsa
       end
 
       def url
-        BASE_URI + END_POINT + "/#{@year}/#{@manufacturer}" + DEFAULT_PARAMS
+        "#{BASE_URI}#{END_POINT}/#{@year}/#{@manufacturer}#{DEFAULT_PARAMS}"
       end
 
       def models

data/lib/nhtsa/complaints/years.rb

@@ -2,7 +2,7 @@ module Nhtsa
   module Complaints
     class Years
       def url
-        BASE_URI + END_POINT + DEFAULT_PARAMS
+        "#{BASE_URI}#{END_POINT}#{DEFAULT_PARAMS}"
       end
 
       def years

data/lib/nhtsa/recalls/campaign_recalls.rb

@@ -6,7 +6,7 @@ module Nhtsa
       end
 
       def url
-        BASE_URI + END_POINT + "/CampaignNumber/#{@campaign_number}" + DEFAULT_PARAMS
+        "#{BASE_URI}#{END_POINT}/CampaignNumber/#{@campaign_number}#{DEFAULT_PARAMS}"
       end
 
       def campaign_recalls

data/lib/nhtsa/recalls/manufacturers.rb

@@ -6,7 +6,7 @@ module Nhtsa
       end
 
       def url
-        BASE_URI + END_POINT + "/#{@year}" + DEFAULT_PARAMS
+        "#{BASE_URI}#{END_POINT}/#{@year}#{DEFAULT_PARAMS}"
       end
 
       def manufacturers

data/lib/nhtsa/recalls/models.rb

@@ -7,7 +7,7 @@ module Nhtsa
       end
 
       def url
-        BASE_URI + END_POINT + "/#{@year}/#{@manufacturer}" + DEFAULT_PARAMS
+        "#{BASE_URI}#{END_POINT}/#{@year}/#{@manufacturer}#{DEFAULT_PARAMS}"
       end
 
       def models

data/lib/nhtsa/recalls/recalls.rb

@@ -8,7 +8,7 @@ module Nhtsa
       end
 
       def url
-        BASE_URI + END_POINT + "/#{@year}/#{@manufacturer}/#{@model}" + DEFAULT_PARAMS
+        "#{BASE_URI}#{END_POINT}/#{@year}/#{@manufacturer}/#{@model}#{DEFAULT_PARAMS}"
       end
 
       def recalls

data/lib/nhtsa/recalls/years.rb

@@ -3,7 +3,7 @@ module Nhtsa
   module Recalls
     class Years
       def url
-        BASE_URI + END_POINT + DEFAULT_PARAMS
+        "#{BASE_URI}#{END_POINT}#{DEFAULT_PARAMS}"
       end
 
       def years

data/lib/nhtsa/safety_ratings/manufacturers.rb

@@ -7,7 +7,7 @@ module Nhtsa
       end
 
       def url
-        BASE_URI + END_POINT + "/#{@year}" + DEFAULT_PARAMS
+        "#{BASE_URI}#{END_POINT}/#{@year}#{DEFAULT_PARAMS}"
       end
 
       def manufacturers

data/lib/nhtsa/safety_ratings/models.rb

@@ -8,7 +8,7 @@ module Nhtsa
       end
 
       def url
-        BASE_URI + END_POINT + "/#{@year}/#{URI.encode(@manufacturer.name)}" + DEFAULT_PARAMS
+        "#{BASE_URI}#{END_POINT}/#{@year}/#{URI.encode(@manufacturer.name)}#{DEFAULT_PARAMS}"
       end
 
       def models

data/lib/nhtsa/safety_ratings/ratings.rb

@@ -8,7 +8,7 @@ module Nhtsa
       end
 
       def url(vehicle_id)
-        BASE_URI + END_POINT + "/VehicleId/#{vehicle_id}" + DEFAULT_PARAMS
+        "#{BASE_URI}#{END_POINT}/VehicleId/#{vehicle_id}#{DEFAULT_PARAMS}"
       end
 
       def ratings

data/lib/nhtsa/safety_ratings/trims.rb

@@ -9,7 +9,7 @@ module Nhtsa
       end
 
       def url
-        BASE_URI + END_POINT + "/#{@year}/#{URI.encode(@manufacturer.name)}/#{URI.encode(@model.name)}" + DEFAULT_PARAMS
+        "#{BASE_URI}#{END_POINT}/#{@year}/#{URI.encode(@manufacturer.name)}/#{URI.encode(@model.name)}#{DEFAULT_PARAMS}"
       end
 
       def year

data/lib/nhtsa/safety_ratings/years.rb

@@ -6,7 +6,7 @@ module Nhtsa
       end
 
       def url
-        BASE_URI + END_POINT + DEFAULT_PARAMS
+        "#{BASE_URI}#{END_POINT}#{DEFAULT_PARAMS}"
       end
 
       def years

data/lib/nhtsa/version.rb

@@ -1,3 +1,3 @@
 module Nhtsa
-  VERSION = "0.2.0"
+  VERSION = "0.2.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: nhtsa
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Mwaki Harri Magotswi
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-09-18 00:00:00.000000000 Z
+date: 2017-06-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -78,6 +78,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".travis.yml"
+- CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - Gemfile
 - LICENSE.txt