nhkore 0.3.8 → 0.3.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c63efbc2f65cfe83c7b55e53a0dfca329c2aded4c22ae05c2fb50583876452b4
-  data.tar.gz: 87c5116e11cb7e2dd4a5cdb86d6fc1a80ea58dd4efa7bc27ad448c25c4fad724
+  metadata.gz: 4a7084fd097785a525cbe62fe59eaaa5a659c84a1673cb8663b3413b70e4e3a9
+  data.tar.gz: 7fd6c701cacc6bcbc2b55d8c33a1f9cefcbff36e39b2ebbb42022ce438188920
 SHA512:
-  metadata.gz: 68eb93da6d8f5c8ba3c4c58e0a9a71803dd4eefc6063df4ead9f0d06c0f1ba59892f5ddb43a9735c30ceaf85db63ed80c1b155bac1d5f0daf73f9cebbc7f6c6e
-  data.tar.gz: 33e9f4f770bceb2c0eb5d6d62781af400bc2b66f4ba4d4092b01b224bc365edef98cc47032f4b2389e04664f6cabcd2c02024139971bee207a121570805a6015
+  metadata.gz: e14fa1030416d99ad30c55ecb97b58135641e8008a485fe081104ab3cd177495889c3132015a8310b7aa9eee22e502e83de8378faee48c64785ed502eada4727
+  data.tar.gz: 16a856938c0a598122671cdf39ebaf569a9ec9d260a32f5830b9a21b1a3cf45b0940289c4136c273de1358211653ab3e250dd22bede936d312d4989edbb37cdd

data/CHANGELOG.md

@@ -5,10 +5,16 @@ All notable changes to this project will be documented in this file.
 Format is based on [Keep a Changelog v1.0.0](https://keepachangelog.com/en/1.0.0),
 and this project adheres to [Semantic Versioning v2.0.0](https://semver.org/spec/v2.0.0.html).
 
-## [[Unreleased]](https://github.com/esotericpig/nhkore/compare/v0.3.8...HEAD)
+## [[Unreleased]](https://github.com/esotericpig/nhkore/compare/v0.3.9...HEAD)
 -
 
 
+## [v0.3.9] - 2021-06-26
+
+### Fixed
+- Reverted `App#refresh_cmd()` back to not copying over the `default_proc` (from v0.3.8). Because the old code didn't know about this, it created some unintended issues with command options. Nothing major, but for example, specifying `output.html` with the `sift` command would not produce HTML output (however, using the `-e html` option still worked). This is the only instance that I know of, but reverting the code back in case of more instances. In the future, I'll need to thoroughly test all CLI options after changing `App#refresh_cmd()` to copy over the `default_proc`, but for now, not worrying about it (as it's not necessary).
+
+
 ## [v0.3.8] - 2021-06-26
 
 ### Fixed

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    nhkore (0.3.8)
+    nhkore (0.3.9)
       attr_bool (~> 0.2)
       bimyou_segmenter (~> 1.2)
       cri (~> 2.15)

data/lib/nhkore/app.rb

@@ -506,14 +506,20 @@ module NHKore
         new_opts[key] = value
       end
 
-      # Cri has a default proc for default values
-      #   that doesn't store the keys.
-      new_opts.default_proc = proc do |hash,key|
-        # :max_retry => %s(max-retry)
-        key = key.to_s.gsub('_','-').to_sym
-
-        opts.default_proc.call(hash,key)
-      end
+      # For now don't set the default proc, as the original code
+      #   did not have this in mind.
+      # Specifically, SiftCmd.build_sift_filename() is affected by
+      #   this due to relying on @cmd_opts[:ext] to be nil.
+      #   It's easy to change this one instance, but I'm not sure
+      #   at the moment where else might be affected
+      ## Cri has a default proc for default values
+      ##   that doesn't store the keys.
+      #new_opts.default_proc = proc do |hash,key|
+      #  # :max_retry => %s(max-retry)
+      #  key = key.to_s.gsub('_','-').to_sym
+      #
+      #  opts.default_proc.call(hash,key)
+      #end
 
       @cmd = cmd
       @cmd_args = args

data/lib/nhkore/version.rb

@@ -10,5 +10,5 @@
 
 
 module NHKore
-  VERSION = '0.3.8'
+  VERSION = '0.3.9'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: nhkore
 version: !ruby/object:Gem::Version
-  version: 0.3.8
+  version: 0.3.9
 platform: ruby
 authors:
 - Jonathan Bradley Whited
@@ -398,7 +398,7 @@ metadata:
   changelog_uri: https://github.com/esotericpig/nhkore/blob/master/CHANGELOG.md
 post_install_message: |2+
 
-    NHKore v0.3.8
+    NHKore v0.3.9
 
     You can now use [nhkore] on the command line.
 
@@ -413,7 +413,7 @@ rdoc_options:
 - "--hyperlink-all"
 - "--show-hash"
 - "--title"
-- NHKore v0.3.8 Doc
+- NHKore v0.3.9 Doc
 - "--main"
 - README.md
 require_paths: