ngauthier-slow-actions 0.3.2 → 0.3.3

data/README.rdoc

@@ -25,36 +25,56 @@ Reads a rails app's log file for slow actions
   puts @sa.print_actions
 
 == Sample output:
-  $> slow-actions --controller my_log_file
+  $> slow-actions --actions --min-cost=2 test/data/development.log
+             Cost    Average Max
+  - UsersController : game_history (22 entries, 0% Error)
+    Total:   11275.447 3642.437 12728.0 
+    Render:  7.20300 2.32700 17.2450 
+    DB:      10.5020 3.39200 10.0000 
+
+  - QuestionsController : refresh_index_table (89 entries, 0% Error)
+    Total:   908.494 202.348 307.000 
+    Render:  0.00000 0.00000 0.00000 
+    DB:      32.5880 7.25800 10.0000 
+
+  - UsersController : show (128 entries, 0% Error)
+    Total:   664.292 136.888 2680.00 
+    Render:  0.33500 0.06900 3.41000 
+    DB:      18.2330 3.75700 114.000 
+
+  $> slow-actions --controllers --min-cost=2 test/data/development.log > ~/Desktop/sa-controllers.txt
                Cost    Average Max
-  + UsersController (7 entries)
-  | Total:     1.88300 0.96000 6.62000 
-  | Render:    1.75600 0.89600 6.24000 
-  | DB:        0.29500 0.15000 0.36400 
-  |-+ index (3 entries)
-  | | Total:   2.49600 2.20600 6.62000 
-  | | Render:  2.35300 2.08000 6.24000 
-  | | DB:      0.25700 0.22800 0.36400 
-  |-+ winning_history (2 entries)
-  | | Total:   0.03800 0.05200 0.10400 
-  | | Render:  0.01100 0.01600 0.03200 
-  | | DB:      0.13800 0.18600 0.34800 
-
-  + StaticPagesController (3 entries)
-  | Total:     0.04500 0.04000 0.06000 
-  | Render:    0.03100 0.02700 0.04400 
-  | DB:        0.08200 0.07300 0.21600 
-  |-+ static_hunters_lodge (3 entries)
-  | | Total:   0.04500 0.04000 0.06000 
-  | | Render:  0.03100 0.02700 0.04400 
-  | | DB:      0.08200 0.07300 0.21600 
-
-  + SessionsController (5 entries)
-  | Total:     0.03300 0.02000 0.06400 
-  | Render:    0.00700 0.00400 0.01600 
-  | DB:        0.01500 0.00900 0.04800 
-  |-+ create (2 entries)
-  | | Total:   0.03400 0.04600 0.06400 
-  | | Render:  0.00100 0.00200 0.00400 
-  | | DB:      0.02600 0.03600 0.04800 
+  + UsersController (236 entries, 0% Error)
+  | Total:     2165.375 396.279 12728.0 
+  | Render:    1.63400 0.29900 17.2450 
+  | DB:        7.03400 1.28700 114.000 
+  |-+ game_history (22 entries, 0% Error)
+  | | Total:   11275.447 3642.437 12728.0 
+  | | Render:  7.20300 2.32700 17.2450 
+  | | DB:      10.5020 3.39200 10.0000 
+  |-+ show (128 entries, 0% Error)
+  | | Total:   664.292 136.888 2680.00 
+  | | Render:  0.33500 0.06900 3.41000 
+  | | DB:      18.2330 3.75700 114.000 
+  |-+ index (812 entries, 51% Error)
+  | | Total:   465.660 69.5050 1922.00 
+  | | Render:  0.30100 0.04500 2.39600 
+  | | DB:      40.9320 6.10900 1164.00 
+
+  $> slow-actions --sessions --min-cost=2 test/data/development.log > ~/Desktop/sa-sessions.txt
+             Cost    Average Max
+  + d2dac54dc3816195ed9ef083e2811c61 (89 entries, 60% Error)
+  | Total:   10923.296 2432.935 12603.0 
+  | Render:  0.00000 0.00000 0.00000 
+  | DB:      51.9520 11.5710 53.0000 
+
+  + 3283ca1f8b1039f8c4403cbc7f9941c9 (18 entries, 5% Error)
+  | Total:   2179.158 752.494 12728.0 
+  | Render:  9.70500 3.35100 17.2450 
+  | DB:      2.93100 1.01200 10.0000 
+
+  + 867bc340e6d65e673f29c57189feaf2b (133 entries, 0% Error)
+  | Total:   1083.138 221.450 386.000 
+  | Render:  0.00000 0.00000 0.00000 
+  | DB:      44.2030 9.03700 90.0000 
 

data/VERSION.yml

@@ -1,4 +1,4 @@
 --- 
-:patch: 2
+:patch: 3
 :major: 0
 :minor: 3

data/lib/slow_actions.rb

@@ -46,7 +46,8 @@ class SlowActions
       next if opts[:mincost] and a.total_cost < opts[:mincost]
       next if opts[:minavg] and a.total_avg < opts[:minavg]
       next if opts[:minmax] and a.total_max < opts[:minmax]
-      str += "- #{a.controller.name} : #{a.name} (#{a.log_entries.size} entries)\n"
+      str += "- #{a.controller.name} : #{a.name} "
+      str += "(#{a.log_entries.size} entries, #{(a.error_avg*100).to_i}% Error)\n"
       str += "  Total:   #{ftos a.total_cost}#{ftos a.total_avg}#{ftos a.total_max}\n"
       str += "  Render:  #{ftos a.render_cost}#{ftos a.render_avg}#{ftos a.render_max}\n"
       str += "  DB:      #{ftos a.db_cost}#{ftos a.db_avg}#{ftos a.db_max}\n"
@@ -63,7 +64,7 @@ class SlowActions
       next if opts[:mincost] and c.total_cost < opts[:mincost]
       next if opts[:minavg] and c.total_avg < opts[:minavg]
       next if opts[:minmax] and c.total_max < opts[:minmax]
-      str += "+ #{c.name} (#{c.log_entries.size} entries)\n"
+      str += "+ #{c.name} (#{c.log_entries.size} entries, #{(c.error_avg*100).to_i}% Error)\n"
       str += "| Total:     #{ftos c.total_cost}#{ftos c.total_avg}#{ftos c.total_max}\n"
       str += "| Render:    #{ftos c.render_cost}#{ftos c.render_avg}#{ftos c.render_max}\n"
       str += "| DB:        #{ftos c.db_cost}#{ftos c.db_avg}#{ftos c.db_max}\n"
@@ -71,7 +72,7 @@ class SlowActions
         next if opts[:mincost] and a.total_cost < opts[:mincost]
         next if opts[:minavg] and a.total_avg < opts[:minavg]
         next if opts[:minmax] and a.total_max < opts[:minmax]
-        str += "|-+ #{a.name} (#{a.log_entries.size} entries)\n"
+        str += "|-+ #{a.name} (#{a.log_entries.size} entries, #{(a.error_avg*100).to_i}% Error)\n"
         str += "| | Total:   #{ftos a.total_cost}#{ftos a.total_avg}#{ftos a.total_max}\n"
         str += "| | Render:  #{ftos a.render_cost}#{ftos a.render_avg}#{ftos a.render_max}\n"
         str += "| | DB:      #{ftos a.db_cost}#{ftos a.db_avg}#{ftos a.db_max}\n"
@@ -89,7 +90,7 @@ class SlowActions
       next if opts[:mincost] and s.total_cost < opts[:mincost]
       next if opts[:minavg] and s.total_avg < opts[:minavg]
       next if opts[:minmax] and s.total_max < opts[:minmax]
-      str += "+ #{s.name} (#{s.log_entries.size} entries)\n"
+      str += "+ #{s.name} (#{s.log_entries.size} entries, #{(s.error_avg*100).to_i}% Error)\n"
       str += "| Total:   #{ftos s.total_cost}#{ftos s.total_avg}#{ftos s.total_max}\n"
       str += "| Render:  #{ftos s.render_cost}#{ftos s.render_avg}#{ftos s.render_max}\n"
       str += "| DB:      #{ftos s.db_cost}#{ftos s.db_avg}#{ftos s.db_max}\n"
@@ -160,6 +161,9 @@ class SlowActions
     @controllers.values.each{|c| c.compute_times}
     @actions.values.each{|a| a.compute_times}
     @sessions.values.each{|s| s.compute_times}
+
+    # return something simple. This helps irb not barf on itself trying to print everything
+    return true
   end
 
   # Convert a float to 7 places padded with zeros then one space

data/lib/slow_actions_computation_module.rb

@@ -49,9 +49,9 @@ module Computable
         @total_max  = la.duration     if la.duration     > @total_max
       end
       
-      @render_avg /= @log_entries.size.to_f
-      @db_avg     /= @log_entries.size.to_f
-      @total_avg  /= @log_entries.size.to_f
+      @render_avg /= @log_entries.size.to_f - @error_avg + 0.0001
+      @db_avg     /= @log_entries.size.to_f - @error_avg + 0.0001
+      @total_avg  /= @log_entries.size.to_f - @error_avg + 0.0001
       @error_avg  /= @log_entries.size.to_f
 
       # using math.log allows us to smooth out the score between

data/lib/slow_actions_log_entry.rb

@@ -35,8 +35,7 @@ class SlowActions
 
     # Whether or not this #LogEntry was an error
     def error?
-      return false if error_text.nil?
-      return false if error_text.empty?
+      return false if error_text.nil? or error_text.empty?
       return true
     end
   end

data/lib/slow_actions_parser.rb

@@ -89,12 +89,12 @@ class SlowActions
       while line == "\n"
         line = @file.readline
       end
-      error_txt = ""
+      error_txt = []
       while line != "\n"
         line = @file.readline
-        error_txt += line
+        error_txt.push line
       end
-      return error_txt
+      return error_txt.join("")
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: ngauthier-slow-actions
 version: !ruby/object:Gem::Version 
-  version: 0.3.2
+  version: 0.3.3
 platform: ruby
 authors: 
 - Nick Gauthier