ng-bank-parser 0.1.5 → 0.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6521c62889ffd5475c6f76e04f79b01aa0d744bc
-  data.tar.gz: a8b6dd72ce1d0b64872fa4e46b4e1ac9b1859360
+  metadata.gz: 5904cb150c3b458c49643ee2ff3717ddaf01cc30
+  data.tar.gz: 875fe8dc6feaccba17d8da19f27ebde90f45e0c0
 SHA512:
-  metadata.gz: 15818a961c4c2745f6e6fc3ffffeffa20ff0e124c4caed2f6a8515abfebd4dbfc8516e6954f7599f3b72665d5cf55ee14d75d266d585eb006bd28f4f2aea64b6
-  data.tar.gz: 194188f43d96f693f8cdedfc38730bb5aa2f97ef0dd42505230e0c247ce5d06fd9c16b1c2bddc07a118410bec25e76f2f43cfc061066bbaa75d1e546fbda81ea
+  metadata.gz: 5e09a5b5685f2d03555aeaf0ca727e3428acd730f2da07463b54c988d6351538ca58a20b8bbd77aaa4612dd06a513c0fe88aaac2956b60b190334b82111fe9fd
+  data.tar.gz: c4e7303f6756d87d1d91c1bb48a94d3b99101dc2fe1ba16a0aa04b5e0743c038fb686a0c31a2998aaeee2daf2ab9feed485dd78ea9a146903da1795022b35d70

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    ng-bank-parser (0.1.4)
+    ng-bank-parser (0.1.5)
       activesupport
       nokogiri
       pdf-reader
@@ -20,19 +20,19 @@ GEM
       tzinfo (~> 1.1)
     afm (0.2.2)
     diff-lcs (1.2.5)
-    domain_name (0.5.24)
+    domain_name (0.5.25)
       unf (>= 0.0.5, < 1.0.0)
     hashery (2.1.1)
     http-cookie (1.0.2)
       domain_name (~> 0.5)
     i18n (0.7.0)
     json (1.8.3)
-    mime-types (2.6.1)
-    mini_portile (0.6.2)
-    minitest (5.8.0)
-    netrc (0.10.3)
-    nokogiri (1.6.6.2)
-      mini_portile (~> 0.6.0)
+    mime-types (2.99)
+    mini_portile2 (2.0.0)
+    minitest (5.8.3)
+    netrc (0.11.0)
+    nokogiri (1.6.7)
+      mini_portile2 (~> 2.0.0.rc2)
     pdf-reader (1.3.3)
       Ascii85 (~> 1.0.0)
       afm (~> 0.2.0)

data/README.md

@@ -39,7 +39,7 @@ result = NgBankParser::Router.parse(bank_key, file_path, password)
 
 ```ruby
 result = {
-    status: 1,
+    status: 200,
     data: {
         bank_name: the_bank_name,
         account_number: the_account_number,
@@ -51,11 +51,11 @@ result = {
 }
 ```
 
-`:status` can either be 1 or 0. 1 for when the parsing is succesful and 0 for when it's not. A status of 0 is accompanied with an error message that aims to clarify why it could not parse the file.
+`:status` can either be 200 or 400. 200 for when the parsing is succesful and 200 for when it's not. A status of 400 is accompanied with an error message that aims to clarify why it could not parse the file.
 
 ```ruby
 result = {
-    status: 0,
+    status: 400,
     message: "RELEVANT ERROR MESSAGE"
 }
 ```

data/lib/ng-bank-parser/banks.rb

@@ -1,6 +1,6 @@
 module NgBankParser
 	class Banks
-		$Banks = [{
+    BANK_DEFINITIONS = [{
 		    key: "gtb",
 		    name: "Guaranty Trust Bank",
 		    parsers: [{

data/lib/ng-bank-parser/parsers/accessbank-pdf-parser/helpers.rb

@@ -114,11 +114,11 @@ module AccessbankPdfHelpers
 
 
   def error(msg)
-    { status: 0, message: msg }
+    { status: 400, message: msg }
   end
 
   def success(data)
-    { status: 1, data: data }
+    { status: 200, data: data }
   end
 
 

data/lib/ng-bank-parser/parsers/firstbank-pdf-parser.rb

@@ -1,12 +1,11 @@
 require 'pdf-reader'
 require_relative 'firstbank-pdf-parser/helpers'
 
+
 module NgBankParser
 	class FirstbankPdf
 		extend FirstbankPdfHelpers
 
-		@@transactions = []
-		
 		def self.parse(path, password = nil)
 			accepted_formats = [".pdf"];
 			unless accepted_formats.include? File.extname(path)
@@ -29,15 +28,16 @@ module NgBankParser
 				return error_message 'Unable to read account details'
 			end
 
-			if contains_transactions_table?
-				extract_transactions(clean(get_raw_transactions))
+			raw_transactions = contains_transactions_table?
+			if raw_transactions
+				bdd = extract_transactions(clean(raw_transactions))
 				data = {}
 				data[:bank_name] = 'First Bank'
 				data[:account_number] = get_account_number
 				data[:account_name] = get_account_name
 				data[:from_date] = get_from_date
 				data[:to_date] = get_to_date
-				data[:transactions] = @@transactions
+				data[:transactions] = bdd
 				send_response data
 			else
 				return error_message 'Could not find any transactions'
@@ -47,6 +47,7 @@ module NgBankParser
 		private
 
 		def self.extract_transactions(jagged_array = [[]])
+			arr = []
 			jagged_array.each do |array|
 				if is_transaction_row? array
 					transaction = {}
@@ -62,11 +63,12 @@ module NgBankParser
 						transaction[:type] = 'debit'
 						update_last_balance transaction[:balance]
 					end
-					@@transactions << transaction
+					arr << transaction
 				else
-					@@transactions.last[:remarks] += array[0] if @@transactions
+					arr.last[:remarks] += array[0]
 				end
 			end
+			arr
 		end
 
 

data/lib/ng-bank-parser/parsers/firstbank-pdf-parser/helpers.rb

@@ -1,16 +1,14 @@
 require 'pdf-reader'
 require 'date'
 require 'open-uri'
-require 'securerandom'
 require_relative 'statement_utils'
 require_relative '../../pdf-unlocker.rb'
 
 module NgBankParser
 	module FirstbankPdfHelpers
 		include StatementUtils
-		
+
 		@@pdf_reader = nil
-		@@raw_transactions = [[]]
 		@@account_name = nil
 		@@account_number = nil
 		@@last_balance = nil
@@ -29,7 +27,6 @@ module NgBankParser
 
 		def get_unlocked_pdf? path, password
 			response = PDFUnlocker.unlock(path, password)
-
 			return false unless response
 			if response.include? 'Unlock Failed'
 				return false
@@ -40,26 +37,15 @@ module NgBankParser
 					@@pdf_reader = PDF::Reader.new(pseudo_file)
 					return true
 				rescue
-					return false					
+					return false
 				end
 			end
 		end
 
 
-		def get_raw_transactions
-			@@raw_transactions
-		end
-
-
 		def get_transaction_data
 			pages = get_pages @@pdf_reader
-			pages.each do |page|
-				page_text = get_page_text page
-				index = get_transaction_table_index page_text
-				unless index == -1
-					add_to_transactions page_text[index..-1]
-				end
-			end
+			get_all_transactions(pages)
 		end
 
 
@@ -104,7 +90,6 @@ module NgBankParser
 
 		def contains_transactions_table?
 			get_transaction_data
-			@@raw_transactions
 		end
 
 
@@ -157,7 +142,7 @@ module NgBankParser
 
 		def error_message msg
 			return {
-					status: 0,
+					status: 400,
 					message: msg
 				}
 		end
@@ -165,7 +150,7 @@ module NgBankParser
 
 		def send_response data
 			return {
-					status: 1,
+					status: 200,
 					data: data
 				}
 		end
@@ -173,10 +158,19 @@ module NgBankParser
 
 		private
 
-		def add_to_transactions lines
-			lines.each do |line|
-				@@raw_transactions << line.strip.split(/\s\s+/)
+		def get_all_transactions pages
+			raw_transactions = [[]]
+			pages.each do |page|
+				page_text = get_page_text page
+				index = get_transaction_table_index page_text
+				unless index == -1
+					lines = page_text[index..-1]
+					lines.each do |line|
+						raw_transactions << line.strip.split(/\s\s+/)
+					end
+				end
 			end
+			return raw_transactions
 		end
 
 	end

data/lib/ng-bank-parser/parsers/gtb-excel-parser.rb

@@ -50,14 +50,14 @@ module NgBankParser
 
 			def error_message(text)
 				return { 
-					status: 0, 
+					status: 400,
 					message: text
 				}
 			end
 
 			def send_response(data)
 				return {
-					status: 1,
+					status: 200,
 					data: data
 				}
 			end

data/lib/ng-bank-parser/parsers/hb-pdf-parser.rb

@@ -57,13 +57,12 @@ module NgBankParser
         return {
             status: VALID_ACCOUNT_STATUS,
             data: {
-                bank_name: $Banks[1][:name],
+                bank_name: NgBankParser::Banks::BANK_DEFINITIONS[1][:name],
                 account_number: @account_number,
                 account_name: @account_name,
                 from_date: @start_date,
                 to_date: @end_date,
                 transactions: @transactions
-                # reader: @reader
             }
         }
       end

data/lib/ng-bank-parser/parsers/hb-pdf-parser/hb_constants.rb

@@ -2,8 +2,8 @@ module NgBankParser
   module HbConstants
     ACCEPTED_FORMATS = ['.pdf']
 
-    INVALID_ACCOUNT_STATUS = 0
-    VALID_ACCOUNT_STATUS = 1
+    INVALID_ACCOUNT_STATUS = 400
+    VALID_ACCOUNT_STATUS = 200
 
     SECOND_PAGE_INDEX = 1
     DURATION_DATE_LINE_INDEX = 3

data/lib/ng-bank-parser/parsers/uba-pdf-parser.rb

@@ -87,7 +87,7 @@ module NgBankParser
 
       def return_payload
         return {
-            status: 1,
+            status: 200,
             data: {
                 bank_name: @bank_name,
                 account_number: @account_number,
@@ -101,7 +101,7 @@ module NgBankParser
 
       def invalid_file
         return {
-            status: 0, message: INVALID_FILE_STRING
+            status: 400, message: INVALID_FILE_STRING
         }
       end
 

data/lib/ng-bank-parser/router.rb

@@ -1,6 +1,6 @@
 module NgBankParser
   class Router
-    @banks = $Banks
+    @banks = NgBankParser::Banks::BANK_DEFINITIONS
     
     #this takes our bank parser along with the bank name supplied from the payload so as to compare
     #and see if the file extension is available for that bank

data/lib/ng-bank-parser/version.rb

@@ -1,3 +1,3 @@
 module NgBankParser
-  VERSION = "0.1.5"
+  VERSION = "0.1.6"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ng-bank-parser
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.1.6
 platform: ruby
 authors:
 - Opemipo Aikomo
@@ -11,118 +11,118 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2015-09-22 00:00:00.000000000 Z
+date: 2015-12-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.10'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.10'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '10.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '10.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: roo
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: pdf-reader
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rest-client
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: This is a simple gem to parse Nigerian bank statements of all formats.
@@ -135,8 +135,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
+- ".gitignore"
+- ".rspec"
 - CODE_OF_CONDUCT.md
 - Gemfile
 - Gemfile.lock
@@ -189,17 +189,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.2
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: This is a simple gem to parse Nigerian bank statements of all formats created