nfl_data 0.0.2 → 0.0.3

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    NjNhOTYxZmI2MDJmNjQ1MzhlOWZkZTY2OGQ1NGZhZTk4MWVjNTRhYQ==
+    ZGY4MDZmMWQzZTUxYTNmZDYyYWM0YzlhM2JjNjQxZTYzZGJhOTA1MA==
   data.tar.gz: !binary |-
-    ZWJjMzA4YTJiZTcyYWNlZmFlZjQ1YmVlOTJlYmZlM2VhNTM0NWQ5Yg==
+    NmM4ZmJlNWEwZmE0ZTQ4YjRkNGYzODg4NmQxYTUyNDcwNWQ4MWY0Zg==
 SHA512:
   metadata.gz: !binary |-
-    MWQ2OWIzNTdjMTEzOWEwNGIxY2RhY2Q1Yjg0YjdmYzNkNjk1YTgwNWQ4M2U0
-    MmQwMTZjNTkwOGYzMWZkNzBjYjk1YzE4MTM2MDUxYTRlOWQ0NDcyODE5ZDMy
-    YTBiMDA1YWY0YWY2YmIzZTE5MDNhYjI0NTNjYjVlMDg4NTkwN2U=
+    N2MwYWVlZWI2OTQ0M2Y3ZjA5Mjk1OTc4ZmEyNmY5MTk4Y2VlYzZhZjYzZDM4
+    ODAyMDhmNzUxYWJiYzFkNGM1YjIzNjc3MjY3NWQ0MDEzOGZiY2MxMGMwMDll
+    Y2MwOTQ2MmI1NDc1ZGRiNzZlY2JlYmE3ZDM2Y2I3ODg0MzBjMDY=
   data.tar.gz: !binary |-
-    ZTA3ZjhlNDkwNTdlMGJiMDljY2YwMTUwNTQyZTdmNWFhOGI5ZjhlZjZmMzg5
-    ODJkZGVhNjQ4NmE1NjQ0MThkZTg5MjE5NWJjNTUzNTQ2Y2Q0Y2M4NDdiZDY2
-    MWE3ODE4ODNhYjRmOTcyM2MzZmNlOGY3NjEzN2Q5ODExMDZhMjc=
+    YWQ1MGNhNTc1ODEwODEwZjBkN2U1OGZiMWRjMTQ3Mzk3Mzk5ODE5M2ZlOTZh
+    YTk2MDU2MDJhM2ExNTFmZmQ1NTcyOGQwZmE4MjRhNDNlMTA3NTM0NDA0Mjcw
+    NTk1Y2M2ODc1OTI2ZmI0OGM0MWJhZWM3M2ZhYmNhN2FmN2NkMGQ=

data/lib/nfl_data/api/player.rb

@@ -2,31 +2,38 @@ module NflData
   module API
     class Player
 
+      def initialize
+        @parser = PlayerParser.new
+      end
+
+      def get(position)
+        @parser.get_by_position(position).to_json
+      end
+
       class << self
-        def positions
-          ['quarterback', 'runningback', 'widereceiver', 'tightend']
+
+        def get_all
+          self.new.get(:all)
         end
 
         def get_quarterbacks
-          players = PlayerParser.new.get_by_position('quarterback').map { |player| player.to_json }
-          JSON.generate({quarterbacks: players})
+          self.new.get(:quarterbacks)
         end
 
         def get_runningbacks
-          players = PlayerParser.new.get_by_position('runningback').map { |player| player.to_json }
-          JSON.generate({runningbacks: players})
+          self.new.get(:runningbacks)
         end
 
         def get_wide_receivers
-          players = PlayerParser.new.get_by_position('widereceiver').map { |player| player.to_json }
-          JSON.generate({wide_receivers: players})
+          self.new.get(:wide_receivers)
         end
 
         def get_tight_ends
-          players = PlayerParser.new.get_by_position('tightend').map { |player| player.to_json }
-          JSON.generate({tight_ends: players})
+          self.new.get(:tight_ends)
         end
+
       end
+
     end
   end
 end

data/lib/nfl_data/parsers/player_parser.rb

@@ -2,13 +2,36 @@ require 'nokogiri'
 
 module NflData
   class PlayerParser
+    attr_reader :base_url
 
     def initialize
-      @url = "http://www.nfl.com/players/search?category=position&conferenceAbbr=null&playerType=current&conference=ALL&filter="
+      @base_url = "http://www.nfl.com/players/search?category=position&conferenceAbbr=null&playerType=current&conference=ALL&filter="
     end
 
     def get_by_position(position)
-      baseurl = @url + position
+      case position
+      when :quarterbacks
+        { position => get('quarterback') }
+      when :runningbacks
+        { position => get('runningback') }
+      when :wide_receivers
+        { position => get('widereceiver') }
+      when :tight_ends
+        { position => get('tightend') }
+      when :all
+        {
+          quarterbacks: get('quarterback'),
+          runningbacks: get('runningback'),
+          wide_receivers: get('widereceiver'),
+          tight_ends: get('tightend')
+        }
+      end
+    end
+
+    private
+
+    def get(position)
+      baseurl = @base_url + position
       url = baseurl
       returnVal = []
       page_num = 1
@@ -24,7 +47,7 @@ module NflData
         url += page_num.to_s
       end
 
-      returnVal.flatten
+      returnVal.flatten.map{ |player| player.to_hash }
     end
 
     def update_or_create_players(url)
@@ -45,14 +68,14 @@ module NflData
         elements = p.search("td")
         player.position = elements[0].inner_text.strip
         player.number = elements[1].inner_text.strip
-        player.name = elements[2].inner_text.strip
+        name = elements[2].inner_text.strip
         player.status = elements[3].inner_text.strip
         player.team = elements[12].inner_text.strip
 
         #Get NFL.com Unique player id
         player.nfl_player_id = elements[2].to_s.split('/')[3]
 
-        names = player.name.split(',')
+        names = name.split(',')
 
         player.first_name = names[1].strip
         player.last_name = names[0].strip

data/lib/nfl_data/player.rb

@@ -5,8 +5,8 @@ module NflData
   class Player
     attr_accessor :first_name, :last_name, :full_name, :position, :number, :status, :team, :nfl_player_id
 
-    def to_json
-      JSON.generate({
+    def to_hash
+      {
         first_name: first_name,
         last_name: last_name,
         full_name: full_name,
@@ -15,7 +15,7 @@ module NflData
         status: status,
         team: team,
         nfl_player_id: nfl_player_id
-        })
+      }
     end
 
   end

data/lib/nfl_data/version.rb

@@ -1,3 +1,3 @@
 module NflData
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/test/nfl_data/parsers/player_parser_test.rb

@@ -0,0 +1,15 @@
+require 'test_helper'
+
+describe PlayerParser do
+  before do
+    @parser = PlayerParser.new
+  end
+
+  after do
+    @parser = nil
+  end
+
+  it 'should know the correct base url' do
+    @parser.base_url.must_equal "http://www.nfl.com/players/search?category=position&conferenceAbbr=null&playerType=current&conference=ALL&filter="
+  end
+end

data/test/nfl_data/player_test.rb

@@ -1,6 +1,6 @@
 require 'test_helper'
 
-describe NflData::Player do
+describe Player do
   before do
     @player = NflData::Player.new
   end
@@ -41,7 +41,7 @@ describe NflData::Player do
     @player.must_respond_to :nfl_player_id
   end
 
-  describe 'to_json' do
+  describe 'to_hash' do
     before do
       @player.first_name = 'John'
       @player.last_name = 'Elway'
@@ -53,8 +53,8 @@ describe NflData::Player do
       @player.nfl_player_id = '123'
     end
 
-    def valid_player_json
-      JSON.generate({
+    def valid_player_hash
+      {
         first_name: 'John',
         last_name: 'Elway',
         full_name: 'John Elway',
@@ -63,11 +63,11 @@ describe NflData::Player do
         status: 'Retired',
         team: 'Broncos',
         nfl_player_id: '123'
-        })
+      }
     end
 
-    it 'can return itself as JSON' do
-      @player.to_json.must_equal valid_player_json
+    it 'can return itself as hash' do
+      @player.to_hash.must_equal valid_player_hash
     end
 
   end

data/test/test_helper.rb

@@ -2,3 +2,5 @@ require 'nfl_data'
 
 require 'minitest/autorun'
 require 'minitest/pride'
+
+include NflData

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: nfl_data
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - thetizzo
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-30 00:00:00.000000000 Z
+date: 2014-10-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -86,6 +86,7 @@ files:
 - lib/nfl_data/player.rb
 - lib/nfl_data/version.rb
 - nfl_data.gemspec
+- test/nfl_data/parsers/player_parser_test.rb
 - test/nfl_data/player_test.rb
 - test/test_helper.rb
 homepage: ''
@@ -113,5 +114,6 @@ signing_key:
 specification_version: 4
 summary: Grabber for NFL data that is useful for fantasy purposes from NFL.com
 test_files:
+- test/nfl_data/parsers/player_parser_test.rb
 - test/nfl_data/player_test.rb
 - test/test_helper.rb