nfl_data 0.0.13 → 0.0.14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 799b7134e6d90536c68bdd577ff48e5607ed2959
-  data.tar.gz: dd7cc4008c4631f4d7ca4206d116c41a79fa2782
+SHA256:
+  metadata.gz: 4770f23bf68572218ed0d2f64f695f7a18f67836b383f70ad5e4905294c2fea5
+  data.tar.gz: bb3999a02144d75d47bce2db82a5421da2e439896896e7f1f49bc585feff01a7
 SHA512:
-  metadata.gz: a661cf0cbafaacb50d9d7c2b93239f933b1c3bfd9215ed76b77b496c43edf88cfef8ba6926c4520146cebb2eafd97c2ec03e9707978738591662bd6a2e366427
-  data.tar.gz: 92876394fef9af6fa48ab3b3ded2a8d5a1ef8b678f95ed8945b753dcb291c5410d4dda51ad4e942b8143efd3069e88ab8052e37b066e56d39b44d2c18339ad7d
+  metadata.gz: 160b8568b742784ea4b43df322d315282a5fe83de4b6490f22a916873497ae65864ef03a797d153c1fce4042f854e029482255d2edcd37811cf3f2f93ef9c2f8
+  data.tar.gz: 3a39657ad68a0b8e18b2e16896d7cf17baf4afc54d73a76f2c2e58335e5f795b39e17aceb463b0c1488722035cb556f38072b1b066604de5f6266f626a3293c6

data/.gitignore

@@ -20,6 +20,6 @@ tmp
 *.o
 *.a
 mkmf.log
-test/fixtures/cassettes
+test/cassettes
 .ruby-version
 .ruby-gemset

data/lib/nfl_data.rb

@@ -8,6 +8,7 @@ require 'nfl_data/models/player'
 require 'nfl_data/models/statline'
 require 'nfl_data/models/team'
 
+require 'nfl_data/parsers/data/teams'
 require 'nfl_data/parsers/parser_helper'
 require 'nfl_data/parsers/player_parser'
 require 'nfl_data/parsers/statline_parser'

data/lib/nfl_data/parsers/data/teams.rb

@@ -0,0 +1,36 @@
+module Teams
+  TEAMS = {
+    'ARI' => 'Arizona Cardinals',
+    'ATL' => 'Atlanta Falcons',
+    'BAL' => 'Baltimore Ravens',
+    'BUF' => 'Buffalo Bills',
+    'CAR' => 'Carolina Panthers',
+    'CHI' => 'Chicago Bears',
+    'CIN' => 'Cincinnati Bengals',
+    'CLE' => 'Cleveland Browns',
+    'DAL' => 'Dallas Cowboys',
+    'DEN' => 'Denver Broncos',
+    'DET' => 'Detroit Lions',
+    'GB' => 'Green Bay Packers',
+    'HOU' => 'Houston Texans',
+    'IND' => 'Indianapolis Colts',
+    'JAX' => 'Jacksonville Jaguars',
+    'KC' => 'Kansas City Chiefs',
+    'LA' => 'Los Angeles Rams',
+    'LAC' => 'Los Angeles Chargers',
+    'MIA' => 'Miami Dolphins',
+    'MIN' => 'Minnesota Vikings',
+    'NE' => 'New England Patriots',
+    'NO' => 'New Orleans Saints',
+    'NYG' => 'New York Giants',
+    'NYJ' => 'New York Jets',
+    'OAK' => 'Oakland Raiders',
+    'PHI' => 'Philadelphia Eagles',
+    'PIT' => 'Pittsburgh Steelers',
+    'SEA' => 'Seattle Seahawks',
+    'SF' => 'San Francisco 49ers',
+    'TB' => 'Tampa Bay Buccaneers',
+    'TEN' => 'Tennessee Titans',
+    'WAS' => 'Washington Redskins'
+  }
+end

data/lib/nfl_data/parsers/player_parser.rb

@@ -81,7 +81,6 @@ module NflData
     end
 
     def get_profile_link(nfl_player_id, first_name, last_name)
-      return nil if ENV['NFL_DATA_ENV'] == 'test'
       "http://www.nfl.com/player/#{first_name.gsub(/\s/, '')}#{last_name.gsub(/\s/, '')}/#{nfl_player_id}/profile"
     end
 

data/lib/nfl_data/parsers/team_parser.rb

@@ -1,11 +1,10 @@
 module NflData
   class TeamParser
-    include ParserHelper
+    include Teams
 
     attr_reader :base_url
 
     def initialize
-      @base_url = 'http://www.nfl.com/standings?category=league&split=Overall&season='
     end
 
     def get_by_year(year, with_schedule)
@@ -15,27 +14,10 @@ module NflData
     private
 
     def get(year, with_schedule)
-      url = @base_url + "#{year}-REG"
-
-      doc = open(url) { |f| Nokogiri(f) }
-
-      all_links = doc.search('a').to_a
-
-      team_links = all_links.reject do |link|
-        href = link.attribute('href')
-
-        if href.nil?
-          true
-        else
-          !href.value.start_with?('/teams/profile?team=')
-        end
-      end
-
-      team_links.map do |link|
+      TEAMS.map do |short_name, team_name|
         team = Team.new
-        team.name = link.inner_text.strip
-        short_name = link.attribute('href').value.scan(/=(.*)/).flatten.first
-        team.short_name = make_jacksonville_abbreviation_consistent(short_name)
+        team.name = team_name
+        team.short_name = short_name
         team.schedule = get_schedule(team, year) if with_schedule
 
         team.to_hash

data/lib/nfl_data/version.rb

@@ -1,3 +1,3 @@
 module NflData
-  VERSION = '0.0.13'
+  VERSION = '0.0.14'
 end

data/nfl_data.gemspec

@@ -19,12 +19,12 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 
-  spec.add_development_dependency 'bundler', '~> 1.6'
+  spec.add_development_dependency 'bundler', '~> 1.16.5'
   spec.add_development_dependency 'rake'
-  spec.add_development_dependency 'minitest', '~> 5.4.1'
-  spec.add_development_dependency 'vcr', '~> 2.9.3'
-  spec.add_development_dependency 'webmock', '~> 1.19.0'
-  spec.add_development_dependency 'rubocop', '~> 0.52.1'
+  spec.add_development_dependency 'minitest', '~> 5.11.3'
+  spec.add_development_dependency 'vcr', '~> 4.0.0'
+  spec.add_development_dependency 'webmock', '~> 3.4.2'
+  spec.add_development_dependency 'rubocop', '~> 0.59.1'
 
   spec.add_dependency 'typhoeus', '~> 1.3'
   spec.add_dependency 'nokogiri', '~> 1.6'

data/test/nfl_data/parsers/player_parser_test.rb

@@ -23,7 +23,7 @@ describe PlayerParser do
         response = @parser.get_by_position(:quarterbacks)
 
         response.keys.must_include :quarterbacks
-        response[:quarterbacks].count.must_equal 118
+        response[:quarterbacks].count.must_be :>, 0
       end
     end
 
@@ -32,7 +32,7 @@ describe PlayerParser do
         response = @parser.get_by_position(:runningbacks)
 
         response.keys.must_include :runningbacks
-        response[:runningbacks].count.must_equal 243
+        response[:runningbacks].count.must_be :>, 0
       end
     end
 
@@ -41,7 +41,7 @@ describe PlayerParser do
         response = @parser.get_by_position(:wide_receivers)
 
         response.keys.must_include :wide_receivers
-        response[:wide_receivers].count.must_equal 339
+        response[:wide_receivers].count.must_be :>, 0
       end
     end
 
@@ -50,7 +50,7 @@ describe PlayerParser do
         response = @parser.get_by_position(:tight_ends)
 
         response.keys.must_include :tight_ends
-        response[:tight_ends].count.must_equal 188
+        response[:tight_ends].count.must_be :>, 0
       end
     end
 
@@ -58,14 +58,9 @@ describe PlayerParser do
       VCR.use_cassette('all_players') do
         response = @parser.get_by_position(:all)
 
-        {
-          quarterbacks: 118,
-          runningbacks: 243,
-          wide_receivers: 339,
-          tight_ends: 188
-        }.each do |position, player_count|
+        [:quarterbacks, :runningbacks, :wide_receivers, :tight_ends].each do |position|
           response.keys.must_include position
-          response[position].count.must_equal player_count
+          response[position].count.must_be :>, 0
         end
       end
     end

data/test/nfl_data/parsers/team_parser_test.rb

@@ -9,10 +9,6 @@ describe TeamParser do
     @parser = nil
   end
 
-  it 'should know the correct base url' do
-    @parser.base_url.must_equal 'http://www.nfl.com/standings?category=league&split=Overall&season='
-  end
-
   describe 'get_by_year' do
     it 'should get all the teams for year without schedule' do
       VCR.use_cassette('teams_without_schedule') do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: nfl_data
 version: !ruby/object:Gem::Version
-  version: 0.0.13
+  version: 0.0.14
 platform: ruby
 authors:
 - thetizzo
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-06 00:00:00.000000000 Z
+date: 2018-09-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: 1.16.5
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: 1.16.5
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -44,56 +44,56 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.4.1
+        version: 5.11.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.4.1
+        version: 5.11.3
 - !ruby/object:Gem::Dependency
   name: vcr
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.9.3
+        version: 4.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.9.3
+        version: 4.0.0
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.19.0
+        version: 3.4.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.19.0
+        version: 3.4.2
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.52.1
+        version: 0.59.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.52.1
+        version: 0.59.1
 - !ruby/object:Gem::Dependency
   name: typhoeus
   requirement: !ruby/object:Gem::Requirement
@@ -145,6 +145,7 @@ files:
 - lib/nfl_data/models/player.rb
 - lib/nfl_data/models/statline.rb
 - lib/nfl_data/models/team.rb
+- lib/nfl_data/parsers/data/teams.rb
 - lib/nfl_data/parsers/parser_helper.rb
 - lib/nfl_data/parsers/player_parser.rb
 - lib/nfl_data/parsers/statline_parser.rb
@@ -181,7 +182,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.7.3
 signing_key: 
 specification_version: 4
 summary: Parse NFL data like a boss