nfl_data 0.0.11 → 0.0.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fde80abd92b5afed0b3c16a9cd3d687387380bd5
-  data.tar.gz: f904cf0f9158c3996494aff4864f1ab3767daa59
+  metadata.gz: 8ddfd102d1e34fb5f67cf1cd9bfeff27db2e907f
+  data.tar.gz: fd0babfb2953f8f0d7e927e28655b71f49aa78ad
 SHA512:
-  metadata.gz: 6e7d173e1e01bdf293fda1ad9c5c495bb6d7a3f4d5ee0382a680e411241450aaf0c6c762aeb7334a48ec6f403de1e702ceeec7981d29b5478123f9dac38b415e
-  data.tar.gz: fd76a8e7240ae7b46e4c5b084c52138f11eb671de0ae7d8115d926a205e510636563d670e3291ec138e68688e1e594e134baeb729fc57c200944f1059528b365
+  metadata.gz: 8efd6056e6012919326f1f6ed1223b25d1b43fe916b25c452c396070a52a6dff5b9db928fef14d364ea3efc879d514fb946d427ba176d9649247d2c6ea2dd6b1
+  data.tar.gz: a4faa749be2a46f744e16e27da1eb67fb72ae0bfb52cd6de3e174de08c76b961fc71881d57d51ba9cfd3d13408c128878807198d04cef956a4d315f7f667a59b

data/lib/nfl_data/models/player.rb

@@ -2,7 +2,7 @@ module NflData
   class Player
     ATTRIBUTES = [
       :first_name, :last_name, :full_name, :position, :number,
-      :status, :team, :nfl_player_id, :picture_link
+      :status, :team, :nfl_player_id, :picture_link, :profile_link
     ]
 
     attr_accessor(*ATTRIBUTES)

data/lib/nfl_data/parsers/player_parser.rb

@@ -1,3 +1,5 @@
+require 'typhoeus'
+
 module NflData
   class PlayerParser
     include ParserHelper
@@ -40,6 +42,10 @@ module NflData
       end
 
       return_val.flatten.map(&:to_hash)
+
+      return_val = return_val.flatten
+      populate_picture_links(return_val)
+      return_val.map(&:to_hash)
     end
 
     def update_or_create_players(url)
@@ -70,15 +76,27 @@ module NflData
         first_name: names[0],
         last_name: names[1],
         full_name: names.join(' '),
-        picture_link: get_picture_link(nfl_player_id, names[0], names[1])
+        profile_link: get_profile_link(nfl_player_id, names[0], names[1])
       )
     end
 
-    def get_picture_link(nfl_player_id, first_name, last_name)
+    def get_profile_link(nfl_player_id, first_name, last_name)
       return nil if ENV['NFL_DATA_ENV'] == 'test'
-      url = "http://www.nfl.com/player/#{first_name.gsub(/\s/, '')}#{last_name.gsub(/\s/, '')}/#{nfl_player_id}/profile"
-      doc = open(url) { |f| Nokogiri(f) }
-      doc.search('div.player-photo img').first.attributes['src'].value
+      "http://www.nfl.com/player/#{first_name.gsub(/\s/, '')}#{last_name.gsub(/\s/, '')}/#{nfl_player_id}/profile"
+    end
+
+    def populate_picture_links(players)
+      hydra = Typhoeus::Hydra.hydra
+      players.each do |player|
+        request = Typhoeus::Request.new(player.profile_link, followlocation: true, accept_encoding: 'gzip')
+        request.on_complete do |response|
+          doc = Nokogiri::HTML(response.body)
+          img_element = doc.search('div.player-photo img').first
+          player.picture_link = img_element.attributes['src'].value unless img_element.nil?
+        end
+        hydra.queue(request)
+      end
+      hydra.run
     end
   end
 end

data/lib/nfl_data/version.rb

@@ -1,3 +1,3 @@
 module NflData
-  VERSION = '0.0.11'
+  VERSION = '0.0.12'
 end

data/nfl_data.gemspec

@@ -26,5 +26,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'webmock', '~> 1.19.0'
   spec.add_development_dependency 'rubocop', '~> 0.35.1'
 
+  spec.add_dependency 'typhoeus', '~> 1.3'
   spec.add_dependency 'nokogiri', '~> 1.6'
 end

data/test/nfl_data/models/player_test.rb

@@ -56,6 +56,7 @@ describe Player do
       @player.team = 'Broncos'
       @player.nfl_player_id = '123'
       @player.picture_link = 'google.com'
+      @player.profile_link = 'espn.com'
     end
 
     def valid_player_hash
@@ -68,7 +69,8 @@ describe Player do
         status: 'Retired',
         team: 'Broncos',
         nfl_player_id: '123',
-        picture_link: 'google.com'
+        picture_link: 'google.com',
+        profile_link: 'espn.com'
       }
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: nfl_data
 version: !ruby/object:Gem::Version
-  version: 0.0.11
+  version: 0.0.12
 platform: ruby
 authors:
 - thetizzo
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-05 00:00:00.000000000 Z
+date: 2017-09-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -94,6 +94,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.35.1
+- !ruby/object:Gem::Dependency
+  name: typhoeus
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.3'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.3'
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement