nexus 1.2.3 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3bebf90c036e91a7bf8f68ab2bf40e1ed2979ecd
-  data.tar.gz: 5c42f749fe16cf437c4c292da178d6c2d58ece12
+  metadata.gz: c390f45bd0c31e68df98712adf0b1fdde32c2fe8
+  data.tar.gz: 9dc8685041e8fcd7ae302321015676e45d3db73a
 SHA512:
-  metadata.gz: e64101606a5ea82066c58f3c526d4dd8ac6a8390a3a289e12c90454b8ebab665db7c42acedc4af484e198be90fdeacc07b9cda4218d3d245b55dd9282bbbaf1d
-  data.tar.gz: 0302bbdd6654fe2203ceff3ff3dba0e5085588fc66cc3a165d42cd0ea5229bd9414d322e840c4c16e4040a2fdff4b61dbedbd9c8284a69c7d4b4386843d60c38
+  metadata.gz: 6726114873b1ea9aa57c74bc9a4391ed8e5f077fe50ce21334f1cb35589712c23a1eb727940e3415d7a9aecb5a6dae44487f97fe4c35a7ab247e1f06856357a3
+  data.tar.gz: e768d7cec487c0176392bc4e4c537b759ee93fe0d744ccebaec92a9f570c96f0b846f3c4d82b7d6f7bead46b91d284b931309e0340f11701f7c7322bec4987bb

data/lib/commands/abstract_command.rb

@@ -23,6 +23,11 @@ class Gem::AbstractCommand < Gem::Command
                 "File location of nexus config to use.\n                                     default #{Nexus::Config.default_file}" ) do |value, options|
       options[ :nexus_config ] = File.expand_path( value )
     end
+
+    add_option( '--ignore-ssl-errors',
+                "No check certificate." ) do |value, options|
+      options[ :ssl_verify_mode ] = OpenSSL::SSL::VERIFY_NONE
+    end
   end
 
   def url
@@ -109,6 +114,8 @@ class Gem::AbstractCommand < Gem::Command
 
     if url.scheme == 'https'
       http.use_ssl = true
+      http.verify_mode =
+        options[ :ssl_verify_mode ] || config.ssl_verify_mode || OpenSSL::SSL::VERIFY_PEER
     end
     
     #Because sometimes our gems are huge and our people are on vpns

data/lib/commands/nexus.rb

@@ -9,7 +9,7 @@ class Gem::Commands::NexusCommand < Gem::AbstractCommand
   end
 
   def usage
-    "#{program_name} GEM"
+    "#{program_name} GEM [GEM [...]]"
   end
 
   def list_repos
@@ -55,17 +55,17 @@ class Gem::Commands::NexusCommand < Gem::AbstractCommand
                 'encrypt/decrypt the credentials with a master password.' ) do |value, options|
       options[ :nexus_encrypt ] = value
     end
-    
+
   end
 
   def execute
-    name = get_one_gem_name rescue nil
-    if( name && ( options[ :nexus_all_repos ] != nil ||
+    names = get_all_gem_names rescue nil
+    if( names && ( options[ :nexus_all_repos ] != nil ||
                   options[ :nexus_clear_all ] != nil ||
                   options[ :nexus_prompt_all ] != nil ||
                   options[ :nexus_encrypt ] != nil ||
                   options[ :nexus_secrets ] != nil ) )
-      warn "given gemfile #{name} get ignored due to the options used"
+      warn "given gemfile(s) #{names.join(' ')} get ignored due to the options used"
     end
 
     if options[ :nexus_all_repos ]
@@ -99,26 +99,32 @@ class Gem::Commands::NexusCommand < Gem::AbstractCommand
   end
 
   def send_gem
-    say "Uploading gem to Nexus..."
+    gems = get_all_gem_names
 
-    path = get_one_gem_name
+    say "Uploading #{gems.size} gem#{'s' if gems.size != 1} to Nexus..."
 
-    response = make_request(:put, "gems/#{File.basename(path)}") do |request|
-      request.body = Gem.read_binary(path)
-      request.add_field("Content-Length", request.body.size)
-      request.add_field("Content-Type", "application/octet-stream")
-      request.add_field("Authorization", authorization.strip) if authorization
-    end
+    gems.each do |path|
+      response = make_request(:put, "gems/#{File.basename(path)}") do |request|
+        request.body = Gem.read_binary(path)
+        request.add_field("Content-Length", request.body.size)
+        request.add_field("Content-Type", "application/octet-stream")
+        request.add_field("Authorization", authorization.strip) if authorization
+      end
 
-    case response.code
-    when "401"
-      say "Unauthorized"
-    when "400"
-      say "something went wrong - maybe (re)deployment is not allowed"
-    when "500"
-      say "something went wrong"
-    else
-      say response.message
+      case response.code
+      when "400"
+        say "something went wrong - maybe (re)deployment is not allowed"
+      when "401"
+        say "Unauthorized"
+      when "500"
+        say "something went wrong"
+      else
+        say "#{response.message} #{path.split(/\//).last}"
+      end
+
+      if !response.kind_of? Net::HTTPSuccess
+        exit 1
+      end
     end
   end
 end

data/lib/nexus/config.rb

@@ -190,6 +190,10 @@ module Nexus
       @conf.store
     end
 
+    def ssl_verify_mode
+      @conf[ :ssl_verify_mode, @repo ]
+    end
+
     def to_s
       config.file
     end

data/lib/nexus/version.rb

@@ -1,3 +1,3 @@
 module Nexus
-  VERSION = '1.2.3'.freeze
+  VERSION = '1.3.0'.freeze
 end

data/test/abstract_command_test.rb

@@ -222,5 +222,27 @@ class AbstractCommandTest < CommandTest
         assert_equal( @command.config.url, "http://url" )
       end
     end
+
+    context "SSL verification" do
+      setup do
+        @url = "https://url"
+        @connection = Net::HTTP.new("host", 443)
+        stub(@connection).request
+        stub(Net::HTTP).new { @connection }
+        @command.config.url = @url
+      end
+
+      should "disable SSL verification" do
+        stub(@command.config).ssl_verify_mode { OpenSSL::SSL::VERIFY_NONE }
+        stub(Gem.configuration).verbose { 0 }
+        @command.make_request(:put, "gems/gem")
+        assert_equal( @connection.verify_mode, OpenSSL::SSL::VERIFY_NONE )
+      end
+
+      should "verify SSL" do
+        @command.make_request(:put, "gems/gem")
+        assert_equal( @connection.verify_mode, OpenSSL::SSL::VERIFY_PEER )
+      end
+    end
   end
 end

data/test/nexus_command_test.rb

@@ -47,7 +47,7 @@ class NexusCommandTest < CommandTest
       @command.options[ :nexus_encrypt ] = true
       mock(@command).ask( "Enter your Nexus encryption credentials (no prompt)" ) { 'behappy' }
       @command.execute
-      assert_equal( File.read( @with + ".config" ), 
+      assert_equal( File.read( @with + ".config" ),
                     File.read( @from + ".config" ) )
       assert_equal( File.read( @with + ".secrets" ) != File.read( @from + ".secrets" ), true )
 
@@ -80,13 +80,13 @@ class NexusCommandTest < CommandTest
       config_path = File.join( 'pkg', 'encconfig_prompt')
       File.open( config_path, 'w') do |f|
         h = { :url => 'http://example.com',
-          :authorization => 'something', 
+          :authorization => 'something',
           :token => 'pe/ty1I5sl7qD5drdsSXOBi0peRYOqdhhvRXJBjzzNY=' }
         f.write h.to_yaml
       end
       stub(@command).options { {:nexus_config => config_path } }
       stub(@command).ask_for_password { "behappy" }
-      
+
       @command.setup
       assert_equal @command.config.encrypted?, true
     end
@@ -109,7 +109,7 @@ class NexusCommandTest < CommandTest
       @command.options[ :nexus_encrypt ] = false
       mock(@command).ask( "Enter your Nexus encryption credentials (no prompt)" ) { 'behappy' }
       @command.execute
-      assert_equal( File.read( @with + ".config" ), 
+      assert_equal( File.read( @with + ".config" ),
                     File.read( @from + ".config" ) )
       assert_equal( File.read( @with + ".secrets" ) != File.read( @from + ".secrets" ), true )
 
@@ -304,14 +304,13 @@ class NexusCommandTest < CommandTest
           obj
         end
         stub_request(:put, @url).to_return(:status => 201)
-        
         @command.send_gem
       end
 
       should "say push was successful" do
-        assert_received(@command) { |command| command.say("Uploading gem to Nexus...") }
+        assert_received(@command) { |command| command.say("Uploading 1 gem to Nexus...") }
         # due to webmock there is no status message
-        assert_received(@command) { |command| command.say("") }
+        assert_received(@command) { |command| command.say(" foo-0.0.0.gem") }
       end
 
       should "put to api" do
@@ -321,10 +320,46 @@ class NexusCommandTest < CommandTest
         assert_requested(:put, @url,
                          :body => @gem_binary,
                          :headers => {
-                           'Authorization' => 'key', 
+                           'Authorization' => 'key',
                            'Content-Type' => 'application/octet-stream'
                          })
       end
+
+      context "non-successful push" do
+        should "say something went wrong - maybe (re)deployment is not allowed when receiving a 400 reponse" do
+          stub_request(:put, @url).to_return(:status => 400)
+          begin
+            @command.send_gem
+          rescue SystemExit => e
+            @exit_code = e.status
+            msg = "something went wrong - maybe (re)deployment is not allowed"
+            assert_received(@command) { |command| command.say(msg) }
+            assert_equal 1, @exit_code
+          end
+        end
+
+        should "say unauthorized when receiving a 401 response" do
+          stub_request(:put, @url).to_return(:status => 401)
+          begin
+            @command.send_gem
+          rescue SystemExit => e
+            @exit_code = e.status
+            assert_received(@command) { |command| command.say("Unauthorized") }
+            assert_equal 1, @exit_code
+          end
+        end
+
+        should "say something went wrong when receiving a 500 response" do
+          stub_request(:put, @url).to_return(:status => 500)
+          begin
+            @exit_code = @command.send_gem
+          rescue SystemExit => e
+            @exit_code = e.status
+            assert_received(@command) { |command| command.say("something went wrong") }
+            assert_equal 1, @exit_code
+          end
+        end
+      end
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: nexus
 version: !ruby/object:Gem::Version
-  version: 1.2.3
+  version: 1.3.0
 platform: ruby
 authors:
 - Nick Quaranto
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-15 00:00:00.000000000 Z
+date: 2017-03-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -101,6 +101,20 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: '1.16'
+- !ruby/object:Gem::Dependency
+  name: addressable
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.4.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.4.0
 description: Adds a command to RubyGems for uploading gems to a nexus server.
 email:
 - nick@quaran.to
@@ -130,12 +144,24 @@ homepage: https://github.com/sonatype/nexus-gem
 licenses:
 - MIT-LICENSE
 metadata: {}
-post_install_message: "\n========================================================================\n\n
-  \          Thanks for installing Nexus gem! You can now run:\n\n    gem nexus          publish
-  your gems onto Nexus server\n\n    nbundle            a bundler fork with mirror
-  support. for bundler before 1.5.0\n                       \nadd a mirror with:\n\n
-  \   bundle config mirror.http://rubygems.org http://localhost:8081/nexus/content/repositories/rubygems.org\n\nfor
-  bundler before 1.5.0 use 'nbundle' instead of 'bundle' to use the mirror\n\n========================================================================\n\n"
+post_install_message: |2+
+
+  ========================================================================
+
+             Thanks for installing Nexus gem! You can now run:
+
+      gem nexus          publish your gems onto Nexus server
+
+      nbundle            a bundler fork with mirror support. for bundler before 1.5.0
+
+  add a mirror with:
+
+      bundle config mirror.http://rubygems.org http://localhost:8081/nexus/content/repositories/rubygems.org
+
+  for bundler before 1.5.0 use 'nbundle' instead of 'bundle' to use the mirror
+
+  ========================================================================
+
 rdoc_options: []
 require_paths:
 - lib