nexmo 0.2.1 → 0.2.2

data/lib/nexmo.rb

@@ -27,7 +27,7 @@ module Nexmo
       if status == 0
         Success.new(object['message-id'])
       else
-        Failure.new(Error.new(object['error-text']))
+        Failure.new(Error.new("#{object['error-text']} (status=#{status})"))
       end
     end
 

data/nexmo.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name = 'nexmo'
-  s.version = '0.2.1'
+  s.version = '0.2.2'
   s.platform = Gem::Platform::RUBY
   s.authors = ['Tim Craft']
   s.email = ['mail@timcraft.com']

data/spec/nexmo_spec.rb

@@ -8,27 +8,50 @@ describe Nexmo::Client do
     @client = Nexmo::Client.new('key', 'secret')
   end
 
-  it 'uses ssl by default' do
-    assert @client.http.use_ssl?
+  describe 'http method' do
+    it 'should return a Net::HTTP object that uses SSL' do
+      @client.http.must_be_instance_of(Net::HTTP)
+      @client.http.use_ssl?.must_equal(true)
+    end
   end
 
-  it 'allows access to headers' do
-    @client.headers.must_be_kind_of(Hash)
+  describe 'headers method' do
+    it 'should return a hash' do
+      @client.headers.must_be_kind_of(Hash)
+    end
   end
 
-  describe '#send_message' do
-    it 'makes the correct http call' do
+  describe 'send_message method' do
+    before do
+      @headers = {'Content-Type' => 'application/x-www-form-urlencoded'}
+    end
+
+    it 'should make the correct http call return a successful response if the first message status equals 0' do
       http_response = stub(:body => '{"messages":[{"status":0,"message-id":"id"}]}')
 
       data = 'from=ruby&to=number&text=Hey%21&username=key&password=secret'
 
-      headers = {'Content-Type' => 'application/x-www-form-urlencoded'}
-
-      @client.http.expects(:post).with('/sms/json', data, headers).returns(http_response)
+      @client.http.expects(:post).with('/sms/json', data, @headers).returns(http_response)
 
       response = @client.send_message({from: 'ruby', to: 'number', text: 'Hey!'})
 
-      assert response.success?
+      response.success?.must_equal(true)
+      response.failure?.must_equal(false)
+      response.message_id.must_equal('id')
+    end
+
+    it 'should return a failure response if the first message status does not equal 0' do
+      http_response = stub(:body => '{"messages":[{"status":2,"error-text":"Missing from param"}]}')
+
+      data = 'to=number&text=Hey%21&username=key&password=secret'
+
+      @client.http.expects(:post).with('/sms/json', data, @headers).returns(http_response)
+
+      response = @client.send_message({to: 'number', text: 'Hey!'})
+
+      response.success?.must_equal(false)
+      response.failure?.must_equal(true)
+      response.error.to_s.must_equal('Missing from param (status=2)')
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: nexmo
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-11-25 00:00:00.000000000Z
+date: 2012-01-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
-  requirement: &11028540 !ruby/object:Gem::Requirement
+  requirement: &3707430 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -21,10 +21,10 @@ dependencies:
         version: '1.5'
   type: :runtime
   prerelease: false
-  version_requirements: *11028540
+  version_requirements: *3707430
 - !ruby/object:Gem::Dependency
   name: mocha
-  requirement: &11027930 !ruby/object:Gem::Requirement
+  requirement: &3707100 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,7 +32,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *11027930
+  version_requirements: *3707100
 description: A simple wrapper for the Nexmo API
 email:
 - mail@timcraft.com