newsman 1.2.1 → 1.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 28993b9f11754759d159a42a76b5979bec9c12980098de771abd5442fc124ccd
-  data.tar.gz: 1e98570b8d3b0cb9b0694472e5fefa7fe780ce6434efa12cd231dfa86a31c885
+  metadata.gz: '0166813d55623364efd38ff1f3bc83ff3ae76ee9d793b1b5ac52924477122135'
+  data.tar.gz: 48d3c00284b0973851b95c2b144fe50972f801deeb826b400ab31e87102b7cfc
 SHA512:
-  metadata.gz: a807c540f352124e1a89d485cccfb2f0cf6ff36300b42d57ebb591b5e3e4b03d12413325f69a75d7f99e309c0813d336b1c3e32bb71012e22dd1093129cee5a6
-  data.tar.gz: 81a635a5caba68596e9c3acd7a242fbf597da0cb06ce87c2103cdab84c1e2e89ef59ec9812e997ff970a0484a16ace406415a83b8c642f6db8ff0f82e571c111
+  metadata.gz: 193cf28ea41b994cab278212cc255dcf0d1f7b78570e631f68e17003d489d505fd0e12a8b3244d576fa1e0826d992ead7af9c1febefd80074dc8260174294dae
+  data.tar.gz: 4e3a9c5920d471c3c5a1dcabe16692a6154ea50d44adaf775d263ce04186e814068391555d3e90682b043dbb2b3c4fb0372da2f8fa7e91abf331a594bfefe4e7

data/README.md

@@ -98,6 +98,25 @@ newsman --help
 ```
 And you should see a welcome message from newsman.
 
+## Releases
+
+Releases are handled by the [`release.yaml`](.github/workflows/release.yaml) GitHub Actions workflow. It runs whenever a tag matching `v*.*.*` (e.g. `v1.2.1`) is pushed, or manually via `workflow_dispatch`. On trigger it:
+
+1. Runs the test suite (`rake test`) and RuboCop (`rake rubocop`).
+2. Builds and installs the gem (`rake install`).
+3. Publishes the gem to [RubyGems.org](https://rubygems.org/gems/newsman) (`rake publish`), using the `RUBYGEMS_API_KEY` secret.
+4. Creates a GitHub Release for the pushed tag, using the `RELEASE_GITHUB_TOKEN` secret.
+
+### How to cut a release
+
+1. **Bump the version** in `newsman.gemspec` (`spec.version`) and commit it to `main`. RubyGems refuses to publish a version that's already live, so this step is mandatory - the workflow's `gem push` will silently fail otherwise (the publish step is `continue-on-error: true`, so the run can still show green even though nothing was actually published).
+2. **Tag the commit** with the same version, prefixed with `v`, and push the tag:
+   ```shell
+   git tag v1.2.1
+   git push origin v1.2.1
+   ```
+3. Watch the `Release Ruby Gem` workflow run in the Actions tab, and confirm the new version shows up on [RubyGems.org](https://rubygems.org/gems/newsman) and as a [GitHub Release](https://github.com/volodya-lombrozo/newsman/releases).
+
 ## Examples
 
 You can find examples of generated reports [here](https://volodya-lombrozo.github.io/newsman/)

data/lib/newsman/assistant.rb

@@ -112,32 +112,32 @@ class Assistant
     send(prompt)
   end
 
-  # rubocop:disable Metrics/MethodLength
+  # OpenAI's reasoning-family models (o1, o3, o4-mini, gpt-5, ...) only accept
+  # the default temperature (1) and reject any explicit value with a 400.
+  # Their "-chat" flavors (e.g. gpt-5-chat-latest) are non-reasoning and
+  # support a custom temperature just like gpt-4o, gpt-3.5-turbo, etc.
+  FIXED_TEMPERATURE_MODELS = /\A(o[1-9]|gpt-5)/
+
   def send(request)
+    parameters = { model: @model, messages: messages(request) }
+    parameters[:temperature] = @temperature unless fixed_temperature?
+    @client.chat(parameters: parameters).dig('choices', 0, 'message', 'content')
+  end
+
+  def fixed_temperature?
+    @model.match?(FIXED_TEMPERATURE_MODELS) && !@model.include?('chat')
+  end
+
+  SYSTEM_PROMPT = 'You are a developer tasked with composing a concise report detailing'\
+    ' your activities and progress for the previous week, intended for submission to your supervisor.'
+
+  def messages(request)
     if @model == 'o1-preview'
-      @client.chat(
-        parameters: {
-          model: @model,
-          messages: [{ role: 'user', content: request.to_s }]
-        }
-      ).dig('choices', 0, 'message', 'content')
+      [{ role: 'user', content: request.to_s }]
     else
-      @client.chat(
-        parameters: {
-          model: @model,
-          messages: [
-            { role: 'system', content: 'You are a developer tasked'\
-  ' with composing a concise report detailing your activities'\
-  ' and progress for the previous week,'\
-  ' intended for submission to your supervisor.' },
-            { role: 'user', content: request.to_s }
-          ],
-          temperature: @temperature
-        }
-      ).dig('choices', 0, 'message', 'content')
+      [{ role: 'system', content: SYSTEM_PROMPT }, { role: 'user', content: request.to_s }]
     end
   end
-  # rubocop:enable Metrics/MethodLength
 
   def deprecated(method)
     warn "Warning! '#{method}' is deprecated and will be removed in future versions."

data/test/test_assistant.rb

@@ -35,4 +35,31 @@ class TestAssistant < Minitest::Test
     assert_equal expected,
                  assistant.say_hello
   end
+
+  def test_fixed_temperature_for_reasoning_models
+    %w[o1 o1-preview o1-mini o3 o3-mini o4-mini gpt-5 gpt-5-mini gpt-5.6].each do |model|
+      assistant = Assistant.new('test-token', model: model)
+      assert(assistant.fixed_temperature?, "expected #{model} to have a fixed temperature")
+    end
+  end
+
+  def test_custom_temperature_for_chat_models
+    %w[gpt-3.5-turbo gpt-4o gpt-4.1 gpt-5-chat-latest].each do |model|
+      assistant = Assistant.new('test-token', model: model)
+      refute(assistant.fixed_temperature?, "expected #{model} to allow a custom temperature")
+    end
+  end
+
+  def test_o1_preview_skips_system_message
+    assistant = Assistant.new('test-token', model: 'o1-preview')
+    messages = assistant.messages('do something')
+    assert_equal([{ role: 'user', content: 'do something' }], messages)
+  end
+
+  def test_other_models_keep_system_message
+    assistant = Assistant.new('test-token', model: 'gpt-5.6')
+    messages = assistant.messages('do something')
+    assert_equal(2, messages.size)
+    assert_equal('system', messages.first[:role])
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: newsman
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 1.2.2
 platform: ruby
 authors:
 - Volodya Lombrozo