newrelic_rpm 10.9.0 → 10.9.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fbb51c8f4559d8bb50f88a7e3fcd47d63de49fbe5ec974e9c4ec48b277e28049
-  data.tar.gz: 129662fccdead351c98519c957172412b20a917e79350960875b53a5ff2d4dcd
+  metadata.gz: 76701fc98dcc89355b941dcf726ee2864d9a2badad1519d783d22e033532aa73
+  data.tar.gz: 7bfb863d02d054cac5e396b220b0d88aed86bc386f9fab2cb7ce4901f75aa4cf
 SHA512:
-  metadata.gz: 630af5f3ffd009f852384cae072cb42d6f0b293c5ca4b13d096d442bbc2f51ab52d12af348e72bdbccfee60549a45ad4e449e45c0ee401aabc8efb58342e61ad
-  data.tar.gz: 429d5e818a9ec3ece5838b30882fc9ae56dc717916ce423c1bde6e928f4bc672f3eaeb77f26ea608206c203f0db03bec52bc8d9b406822e4646ad0f807a781f3
+  metadata.gz: feec753d9d9e92e15a1fe7fa6903af4742aab5714bfc30c9a1100bc4278c614d9a62b0b57119930d9015deda23780ec264f6f5e775f846ea24f6f5f741119ffd
+  data.tar.gz: 85cfbf5ae32b4778a3ce743d030ba4995b1da13e9cc8ebaa4c7fe94204be2b3a8e84055ea52b5993e0501976c1a25657fd4626c4192d5bbc794a3e2c1af2473e

data/CHANGELOG.md

@@ -1,5 +1,19 @@
 # New Relic Ruby Agent Release Notes
 
+## v10.9.1
+
+- **Bugfix: Action Controller instrumentation no longer errors when it can't identify the controller class**
+
+  When the agent could not identify a request's controller class, it logged `TypeError: no implicit conversion of nil into String` and then `NoMethodError: undefined method 'finish' for nil`, and recorded no data for that request. These transactions are now named `Controller/(unknown)/<action>` and recorded normally. [PR#3691](https://github.com/newrelic/newrelic-ruby-agent/pull/3691)
+
+- **Bugfix: Prevent `Parallel` workers from hanging when reporting large payloads**
+
+  When `parallel` instrumentation was enabled, `Parallel.each`/`Parallel.map` with `in_processes:` could hang forever. Each worker inherited the pipe write ends the agent registered for its earlier siblings, so those pipes couldn't reach end-of-file, and the agent's pipe listener thread blocked waiting on one of them. Any worker whose data exceeded the operating system pipe buffer then blocked on exit. Now, the agent closes each pipe's write end in the parent right after forking, and the listener no longer blocks on a single pipe while others still have data waiting. Thank you to [@yayamochi](https://github.com/yayamochi) for reporting this bug. [Issue#3680](https://github.com/newrelic/newrelic-ruby-agent/issues/3680) [PR#3688](https://github.com/newrelic/newrelic-ruby-agent/pull/3688)
+
+- **Bugfix: gRPC calls no longer fail on requests from Synthetics monitors**
+
+  When a request from a Synthetics monitor made a gRPC call, the agent added `X-NewRelic-Synthetics` to the call's metadata. gRPC only allows lowercase metadata keys, so the call raised `ArgumentError: 'X-NewRelic-Synthetics' is an invalid header key`. The agent now sends the synthetics headers in lowercase. gRPC server transactions also now read the synthetics headers from incoming metadata, so a gRPC service called during a Synthetics check records its trace and Synthetics attributes. [PR#3693](https://github.com/newrelic/newrelic-ruby-agent/pull/3693)
+
 ## v10.9.0
 
 - **Feature: Continuous Profiling (preview)**

data/lib/new_relic/agent/instrumentation/action_controller_subscriber.rb

@@ -33,10 +33,10 @@ module NewRelic
               && !should_ignore(payload, controller_class(payload))
 
             if exception = exception_object(payload)
-              finishable.notice_error(exception)
+              finishable&.notice_error(exception)
             end
 
-            finishable.finish
+            finishable&.finish
           else
             Agent.instance.pop_trace_execution_flag
           end
@@ -75,6 +75,9 @@ module NewRelic
         def format_metric_name(metric_action, controller)
           controller_class = controller.is_a?(Class) ? controller : Object.const_get(controller)
           "Controller/#{controller_class.controller_path}/#{metric_action}"
+        rescue StandardError => e
+          NewRelic::Agent.logger.debug("#{e.class} : #{e.message} - Error encountered trying to identify Rails controller name")
+          "Controller/#{NewRelic::Agent::UNKNOWN_METRIC}/#{metric_action}"
         end
 
         def controller_class(payload)

data/lib/new_relic/agent/instrumentation/grpc/client/request_wrapper.rb

@@ -19,8 +19,9 @@ module NewRelic
               @host
             end
 
+            # gRPC raises ArgumentError on non-lowercase metadata keys.
             def []=(key, value)
-              @newrelic_metadata[key] = value
+              @newrelic_metadata[key.to_s.downcase] = value
             end
           end
         end

data/lib/new_relic/agent/instrumentation/grpc/server/instrumentation.rb

@@ -14,6 +14,9 @@ module NewRelic
           INSTRUMENTATION_NAME = 'gRPC_Server'
 
           DT_KEYS = [NewRelic::NEWRELIC_KEY, NewRelic::TRACEPARENT_KEY, NewRelic::TRACESTATE_KEY].freeze
+          SYNTHETICS_KEY = 'x-newrelic-synthetics'
+          SYNTHETICS_INFO_KEY = 'x-newrelic-synthetics-info'
+          NEWRELIC_KEYS = (DT_KEYS + [SYNTHETICS_KEY, SYNTHETICS_INFO_KEY]).freeze
           INSTANCE_VAR_HOST = :@host_nr
           INSTANCE_VAR_PORT = :@port_nr
           INSTANCE_VAR_METHOD = :@method_nr
@@ -33,6 +36,7 @@ module NewRelic
               trace_options)
             add_attributes(txn, metadata, streamer_type)
             process_distributed_tracing_headers(metadata)
+            process_synthetics_headers(metadata)
 
             begin
               yield
@@ -75,6 +79,14 @@ module NewRelic
             ::NewRelic::Agent::DistributedTracing::accept_distributed_trace_headers(metadata, 'Other')
           end
 
+          def process_synthetics_headers(metadata)
+            return unless metadata && !metadata.empty?
+
+            ::NewRelic::Agent.agent.monitors.synthetics_monitor.accept_headers(
+              metadata[SYNTHETICS_KEY], metadata[SYNTHETICS_INFO_KEY]
+            )
+          end
+
           def host_and_port_from_host_string(host_string)
             return unless host_string
 
@@ -101,7 +113,7 @@ module NewRelic
           end
 
           def grpc_headers(metadata)
-            metadata.reject { |k, v| DT_KEYS.include?(k) }
+            metadata.reject { |k, v| NEWRELIC_KEYS.include?(k) }
           end
 
           def grpc_params(metadata, streamer_type)

data/lib/new_relic/agent/instrumentation/parallel/chain.rb

@@ -22,9 +22,11 @@ module NewRelic::Agent::Instrumentation
               channel_id = Process.clock_gettime(Process::CLOCK_MONOTONIC, :nanosecond)
               NewRelic::Agent.register_report_channel(channel_id)
 
-              worker_without_newrelic(job_factory, options) do |*args|
+              worker = worker_without_newrelic(job_factory, options) do |*args|
                 worker_with_tracing(channel_id) { yield(*args) }
               end
+              close_report_channel_write_end(channel_id)
+              worker
             end
           end
         end

data/lib/new_relic/agent/instrumentation/parallel/instrumentation.rb

@@ -17,6 +17,12 @@ module NewRelic::Agent::Instrumentation
         yield
       end
 
+      # Runs in the parent right after the fork. Parallel forks every worker back-to-back,
+      # so waiting for the child's READY marker would let later siblings inherit this write end.
+      def close_report_channel_write_end(channel_id)
+        NewRelic::Agent::PipeChannelManager.channels[channel_id]&.after_fork_in_parent
+      end
+
       def setup_for_txn_metric_merge_at_exit
         # Clear out any existing transaction metrics to prevent duplicates
         # when merging metrics back in at the end of the forked process

data/lib/new_relic/agent/instrumentation/parallel/prepend.rb

@@ -17,9 +17,11 @@ module NewRelic::Agent::Instrumentation
         channel_id = Process.clock_gettime(Process::CLOCK_MONOTONIC, :nanosecond)
         NewRelic::Agent.register_report_channel(channel_id)
 
-        super do |*args|
+        worker = super do |*args|
           worker_with_tracing(channel_id) { yield(*args) }
         end
+        close_report_channel_write_end(channel_id)
+        worker
       end
     end
   end

data/lib/new_relic/agent/monitors/synthetics_monitor.rb

@@ -17,9 +17,11 @@ module NewRelic
       end
 
       def on_before_call(request) # THREAD_LOCAL_ACCESS
-        encoded_header = request[SYNTHETICS_HEADER_KEY]
-        info_header = request[SYNTHETICS_INFO_HEADER_KEY]
-        return unless encoded_header
+        accept_headers(request[SYNTHETICS_HEADER_KEY], request[SYNTHETICS_INFO_HEADER_KEY])
+      end
+
+      def accept_headers(encoded_header, info_header)
+        return unless encoded_header && (txn = Tracer.current_transaction)
 
         incoming_payload = deserialize_header(encoded_header, SYNTHETICS_HEADER_KEY)
 
@@ -28,11 +30,12 @@ module NewRelic
           SyntheticsMonitor.is_supported_version?(incoming_payload) &&
           SyntheticsMonitor.is_trusted?(incoming_payload)
 
-        txn = Tracer.current_transaction
         txn.raw_synthetics_header = encoded_header
         txn.raw_synthetics_info_header = info_header
         txn.synthetics_payload = incoming_payload
         txn.synthetics_info_payload = load_json(info_header, SYNTHETICS_INFO_HEADER_KEY)
+      rescue => e
+        NewRelic::Agent.logger.debug('Failure accepting synthetics headers', e)
       end
 
       def load_json(header, key)

data/lib/new_relic/agent/pipe_channel_manager.rb

@@ -237,6 +237,9 @@ module NewRelic
 
         def merge_data_from_pipe(pipe_handle)
           pipe = find_pipe_for_handle(pipe_handle)
+
+          return pipe.close if pipe.eof?
+
           raw_payload = pipe.read
           if raw_payload && !raw_payload.empty?
             if raw_payload == Pipe::READY_MARKER
@@ -249,8 +252,6 @@ module NewRelic
               end
             end
           end
-
-          pipe.close if pipe.eof?
         end
 
         def unmarshal(data)

data/lib/new_relic/version.rb

@@ -7,7 +7,7 @@ module NewRelic
   module VERSION # :nodoc:
     MAJOR = 10
     MINOR = 9
-    TINY = 0
+    TINY = 1
 
     STRING = "#{MAJOR}.#{MINOR}.#{TINY}"
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: newrelic_rpm
 version: !ruby/object:Gem::Version
-  version: 10.9.0
+  version: 10.9.1
 platform: ruby
 authors:
 - Tanna McClure