newrelic_postgres_plugin 0.1.10 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9963116cf3fcb09cc1a828c0ec7f42da61e06565
-  data.tar.gz: d6c729e2ff896425a3d9b71fe84af67a50913ef9
+  metadata.gz: 42e010eea7c25bffabade08f52c80b7d30d97c93
+  data.tar.gz: 7483bf38fad8a1843f1cd0e8b3e78f1b52e00eb7
 SHA512:
-  metadata.gz: 94d5fe44288f1606c4d26b06aa8ee4d46bde9f5643d28f80e9b67a2fb454e18ff38c9e8e9b070e8c3b7e64aa33a96a06d5632fb781e42f8b1680bff803fd712c
-  data.tar.gz: 39f0650e1cca644fef715560493a6d8d1e82ceded511c521cf04867426b685dd6e0e4be9fa31a47c6128590e60de10098bed580f886febe4b6d96e2ad73a5a67
+  metadata.gz: b2f5837b91fa26beae34557ecaf5e933d67daf122ce6591d64284c8dd1e51471dd66822b61afbc5c4071cf1d142a9999f923ae9c7c47473596453eb75d13812e
+  data.tar.gz: b9506081e2b0fdf1ec3e0a1ae5b19d4f52b383213197012514f55bc1517312d2dcd877cabf26db35231988bc487508fdbd5967bec8963b7cc68f6bc3fda5cec3

data/Gemfile.lock

@@ -1,21 +1,17 @@
 PATH
   remote: .
   specs:
-    newrelic_postgres_plugin (0.1.6)
-      newrelic_plugin (~> 1.0.2)
+    newrelic_postgres_plugin (0.1.10)
+      newrelic_plugin (~> 1.3)
       pg (>= 0.15.1)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    faraday (0.8.8)
-      multipart-post (~> 1.2.0)
-    json (1.8.0)
-    multipart-post (1.2.0)
-    newrelic_plugin (1.0.3)
-      faraday (>= 0.8.1)
+    json (1.8.1)
+    newrelic_plugin (1.3.1)
       json
-    pg (0.16.0)
+    pg (0.17.1)
 
 PLATFORMS
   ruby

data/README.md

@@ -5,8 +5,8 @@ A NewRelic Platform Postgres Plugin
 
 The New Relic Postgres Plugin enables integrated monitoring of your Postgres database in a custom NewRelic dashboard. Currently the following metrics are recorded:
 
-* Index size, hit rate, and count
-* Cache hit rate
+* Index size, miss rate, and count
+* Cache miss rate
 * Idle and active connection counts
 * BGWriter metrics
 * Tuple metrics
@@ -17,14 +17,14 @@ The New Relic Postgres Plugin enables integrated monitoring of your Postgres dat
 ### Proxy host
 
 You need a host to install the plugin on that is able to poll the desired Postgres database. That
-host also needs Ruby (tested with 2.0.0), and support for rubygems.
+host also needs Ruby (tested with 2.0.0), and support for rubygems. Heroku is a great choice for this. A fully deployable example app is provided.
 
+https://github.com/GoBoundless/heroku_postgres_monitor
 
 ### Postgres
 
 This plugin has been tested with with a few different Postgres version and should work with any version compatible with the pg gem.
 
-
 ## Installation and Running
 
 1. Install this gem from RubyGems:
@@ -37,7 +37,7 @@ This plugin has been tested with with a few different Postgres version and shoul
       ```pg_monitor install -l LICENSE_KEY```
 
    using the license key from your New Relic account.
-4. Edit the +config/newrelic_plugin.yml+ file generated in step 4.  Setup host/port/user/password/dbname for your postgres connection.
+4. Edit the `config/newrelic_plugin.yml` file generated in step 4. Setup host/port/user/password/dbname for your postgres connection.
 5. Execute
 
       ```pg_monitor run```
@@ -61,4 +61,4 @@ Please use Github issue for support. We will do our best to address issues in a
 
       ```bundle install```
 
-3. Run <b><tt>rake -T</tt></b> to see rake options, including tests.
+3. Run `rake -T` to see rake options, including tests.

data/lib/newrelic_postgres_plugin/agent.rb

@@ -76,7 +76,6 @@ module NewRelic::PostgresPlugin
       @previous_metrics[name] = value
     end
 
-
     def report_backend_metrics
       @connection.exec(backend_query) do |result|
         report_metric "Backends/Active", 'connections', result[0]['backends_active']
@@ -87,22 +86,23 @@ module NewRelic::PostgresPlugin
     def report_database_metrics
       @connection.exec(database_query) do |result|
         result.each do |row|
-          database_name = row['datname']
-          if database_name == dbname
-            report_metric         "Database/Backends",                        '', row['numbackends'].to_i
-            report_derived_metric "Database/Transactions/Committed",          '', row['xact_commit'].to_i
-            report_derived_metric "Database/Transactions/Rolled Back",        '', row['xact_rollback'].to_i
-            report_derived_metric "Database/Tuples/Read from Disk",           '', row['blks_read'].to_i
-            report_derived_metric "Database/Tuples/Read Cache Hit",           '', row['blks_hit'].to_i
-            report_derived_metric "Database/Tuples/Returned/From Sequential", '', row['tup_returned'].to_i
-            report_derived_metric "Database/Tuples/Returned/From Bitmap",     '', row['tup_fetched'].to_i
-            report_derived_metric "Database/Tuples/Writes/Inserts",           '', row['tup_inserted'].to_i
-            report_derived_metric "Database/Tuples/Writes/Updates",           '', row['tup_updated'].to_i
-            report_derived_metric "Database/Tuples/Writes/Deletes",           '', row['tup_deleted'].to_i
-            report_derived_metric "Database/Conflicts",                       '', row['conflicts'].to_i
-          end
+          report_metric         "Database/Backends",                        '', row['numbackends'].to_i
+          report_derived_metric "Database/Transactions/Committed",          '', row['xact_commit'].to_i
+          report_derived_metric "Database/Transactions/Rolled Back",        '', row['xact_rollback'].to_i
+          report_derived_metric "Database/Tuples/Returned/From Sequential", '', row['tup_returned'].to_i
+          report_derived_metric "Database/Tuples/Returned/From Bitmap",     '', row['tup_fetched'].to_i
+          report_derived_metric "Database/Tuples/Writes/Inserts",           '', row['tup_inserted'].to_i
+          report_derived_metric "Database/Tuples/Writes/Updates",           '', row['tup_updated'].to_i
+          report_derived_metric "Database/Tuples/Writes/Deletes",           '', row['tup_deleted'].to_i
+          report_derived_metric "Database/Conflicts",                       '', row['conflicts'].to_i
         end
       end
+      @connection.exec(index_count_query) do |result|
+        report_metric "Database/Indexes/Count", 'indexes', result[0]['indexes'].to_i
+      end
+      @connection.exec(index_size_query) do |result|
+        report_metric "Databases/Indexes/Size", 'bytes', result[0]['size'].to_i
+      end
     end
 
     def report_bgwriter_metrics
@@ -113,71 +113,83 @@ module NewRelic::PostgresPlugin
     end
 
     def report_index_metrics
-      @connection.exec(index_count_query) do |result|
-        report_metric "Indexes/Number of Indexes", 'indexes', result[0]['indexes'].to_i
-      end
-      @connection.exec(index_hit_rate_query) do |result|
-        report_metric "Indexes/Index Hit Rate", '%', result[0]['ratio'].to_f * 100.0
-        report_metric "Indexes/Cache Hit Rate", '%', result[1]['ratio'].to_f * 100.0
-      end
-      @connection.exec(index_size_query) do |result|
-        report_metric "Indexes/Size on Disk", 'bytes', result[0]['size'].to_i
-      end
+      report_metric "Indexes/Miss Ratio", '%', calculate_miss_ratio(%Q{SELECT SUM(idx_blks_hit) AS hits, SUM(idx_blks_read) AS reads FROM pg_statio_user_indexes})
     end
 
-    def backend_query
-      %Q(
-        SELECT ( SELECT count(*) FROM pg_stat_activity WHERE
-          #{
-            if nine_two?
-              "state <> 'idle'"
-            else
-              "current_query <> '<IDLE>'"
-            end
-          }
-        ) AS backends_active, ( SELECT count(*) FROM pg_stat_activity WHERE
-          #{
-            if nine_two?
-              "state = 'idle'"
-            else
-              "current_query = '<IDLE>'"
-            end
-          }
-        ) AS backends_idle FROM pg_stat_activity;
-      )
+    def report_cache_metrics
+      report_metric "Cache/Miss Ratio", '%', calculate_miss_ratio(%Q{SELECT SUM(heap_blks_hit) AS hits, SUM(heap_blks_read) AS reads FROM pg_statio_user_tables})
     end
 
-    def database_query
-      "SELECT * FROM pg_stat_database;"
-    end
+    private 
 
-    def bgwriter_query
-      "SELECT * FROM pg_stat_bgwriter;"
-    end
+      # This assumes the query returns a single row with two columns: hits and reads.
+      def calculate_miss_ratio(query)
+        sample = @connection.exec(query)[0]
+        sample.each { |k,v| sample[k] = v.to_i }
+        @previous_result_for_query ||= {}
+        miss_ratio = if check_samples(@previous_result_for_query[query], sample)
 
-    def index_count_query
-      "SELECT count(1) as indexes FROM pg_class WHERE relkind = 'i';"
-    end
+          hits = sample["hits"] - @previous_result_for_query[query]["hits"]
+          reads = sample["reads"] - @previous_result_for_query[query]["reads"]
+          
+          if (hits + reads) == 0
+            0.0
+          else
+            reads.to_f / (hits + reads) * 100.0
+          end
+        else
+          0.0
+        end
+      
+        @previous_result_for_query[query] = sample
+        return miss_ratio
+      end
+ 
+      # Check if we don't have a time dimension yet or metrics have decreased in value.
+      def check_samples(last, current)
+        return false if last.nil? # First sample?
+        return false unless current.find { |k,v| last[k] > v }.nil? # Values have gone down?
+        return true
+      end
 
-    def index_hit_rate_query
-      %Q(
-        SELECT
-          'index hit rate' AS name,
-          (sum(idx_blks_hit)) / sum(idx_blks_hit + idx_blks_read) AS ratio
-        FROM pg_statio_user_indexes
-        WHERE idx_blks_hit > 0
-        UNION ALL
-        SELECT
-         'cache hit rate' AS name,
-          sum(heap_blks_hit) / (sum(heap_blks_hit) + sum(heap_blks_read)) AS ratio
-        FROM pg_statio_user_tables
-        WHERE idx_blks_hit > 0;
-      )
-    end
+      def backend_query
+        %Q(
+          SELECT ( SELECT count(*) FROM pg_stat_activity WHERE
+            #{
+              if nine_two?
+                "state <> 'idle'"
+              else
+                "current_query <> '<IDLE>'"
+              end
+            }
+          ) AS backends_active, ( SELECT count(*) FROM pg_stat_activity WHERE
+            #{
+              if nine_two?
+                "state = 'idle'"
+              else
+                "current_query = '<IDLE>'"
+              end
+            }
+          ) AS backends_idle FROM pg_stat_activity;
+        )
+      end
 
-    def index_size_query
-      "SELECT sum(relpages::bigint*8192) AS size FROM pg_class WHERE reltype = 0;"
-    end
+      def database_query
+        "SELECT * FROM pg_stat_database WHERE datname='#{dbname}';"
+      end
+
+      def bgwriter_query
+        "SELECT * FROM pg_stat_bgwriter;"
+      end
+
+      def index_count_query
+        "SELECT count(1) as indexes FROM pg_class WHERE relkind = 'i';"
+      end
+
+      def index_size_query
+        "SELECT sum(relpages::bigint*8192) AS size FROM pg_class WHERE reltype = 0;"
+      end
 
   end
+
 end

data/lib/newrelic_postgres_plugin/version.rb

@@ -1,3 +1,3 @@
 module NewRelic::PostgresPlugin
-  VERSION = '0.1.10'
+  VERSION = '0.2.0'
 end

data/newrelic_postgres_plugin.gemspec

@@ -13,8 +13,8 @@ Gem::Specification.new do |s|
   ## If your rubyforge_project name is different, then edit it and comment out
   ## the sub! line in the Rakefile
   s.name              = 'newrelic_postgres_plugin'
-  s.version           = '0.1.10'
-  s.date              = '2014-01-31'
+  s.version           = '0.2.0'
+  s.date              = '2014-08-05'
   s.rubyforge_project = 'newrelic_postgres_plugin'
 
   ## Make sure your summary is short. The description may be as long

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: newrelic_postgres_plugin
 version: !ruby/object:Gem::Version
-  version: 0.1.10
+  version: 0.2.0
 platform: ruby
 authors:
 - Matt Hodgson
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-31 00:00:00.000000000 Z
+date: 2014-08-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: newrelic_plugin
@@ -86,7 +86,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: newrelic_postgres_plugin
-rubygems_version: 2.2.0
+rubygems_version: 2.4.1
 signing_key: 
 specification_version: 2
 summary: New Relic Postgres plugin