newrelic_f5_plugin 1.0.9 → 1.0.10

data/CHANGES

@@ -1,3 +1,12 @@
+* 1.0.10
+  - Add iRule statistics:
+    - Executions per second
+    - Failures per second
+    - Aborts per second
+    - Average cycles taken (requires timing to be enabled)
+  - Updated SNMP connection logic to skip devices that are unreachable
+  - Skip collecting metrics if we can not get list of names for them
+
 * 1.0.9
   - Add SNAT Pools statistics:
     - Current Connections

data/README.rdoc

@@ -27,6 +27,12 @@ Pool Statistics
 * Connections per Second
 * Inbound and Outbound Throughput
 
+iRule Statistics
+* Executions per Second
+* Failures per Second
+* Aborts per Second
+* Average cycles (requires timing enabled on the iRule)
+
 
 == Requirements
 
@@ -62,6 +68,12 @@ SNMP version 2c is supported.
 
       f5_monitor run
 
+== Installation with Chef/Puppet
+
+The F5 plugin can also be installed with {Chef}[http://www.getchef.com] and {Puppet}[http://puppetlabs.com]. For Chef and Puppet support see the New Relic plugin's {Chef Cookbook}[http://community.opscode.com/cookbooks/newrelic_plugins] and {Puppet Module}[https://forge.puppetlabs.com/newrelic/newrelic_plugins].
+
+Additional information on using Chef and Puppet with New Relic is available in New Relic's {documentation}[https://docs.newrelic.com/docs/plugins/plugin-installation-with-chef-and-puppet].
+
 == Developer Instructions
 
 1. Fork/Clone the repository

data/lib/newrelic_f5_plugin/agent.rb

@@ -4,7 +4,7 @@ require 'newrelic_plugin'
 require 'snmp'
 
 module NewRelic::F5Plugin
-  VERSION = '1.0.9'
+  VERSION = '1.0.10'
 
   # Register and run the agent
   def self.run
@@ -50,9 +50,27 @@ module NewRelic::F5Plugin
     # This is called on every polling cycle
     #
     def poll_cycle
+      NewRelic::PlatformLogger.debug("Starting poll cycle for '#{hostname}'")
+
       # SNMP Stuff here
       snmp = SNMP::Manager.new(:host => hostname, :port => port, :community => snmp_community)
 
+      #
+      # Test our SNMP connection, return if we fail to connect so the entire agent doesn't quit
+      #
+      begin
+        product_name = snmp.get_value(["1.3.6.1.4.1.3375.2.1.4.1.0"]).first
+        NewRelic::PlatformLogger.debug("Found F5 device of type: '#{product_name}'")
+      rescue SNMP::RequestTimeout
+        NewRelic::PlatformLogger.error("Unable to connect to device: '#{hostname}', skipping...")
+        snmp.close
+        return
+      rescue => e
+        NewRelic::PlatformLogger.error(e)
+        snmp.close
+        return
+      end
+
 
       #
       # Device wide metrics
@@ -108,43 +126,71 @@ module NewRelic::F5Plugin
       #
       NewRelic::PlatformLogger.debug("Collecting Virtual Server stats")
       vs = NewRelic::F5Plugin::Virtuals.new snmp
-      virtual_requests = vs.get_requests
-      virtual_requests.each_key { |m| report_counter_metric m, "req/sec", virtual_requests[m] } unless virtual_requests.nil?
 
-      virtual_conns_current = vs.get_conns_current
-      virtual_conns_current.each_key { |m| report_metric m, "conns", virtual_conns_current[m] } unless virtual_conns_current.nil?
+      if vs.get_names
+        virtual_requests = vs.get_requests
+        virtual_requests.each_key { |m| report_counter_metric m, "req/sec", virtual_requests[m] } unless virtual_requests.nil?
 
-      virtual_conns_total = vs.get_conns_total
-      virtual_conns_total.each_key { |m| report_counter_metric m, "conn/sec", virtual_conns_total[m] } unless virtual_conns_total.nil?
+        virtual_conns_current = vs.get_conns_current
+        virtual_conns_current.each_key { |m| report_metric m, "conns", virtual_conns_current[m] } unless virtual_conns_current.nil?
 
-      virtual_throughput_in = vs.get_throughput_in
-      virtual_throughput_in.each_key { |m| report_counter_metric m, "bits/sec", virtual_throughput_in[m] } unless virtual_throughput_in.nil?
+        virtual_conns_total = vs.get_conns_total
+        virtual_conns_total.each_key { |m| report_counter_metric m, "conn/sec", virtual_conns_total[m] } unless virtual_conns_total.nil?
 
-      virtual_throughput_out = vs.get_throughput_out
-      virtual_throughput_out.each_key { |m| report_counter_metric m, "bits/sec", virtual_throughput_out[m] } unless virtual_throughput_out.nil?
+        virtual_throughput_in = vs.get_throughput_in
+        virtual_throughput_in.each_key { |m| report_counter_metric m, "bits/sec", virtual_throughput_in[m] } unless virtual_throughput_in.nil?
 
-      virtual_cpu_usage_1m = vs.get_cpu_usage_1m
-      virtual_cpu_usage_1m.each_key { |m| report_metric m, "%", virtual_cpu_usage_1m[m] } unless virtual_cpu_usage_1m.nil?
+        virtual_throughput_out = vs.get_throughput_out
+        virtual_throughput_out.each_key { |m| report_counter_metric m, "bits/sec", virtual_throughput_out[m] } unless virtual_throughput_out.nil?
+
+        virtual_cpu_usage_1m = vs.get_cpu_usage_1m
+        virtual_cpu_usage_1m.each_key { |m| report_metric m, "%", virtual_cpu_usage_1m[m] } unless virtual_cpu_usage_1m.nil?
+      end
 
       #
       # Collect pool statistics
       #
       NewRelic::PlatformLogger.debug("Collecting Pool stats")
       pool = NewRelic::F5Plugin::Pools.new snmp
-      pool_requests = pool.get_requests
-      pool_requests.each_key { |m| report_counter_metric m, "req/sec", pool_requests[m] } unless pool_requests.nil?
 
-      pool_conns_current = pool.get_conns_current
-      pool_conns_current.each_key { |m| report_metric m, "conns", pool_conns_current[m] } unless pool_conns_current.nil?
+      if pool.get_names
+        pool_requests = pool.get_requests
+        pool_requests.each_key { |m| report_counter_metric m, "req/sec", pool_requests[m] } unless pool_requests.nil?
+
+        pool_conns_current = pool.get_conns_current
+        pool_conns_current.each_key { |m| report_metric m, "conns", pool_conns_current[m] } unless pool_conns_current.nil?
 
-      pool_conns_total = pool.get_conns_total
-      pool_conns_total.each_key { |m| report_counter_metric m, "conn/sec", pool_conns_total[m] } unless pool_conns_total.nil?
+        pool_conns_total = pool.get_conns_total
+        pool_conns_total.each_key { |m| report_counter_metric m, "conn/sec", pool_conns_total[m] } unless pool_conns_total.nil?
 
-      pool_throughput_in = pool.get_throughput_in
-      pool_throughput_in.each_key { |m| report_counter_metric m, "bits/sec", pool_throughput_in[m] } unless pool_throughput_in.nil?
+        pool_throughput_in = pool.get_throughput_in
+        pool_throughput_in.each_key { |m| report_counter_metric m, "bits/sec", pool_throughput_in[m] } unless pool_throughput_in.nil?
+
+        pool_throughput_out = pool.get_throughput_out
+        pool_throughput_out.each_key { |m| report_counter_metric m, "bits/sec", pool_throughput_out[m] } unless pool_throughput_out.nil?
+      end
+
+
+      #
+      # iRule statistics
+      #
+      NewRelic::PlatformLogger.debug("Collecting iRule stats")
+      rule = NewRelic::F5Plugin::Rules.new snmp
+
+      if rule.get_names
+        rule_execs = rule.get_executions
+        rule_execs.each_key { |m| report_counter_metric m, "execs/sec", rule_execs[m] } unless rule_execs.nil?
+
+        rule_failures = rule.get_failures
+        rule_failures.each_key { |m| report_counter_metric m, "failures/sec", rule_failures[m] } unless rule_failures.nil?
+
+        rule_aborts = rule.get_aborts
+        rule_aborts.each_key { |m| report_counter_metric m, "aborts/sec", rule_aborts[m] } unless rule_aborts.nil?
+
+        rule_cycles = rule.get_average_cycles
+        rule_cycles.each_key { |m| report_metric m, "cycles", rule_cycles[m] } unless rule_cycles.nil?
+      end
 
-      pool_throughput_out = pool.get_throughput_out
-      pool_throughput_out.each_key { |m| report_counter_metric m, "bits/sec", pool_throughput_out[m] } unless pool_throughput_out.nil?
 
       #
       # Collect snat pool statistics
@@ -152,26 +198,29 @@ module NewRelic::F5Plugin
       NewRelic::PlatformLogger.debug("Collecting SNAT Pool stats")
       snatpool = NewRelic::F5Plugin::SnatPools.new snmp
 
-      snatpool_conns_max = snatpool.get_conns_max
-      snatpool_conns_max.each_key { |m| report_metric m, "conns", snatpool_conns_max[m] } unless snatpool_conns_max.nil?
+      if snatpool.get_names
+        snatpool_conns_max = snatpool.get_conns_max
+        snatpool_conns_max.each_key { |m| report_metric m, "conns", snatpool_conns_max[m] } unless snatpool_conns_max.nil?
 
-      snatpool_conns_current = snatpool.get_conns_current
-      snatpool_conns_current.each_key { |m| report_metric m, "conns", snatpool_conns_current[m] } unless snatpool_conns_current.nil?
+        snatpool_conns_current = snatpool.get_conns_current
+        snatpool_conns_current.each_key { |m| report_metric m, "conns", snatpool_conns_current[m] } unless snatpool_conns_current.nil?
 
-      snatpool_conns_total = snatpool.get_conns_total
-      snatpool_conns_total.each_key { |m| report_counter_metric m, "conn/sec", snatpool_conns_total[m] } unless snatpool_conns_total.nil?
+        snatpool_conns_total = snatpool.get_conns_total
+        snatpool_conns_total.each_key { |m| report_counter_metric m, "conn/sec", snatpool_conns_total[m] } unless snatpool_conns_total.nil?
 
-      snatpool_throughput_in = snatpool.get_throughput_in
-      snatpool_throughput_in.each_key { |m| report_counter_metric m, "bits/sec", snatpool_throughput_in[m] } unless snatpool_throughput_in.nil?
+        snatpool_throughput_in = snatpool.get_throughput_in
+        snatpool_throughput_in.each_key { |m| report_counter_metric m, "bits/sec", snatpool_throughput_in[m] } unless snatpool_throughput_in.nil?
 
-      snatpool_throughput_out = snatpool.get_throughput_out
-      snatpool_throughput_out.each_key { |m| report_counter_metric m, "bits/sec", snatpool_throughput_out[m] } unless snatpool_throughput_out.nil?
+        snatpool_throughput_out = snatpool.get_throughput_out
+        snatpool_throughput_out.each_key { |m| report_counter_metric m, "bits/sec", snatpool_throughput_out[m] } unless snatpool_throughput_out.nil?
 
-      snatpool_packets_in = snatpool.get_packets_in
-      snatpool_packets_in.each_key { |m| report_counter_metric m, "pkts/sec", snatpool_packets_in[m] } unless snatpool_packets_in.nil?
+        snatpool_packets_in = snatpool.get_packets_in
+        snatpool_packets_in.each_key { |m| report_counter_metric m, "pkts/sec", snatpool_packets_in[m] } unless snatpool_packets_in.nil?
+
+        snatpool_packets_out = snatpool.get_packets_out
+        snatpool_packets_out.each_key { |m| report_counter_metric m, "pkts/sec", snatpool_packets_out[m] } unless snatpool_packets_out.nil?
+      end
 
-      snatpool_packets_out = snatpool.get_packets_out
-      snatpool_packets_out.each_key { |m| report_counter_metric m, "pkts/sec", snatpool_packets_out[m] } unless snatpool_packets_out.nil?
 
       #
       # Cleanup snmp connection

data/lib/newrelic_f5_plugin/rules.rb

@@ -0,0 +1,134 @@
+#!/usr/bin/env ruby
+
+require 'newrelic_plugin'
+require 'snmp'
+
+#LtmRuleEventStatEntry
+#  ltmRuleEventStatName                                   LongDisplayString,
+#  ltmRuleEventStatEventType                              LongDisplayString,
+#  ltmRuleEventStatPriority                               INTEGER,
+#  ltmRuleEventStatFailures                               Integer32,
+#  ltmRuleEventStatAborts                                 Integer32,
+#  ltmRuleEventStatTotalExecutions                        Integer32,
+#  ltmRuleEventStatAvgCycles                              Integer32,
+#  ltmRuleEventStatMaxCycles                              Integer32,
+#  ltmRuleEventStatMinCycles                              Integer32
+
+
+module NewRelic
+  module F5Plugin
+
+    class Rules
+      attr_accessor :rule_names, :snmp_manager
+
+      OID_LTM_RULES                 = "1.3.6.1.4.1.3375.2.2.8"
+      OID_LTM_RULE_STAT             = "#{OID_LTM_RULES}.3"
+      OID_LTM_RULE_ENTRY            = "#{OID_LTM_RULE_STAT}.3.1"
+      OID_LTM_RULE_STAT_NAME        = "#{OID_LTM_RULE_ENTRY}.1"
+      OID_LTM_RULE_STAT_TYPE        = "#{OID_LTM_RULE_ENTRY}.2"
+      OID_LTM_RULE_STAT_FAILURES    = "#{OID_LTM_RULE_ENTRY}.4"
+      OID_LTM_RULE_STAT_ABORTS      = "#{OID_LTM_RULE_ENTRY}.5"
+      OID_LTM_RULE_STAT_TOT_EXEC    = "#{OID_LTM_RULE_ENTRY}.6"
+      OID_LTM_RULE_STAT_AVG_CYCLES  = "#{OID_LTM_RULE_ENTRY}.7"
+
+
+
+      #
+      # Init
+      #
+      def initialize(snmp = nil)
+        @rule_names = [ ]
+
+        if snmp
+          @snmp_manager = snmp
+        else
+          @snmp_manager = nil
+        end
+      end
+
+
+
+      #
+      # Get the list of iRule names
+      #
+      def get_names(snmp = nil)
+        snmp = snmp_manager unless snmp
+
+        if snmp
+          @rule_names.clear
+
+          begin
+            snmp.walk([OID_LTM_RULE_STAT_NAME, OID_LTM_RULE_STAT_TYPE]) do |rule, func|
+              @rule_names.push("#{rule.value}/#{func.value}")
+            end
+          rescue Exception => e
+            NewRelic::PlatformLogger.error("Unable to gather iRule names with error: #{e}")
+          end
+
+          NewRelic::PlatformLogger.debug("Rules: Found #{@rule_names.size} iRules")
+          return @rule_names
+        end
+      end
+
+
+
+      #
+      # Gather Total iRule Executions
+      #
+      def get_executions(snmp = nil)
+        snmp = snmp_manager unless snmp
+
+        get_names(snmp) if @rule_names.empty?
+        res = gather_snmp_metrics_by_name("Rules/Executions", @rule_names, OID_LTM_RULE_STAT_TOT_EXEC, snmp)
+        NewRelic::PlatformLogger.debug("Rules: Got #{res.size}/#{@rule_names.size} Execution metrics")
+        return res
+      end
+
+
+
+      #
+      # Gather Total iRule Failures
+      #
+      def get_failures(snmp = nil)
+        snmp = snmp_manager unless snmp
+
+        get_names(snmp) if @rule_names.empty?
+        res = gather_snmp_metrics_by_name("Rules/Failures", @rule_names, OID_LTM_RULE_STAT_FAILURES, snmp)
+        NewRelic::PlatformLogger.debug("Rules: Got #{res.size}/#{@rule_names.size} Failure metrics")
+        return res
+      end
+
+
+
+      #
+      # Gather Total iRule Aborts
+      #
+      def get_aborts(snmp = nil)
+        snmp = snmp_manager unless snmp
+
+        get_names(snmp) if @rule_names.empty?
+        res = gather_snmp_metrics_by_name("Rules/Aborts", @rule_names, OID_LTM_RULE_STAT_ABORTS, snmp)
+        NewRelic::PlatformLogger.debug("Rules: Got #{res.size}/#{@rule_names.size} Abort metrics")
+        return res
+      end
+
+
+
+      #
+      # Gather Average iRule execution time (in cycles)
+      #
+      def get_average_cycles(snmp = nil)
+        snmp = snmp_manager unless snmp
+
+        get_names(snmp) if @rule_names.empty?
+        res = gather_snmp_metrics_by_name("Rules/Time", @rule_names, OID_LTM_RULE_STAT_AVG_CYCLES, snmp)
+        NewRelic::PlatformLogger.debug("Rules: Got #{res.size}/#{@rule_names.size} Abort metrics")
+        return res
+      end
+
+
+
+    end
+  end
+end
+

data/lib/newrelic_f5_plugin.rb

@@ -3,6 +3,7 @@ require 'newrelic_f5_plugin/util'
 require 'newrelic_f5_plugin/device'
 require 'newrelic_f5_plugin/nodes'
 require 'newrelic_f5_plugin/pools'
+require 'newrelic_f5_plugin/rules'
 require 'newrelic_f5_plugin/snatpools'
 require 'newrelic_f5_plugin/virtuals'
 require 'newrelic_f5_plugin/agent'

data/newrelic_f5_plugin.gemspec

@@ -13,8 +13,8 @@ Gem::Specification.new do |s|
   ## If your rubyforge_project name is different, then edit it and comment out
   ## the sub! line in the Rakefile
   s.name              = 'newrelic_f5_plugin'
-  s.version           = '1.0.9'
-  s.date              = '2014-01-21'
+  s.version           = '1.0.10'
+  s.date              = '2014-02-03'
   s.rubyforge_project = 'newrelic_f5_plugin'
 
   ## Make sure your summary is short. The description may be as long
@@ -78,6 +78,7 @@ to find out how to install and run the plugin agent.
     lib/newrelic_f5_plugin/device.rb
     lib/newrelic_f5_plugin/nodes.rb
     lib/newrelic_f5_plugin/pools.rb
+    lib/newrelic_f5_plugin/rules.rb
     lib/newrelic_f5_plugin/snatpools.rb
     lib/newrelic_f5_plugin/util.rb
     lib/newrelic_f5_plugin/virtuals.rb

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: newrelic_f5_plugin
 version: !ruby/object:Gem::Version
-  version: 1.0.9
+  version: 1.0.10
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-21 00:00:00.000000000 Z
+date: 2014-02-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: newrelic_plugin
@@ -69,6 +69,7 @@ files:
 - lib/newrelic_f5_plugin/device.rb
 - lib/newrelic_f5_plugin/nodes.rb
 - lib/newrelic_f5_plugin/pools.rb
+- lib/newrelic_f5_plugin/rules.rb
 - lib/newrelic_f5_plugin/snatpools.rb
 - lib/newrelic_f5_plugin/util.rb
 - lib/newrelic_f5_plugin/virtuals.rb