newrelic-rake 1.3.0 → 1.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 80dde3f9f464a121fec50bcde415c58d9d4d64af
-  data.tar.gz: 38bde0a314c6dd3a406c33bf37d71701410473c6
+  metadata.gz: ebb5539b5edae9941c21451a4cb61b1e85c56fa5
+  data.tar.gz: 9435c7f6ccb5253ac9816617c7c4cbb73ede3d45
 SHA512:
-  metadata.gz: 36764042bc4672e0cc277f0cbd0618fa540c45597489c15daa082fb76805a5b5df70b43a67c10094ca4d4fbb81100dc3d4bd05e0359cf80d0b26262d511e7681
-  data.tar.gz: c1be5503fa8559a2e121fb64128f53c87ddbae229efe30632d62b0d6d7e21fa6e3fc78d780ee674b066f27a16cbba2be7a1af456463a555cb3cd3e6bd4f4eb7e
+  metadata.gz: 00c6f01a62032c5f4e6c7f2f25ead03d3df9c4014f738e26c63029229b8462499c62b22b5bc1ab5763365f78ee5b9b0eb44713d23219cc112566dc994b1dc64f
+  data.tar.gz: 4831d28cd4d8b69dfbf12bb06594be715945d3644352adb75caf494d68144f693829d448a0569576fd538f30033d19be14f2f2cc09c26e9bbfbc31f362dda939

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Next Release
 
+## 1.3.1 (08/21/2013)
+
+* Ignore delay job rake task
+* Add document to use newrelic-rake without rails
+
 ## 1.3.0 (03/24/2013)
 
 * Add a NewRelic::Rake.started to promise starting newrelic agent only

data/README.md

@@ -18,7 +18,18 @@ Or install it yourself as:
 
 ## Usage
 
-nothing special to set.
+There is usually nothing to do for rake tasks in rails that depend on `:environment`,
+monitoring of these should just work.
+
+Rake files need to require `newrelic-rake` and start the newrelic agent
+before executing tasks to monitor:
+
+```
+require 'newrelic-rake'
+NewRelic::Agent.manual_start
+```
+
+These steps happen automatically in Rails' `:environment` task if you use `Bundler.require` in your `application.rb`.
 
 ## Authors and Contributors
 

data/lib/newrelic-rake/instrument.rb

@@ -17,12 +17,10 @@ DependencyDetection.defer do
 
       alias_method :origin_execute, :execute
       def execute(args=nil)
-        unless NewRelic::Rake.started?
-          NewRelic::Agent.manual_start(:dispatcher => :rake)
-          NewRelic::Rake.started = true
-        end
-        perform_action_with_newrelic_trace(:name => self.name, :category => "OtherTransaction/Rake") do
+        if ignore_metric_reporting?
           origin_execute(args)
+        else
+          execute_with_newrelic_trace(args)
         end
       end
 
@@ -30,6 +28,21 @@ DependencyDetection.defer do
       # https://newrelic.com/docs/ruby/monitoring-ruby-background-processes-and-daemons
       # even though Agent configuration is :send_data_on_exit => true
       at_exit { NewRelic::Agent.shutdown }
+
+      def execute_with_newrelic_trace(args)
+        unless ::NewRelic::Rake.started?
+          ::NewRelic::Agent.manual_start(:dispatcher => :rake)
+          ::NewRelic::Rake.started = true
+        end
+        perform_action_with_newrelic_trace(:name => self.name, :category => "OtherTransaction/Rake") do
+          origin_execute(args)
+        end
+      end
+
+      def ignore_metric_reporting?
+        self.name == 'jobs:work'
+      end
     end
   end
+
 end

data/lib/newrelic-rake/version.rb

@@ -1,5 +1,5 @@
 module Newrelic
   module Rake
-    VERSION = "1.3.0"
+    VERSION = "1.3.1"
   end
 end

data/test/newrelic_rake_test.rb

@@ -1,6 +1,6 @@
 require 'test/unit'
 require 'mocha/setup'
-require 'newrelic-rake/instrument'
+require 'newrelic-rake'
 
 class TestNewRelicRake < Test::Unit::TestCase
   include NewRelic::Agent::Instrumentation::ControllerInstrumentation
@@ -19,6 +19,12 @@ class TestNewRelicRake < Test::Unit::TestCase
     @sampler.clear_builder
   end
 
+  def test_ignore_delayed_job
+    Rake::Task.define_task('jobs:work')
+    Rake::Task['jobs:work'].invoke
+    assert !@engine.metrics.include?('OtherTransaction/Rake/Rake::Task/jobs:work'), 'jobs:work task is in metrics'
+  end
+
   def test_metrics
     Rake::Task.define_task('foo')
     Rake::Task['foo'].invoke

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: newrelic-rake
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.3.1
 platform: ruby
 authors:
 - Richard Huang
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-03-24 00:00:00.000000000 Z
+date: 2013-08-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: newrelic_rpm
@@ -62,10 +62,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.2
+rubygems_version: 2.0.6
 signing_key: 
 specification_version: 4
 summary: newrelic instrument for rake task.
 test_files:
 - test/newrelic_rake_test.rb
-has_rdoc: