newman 0.2.0 → 0.2.1

data/CHANGELOG.md

@@ -1,6 +1,13 @@
+### 0.2.1 (2012-02-11)
+
+- Fixed a bug with `Newman::Application#match`. It now normalizes keys to 
+  strings for easy use with `Newman::Application#compile_regex`, which
+  fixes our substitution logic in patterns.
+
 ### 0.2.0 (2012-02-08)
 
-- Internals mostly rewritten, changes too numerous to outline meaningfully. We'll keep better track of these changes in the future.
+- Internals mostly rewritten, changes too numerous to outline meaningfully. 
+  We'll keep better track of these changes in the future.
 
 - Basic logging support added.
 

data/lib/newman/application.rb

@@ -175,9 +175,13 @@ module Newman
     # only high-level mechanism for dynamic filter matches. Low level matching
     # is possible via `Newman::Application#callback`, but would
     # be an exercise in tedium for most application developers.
-
+    #
+    # NOTE: `Newman::Application#match` converts the provided `name` to a
+    # string using `to_s` to make life easier for the internals. Because
+    # `Newman::Application#matchers` is an implementation detail, you probably
+    # don't need to worry about this unless you're hacking on Newman itself.
     def match(name, pattern)
-      matchers[name] = pattern
+      matchers[name.to_s] = pattern
     end
 
     # ---

data/lib/newman/version.rb

@@ -5,7 +5,7 @@ module Newman
   module Version
     MAJOR  = 0
     MINOR  = 2
-    TINY   = 0
+    TINY   = 1
     STRING = "#{MAJOR}.#{MINOR}.#{TINY}"
   end
 end

data/test/integration/to_filter_test.rb

@@ -0,0 +1,28 @@
+require_relative "../helper"
+
+describe "subject filter" do
+  let(:app) do
+    Newman::Application.new do
+     match :list_id, /[^.]+/
+
+     to :tag, "{list_id}.subscribe" do
+        respond(:subject => "Subscribing you to [#{params[:list_id]}]")
+      end
+
+      default do
+        respond(:subject => "Didn't understand you!")
+      end
+    end
+  end
+
+  let(:server) { Newman.new_test_server(app) }
+  let(:mailer) { server.mailer }
+
+  it "should automatically not match emails without subjects" do
+    mailer.deliver_message(:to => "test+foo.subscribe@test.com")
+    server.tick
+
+    mailer.messages.first.subject.must_equal("Subscribing you to [foo]")
+  end
+end
+

data/test/suite.rb

@@ -4,3 +4,4 @@ SimpleCov.start
 require_relative "integration/acid_tests"
 require_relative "integration/skip_response_test"
 require_relative "integration/subject_filter_test"
+require_relative "integration/to_filter_test"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: newman
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-02-08 00:00:00.000000000 Z
+date: 2012-02-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mail
-  requirement: &2154675600 !ruby/object:Gem::Requirement
+  requirement: &2153405740 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -21,10 +21,10 @@ dependencies:
         version: 2.3.0
   type: :runtime
   prerelease: false
-  version_requirements: *2154675600
+  version_requirements: *2153405740
 - !ruby/object:Gem::Dependency
   name: tilt
-  requirement: &2154675020 !ruby/object:Gem::Requirement
+  requirement: &2153405240 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -32,10 +32,10 @@ dependencies:
         version: 1.3.3
   type: :runtime
   prerelease: false
-  version_requirements: *2154675020
+  version_requirements: *2153405240
 - !ruby/object:Gem::Dependency
   name: minitest
-  requirement: &2154674500 !ruby/object:Gem::Requirement
+  requirement: &2153404780 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -43,10 +43,10 @@ dependencies:
         version: 2.11.1
   type: :development
   prerelease: false
-  version_requirements: *2154674500
+  version_requirements: *2153404780
 - !ruby/object:Gem::Dependency
   name: simplecov
-  requirement: &2154674080 !ruby/object:Gem::Requirement
+  requirement: &2153404380 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2154674080
+  version_requirements: *2153404380
 - !ruby/object:Gem::Dependency
   name: purdytest
-  requirement: &2154673560 !ruby/object:Gem::Requirement
+  requirement: &2153403880 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,10 +65,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2154673560
+  version_requirements: *2153403880
 - !ruby/object:Gem::Dependency
   name: rocco
-  requirement: &2154673120 !ruby/object:Gem::Requirement
+  requirement: &2153403360 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,10 +76,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2154673120
+  version_requirements: *2153403360
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &2154672680 !ruby/object:Gem::Requirement
+  requirement: &2153402880 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -87,7 +87,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2154672680
+  version_requirements: *2153402880
 description: A microframework for mail-centric applications
 email:
 - gregory.t.brown@gmail.com
@@ -127,6 +127,7 @@ files:
 - test/integration/acid_tests.rb
 - test/integration/skip_response_test.rb
 - test/integration/subject_filter_test.rb
+- test/integration/to_filter_test.rb
 - test/settings.rb
 - test/suite.rb
 - README.md