newgistics 2.4.0 → 2.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b9c1f08cf89a001dd497f70997128e207d4fccc3
-  data.tar.gz: ffbf57d283b076a5fdfcd2b3859deb6e77260c48
+  metadata.gz: 501fd75a15918e4343b08c54703c624ed3321b26
+  data.tar.gz: 16007118503adb0b95b51d8591d159feefd77448
 SHA512:
-  metadata.gz: ef9f20d382e4e78ffecadf41c99fd618a4c23cf9976b2b08b34c7b87fd5f27da0dc7b21b9a908a75c5737a17ca09752a9254defeb2df7bf7e3c9d152fa394ae5
-  data.tar.gz: b79656c7ab47c26c4ddb5401f8e67d5bda8fca6ddf6a2780f48e69190b4ab6ca3641d0794128c61ecadf6db22348e79149f0ca3e3e024c0533d25f05e4bc91c5
+  metadata.gz: a5f51b558789523c672cd74c024d1d0097cc0b8fa74fdb915d3077f252729021ce5534b9ed29e77a79de1a513fcbeaf157393ee5d8e33d5a721fa4b3691f035d
+  data.tar.gz: b660bffc2914034cbaa7fb14260e0f36ecacb2e5b27bc7904ae0da56ce5c9c0b971d9b4c0e9dbbff9c006c7adaaceb6639f55214ae898b3071259c851fa47249

data/lib/newgistics/requests/update_shipment_address.rb

@@ -34,25 +34,30 @@ module Newgistics
 
       def shipment_address_update_xml(xml)
         xml.updateShipment(shipment_address_update_attributes) do
-          xml.FirstName shipment_address_update.first_name
-          xml.LastName shipment_address_update.last_name
-          xml.Company shipment_address_update.company
-          xml.Address1 shipment_address_update.address1
-          xml.Address2 shipment_address_update.address2
-          xml.City shipment_address_update.city
-          xml.State shipment_address_update.state
-          xml.PostalCode shipment_address_update.postal_code
-          xml.Country shipment_address_update.country
-          xml.Email shipment_address_update.email
-          xml.Phone shipment_address_update.phone
-          xml.Fax shipment_address_update.fax
-          xml.IsResidential shipment_address_update.is_residential
-          xml.Status shipment_address_update.status
-          xml.StatusNotes shipment_address_update.status_notes
-          xml.ShipMethod shipment_address_update.ship_method
+          xml_field(xml, 'FirstName', :first_name)
+          xml_field(xml, 'LastName', :last_name)
+          xml_field(xml, 'Company', :company)
+          xml_field(xml, 'Address1', :address1)
+          xml_field(xml, 'Address2', :address2)
+          xml_field(xml, 'City', :city)
+          xml_field(xml, 'State', :state)
+          xml_field(xml, 'PostalCode', :postal_code)
+          xml_field(xml, 'Country', :country)
+          xml_field(xml, 'Email', :email)
+          xml_field(xml, 'Phone', :phone)
+          xml_field(xml, 'Fax', :fax)
+          xml_field(xml, 'IsResidential', :is_residential)
+          xml_field(xml, 'Status', :status)
+          xml_field(xml, 'StatusNotes', :status_notes)
+          xml_field(xml, 'ShipMethod', :ship_method)
         end
       end
 
+      def xml_field(xml, xml_node, attribute_name)
+        value = shipment_address_update.send(attribute_name)
+        xml.send(xml_node, value) unless value.nil?
+      end
+
       def api_key
         Newgistics.configuration.api_key
       end

data/lib/newgistics/version.rb

@@ -1,3 +1,3 @@
 module Newgistics
-  VERSION = "2.4.0".freeze
+  VERSION = "2.4.1".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: newgistics
 version: !ruby/object:Gem::Version
-  version: 2.4.0
+  version: 2.4.1
 platform: ruby
 authors:
 - Manuel Martinez
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-05-29 00:00:00.000000000 Z
+date: 2019-06-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: virtus