neutral 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6aaf880268538c5e572b0635e0d6d1a0298fb058
-  data.tar.gz: df6a732d8a833ef2d02a3c59d8f71cf06bd38db5
+  metadata.gz: 28bba1188ad74ced81d86d0eb403f409096a47fa
+  data.tar.gz: c8f8894572d72f30ebfb941e8d94762d5779f5da
 SHA512:
-  metadata.gz: 136f7fcb7713b4a85a2b94787834b57a729f323e2422060c44e4a8b633d843e23e92a405ed66aa292637880d8f18d66818d052473f835f8dbd6a79b782cd38f7
-  data.tar.gz: 0c839982f3abccc87b357d2b41716e4f89e11d67c9a3dcd1f7aae6d1dcc7ed5a4d22c6a942265abda6ff1628eb23152e72cd7cebc5d4fc1862d57312bb0210fc
+  metadata.gz: fc745f228aad30bd887a3e4d821f2eae223165bb4186c3ed6bcd6c149976a954fe07dbe89f475abe3d253c058924352196c38761ec136fa13c7a239c68c62dfc
+  data.tar.gz: 317ec623838b2d8e8c15a7dcad67515667280e25b65ae7050fbbd57f3803f8a08c9ed674a544d2ab6896818e8ca1946ab0fca025f39bdbb4bea2706545f52b26

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    neutral (0.0.2)
+    neutral (0.0.3)
       font-awesome-rails (~> 4.0.3.1)
       jquery-rails
       rails (~> 4.0.0)

data/app/assets/stylesheets/neutral/index.css

@@ -29,11 +29,11 @@ div.neutral span {
   display: inline;  
 }
 
-div.neutral span#positive, div.neutral span.positive {
+div.neutral span.positive {
   color: green;
 }
 
-div.neutral span#negative, div.neutral span.negative {
+div.neutral span.negative {
   color: red;
 }
 

data/app/views/neutral/votes/create.js.erb

@@ -2,11 +2,11 @@ $(document).ready(function() {
 
   neutral = $("div.neutral").find("<%= by_url %>").parent();
 
-  neutral.find("span#positive").html("<%= voting.positive.nonzero? %>");
-  neutral.find("span#negative").html("<%= voting.negative.nonzero? %>");
-  neutral.find("span#difference").html("<%= voting.difference.nonzero?.try(:abs) %>");
+  neutral.find("span.positive").html("<%= voting.positive.nonzero? %>");
+  neutral.find("span.negative").html("<%= voting.negative.nonzero? %>");
+  neutral.find("span.difference").html("<%= voting.difference.nonzero?.try(:abs) %>");
 
-  neutral.find("span#difference").attr("class", "<%= voting.difference > 0 ? 'positive' : 'negative' %>");
+  neutral.find("span.difference").attr("class", "<%= "difference #{voting.difference > 0 ? 'positive' : 'negative'}" %>");
 
   <% if vote.voter_id && Neutral.config.can_change %>
 

data/app/views/neutral/votes/destroy.js.erb

@@ -7,11 +7,11 @@ $(document).ready(function() {
   neutral.find("a.positive").attr('href', '<%= votes_path(1) %>');
   neutral.find("a.negative").attr('href', '<%= votes_path(0) %>');
 
-  neutral.find("span#positive").html("<%= voting.positive.nonzero? %>");
-  neutral.find("span#negative").html("<%= voting.negative.nonzero? %>");
-  neutral.find("span#difference").html("<%= voting.difference.nonzero?.try(:abs) %>");
+  neutral.find("span.positive").html("<%= voting.positive.nonzero? %>");
+  neutral.find("span.negative").html("<%= voting.negative.nonzero? %>");
+  neutral.find("span.difference").html("<%= voting.difference.nonzero?.try(:abs) %>");
 
-  neutral.find("span#difference").attr("class", "<%= voting.difference > 0 ? 'positive' : 'negative' %>");
+  neutral.find("span.difference").attr("class", "<%= "difference #{voting.difference > 0 ? 'positive' : 'negative'}" %>");
 
   neutral.find("a.remove").remove();
 

data/app/views/neutral/votes/update.js.erb

@@ -2,10 +2,10 @@ $(document).ready(function() {
 
   neutral = $("div.neutral").find("<%= by_url %>").parent();
 
-  neutral.find("span#positive").html("<%= voting.positive.nonzero? %>");
-  neutral.find("span#negative").html("<%= voting.negative.nonzero? %>");
-  neutral.find("span#difference").html("<%= voting.difference.nonzero?.try(:abs) %>");
+  neutral.find("span.positive").html("<%= voting.positive.nonzero? %>");
+  neutral.find("span.negative").html("<%= voting.negative.nonzero? %>");
+  neutral.find("span.difference").html("<%= voting.difference.nonzero?.try(:abs) %>");
 
-  neutral.find("span#difference").attr("class", "<%= voting.difference > 0 ? 'positive' : 'negative' %>");
+  neutral.find("span.difference").attr("class", "<%= "difference #{voting.difference > 0 ? 'positive' : 'negative'}" %>");
 
 });

data/lib/neutral/version.rb

@@ -1,3 +1,3 @@
 module Neutral
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/lib/neutral/voting_builder/elements/span.rb

@@ -15,19 +15,19 @@ module Neutral
 
         class Positive < Span
           def to_s
-            content_tag :span, total, id: 'positive'
+            content_tag :span, total, class: 'positive'
           end
         end
 
         class Negative < Span
           def to_s
-            content_tag :span, total, id: 'negative'
+            content_tag :span, total, class: 'negative'
           end
         end
 
         class Difference < Span
           def to_s
-            content_tag :span, total.try(:abs), class: color, id: 'difference'
+            content_tag :span, total.try(:abs), class: "difference #{color}"
           end
 
           private

data/neutral.gemspec

@@ -15,8 +15,8 @@ Gem::Specification.new do |s|
   s.test_files = `git ls-files -- spec/**/*`.split("\n")
 
   s.add_dependency "rails", "~> 4.0.0"
-	s.add_dependency "font-awesome-rails", "~> 4.0.3.1"
-	s.add_dependency "jquery-rails"
+  s.add_dependency "font-awesome-rails", "~> 4.0.3.1"
+  s.add_dependency "jquery-rails"
 
   s.add_development_dependency "sqlite3"
   s.add_development_dependency "simplecov"

data/spec/voting_builder/builder_spec.rb

@@ -9,18 +9,16 @@ describe Neutral::VotingBuilder::Builder, type: :feature do
       subject { Neutral::VotingBuilder::Builder.new(voteable, {}).build }
 
       it { should have_selector "div.neutral" }
-      it { should have_selector "span#positive" }
+      it { should have_selector "span.positive" }
       it { should have_selector "a.positive" }
       it { should have_selector "a.negative" }
-      it { should have_selector "span#negative" }
+      it { should have_selector "span.negative" }
     end
 
     context "with difference" do
       subject { Neutral::VotingBuilder::Builder.new(voteable, difference: true).build }
 
-      it { should have_selector "span#difference" }
-      it { should_not have_selector "span#positive" }
-      it { should_not have_selector "span#negative" }
+      it { should have_selector "span.difference" }
     end
 
     describe "remove link" do

data/spec/voting_builder/elements/span_spec.rb

@@ -7,10 +7,11 @@ describe Span, type: :feature do
     describe span do
       describe "#to_s" do
         let(:total) { rand(100) + 1 }
+        let(:klass) { span.to_s.demodulize.downcase }
 
         subject { Capybara.string span.new(total).to_s }
 
-        it { should have_selector("span##{span.to_s.demodulize.downcase}") }
+        it { should have_selector("span.#{klass}") }
 
         it "has value of given total" do
           subject.find("span").text.should == total.to_s
@@ -24,20 +25,24 @@ describe Span, type: :feature do
   end
 
   describe Span::Difference do
+    def difference_element(total)
+      Capybara.string(Span::Difference.new(total).to_s).find("span")
+    end
+
     describe "#to_s" do
       let(:positive) { rand(100) + 1 }
       let(:negative) { -(rand(100) + 1) }
 
       it "has absolute value of total" do
-        Capybara.string(Span::Difference.new(negative).to_s).find("span").text.to_i.should > 0
+        difference_element(negative).text.to_i.should > 0
       end                       
 
       it "has 'positive' class when positive value of total is passed" do
-        Capybara.string(Span::Difference.new(positive).to_s).find("span")[:class].should == "positive"    
+        difference_element(positive)[:class].should include("positive")
       end
 
       it "has 'negative' class when negative value of total is passed" do
-        Capybara.string(Span::Difference.new(negative).to_s).find("span")[:class].should == "negative"    
+        difference_element(negative)[:class].should include("negative") 
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: neutral
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Peter Tóth