netzke-basepack 0.6.2 → 0.6.3

data/CHANGELOG.rdoc

@@ -1,3 +1,28 @@
+= v0.6.3 - 2011-01-14
+* compatibility with netzke-core 0.6.5
+
+* refactoring
+  * GridPanel code restructured, using the new +js_mixin+ method
+
+* bug fix
+  * GridPanel respects strong_default_attrs
+  * TabPanel doesn't fire multiple load requests per tab in case of lazy-loaded tabs and fast clicking
+  * Filtering/sorting on virtual columns is now disabled by default
+  * Filtering on date columns
+
+* enhancements
+  * I18n for Grid/FormPanel
+  * new +getter+ config option for columns/fields, a lambda receiving the record as parameter
+  * new +setter+ config option for columns/fields, a lambda receiving the record as first parameter, new value as the second
+  * GridPanel passes columns' default values to the "Add in form" form
+  * FormPanel can now be used without specifying a model
+  * New +commalistcbg+ form field for checkboxes, where boxLabels of selected checkboxes are serialized into comma-separated string (the separator is configurable)
+  * New +nradiogroup+ form field for radio buttons, where the value is defined by the boxLabel of the selected radio button
+  * New +no_binding+ option for configuring a form field. Set it to "true" when you don't want Netzke to expand the field configuration based on the +name+ property. May be needed in some cases, e.g. when using checkboxes/radio buttons in the form.
+  * New +nested_attribute+ option for configuring data attributes (thus applicable for a column, a field, or a +netzke_attribute+ in the model). When set to true for an association attribute (e.g. author__name), assigning a value to it will change the association's attribute, *not* trying to find an association by name and reassign it if found (default behavior).
+  * FormPanel shows the "Updating..." mask while sending values to the server (configurable with updateMask option/property)
+  * FormPanel now can be used in the "lockable" mode (:config => :lockable), which makes it load initially in "display mode", then "unlock" it, change the values, and "lock" it again (updating the values on the server)
+
 = v0.6.2 - 2010-11-05
 * compatibility with netzke-core 0.6.4
 * bug fix
@@ -7,7 +32,7 @@
 * enhancements
   * BorderLayoutPanel persistence: remembers region sizes and collapsed/expanded states
   * tooltips for grid buttons
-  
+
 * bug fix
   * auto-detection of association's method when the latter is virtual was broken in 1.9.2
 
@@ -321,4 +346,4 @@
 * Meta work: replacing underscore with dash in the name
 
 = v0.1.0 - 2008-12-20
-* Initial release
+* Initial release

data/TODO.rdoc

@@ -1,6 +1,5 @@
 == Priority
-* Fix :meta => true config in columns work
-* On grid refresh, reset the dirty fields, so that the "Apply" button doesn't do anything
+* Make GridPanel show the mask straight after pressing "Apply"
 * DataAccessor#to_array should not rescue exceptions, but rather check the availability of the attributes; `respond_to_with_basepack?` should be extended to also return true for association columns
 * GridPanel's read_only vs editable (doesn't work now) options
 * Find a way to print the grid nicely (along with the column and rows that don't fit on the screen)
@@ -10,6 +9,3 @@
 
 == Optimizations
 * Check persistent_config-related queries (aren't they too many?)
-
-== One day
-* Replace xcheckbox with checkbox in FormPanel

data/app/models/netzke_persistent_array_auto_model.rb

@@ -41,7 +41,6 @@ class NetzkePersistentArrayAutoModel < ActiveRecord::Base
     # only select those attributes that were provided to us as columns. The rest is ignored.
     column_names = config[:columns].map{ |c| c[:name] }
     clean_data = data.collect{ |c| c.reject{ |k,v| !column_names.include?(k.to_s) } }
-    Rails.logger.debug "!!! clean_data: #{clean_data.inspect}\n"
     self.delete_all
     self.create(clean_data)
   end

data/features/components_in_view.feature

@@ -0,0 +1,11 @@
+Feature: Components in view
+  In order to value
+  As a role
+  I want feature
+
+  @javascript
+  Scenario: Components configured in the view should render properly
+    When I go to the "simple panel" view
+    Then I should see "Simple Panel content"
+    When I press "Update html"
+    Then I should see "HTML received from server"

data/features/form_panel.feature

@@ -38,3 +38,52 @@ Scenario: UserFormWithDefaultFields should render properly
   And I should see "Castaneda"
   And I should see "writer"
 
+@javascript
+Scenario: FormPanel should be functional without model provided
+  Given I am on the FormWithoutModel test page
+  When I fill in "Text field:" with "Some text"
+  And I fill in "Number field:" with "42"
+  And I check "Boolean field:"
+  And I press "Apply"
+
+  Then I should see "Text field: Some text"
+  And I should see "Number field: 42"
+  And I should see "Boolean field: true"
+
+@javascript
+Scenario: Checkbox field should work properly
+  Given an author exists with first_name: "Carlos"
+  And a book exists with author: that author, digitized: false, exemplars: 2, title: "Some Title"
+  When I go to the BookForm test page
+  And I fill in "Exemplars:" with "4"
+  And I check "Digitized:"
+  And I press "Apply"
+  Then I should see "YES"
+  And a book should exist with digitized: true, author: that author, exemplars: 4
+  And a book should not exist with digitized: false, author: that author
+
+@javascript
+Scenario: Checkbox group for tags should work properly
+  Given a book exists with title: "Some Title"
+  When I go to the BookForm test page
+  And I check "recommend"
+  And I check "cool"
+  And I press "Apply"
+  Then the "cool" checkbox should be checked
+  And the "recommend" checkbox should be checked
+  But the "read" checkbox should not be checked
+  And a book should exist with tags: "cool,recommend"
+
+# Needs cleaner check whether AJAX request was completed
+# @javascript
+# Scenario: Validations
+#   Given a book exists with title: "Some Title"
+#   When I go to the BookForm test page
+#   And I fill in "Title:" with ""
+#   And I press "Apply"
+#   And I sleep 1 second
+#   Then I should see "Title can't be blank"
+#   When I fill in "Title:" with ""
+#   And I press "Apply"
+#   And I sleep 1 second
+#   Then I should not see "Title can't be blank"

data/features/grid_panel.feature

@@ -57,7 +57,8 @@ Scenario: Multi-editing records
   And I press "Edit in form"
   And I fill in "First name:" with "Maxim"
   And I press "OK"
-  Then the following users should exist:
+  Then I should see "Updated 2 records."
+  And the following users should exist:
   | first_name | last_name |
   | Maxim | Castaneda |
   | Maxim | Hesse |
@@ -71,4 +72,34 @@ Scenario: Filling out association column with association's virtual method
   Then I should see "Nabokov, Vladimir"
   And I should see "Lolita"
 
+@javascript
+Scenario: Grid with strong_default_attrs
+  Given an author exists with first_name: "Vladimir", last_name: "Nabokov"
+  And a book exists with title: "Lolita", author: that author
+  And a book exists with title: "Unknown"
+  When I go to the BooksBoundToAuthor test page
+  And I press "Add in form"
+  And I fill in "Title:" with "The Luzhin Defence"
+  And I press "OK"
+  And I should see "The Luzhin Defence"
+  And I should see "Lolita"
+  But I should not see "Unknown"
 
+@javascript
+Scenario: Grid with columns with default values
+  Given I am on the BookGridWithDefaultValues test page
+  When I press "Add in form"
+  And I press "OK"
+  And I sleep 1 second
+  Then a book should exist with title: "Lolita", exemplars: 100
+
+@javascript
+Scenario: Inline editing
+  Given a book exists with title: "Magus", exemplars: 100
+  When I go to the BookGrid test page
+  And I edit row 1 of the grid with title: "Collector", exemplars: 200
+  And I press "Apply"
+  And I sleep 1 second
+  Then the grid should have 0 modified records
+  And a book should exist with title: "Collector", exemplars: 200
+  But a book should not exist with title: "Magus"

data/features/i18n.feature

@@ -0,0 +1,18 @@
+Feature: I18n
+  In order to value
+  As a role
+  I want feature
+
+  Scenario: A grid with localized column headers
+    When I go to the "es" version of the BookGrid page
+    Then I should see "Autor"
+    And I should see "Creado en"
+    But I should not see "Author"
+    And I should not see "Created at"
+
+  Scenario: A form with localized field labels
+    When I go to the "es" version of the BookForm page
+    Then I should see "Autor"
+    And I should see "En abundancia"
+    But I should not see "Author"
+    And I should not see "In abundance"

data/features/nested_attributes.feature

@@ -0,0 +1,23 @@
+Feature: Nested attributes
+  In order to value
+  As a role
+  I want feature
+
+@javascript
+Scenario: Grid with nested attributes
+  Given an author exists with first_name: "Vlad", last_name: "Nabokoff"
+  And a book exists with title: "Lola", author: that author
+  When I go to the BookGridWithNestedAttributes test page
+  And I select first row in the grid
+  And I press "Edit in form"
+  And I fill in "Author first name:" with "Vladimir"
+  And I fill in "Author last name:" with "Nabokov"
+  And I fill in "Title:" with "Lolita"
+  And I press "OK"
+
+  Then I should see "Nabokov"
+  Then an author should exist with first_name: "Vladimir", last_name: "Nabokov"
+  And a book should exist with title: "Lolita", author: that author
+
+  But an author should not exist with first_name: "Vlad"
+  And a book should not exist with title: "Lola"

data/features/search_in_grid.feature

@@ -6,17 +6,17 @@ Feature: Search
   @javascript
   Scenario: Search via Search window
     Given the following roles exist:
-    | name |
-    | admin |
-    | superadmin |
-    | user |
+    | id | name       |
+    | 1  | admin      |
+    | 2  | superadmin |
+    | 3  | user       |
 
     And the following users exist:
-    | first_name | last_name | role__name |
-    | Paul | Bley | admin |
-    | Dalai | Lama | user |
-    | Taisha | Abelar | superadmin |
-    | Florinda | Donner | admin |
+    | first_name | last_name | role_id |
+    | Paul       | Bley      | 1       |
+    | Dalai      | Lama      | 3       |
+    | Taisha     | Abelar    | 2       |
+    | Florinda   | Donner    | 1       |
 
     When I go to the UserGrid test page
     Then the grid should show 4 records

data/features/simple_app.feature

@@ -0,0 +1,10 @@
+Feature: Basic application
+  In order to value
+  As a role
+  I want feature
+
+@javascript
+Scenario: SimpleApp should load its components dynamically
+  Given I am on the SomeSimpleApp test page
+  When I press "Simple accordion"
+  Then I should see "Some simple app simple accordion"

data/features/step_definitions/grid_panel_steps.rb

@@ -24,3 +24,26 @@ Then /^the grid should show (\d+) records$/ do |arg1|
     return grid.getStore().getCount();
   JS
 end
+
+When /^I edit row (\d+) of the grid with #{capture_fields}$/ do |rowIndex, fields|
+  fields = ActiveSupport::JSON.decode("{#{fields}}")
+  js_set_fields = fields.each_pair.map do |k,v|
+    "r.set('#{k}', '#{v}');"
+  end.join
+  page.driver.browser.execute_script <<-JS
+    var components = [];
+    for (var cmp in Netzke.page) { components.push(cmp); }
+    var grid = Netzke.page[components[0]];
+    var r = grid.getStore().getAt(#{rowIndex.to_i-1});
+    #{js_set_fields}
+  JS
+end
+
+Then /^the grid should have (\d+) modified records$/ do |n|
+  page.driver.browser.execute_script(<<-JS).should == n.to_i
+    var components = [];
+    for (var cmp in Netzke.page) { components.push(cmp); }
+    var grid = Netzke.page[components[0]];
+    return grid.getStore().getModifiedRecords().length;
+  JS
+end

data/features/support/paths.rb

@@ -40,9 +40,15 @@ module NavigationHelpers
     when /the component loader page/
       '/panel/component_loader'
 
+    when /the "(.*)" view/
+      embedded_components_path(:action => $1.gsub(" ", "_"))
+
     when /the (.*) test page/
       components_path(:component => $1)
 
+    when /the "(.+)" version of the (.*) page/
+      components_path(:component => $2, :locale => $1)
+
     else
       begin
         page_name =~ /the (.*) page/

data/features/support/pickle.rb

@@ -22,4 +22,3 @@ require 'pickle/world'
 #   config.adapters = [:machinist]
 #   config.map 'I', 'myself', 'me', 'my', :to => 'user: "me"'
 # end
-require 'pickle/path/world'

data/features/virtual_attributes.feature

@@ -0,0 +1,20 @@
+Feature: Window component loader
+  In order to value
+  As a role
+  I want feature
+
+  @javascript
+  Scenario: Columns and fields with custom setter/getter methods should work as expected
+    Given an author exists with first_name: "Victor"
+    And a book exists with title: "Lolita", exemplars: "5", author: that author
+    And I am on the BookGridWithVirtualAttributes test page
+    Then I should see "Victor"
+    And I should see "YES"
+
+    When I select first row in the grid
+    And I press "Edit in form"
+    And I fill in "Author first name" with "Vladimir"
+    And I fill in "Exemplars" with "3"
+    And I press "OK"
+    Then I should see "Vladimir"
+    And I should see "NO"

data/javascripts/basepack.js

@@ -1,4 +1,5 @@
 Ext.ns("Netzke.pre");
+Ext.ns("Netzke.pre.Basepack");
 Ext.ns("Ext.ux.grid");
 
 Ext.apply(Ext.History, new Ext.util.Observable());
@@ -38,12 +39,12 @@ Ext.netzke.ComboBox = Ext.extend(Ext.form.ComboBox, {
     });
 
     var parent = Ext.getCmp(this.parentId);
-		// Is parent a grid?
-		if (parent.getSelectionModel) {
-			this.on('beforequery',function(qe) {
-				delete qe.combo.lastQuery;
-			},this);
-		}
+    // Is parent a grid?
+    if (parent.getSelectionModel) {
+      this.on('beforequery',function(qe) {
+        delete qe.combo.lastQuery;
+      },this);
+    }
 
     // A not-so-clean approach to submit the current record id
     store.on('beforeload',function(store, options){
@@ -53,7 +54,7 @@ Ext.netzke.ComboBox = Ext.extend(Ext.form.ComboBox, {
       } else {
         // TODO: also for the FormPanel
       }
-    },this)
+    }, this);
   }
 });
 
@@ -63,65 +64,6 @@ Ext.util.Format.mask = function(v){
   return "********";
 };
 
-// Implementation of totalProperty, successProperty and root configuration options for ArrayReader
-Ext.data.ArrayReader = Ext.extend(Ext.data.JsonReader, {
-  readRecords : function(o){
-    var sid = this.meta ? this.meta.id : null;
-    var recordType = this.recordType, fields = recordType.prototype.fields;
-    var records = [];
-    var root = o[this.meta.root] || o, totalRecords = o[this.meta.totalProperty], success = o[this.meta.successProperty];
-    for(var i = 0; i < root.length; i++){
-      var n = root[i];
-      var values = {};
-      var id = ((sid || sid === 0) && n[sid] !== undefined && n[sid] !== "" ? n[sid] : null);
-      for(var j = 0, jlen = fields.length; j < jlen; j++){
-        var f = fields.items[j];
-        var k = f.mapping !== undefined && f.mapping !== null ? f.mapping : j;
-        var v = n[k] !== undefined ? n[k] : f.defaultValue;
-        v = f.convert(v, n);
-        values[f.name] = v;
-      }
-      var record = new recordType(values, id);
-      record.json = n;
-      records[records.length] = record;
-    }
-    return {
-      records : records,
-      totalRecords : totalRecords,
-      success : success
-    };
-  }
-});
-
-
-Ext.data.RecordArrayReader = Ext.extend(Ext.data.JsonReader, {
-  /**
-   * Create a data block containing Ext.data.Records from an Array.
-   * @param {Object} o An Array of row objects which represents the dataset.
-   * @return {Object} data A data block which is used by an Ext.data.Store object as
-   * a cache of Ext.data.Records.
-   */
-  readRecord : function(o){
-    var sid = this.meta ? this.meta.id : null;
-    var recordType = this.recordType, fields = recordType.prototype.fields;
-    var records = [];
-    var root = o;
-    var n = root;
-    var values = {};
-    var id = ((sid || sid === 0) && n[sid] !== undefined && n[sid] !== "" ? n[sid] : null);
-    for(var j = 0, jlen = fields.length; j < jlen; j++){
-      var f = fields.items[j];
-      var k = f.mapping !== undefined && f.mapping !== null ? f.mapping : j;
-      var v = n[k] !== undefined ? n[k] : f.defaultValue;
-      v = f.convert(v, n);
-      values[f.name] = v;
-    }
-    var record = new recordType(values, id);
-    record.json = n;
-    return record;
-  }
-});
-
 Ext.netzke.JsonField = Ext.extend(Ext.form.TextField, {
   validator: function(value) {
     try{
@@ -794,185 +736,166 @@ Ext.grid.HeaderDropZone.prototype.onNodeDrop = function(n, dd, e, data){
     return false;
 };
 
-// Temporary fix for Ext 3.1 resize problem:
-Ext.override(Ext.Panel, {
-
-   // private
-    onResize : function(w, h, rw, rh){
-        if(Ext.isDefined(w) || Ext.isDefined(h)){
-            if(!this.collapsed){
-                // First, set the the Panel's body width.
-                // If we have auto-widthed it, get the resulting full offset width so we can size the Toolbars to match
-                // The Toolbars must not buffer this resize operation because we need to know their heights.
-
-                if(Ext.isNumber(w)){
-                    this.body.setWidth(w = this.adjustBodyWidth(w - this.getFrameWidth()));
-                } else if (w == 'auto') {
-                    w = this.body.setWidth('auto').dom.offsetWidth;
-                } else {
-                    w = this.body.dom.offsetWidth;
-                }
+Ext.ns('Ext.ux.form');
+Ext.ux.form.TriCheckbox = Ext.extend(Ext.form.Checkbox, {
+  checked: null,
+  valueList: [null, false, true],
+  stateClassList: ['x-checkbox-undef', null, 'x-checkbox-checked'],
+  overClass: 'x-form-check-over',
+  clickClass: 'x-form-check-down',
+  triState: true,
+  defaultAutoCreate: {tag: 'input', type: 'hidden', autocomplete: 'off'},
+  initComponent: function() {
+    this.value = this.checked;
+    Ext.ux.form.TriCheckbox.superclass.initComponent.apply(this, arguments);
+    // make a copy before modifying valueList and stateClassList arrays
+    this.vList = this.valueList.slice(0);
+    this.cList = this.stateClassList.slice(0);
+    if(this.triState !== true) {
+      // consider 'undefined' value and its class go first in arrays
+      this.vList.shift();
+      this.cList.shift();
+    }
+    if(this.overCls !== undefined) {
+      this.overClass = this.overCls;
+      delete this.overCls;
+    }
+    this.value = this.normalizeValue(this.value);
+  },
+  onRender : function(ct, position){
+    Ext.form.Checkbox.superclass.onRender.call(this, ct, position);
+
+    this.innerWrap = this.el.wrap({tag: 'span', cls: 'x-form-check-innerwrap'});
+    this.wrap = this.innerWrap.wrap({cls: 'x-form-check-wrap'});
+
+    this.currCls = this.getCls(this.value);
+    this.wrap.addClass(this.currCls);
+    if(this.clickClass && !this.disabled && !this.readOnly)
+      this.innerWrap.addClassOnClick(this.clickClass);
+    if(this.overClass && !this.disabled && !this.readOnly)
+      this.innerWrap.addClassOnOver(this.overClass);
+
+    this.imageEl = this.innerWrap.createChild({
+      tag: 'img',
+      src: Ext.BLANK_IMAGE_URL,
+      cls: 'x-form-tscheckbox'
+    }, this.el);
+    if(this.fieldClass) this.imageEl.addClass(this.fieldClass);
+
+    if(this.boxLabel){
+      this.innerWrap.createChild({
+        tag: 'label',
+        htmlFor: this.el.id,
+        cls: 'x-form-cb-label',
+        html: this.boxLabel
+      });
+    }
 
-                if(this.tbar){
-                    this.tbar.setWidth(w);
-                    if(this.topToolbar){
-                        this.topToolbar.setSize(w);
-                    }
-                }
-                if(this.bbar){
-                    this.bbar.setWidth(w);
-                    if(this.bottomToolbar){
-                        this.bottomToolbar.setSize(w);
-                        // The bbar does not move on resize without this.
-                        if (Ext.isIE) {
-                            this.bbar.setStyle('position', 'static');
-                            this.bbar.setStyle('position', '');
-                        }
-                    }
-                }
-                if(this.footer){
-                    this.footer.setWidth(w);
-                    if(this.fbar){
-                        this.fbar.setSize(Ext.isIE ? (w - this.footer.getFrameWidth('lr')) : 'auto');
-                    }
-                }
+    // Need to repaint for IE, otherwise positioning is broken
+    if(Ext.isIE){
+      this.wrap.repaint();
+    }
+    this.resizeEl = this.positionEl = this.wrap;
+  },
+  onResize : function(){
+    Ext.form.Checkbox.superclass.onResize.apply(this, arguments);
+    if(!this.boxLabel && !this.fieldLabel && this.imageEl){
+      this.imageEl.alignTo(this.wrap, 'c-c');
+    }
+  },
+  initEvents : function(){
+    Ext.form.Checkbox.superclass.initEvents.call(this);
+    this.mon(this.innerWrap, {
+      scope: this,
+      click: this.onClick
+    });
+  },
+  onClick : function(){
+    if (!this.disabled && !this.readOnly) {
+      this.setValue(this.vList[(this.vList.indexOf(this.value) + 1) % this.vList.length]);
+    }
+  },
+  getValue : function(){
+    return this.value;
+  },
+  setValue : function(v){
+    var value = this.value;
+    this.value = this.normalizeValue(v);
+    if(this.rendered) this.el.dom.value = this.value;
+
+    if(value !== this.value){
+      this.updateView();
+      this.fireEvent('check', this, this.value);
+      if(this.handler) this.handler.call(this.scope || this, this, this.value);
+    }
+    return this;
+  },
+  normalizeValue: function(v) {
+    return (v === null || v === undefined) && this.triState ? null :
+      (v === true || (['true', 'yes', 'on', '1']).indexOf(String(v).toLowerCase()) != -1);
+  },
+  getCls: function(v) {
+    var idx = this.vList.indexOf(this.value);
+    return idx > -1 ? this.cList[idx] : undefined;
+  },
+  updateView: function() {
+    var cls = this.getCls(this.value);
+    if (!this.wrap || cls === undefined) return;
+
+    this.wrap.replaceClass(this.currCls, cls);
+    this.currCls = cls;
+  }
+});
+Ext.reg('tricheckbox', Ext.ux.form.TriCheckbox);
 
-                // At this point, the Toolbars must be layed out for getFrameHeight to find a result.
-                if(Ext.isNumber(h)){
-                    h = Math.max(0, this.adjustBodyHeight(h - this.getFrameHeight()));
-                    this.body.setHeight(h);
-                }else if(h == 'auto'){
-                    this.body.setHeight(h);
-                }
 
-                if(this.disabled && this.el._mask){
-                    this.el._mask.setSize(this.el.dom.clientWidth, this.el.getHeight());
-                }
-            }else{
-                this.queuedBodySize = {width: w, height: h};
-                if(!this.queuedExpand && this.allowQueuedExpand !== false){
-                    this.queuedExpand = true;
-                    this.on('expand', function(){
-                        delete this.queuedExpand;
-                        this.onResize(this.queuedBodySize.width, this.queuedBodySize.height);
-                    }, this, {single:true});
-                }
-            }
-            this.onBodyResize(w, h);
+// Enabling checkbox submission when unchecked
+(function() {
+  origCheckboxRender = Ext.form.Checkbox.prototype.onRender;
+  origCheckboxSetValue = Ext.form.Checkbox.prototype.setValue;
+
+  Ext.override(Ext.form.Checkbox, {
+    onRender: function() {
+      // call the original onRender() function
+      origCheckboxRender.apply(this, arguments);
+
+      if (this.getXType() === 'radio') return;
+
+      // Handle initial case based on this.checked
+      if (this.checked == false) {
+        this.noValEl = Ext.DomHelper.insertAfter(this.el, {
+            tag: 'input',
+            type: 'hidden',
+            value: false,
+            name: this.getName()
+        }, true);
+      }
+      else {
+        this.noValEl = null;
+      }
+    },
+    setValue: function() {
+      // call original setValue() function
+      origCheckboxSetValue.apply(this, arguments);
+
+      if (this.getXType() === 'radio') return;
+
+      if (this.checked) {
+        if (this.noValEl != null) {
+          // Remove the extra hidden element
+          this.noValEl.remove();
+          this.noValEl = null;
         }
-        this.syncShadow();
-        Ext.Panel.superclass.onResize.call(this, w, h, rw, rh);
+      }
+      else {
+        // Add our hidden element for (unchecked) value
+        if (this.noValEl == null) this.noValEl = Ext.DomHelper.insertAfter(this.el, {
+            tag: 'input',
+            type: 'hidden',
+            value: false,
+            name: this.getName()
+        }, true);
+      }
     }
-});
-
-Ext.ns('Ext.ux.form');
-Ext.ux.form.TriCheckbox = Ext.extend(Ext.form.Checkbox, {
-	checked: null,
-	valueList: [null, false, true],
-	stateClassList: ['x-checkbox-undef', null, 'x-checkbox-checked'],
-	overClass: 'x-form-check-over',
-	clickClass: 'x-form-check-down',
-	triState: true,
-	defaultAutoCreate: {tag: 'input', type: 'hidden', autocomplete: 'off'},
-	initComponent: function() {
-		this.value = this.checked;
-		Ext.ux.form.TriCheckbox.superclass.initComponent.apply(this, arguments);
-		// make a copy before modifying valueList and stateClassList arrays
-		this.vList = this.valueList.slice(0);
-		this.cList = this.stateClassList.slice(0);
-		if(this.triState !== true) {
-			// consider 'undefined' value and its class go first in arrays
-			this.vList.shift();
-			this.cList.shift();
-		}
-		if(this.overCls !== undefined) {
-			this.overClass = this.overCls;
-			delete this.overCls;
-		}
-		this.value = this.normalizeValue(this.value);
-	},
-	onRender : function(ct, position){
-		Ext.form.Checkbox.superclass.onRender.call(this, ct, position);
-
-		this.innerWrap = this.el.wrap({tag: 'span', cls: 'x-form-check-innerwrap'});
-		this.wrap = this.innerWrap.wrap({cls: 'x-form-check-wrap'});
-
-		this.currCls = this.getCls(this.value);
-		this.wrap.addClass(this.currCls);
-		if(this.clickClass && !this.disabled && !this.readOnly)
-			this.innerWrap.addClassOnClick(this.clickClass);
-		if(this.overClass && !this.disabled && !this.readOnly)
-			this.innerWrap.addClassOnOver(this.overClass);
-
-		this.imageEl = this.innerWrap.createChild({
-			tag: 'img',
-			src: Ext.BLANK_IMAGE_URL,
-			cls: 'x-form-tscheckbox'
-		}, this.el);
-		if(this.fieldClass) this.imageEl.addClass(this.fieldClass);
-
-		if(this.boxLabel){
-			this.innerWrap.createChild({
-				tag: 'label',
-				htmlFor: this.el.id,
-				cls: 'x-form-cb-label',
-				html: this.boxLabel
-			});
-		}
-
-		// Need to repaint for IE, otherwise positioning is broken
-		if(Ext.isIE){
-			this.wrap.repaint();
-		}
-		this.resizeEl = this.positionEl = this.wrap;
-	},
-	onResize : function(){
-		Ext.form.Checkbox.superclass.onResize.apply(this, arguments);
-		if(!this.boxLabel && !this.fieldLabel && this.imageEl){
-			this.imageEl.alignTo(this.wrap, 'c-c');
-		}
-	},
-	initEvents : function(){
-		Ext.form.Checkbox.superclass.initEvents.call(this);
-		this.mon(this.innerWrap, {
-			scope: this,
-			click: this.onClick
-		});
-	},
-	onClick : function(){
-		if (!this.disabled && !this.readOnly) {
-			this.setValue(this.vList[(this.vList.indexOf(this.value) + 1) % this.vList.length]);
-		}
-	},
-	getValue : function(){
-		return this.value;
-	},
-	setValue : function(v){
-		var value = this.value;
-		this.value = this.normalizeValue(v);
-		if(this.rendered) this.el.dom.value = this.value;
-
-		if(value !== this.value){
-			this.updateView();
-			this.fireEvent('check', this, this.value);
-			if(this.handler) this.handler.call(this.scope || this, this, this.value);
-		}
-		return this;
-	},
-	normalizeValue: function(v) {
-		return (v === null || v === undefined) && this.triState ? null :
-			(v === true || (['true', 'yes', 'on', '1']).indexOf(String(v).toLowerCase()) != -1);
-	},
-	getCls: function(v) {
-		var idx = this.vList.indexOf(this.value);
-		return idx > -1 ? this.cList[idx] : undefined;
-	},
-	updateView: function() {
-		var cls = this.getCls(this.value);
-		if (!this.wrap || cls === undefined) return;
-
-		this.wrap.replaceClass(this.currCls, cls);
-		this.currCls = cls;
-	}
-});
-Ext.reg('tricheckbox', Ext.ux.form.TriCheckbox);
+  });
+})();