network_resiliency 0.8.1 → 0.8.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 251e42c1b03eaa4cb6322a74da1f2b62ee0f08bc48112bd3c5858d1a9c888992
-  data.tar.gz: 87fbd7883d8c3d1ae55287253c88a9f3375b3b8225e44e53ca9443cd27acde46
+  metadata.gz: 0aa3bd17753ae7b79982ef78ec1789f8f83ccbd540165b5600a8d68a521ced06
+  data.tar.gz: c7305e3f42e0229bf63ebc228def5ad136d07539050ea1cf6de21203e5d1656c
 SHA512:
-  metadata.gz: 73a6fe0b5c7c3a97b9d8780c8bed84a8c4b18709dd569d11e13d3aa73a9356a86f0876d40b98e0a544bd8e2866c56062d2351035403e88a84e0ada602d6e2db1
-  data.tar.gz: b7b7229f80aed636d7ac8fda9fe19a8ed415918f323822f0e42ee2c9be23b1594598005b23afaf87c1757745483ac5a9b20063773a99fd5471e7180b15e4481b
+  metadata.gz: b6202ad464c14c7632f2bc8b2220a1964a9065deeb0cf6a948bfdbe8e910449bb9f41a26101fa2b35df0a2282f0377a5886d7ca90c260fe98333ebe81b2217c6
+  data.tar.gz: 7aac06c18cb3a2301a7e47f1deae8da37cdbe9c1e975af15c501c150023319cf16225f62b2aae9646222f32a104720fd45a0544d82f9057bcf2f699a3dab19ff

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+###  v0.8.2  (2024-03-13)
+- revert ddog sampling
+- Revert "lower secondary timeout"
+
 ###  v0.8.1  (2024-03-12)
 - lower secondary timeout
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    network_resiliency (0.8.1)
+    network_resiliency (0.8.2)
 
 GEM
   remote: https://rubygems.org/

data/lib/network_resiliency/stats_engine.rb

@@ -65,13 +65,11 @@ module NetworkResiliency
           empty: data.empty?,
           truncated: data.size < dirty_keys.size,
         }.select { |_, v| v },
-        sample_rate: SAMPLE_RATE[:sync],
       )
 
       NetworkResiliency.statsd&.distribution(
         "network_resiliency.sync.keys.dirty",
         dirty_keys.select { |_, n| n > 0 }.count,
-        sample_rate: SAMPLE_RATE[:sync],
       )
 
       return [] if data.empty?

data/lib/network_resiliency/version.rb

@@ -1,3 +1,3 @@
 module NetworkResiliency
-  VERSION = "0.8.1"
+  VERSION = "0.8.2"
 end

data/lib/network_resiliency.rb

@@ -22,11 +22,6 @@ module NetworkResiliency
   DEFAULT_TIMEOUT_MIN = 10 # ms
   MODE = [ :observe, :resilient ].freeze
   RESILIENCY_THRESHOLD = 100
-  SAMPLE_RATE = {
-    timeout: 0.1,
-    stats: 0.1,
-    sync: 0.1,
-  }
 
   extend self
 
@@ -254,7 +249,6 @@ module NetworkResiliency
         adapter: adapter,
         destination: destination,
       },
-      sample_rate: SAMPLE_RATE[:timeout],
     ) if timeout && timeout > 0
 
     if error
@@ -286,28 +280,23 @@ module NetworkResiliency
       # ensure Syncer is running
       Syncer.start
 
-      if rand < SAMPLE_RATE[:stats]
-        NetworkResiliency.statsd&.distribution(
-          "network_resiliency.#{action}.stats.n",
-          stats.n,
-          tags: tags,
-          sample_rate: SAMPLE_RATE[:stats],
-        )
+      NetworkResiliency.statsd&.distribution(
+        "network_resiliency.#{action}.stats.n",
+        stats.n,
+        tags: tags,
+      )
 
-        NetworkResiliency.statsd&.distribution(
-          "network_resiliency.#{action}.stats.avg",
-          stats.avg,
-          tags: tags,
-          sample_rate: SAMPLE_RATE[:stats],
-        )
+      NetworkResiliency.statsd&.distribution(
+        "network_resiliency.#{action}.stats.avg",
+        stats.avg,
+        tags: tags,
+      )
 
-        NetworkResiliency.statsd&.distribution(
-          "network_resiliency.#{action}.stats.stdev",
-          stats.stdev,
-          tags: tags,
-          sample_rate: SAMPLE_RATE[:stats],
-        )
-      end
+      NetworkResiliency.statsd&.distribution(
+        "network_resiliency.#{action}.stats.stdev",
+        stats.stdev,
+        tags: tags,
+      )
     end
 
     nil
@@ -361,16 +350,18 @@ module NetworkResiliency
 
         # make a second, more lenient attempt
 
-        if p99 * 10 < max
-          timeouts << p99 * 10
+        if p99 * 100 < max
+          timeouts << p99 * 100
+        elsif p99 * 10 < max
+          # use remaining time for second attempt
+          timeouts << max - p99
         else
           timeouts << max
 
           NetworkResiliency.statsd&.increment(
             "network_resiliency.timeout.raised",
             tags: tags,
-            sample_rate: SAMPLE_RATE[:timeout],
-          ) if rand < SAMPLE_RATE[:timeout]
+          )
         end
       else
         # the specified timeout is less than our expected p99...awkward
@@ -379,20 +370,18 @@ module NetworkResiliency
         NetworkResiliency.statsd&.increment(
           "network_resiliency.timeout.too_low",
           tags: tags,
-          sample_rate: SAMPLE_RATE[:timeout],
-        ) if rand < SAMPLE_RATE[:timeout]
+        )
       end
     else
       timeouts << p99
 
       # second attempt
-      timeouts << p99 * 10
+      timeouts << p99 * 100
 
       NetworkResiliency.statsd&.increment(
         "network_resiliency.timeout.missing",
         tags: tags,
-        sample_rate: SAMPLE_RATE[:timeout],
-      ) if rand < SAMPLE_RATE[:timeout]
+      )
     end
 
     NetworkResiliency.statsd&.distribution(
@@ -402,8 +391,7 @@ module NetworkResiliency
         adapter: adapter,
         destination: destination,
       },
-      sample_rate: SAMPLE_RATE[:timeout],
-    ) if rand < SAMPLE_RATE[:timeout]
+    )
 
     case units
     when nil, :ms, :milliseconds

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: network_resiliency
 version: !ruby/object:Gem::Version
-  version: 0.8.1
+  version: 0.8.2
 platform: ruby
 authors:
 - Daniel Pepper
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-03-12 00:00:00.000000000 Z
+date: 2024-03-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: byebug