netvisor 0.9.2 → 0.9.3

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 ## CHANGELOG
 
+## Version 0.9.3
+* Added logging
+* Rewrote configuration
+
 ## Version 0.9.2
 * Changed `ElementBase` from Superclass to Mixin
 

data/lib/netvisor.rb

@@ -1,10 +1,11 @@
+require 'logging'
 require "netvisor/version"
 require "netvisor/base"
 require "netvisor/configuration"
 
 module Netvisor
   class << self
-    attr_accessor :configuration
+    attr_accessor :configuration, :logger
   end
 
   def self.new
@@ -16,10 +17,26 @@ module Netvisor
   end
 
   def self.configuration
-    @configuration ||= Configuration.new(:sender => 'Netvisor gem')
+    init_config if (@configuration.nil? || @configuration == 1)
+    @configuration
   end
 
   def self.reset
-    @configuration = Configuration.new(:sender => 'Netvisor gem')
+    init_config
+    init_logger
+  end
+
+  def self.init_logger
+    @logger = Logging.logger(STDOUT)
+    @logger.level = configuration.log_level
+  end
+
+  def self.init_config
+    @configuration = Configuration.new(:sender => 'Netvisor gem', :log_level => :debug)
+  end
+
+  def self.logger
+    init_logger if (@logger.nil? || @logger == 1)
+    @logger
   end
 end

data/lib/netvisor/configuration.rb

@@ -7,9 +7,10 @@ module Netvisor
                               :language,
                               :organisation_id,
                               :customer_key,
-                              :partner_key) do
+                              :partner_key,
+                              :log_level) do
 
-    # Initialize override to accept named parameters (Config(:host => 'foo'...))
+    # Initialize override to accept named parameters (Configuration(:host => 'foo'...))
     # http://stackoverflow.com/questions/5407940/named-parameters-in-ruby-structs
     def initialize *args
       return super unless (args.length == 1 and args.first.instance_of? Hash)

data/lib/netvisor/element_base.rb

@@ -3,7 +3,7 @@ module ElementBase
     base.class_exec do
       def initialize(args = {})
         args.each_pair do |key, val|
-          self.send("#{key}=", val) if ElementBase.method_defined? key
+          self.send("#{key}=", val) if self.class.method_defined? key
         end
       end
     end

data/lib/netvisor/request.rb

@@ -7,13 +7,14 @@ module Netvisor
     def dispatch(xml, service, method = nil, id = nil)
       url = self.class.build_url(service, method, id)
       headers = self.class.build_headers(url)
+      Netvisor.logger.debug "dispatch: URL #{url}"
+      Netvisor.logger.debug "dispatch: Headers #{headers}"
       xml.gsub!("<?xml version=\"1.0\"?>", '')
 
       res = Faraday.post(url) do |req|
         req.headers.merge!(headers)
         req.body = xml
       end
-      p res
       Netvisor::Response.parse(res.body)
     end
 
@@ -49,7 +50,7 @@ module Netvisor
         Netvisor.configuration.customer_key,
         Netvisor.configuration.partner_key
       ]
-      p arr.join('&')
+      Netvisor.logger.debug "build_mac: #{arr.join('&')}"
       Digest::SHA2.hexdigest(arr.join('&'))
     end
   end

data/lib/netvisor/version.rb

@@ -1,3 +1,3 @@
 module Netvisor
-  VERSION = "0.9.2"
+  VERSION = "0.9.3"
 end

data/netvisor.gemspec

@@ -33,4 +33,5 @@ EOF
   spec.add_runtime_dependency 'system_timer', '~> 1.2.4' if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('1.9')
   spec.add_runtime_dependency 'nokogiri-happymapper-deiga', '~> 0.5.10'
   spec.add_runtime_dependency 'nokogiri', '~> 1.5.11'
+  spec.add_runtime_dependency 'logging'
 end

data/spec/netvisor/element_base_spec.rb

@@ -0,0 +1,28 @@
+require "spec_helper"
+
+module Netvisor
+
+  class Dummy
+    include HappyMapper
+    include ElementBase
+
+    attribute :foo, String
+    element :bar, String
+  end
+
+  describe ElementBase do
+    describe "#initialize" do
+      it "Class values are nil on no parameters" do
+        dummy = Dummy.new
+        expect(dummy.foo).to be_nil
+        expect(dummy.bar).to be_nil
+      end
+
+      it "Class attribute is set to specified value" do
+        dummy = Dummy.new(:foo => 'foo')
+        expect(dummy.foo).to eq 'foo'
+        expect(dummy.bar).to be_nil
+      end
+    end
+  end
+end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: netvisor
 version: !ruby/object:Gem::Version 
-  hash: 63
+  hash: 61
   prerelease: 
   segments: 
   - 0
   - 9
-  - 2
-  version: 0.9.2
+  - 3
+  version: 0.9.3
 platform: ruby
 authors: 
 - Timo Sand
@@ -172,6 +172,20 @@ dependencies:
   requirement: *id010
   type: :runtime
   name: nokogiri
+- !ruby/object:Gem::Dependency 
+  version_requirements: &id011 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  prerelease: false
+  requirement: *id011
+  type: :runtime
+  name: logging
 description: "  This gem is a ruby implementation of the Netvisor invoicing API\n"
 email: 
 - timo.j.sand@gmail.com
@@ -207,6 +221,7 @@ files:
 - lib/netvisor/version.rb
 - netvisor.gemspec
 - spec/netvisor/configuration_spec.rb
+- spec/netvisor/element_base_spec.rb
 - spec/netvisor_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/Eficode/netvisor
@@ -246,5 +261,6 @@ specification_version: 3
 summary: WIP Implementation of Netvisor API in Ruby
 test_files: 
 - spec/netvisor/configuration_spec.rb
+- spec/netvisor/element_base_spec.rb
 - spec/netvisor_spec.rb
 - spec/spec_helper.rb