netuitive_rails_agent 1.0.2 → 1.0.3

data/lib/netuitive_rails_agent.rb

@@ -12,6 +12,7 @@ NetuitiveRailsAgent::ConfigManager.load_config
 NetuitiveRailsAgent::NetuitiveLogger.setup
 NetuitiveRailsAgent::ConfigManager.read_config
 
+require 'netuitive_rails_agent/error_logger'
 require 'netuitive_rails_agent/api_interaction'
 require 'netuitive_rails_agent/controller_utils'
 require 'netuitive_rails_agent/error_utils'
@@ -28,19 +29,20 @@ require 'netuitive_rails_agent/gc'
 require 'netuitive_rails_agent/objectspace'
 require 'netuitive_rails_agent/scheduler'
 
-# subscribe to notifications
-interaction = NetuitiveRailsAgent::ApiInteraction.new
-NetuitiveRailsAgent::ActionControllerSub.new(interaction).subscribe if NetuitiveRailsAgent::ConfigManager.action_controller_enabled
-NetuitiveRailsAgent::ActiveRecordSub.new(interaction).subscribe if NetuitiveRailsAgent::ConfigManager.active_record_enabled
-NetuitiveRailsAgent::ActionViewSub.new(interaction).subscribe if NetuitiveRailsAgent::ConfigManager.action_view_enabled
-NetuitiveRailsAgent::ActionMailerSub.new(interaction).subscribe if NetuitiveRailsAgent::ConfigManager.action_mailer_enabled
-NetuitiveRailsAgent::ActiveSupportSub.new(interaction).subscribe if NetuitiveRailsAgent::ConfigManager.active_support_enabled
-NetuitiveRailsAgent::ActiveJobSub.new(interaction).subscribe if NetuitiveRailsAgent::ConfigManager.active_job_enabled
+NetuitiveRailsAgent::ErrorLogger.guard('error during agent installation') do # subscribe to notifications
+  interaction = NetuitiveRailsAgent::ApiInteraction.new
+  NetuitiveRailsAgent::ActionControllerSub.new(interaction).subscribe if NetuitiveRailsAgent::ConfigManager.action_controller_enabled
+  NetuitiveRailsAgent::ActiveRecordSub.new(interaction).subscribe if NetuitiveRailsAgent::ConfigManager.active_record_enabled
+  NetuitiveRailsAgent::ActionViewSub.new(interaction).subscribe if NetuitiveRailsAgent::ConfigManager.action_view_enabled
+  NetuitiveRailsAgent::ActionMailerSub.new(interaction).subscribe if NetuitiveRailsAgent::ConfigManager.action_mailer_enabled
+  NetuitiveRailsAgent::ActiveSupportSub.new(interaction).subscribe if NetuitiveRailsAgent::ConfigManager.active_support_enabled
+  NetuitiveRailsAgent::ActiveJobSub.new(interaction).subscribe if NetuitiveRailsAgent::ConfigManager.active_job_enabled
 
-# start metrics that are collected on a schedule
-NetuitiveRailsAgent::Scheduler.new(interaction).start_schedule if NetuitiveRailsAgent::ConfigManager.gc_enabled || NetuitiveRailsAgent::ConfigManager.object_space_enabled
+  # start metrics that are collected on a schedule
+  NetuitiveRailsAgent::Scheduler.new(interaction).start_schedule if NetuitiveRailsAgent::ConfigManager.gc_enabled || NetuitiveRailsAgent::ConfigManager.object_space_enabled
 
-# sidekiq
-NetuitiveRailsAgent::SidekiqTracker.new.setup if NetuitiveRailsAgent::ConfigManager.sidekiq_enabled
+  # sidekiq
+  NetuitiveRailsAgent::SidekiqTracker.new.setup if NetuitiveRailsAgent::ConfigManager.sidekiq_enabled
 
-NetuitiveRailsAgent::NetuitiveLogger.log.info 'Netuitive rails agent installed'
+  NetuitiveRailsAgent::NetuitiveLogger.log.info 'Netuitive rails agent installed'
+end

data/lib/netuitive_rails_agent/action_controller.rb

@@ -45,21 +45,23 @@ module NetuitiveRailsAgent
     end
 
     def process_action(*args)
-      event = ActiveSupport::Notifications::Event.new(*args)
-      controller = event.payload[:controller].to_s
-      action = event.payload[:action].to_s
-      interaction.add_sample("action_controller.#{controller}.#{action}.request.total_duration", event.duration)
-      interaction.add_sample("action_controller.#{controller}.#{action}.request.query_time", event.payload[:db_runtime])
-      interaction.add_sample("action_controller.#{controller}.#{action}.request.view_time", event.payload[:view_runtime])
-      interaction.add_sample("action_controller.#{controller}.request.total_duration", event.duration)
-      interaction.add_sample("action_controller.#{controller}.request.query_time", event.payload[:db_runtime])
-      interaction.add_sample("action_controller.#{controller}.request.view_time", event.payload[:view_runtime])
-      interaction.add_sample('action_controller.request.total_duration', event.duration)
-      interaction.add_sample('action_controller.request.query_time', event.payload[:db_runtime])
-      interaction.add_sample('action_controller.request.view_time', event.payload[:view_runtime])
-      interaction.aggregate_metric("action_controller.#{controller}.#{action}.total_requests", 1)
-      interaction.aggregate_metric("action_controller.#{controller}.total_requests", 1)
-      interaction.aggregate_metric('action_controller.total_requests', 1)
+      NetuitiveRailsAgent::ErrorLogger.guard('error during process_action') do
+        event = ActiveSupport::Notifications::Event.new(*args)
+        controller = event.payload[:controller].to_s
+        action = event.payload[:action].to_s
+        interaction.add_sample("action_controller.#{controller}.#{action}.request.total_duration", event.duration)
+        interaction.add_sample("action_controller.#{controller}.#{action}.request.query_time", event.payload[:db_runtime])
+        interaction.add_sample("action_controller.#{controller}.#{action}.request.view_time", event.payload[:view_runtime])
+        interaction.add_sample("action_controller.#{controller}.request.total_duration", event.duration)
+        interaction.add_sample("action_controller.#{controller}.request.query_time", event.payload[:db_runtime])
+        interaction.add_sample("action_controller.#{controller}.request.view_time", event.payload[:view_runtime])
+        interaction.add_sample('action_controller.request.total_duration', event.duration)
+        interaction.add_sample('action_controller.request.query_time', event.payload[:db_runtime])
+        interaction.add_sample('action_controller.request.view_time', event.payload[:view_runtime])
+        interaction.aggregate_metric("action_controller.#{controller}.#{action}.total_requests", 1)
+        interaction.aggregate_metric("action_controller.#{controller}.total_requests", 1)
+        interaction.aggregate_metric('action_controller.total_requests', 1)
+      end
     end
 
     def write_fragment

data/lib/netuitive_rails_agent/action_mailer.rb

@@ -15,15 +15,19 @@ module NetuitiveRailsAgent
     end
 
     def receive(*args)
-      event = ActiveSupport::Notifications::Event.new(*args)
-      mailer = event.payload[:mailer].to_s
-      interaction.aggregate_metric("action_mailer.#{mailer}.receive", 1)
+      NetuitiveRailsAgent::ErrorLogger.guard('error during stop_server') do
+        event = ActiveSupport::Notifications::Event.new(*args)
+        mailer = event.payload[:mailer].to_s
+        interaction.aggregate_metric("action_mailer.#{mailer}.receive", 1)
+      end
     end
 
     def deliver(*args)
-      event = ActiveSupport::Notifications::Event.new(*args)
-      mailer = event.payload[:mailer].to_s
-      interaction.aggregate_metric("action_mailer.#{mailer}.deliver", 1)
+      NetuitiveRailsAgent::ErrorLogger.guard('error during deliver') do
+        event = ActiveSupport::Notifications::Event.new(*args)
+        mailer = event.payload[:mailer].to_s
+        interaction.aggregate_metric("action_mailer.#{mailer}.deliver", 1)
+      end
     end
   end
 end

data/lib/netuitive_rails_agent/api_interaction.rb

@@ -5,39 +5,57 @@ module NetuitiveRailsAgent
     end
 
     def add_sample(metric_id, val)
-      NetuitiveRubyAPI.add_sample(metric_id, val)
+      NetuitiveRailsAgent::ErrorLogger.guard('error during add_sample') do
+        NetuitiveRubyAPI.add_sample(metric_id, val)
+      end
     end
 
     def add_counter_sample(metric_id, val)
-      NetuitiveRubyAPI.add_counter_sample(metric_id, val)
+      NetuitiveRailsAgent::ErrorLogger.guard('error during add_counter_sample') do
+        NetuitiveRubyAPI.add_counter_sample(metric_id, val)
+      end
     end
 
     def aggregate_metric(metric_id, val)
-      NetuitiveRubyAPI.aggregate_metric(metric_id, val)
+      NetuitiveRailsAgent::ErrorLogger.guard('error during aggregate_metric') do
+        NetuitiveRubyAPI.aggregate_metric(metric_id, val)
+      end
     end
 
     def aggregate_counter_metric(metric_id, val)
-      NetuitiveRubyAPI.aggregate_counter_metric(metric_id, val)
+      NetuitiveRailsAgent::ErrorLogger.guard('error during aggregate_counter_metric') do
+        NetuitiveRubyAPI.aggregate_counter_metric(metric_id, val)
+      end
     end
 
     def clear_metrics
-      NetuitiveRubyAPI.clear_metrics
+      NetuitiveRailsAgent::ErrorLogger.guard('error during clear_metrics') do
+        NetuitiveRubyAPI.clear_metrics
+      end
     end
 
     def interval
-      NetuitiveRubyAPI.interval
+      NetuitiveRailsAgent::ErrorLogger.guard('error during interval') do
+        NetuitiveRubyAPI.interval
+      end
     end
 
     def event(message, timestamp = Time.new, title = 'Ruby Event', level = 'Info', source = 'Ruby Agent', type = 'INFO', tags = nil)
-      NetuitiveRubyAPI.event(message, timestamp, title, level, source, type, tags)
+      NetuitiveRailsAgent::ErrorLogger.guard('error during event') do
+        NetuitiveRubyAPI.event(message, timestamp, title, level, source, type, tags)
+      end
     end
 
     def exception_event(exception, klass = nil, tags = nil)
-      NetuitiveRubyAPI.exception_event(exception, klass, tags)
+      NetuitiveRailsAgent::ErrorLogger.guard('error during exception_event') do
+        NetuitiveRubyAPI.exception_event(exception, klass, tags)
+      end
     end
 
     def stop_server
-      NetuitiveRubyAPI.stop_server
+      NetuitiveRailsAgent::ErrorLogger.guard('error during stop_server') do
+        NetuitiveRubyAPI.stop_server
+      end
     end
   end
 end

data/lib/netuitive_rails_agent/controller_utils.rb

@@ -1,8 +1,10 @@
 module NetuitiveRailsAgent
   module ControllerUtils
     def netuitive_action_name
-      return controller.action_name if defined? controller # rails 3.1.X
-      action_name # rails 4.X
+      NetuitiveRailsAgent::ErrorLogger.guard('error during netuitive_action_name') do
+        return controller.action_name if defined? controller # rails 3.1.X
+        action_name # rails 4.X
+      end
     end
 
     def netuitive_controller_name
@@ -10,8 +12,10 @@ module NetuitiveRailsAgent
     end
 
     def netuitive_request_uri
-      return request.fullpath if defined? request.fullpath # rails 3
-      request.original_fullpath # rails >3.2
+      NetuitiveRailsAgent::ErrorLogger.guard('error during netuitive_request_uri') do
+        return request.fullpath if defined? request.fullpath # rails 3
+        request.original_fullpath # rails >3.2
+      end
     end
   end
 end

data/lib/netuitive_rails_agent/error_logger.rb

@@ -0,0 +1,21 @@
+# Important! ruby rescue logic is expensive.
+# This class is *intended* to be used as a catch all, because we don't want any errors to not be logged
+# or worse to bubble up to the host application.
+# That *doesn't* mean we should be throwing exceptions rather than guarding against them
+# From the benchmarks I've read it seems like rescues are free if no exception is thrown
+module NetuitiveRailsAgent
+  class ErrorLogger
+    class << self
+      def guard(message)
+        yield
+      rescue => e
+        NetuitiveRailsAgent::NetuitiveLogger.log.error format_exception(e, message)
+      end
+
+      def format_exception(exception, *message)
+        message = '' unless defined? message || message.nil?
+        "#{message} \n\tException message: #{exception.message}\n\t Backtrace: #{exception.backtrace.join("\n\t")}"
+      end
+    end
+  end
+end

data/lib/netuitive_rails_agent/error_tracker.rb

@@ -9,7 +9,7 @@ module NetuitiveRailsAgent
     included do
       NetuitiveRailsAgent::NetuitiveLogger.log.debug 'ErrorTracker included'
       rescue_from Exception do |exception|
-        begin
+        NetuitiveRailsAgent::ErrorLogger.guard('error during ErrorTrackerHook') do
           tags = {
             URI: netuitive_request_uri,
             Controller: netuitive_controller_name,
@@ -23,8 +23,6 @@ module NetuitiveRailsAgent
             end
           end
           handle_error(exception, metrics, tags)
-        rescue => e
-          NetuitiveRailsAgent::NetuitiveLogger.log.error "exception during controller error tracking: message:#{e.message} backtrace:#{e.backtrace}"
         end
         raise exception
       end

data/lib/netuitive_rails_agent/error_utils.rb

@@ -3,15 +3,17 @@ module NetuitiveRailsAgent
     attr_accessor :interaction
 
     def ignored_error?(exception)
-      unless NetuitiveRailsAgent::ConfigManager.ignored_errors.empty?
-        NetuitiveRailsAgent::ConfigManager.ignored_errors.each do |name|
-          if name.include? '^'
-            name.tr!('^', '')
-            exception.class.ancestors.each do |ancestor|
-              return true if name.casecmp(ancestor.name).zero?
+      NetuitiveRailsAgent::ErrorLogger.guard('error during ignored_error?') do
+        unless NetuitiveRailsAgent::ConfigManager.ignored_errors.empty?
+          NetuitiveRailsAgent::ConfigManager.ignored_errors.each do |name|
+            if name.include? '^'
+              name.tr!('^', '')
+              exception.class.ancestors.each do |ancestor|
+                return true if name.casecmp(ancestor.name).zero?
+              end
+            elsif name.casecmp(exception.class.name).zero?
+              return true
             end
-          elsif name.casecmp(exception.class.name).zero?
-            return true
           end
         end
       end
@@ -19,23 +21,23 @@ module NetuitiveRailsAgent
     end
 
     def handle_error(exception, metrics = [], tags = {})
-      NetuitiveRailsAgent::NetuitiveLogger.log.debug "received error: #{exception}"
-      unless ignored_error?(exception)
-        @interaction = NetuitiveRailsAgent::ApiInteraction.new unless @interaction
-        NetuitiveRailsAgent::NetuitiveLogger.log.debug "#{exception} wasn't ignored"
-        if NetuitiveRailsAgent::ConfigManager.capture_errors
-          NetuitiveRailsAgent::NetuitiveLogger.log.debug "sending error: #{exception}"
-          @interaction.exception_event(exception, exception.class, tags)
-          NetuitiveRailsAgent::NetuitiveLogger.log.debug 'sent error'
-        end
-        NetuitiveRailsAgent::NetuitiveLogger.log.debug 'sending error metrics'
-        metrics.each do |metric|
-          @interaction.aggregate_metric(metric.to_s, 1)
-          NetuitiveRailsAgent::NetuitiveLogger.log.debug "sent error metric with name: #{metric}"
+      NetuitiveRailsAgent::ErrorLogger.guard('error during handle_error') do
+        NetuitiveRailsAgent::NetuitiveLogger.log.debug "received error: #{exception}"
+        unless ignored_error?(exception)
+          @interaction = NetuitiveRailsAgent::ApiInteraction.new unless @interaction
+          NetuitiveRailsAgent::NetuitiveLogger.log.debug "#{exception} wasn't ignored"
+          if NetuitiveRailsAgent::ConfigManager.capture_errors
+            NetuitiveRailsAgent::NetuitiveLogger.log.debug "sending error: #{exception}"
+            @interaction.exception_event(exception, exception.class, tags)
+            NetuitiveRailsAgent::NetuitiveLogger.log.debug 'sent error'
+          end
+          NetuitiveRailsAgent::NetuitiveLogger.log.debug 'sending error metrics'
+          metrics.each do |metric|
+            @interaction.aggregate_metric(metric.to_s, 1)
+            NetuitiveRailsAgent::NetuitiveLogger.log.debug "sent error metric with name: #{metric}"
+          end
         end
       end
-    rescue => e
-      NetuitiveRailsAgent::NetuitiveLogger.log.error "exception during error tracking: message:#{e.message} backtrace:#{e.backtrace}"
     end
   end
 end

data/lib/netuitive_rails_agent/gc.rb

@@ -10,23 +10,21 @@ module NetuitiveRailsAgent
         NetuitiveRailsAgent::NetuitiveLogger.log.warn 'gc profiler not enabled'
         return
       end
-      begin
-          NetuitiveRailsAgent::NetuitiveLogger.log.debug 'collecting gc metrics'
-          GC.stat.each do |key, value|
-            NetuitiveRailsAgent::NetuitiveLogger.log.debug "GC stat key: #{key}"
-            if (key.to_s == 'total_allocated_object') || (key.to_s == 'total_freed_object') || (key.to_s == 'count')
-              NetuitiveRailsAgent::NetuitiveLogger.log.debug "sending aggregateCounterMetric GC.stat.#{key}"
-              interaction.aggregate_counter_metric("GC.stat.#{key}", value)
-            else
-              NetuitiveRailsAgent::NetuitiveLogger.log.debug "sending aggregateMetric GC.stat.#{key}"
-              interaction.aggregate_metric("GC.stat.#{key}", value)
-            end
+      NetuitiveRailsAgent::NetuitiveLogger.log.debug 'collecting gc metrics'
+      NetuitiveRailsAgent::ErrorLogger.guard('error during collecting gc metrics') do
+        GC.stat.each do |key, value|
+          NetuitiveRailsAgent::NetuitiveLogger.log.debug "GC stat key: #{key}"
+          if (key.to_s == 'total_allocated_object') || (key.to_s == 'total_freed_object') || (key.to_s == 'count')
+            NetuitiveRailsAgent::NetuitiveLogger.log.debug "sending aggregateCounterMetric GC.stat.#{key}"
+            interaction.aggregate_counter_metric("GC.stat.#{key}", value)
+          else
+            NetuitiveRailsAgent::NetuitiveLogger.log.debug "sending aggregateMetric GC.stat.#{key}"
+            interaction.aggregate_metric("GC.stat.#{key}", value)
           end
-          NetuitiveRailsAgent::NetuitiveLogger.log.debug 'sending aggregateCounterMetric GC.profiler.total_time'
-          interaction.aggregate_counter_metric('GC.profiler.total_time', GC::Profiler.total_time)
-        rescue => e
-          NetuitiveRailsAgent::NetuitiveLogger.log.error "exception during gc collection: message:#{e.message} backtrace:#{e.backtrace}"
         end
+        NetuitiveRailsAgent::NetuitiveLogger.log.debug 'sending aggregateCounterMetric GC.profiler.total_time'
+        interaction.aggregate_counter_metric('GC.profiler.total_time', GC::Profiler.total_time)
+      end
       NetuitiveRailsAgent::NetuitiveLogger.log.debug 'finished collecting gc metrics'
     end
   end

data/lib/netuitive_rails_agent/objectspace.rb

@@ -7,13 +7,13 @@ module NetuitiveRailsAgent
 
     def collect
       NetuitiveRailsAgent::NetuitiveLogger.log.debug 'collecting object space metrics'
-      ObjectSpace.count_objects.each do |key, value|
-        NetuitiveRailsAgent::NetuitiveLogger.log.debug "ObjectSpace.count_objects.#{key}"
-        interaction.aggregate_metric("ObjectSpace.count_objects.#{key}", value)
+      NetuitiveRailsAgent::ErrorLogger.guard('error during collecting object space metrics') do
+        ObjectSpace.count_objects.each do |key, value|
+          NetuitiveRailsAgent::NetuitiveLogger.log.debug "ObjectSpace.count_objects.#{key}"
+          interaction.aggregate_metric("ObjectSpace.count_objects.#{key}", value)
+        end
       end
       NetuitiveRailsAgent::NetuitiveLogger.log.debug 'finished collecting object space metrics'
-    rescue => e
-      NetuitiveRailsAgent::NetuitiveLogger.log.error "exception during object space collection: message:#{e.message} backtrace:#{e.backtrace}"
     end
   end
 end

data/lib/netuitive_rails_agent/request_data.rb

@@ -9,30 +9,32 @@ module NetuitiveRailsAgent
     ].freeze
 
     def self.header_start_time(headers)
-      if headers
-        start_time = nil
-        HEADERS_NAMES.each do |header_name|
-          header = headers[header_name]
-          next if header.nil?
-          match = /\d+(\.\d{1,2})?/.match(header)
-          if match.nil?
-            NetuitiveRailsAgent::NetuitiveLogger.log.error "queue time header value #{header} is not recognized"
-            next
+      NetuitiveRailsAgent::ErrorLogger.guard('error during header_start_time') do
+        if headers
+          start_time = nil
+          HEADERS_NAMES.each do |header_name|
+            header = headers[header_name]
+            next if header.nil?
+            match = /\d+(\.\d{1,2})?/.match(header)
+            if match.nil?
+              NetuitiveRailsAgent::NetuitiveLogger.log.error "queue time header value #{header} is not recognized"
+              next
+            end
+            header_time = match.to_s.to_f / NetuitiveRailsAgent::ConfigManager.queue_time_divisor
+            NetuitiveRailsAgent::NetuitiveLogger.log.debug "queue header_time: #{header_time}"
+            start_time = start_time.nil? || header_time < start_time ? header_time : start_time
+            NetuitiveRailsAgent::NetuitiveLogger.log.debug "queue start_time: #{start_time}"
           end
-          header_time = match.to_s.to_f / NetuitiveRailsAgent::ConfigManager.queue_time_divisor
-          NetuitiveRailsAgent::NetuitiveLogger.log.debug "queue header_time: #{header_time}"
-          start_time = start_time.nil? || header_time < start_time ? header_time : start_time
-          NetuitiveRailsAgent::NetuitiveLogger.log.debug "queue start_time: #{start_time}"
+          return nil if start_time.nil?
+          return (Time.now.to_f - start_time) * 1000.0
         end
-        return nil if start_time.nil?
-        return (Time.now.to_f - start_time) * 1000.0
       end
       nil
     end
 
     def netuitive_request_hook
       return unless request
-      begin
+      NetuitiveRailsAgent::ErrorLogger.guard('error during netuitive_request_hook') do
         queue_time = NetuitiveRailsAgent::RequestDataHook.header_start_time(request.headers)
         if queue_time.nil?
           NetuitiveRailsAgent::NetuitiveLogger.log.info 'no queue time header found for request'
@@ -47,8 +49,6 @@ module NetuitiveRailsAgent
         return unless netuitive_action_name
         NetuitiveRailsAgent::NetuitiveLogger.log.debug "sending queue_time metrics with netuitive_action_name #{netuitive_action_name}"
         NetuitiveRubyAPI.add_sample("action_controller.#{netuitive_controller_name}.#{netuitive_action_name}.request.queue_time", queue_time)
-      rescue => e
-        NetuitiveRailsAgent::NetuitiveLogger.log.error "exception during request tracking: message:#{e.message} backtrace:#{e.backtrace}"
       end
     end
   end

data/lib/netuitive_rails_agent/scheduler.rb

@@ -13,13 +13,11 @@ module NetuitiveRailsAgent
       NetuitiveRailsAgent::NetuitiveLogger.log.debug 'starting schedule'
       Thread.new do
         loop do
-          begin
+          NetuitiveRailsAgent::ErrorLogger.guard('error during schedule') do
             collect_metrics
             sleep_time = interval
             NetuitiveRailsAgent::NetuitiveLogger.log.debug "scheduler sleeping for: #{sleep_time}"
             sleep(sleep_time)
-          rescue => e
-            NetuitiveRailsAgent::NetuitiveLogger.log.error "error during schedule: #{e.message}, backtrace: #{e.backtrace}"
           end
         end
       end
@@ -32,13 +30,12 @@ module NetuitiveRailsAgent
     end
 
     def collect_metrics
-      NetuitiveRailsAgent::NetuitiveLogger.log.debug 'collecting schedule metrics'
-      begin
+      NetuitiveRailsAgent::NetuitiveLogger.log.debug 'start collecting schedule metrics'
+      NetuitiveRailsAgent::ErrorLogger.guard('error during collect_metrics') do
         gc_stats_collector.collect if NetuitiveRailsAgent::ConfigManager.gc_enabled
         object_space_collector.collect if NetuitiveRailsAgent::ConfigManager.object_space_enabled
-      rescue => e
-        NetuitiveRailsAgent::NetuitiveLogger.log.error "unable to collect schedule metrics: message:#{e.message} backtrace:#{e.backtrace}"
       end
+      NetuitiveRailsAgent::NetuitiveLogger.log.debug 'finshed collecting schedule metrics'
     end
   end
 end

data/lib/netuitive_rails_agent/sidekiq.rb

@@ -2,14 +2,16 @@ module NetuitiveRailsAgent
   class SidekiqTracker
     def setup
       NetuitiveRailsAgent::NetuitiveLogger.log.debug 'turning on sidekiq tracking'
-      require 'sidekiq'
-      Sidekiq.configure_server do |config|
-        config.error_handlers << proc { |ex, ctx_hash| NetuitiveRailsAgent::SidekiqTracker::ErrorTracker.new.call(ex, ctx_hash) }
-        config.server_middleware do |chain|
-          chain.add NetuitiveRailsAgent::SidekiqTracker::ChainTracker
+      NetuitiveRailsAgent::ErrorLogger.guard('error during sidekiq tracking installation') do
+        require 'sidekiq'
+        Sidekiq.configure_server do |config|
+          config.error_handlers << proc { |ex, ctx_hash| NetuitiveRailsAgent::SidekiqTracker::ErrorTracker.new.call(ex, ctx_hash) }
+          config.server_middleware do |chain|
+            chain.add NetuitiveRailsAgent::SidekiqTracker::ChainTracker
+          end
         end
+        NetuitiveRailsAgent::NetuitiveLogger.log.debug 'sidekiq tracking installed'
       end
-      NetuitiveRailsAgent::NetuitiveLogger.log.debug 'sidekiq tracking installed'
     end
 
     class ChainTracker
@@ -19,15 +21,13 @@ module NetuitiveRailsAgent
       end
 
       def call(worker, item, queue)
-        begin
+        NetuitiveRailsAgent::ErrorLogger.guard('error during sidekiq ChainTracker') do
           klass = item['wrapped'.freeze] || worker.class.to_s
           queue = item['queue']
           NetuitiveRailsAgent::NetuitiveLogger.log.debug "sidekiq job tracked. queue: #{queue}, class: #{klass}"
           interaction.aggregate_metric("sidekiq.#{klass}.job.count", 1)
           interaction.aggregate_metric("sidekiq.#{queue}.job.count", 1)
           interaction.aggregate_metric("sidekiq.#{queue}.#{klass}.job.count", 1)
-        rescue => e
-          NetuitiveRailsAgent::NetuitiveLogger.log.error "exception during sidekiq chain tracking: message:#{e.message} backtrace:#{e.backtrace}"
         end
         yield
       end
@@ -41,26 +41,26 @@ module NetuitiveRailsAgent
       end
 
       def call(exception, ctx_hash)
-        NetuitiveRailsAgent::NetuitiveLogger.log.debug "sidekiq error tracked. context: #{ctx_hash[:context]}"
-        tags = {
-          sidekiq: 'true',
-          context: ctx_hash[:context]
-        }
-        metrics = ['sidekiq.errors']
-        job = ctx_hash[:job]
-        unless job.nil?
-          if defined? job.item
-            item = job.item
-            klass = item['wrapped'.freeze] || worker.class.to_s
-            queue = item['queue']
-            metrics << "sidekiq.#{queue}.#{klass}.error.count"
-            metrics << "sidekiq.#{queue}.error.count"
+        NetuitiveRailsAgent::ErrorLogger.guard('error during sidekiq ErrorTracker') do
+          NetuitiveRailsAgent::NetuitiveLogger.log.debug "sidekiq error tracked. context: #{ctx_hash[:context]}"
+          tags = {
+            sidekiq: 'true',
+            context: ctx_hash[:context]
+          }
+          metrics = ['sidekiq.errors']
+          job = ctx_hash[:job]
+          unless job.nil?
+            if defined? job.item
+              item = job.item
+              klass = item['wrapped'.freeze] || worker.class.to_s
+              queue = item['queue']
+              metrics << "sidekiq.#{queue}.#{klass}.error.count"
+              metrics << "sidekiq.#{queue}.error.count"
+            end
           end
-        end
 
-        handle_error(exception, metrics, tags)
-      rescue => e
-        NetuitiveRailsAgent::NetuitiveLogger.log.error "exception during sidekiq error tracking: message:#{e.message} backtrace:#{e.backtrace}"
+          handle_error(exception, metrics, tags)
+        end
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: netuitive_rails_agent
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-10-17 00:00:00.000000000 Z
+date: 2016-10-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: netuitive_ruby_api
@@ -66,6 +66,7 @@ files:
 - lib/netuitive_rails_agent/sidekiq.rb
 - lib/netuitive_rails_agent/error_tracker.rb
 - lib/netuitive_rails_agent/active_support.rb
+- lib/netuitive_rails_agent/error_logger.rb
 - lib/netuitive_rails_agent/api_interaction.rb
 - config/agent.yml
 - ./LICENSE