netsuite_rails 0.3.5 → 0.3.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e4bc78784fc838d1ba5ca38b3d83ce0f0007bde4
-  data.tar.gz: dbdf80d06619156e86871566b1b4e7e728d8571b
+  metadata.gz: 94e9ec288d54f908a10fda708db7194307ccbb88
+  data.tar.gz: c65b576effc53fd1f6f9247990db9a811f5bf0b8
 SHA512:
-  metadata.gz: b246f111c66ac0c86d53c4b7164ace112a2fc22fe15ba664efd13063d59d149ba01824e484664995c28431e14fc0133c451b3389550fe0a9a7c1541cf962b08e
-  data.tar.gz: 60923ddc839b756f3a563e00e65138d5b4bd9003b200edc30111289f8ed75150b5164bdc9bbc00e5c6897c09195d19257ff5a521f52e4317ecb5c39b9a5bbc3f
+  metadata.gz: e147f957716a59cf85c4e05a75487e44ae8d16361f4ff2139517f30d8b49de9b9405815917ac6a606fe9544828c2d8327a2926193849fe1ed1ec85a63a04c028
+  data.tar.gz: d48cd14ca541d80bde208b0b6c0f2943df3f284b5841d3b6c14d006c7c8f43718bc288b6a8360b4a6ca167291a216a40dd723398104f8170df7f72d9e32038e7

data/.gitignore

@@ -3,3 +3,4 @@ tmp/
 .bundle/
 Gemfile.lock
 vendor/
+*.gem

data/lib/netsuite_rails/poll_timestamp.rb

@@ -5,7 +5,7 @@ module NetSuiteRails
     validates :key, presence: true, uniqueness: true
 
     def self.for_class(klass)
-      self.where(key: "netsuite_poll_#{klass.to_s.downcase}timestamp").first_or_initialize
+      self.where(key: "netsuite_poll_#{klass.to_s.downcase}").first_or_initialize
     end
 
     def self.table_name_prefix

data/lib/netsuite_rails/record_sync/poll_manager.rb

@@ -31,21 +31,14 @@ module NetSuiteRails
       def poll(klass, opts = {})
         opts = {
           import_all: false,
-          page_size: NetSuiteRails::Configuration.polling_page_size,
         }.merge(opts)
 
         opts[:netsuite_record_class] ||= klass.netsuite_record_class
         opts[:netsuite_custom_record_type_id] ||= klass.netsuite_custom_record_type_id if opts[:netsuite_record_class] == NetSuite::Records::CustomRecord
         opts[:saved_search_id] ||= klass.netsuite_sync_options[:saved_search_id]
-        opts[:body_fields_only] ||= false
 
         search = opts[:netsuite_record_class].search(
-          poll_criteria(klass, opts).merge({
-            preferences: {
-              body_fields_only: opts[:body_fields_only],
-              page_size: opts[:page_size]
-            }
-          })
+          poll_criteria(klass, opts)
         )
 
         # TODO more robust error reporting
@@ -57,6 +50,9 @@ module NetSuiteRails
       end
 
       def poll_criteria(klass, opts)
+        opts[:body_fields_only] ||= false
+        opts[:page_size] ||= NetSuiteRails::Configuration.polling_page_size
+
         search_criteria = {
           criteria: {
             basic: poll_basic_criteria(klass, opts)
@@ -75,6 +71,13 @@ module NetSuiteRails
           }
         end
 
+        search_criteria.merge!({
+          preferences: {
+            body_fields_only: opts[:body_fields_only],
+            page_size: opts[:page_size]
+          }
+        })
+
         search_criteria
       end
 
@@ -100,13 +103,29 @@ module NetSuiteRails
           }
         end
 
+        # CustomRecordSearchBasic uses lastModified instead of the standard lastModifiedDate
+        opts[:netsuite_poll_field] ||= (klass.netsuite_custom_record?) ? 'lastModified' : 'lastModifiedDate'
+
+        # TODO investigate if defining a date range for `import_all` increases peformance
+
         unless opts[:import_all]
-          criteria << {
-            # CustomRecordSearchBasic uses lastModified instead of the standard lastModifiedDate
-            field: (klass.netsuite_custom_record?) ? 'lastModified' : 'lastModifiedDate',
-            operator: 'after',
-            value: opts[:last_poll]
-          }
+          if opts[:updated_before].present?
+            criteria << {
+              field: opts[:netsuite_poll_field],
+              operator: 'within',
+              type: 'SearchDateField',
+              value: [
+                opts[:last_poll],
+                opts[:updated_before]
+              ]
+            }
+          else
+            criteria << {
+              field: opts[:netsuite_poll_field],
+              operator: 'after',
+              value: opts[:last_poll]
+            }
+          end
         end
 
         criteria

data/lib/netsuite_rails/transformations.rb

@@ -6,6 +6,32 @@ module NetSuiteRails
         self.send(type, value, direction)
       end
 
+      def memo(memo, direction = :push)
+        if direction == :push
+          memo[0..999]
+        else
+          memo
+        end
+      end
+
+      # gift certificate codes have a maximum of 9 characters
+      def gift_card_code(code, direction = :push)
+        if direction == :push
+          code[0..8]
+        else
+          code
+        end
+      end
+
+      # company_name field has a 83 character limit
+      def company_name(company_name, direction = :push)
+        if direction == :push
+          company_name[0..82]
+        else
+          company_name
+        end
+      end
+
       # NS limits firstname fields to 33 characters
       def firstname(firstname, direction = :push)
         if direction == :push
@@ -15,6 +41,20 @@ module NetSuiteRails
         end
       end
 
+      # same limitations as firstname
+      def lastname(lastname, direction = :push)
+        firstname(lastname, direction)
+      end
+
+      def integer(number, direction = :push)
+        number.to_i
+      end
+
+      # TODO consider adding precision?
+      def float(number, direction = :push)
+        number.to_f
+      end
+
       def phone(phone, direction = :push)
         if direction == :push
           return nil if phone.nil?
@@ -58,7 +98,11 @@ module NetSuiteRails
             # an error will be thrown if period is on the end of a sentence
             gsub(/[^A-Za-z]+$/, '').
             # any commas in the email with throw an error
-            gsub(',', '')
+            gsub(',', '').
+            # double periods anywhere in the email cause issues
+            gsub('..', '.').
+            # a period before the @ seems to cause issues
+            gsub('.@', '@')
 
           email
         else

data/lib/netsuite_rails/url_helper.rb

@@ -25,6 +25,8 @@ module NetSuiteRails
       # dependent record links
       # https://system.na1.netsuite.com/core/pages/itemchildrecords.nl?id=12413&t=InvtItem%05ProjectCostCategory&rectype=-10
       # https://system.na1.netsuite.com/app/accounting/transactions/payments.nl?id=91964&label=Customer+Refund&type=custrfnd&alllinks=T
+      
+#     # tax schedule: https://system.na1.netsuite.com/app/common/item/taxschedule.nl?id=1
 
       suffix = if is_custom_record
         "/common/custom/custrecordentry.nl?id=#{internal_id}&rectype=#{record.class.netsuite_custom_record_type_id}"
@@ -64,6 +66,8 @@ module NetSuiteRails
         "/accounting/account/account.nl?id=#{internal_id}"
       elsif NetSuite::Records::Subsidiary == record_class
         "/common/otherlists/subsidiarytype.nl?id=#{internal_id}"
+      elsif NetSuite::Records::PaymentMethod == record_class
+        "/app/common/otherlists/accountingotherlist.nl?id=#{internal_id}"
       else
         # TODO unsupported record type error?
       end

data/netsuite_rails.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |s|
   s.name          = "netsuite_rails"
-  s.version       = "0.3.5"
+  s.version       = "0.3.6"
   s.authors       = ["Michael Bianco"]
   s.email         = ["mike@cliffsidemedia.com"]
   s.summary       = %q{Write Rails applications that integrate with NetSuite}

data/spec/models/poll_manager_spec.rb

@@ -7,12 +7,102 @@ describe NetSuiteRails::RecordSync::PollManager do
 
   let(:empty_search_results) { OpenStruct.new(results: [ OpenStruct.new(internal_id: 0) ]) }
 
-  it "should poll record sync objects" do
-  	allow(NetSuite::Records::Customer).to receive(:search).and_return(empty_search_results)
+  describe 'polling ranges' do
+    let(:updated_after) { DateTime.new(2016, 01, 01) }
+    let(:updated_before) { DateTime.new(2016, 01, 02) }
 
-  	StandardRecord.netsuite_poll(import_all: true)
+    it 'does not restrict poll by date if import_all is specified' do
+      expect(NetSuite::Records::Customer).to receive(:search)
+        .with(hash_including(
+          criteria: hash_including(
+            basic: []
+          )
+        ))
+        .and_return(empty_search_results)
+
+      StandardRecord.netsuite_poll(import_all: true)
+    end
+
+    it 'restricts polling within a range' do
+      expect(NetSuite::Records::Customer).to receive(:search)
+        .with(hash_including(
+          criteria: hash_including(
+            basic: array_including(
+              {
+                field: 'lastModifiedDate',
+                type: 'SearchDateField',
+                operator: 'within',
+                value: [
+                  updated_after,
+                  updated_before
+                ]
+              }
+            )
+          )
+        ))
+        .and_return(empty_search_results)
+
+      StandardRecord.netsuite_poll(
+        last_poll: updated_after,
+        updated_before: updated_before
+      )
+    end
+
+    it 'restricts polling after a date' do
+      expect(NetSuite::Records::Customer).to receive(:search)
+        .with(hash_including(
+          criteria: hash_including(
+            basic: array_including(
+              {
+                field: 'lastModifiedDate',
+                operator: 'after',
+                value: updated_after
+              }
+            )
+          )
+        ))
+        .and_return(empty_search_results)
+
+      StandardRecord.netsuite_poll(last_poll: updated_after)
+    end
+
+    it 'allows the polling field to be customized' do
+      expect(NetSuite::Records::Customer).to receive(:search)
+        .with(hash_including(
+          criteria: hash_including(
+            basic: array_including(
+              {
+                field: 'lastQuantityAvailableChange',
+                operator: 'after',
+                value: updated_after
+              }
+            )
+          )
+        ))
+        .and_return(empty_search_results)
+
+      StandardRecord.netsuite_poll(
+        last_poll: updated_after,
+        netsuite_poll_field: 'lastQuantityAvailableChange'
+      )
+    end
+  end
 
-  	expect(NetSuite::Records::Customer).to have_received(:search)
+  it 'allows search preferences to be customized' do
+    expect(NetSuite::Records::Customer).to receive(:search)
+      .with(hash_including(
+        preferences: hash_including(
+          body_fields_only: true,
+          page_size: 13
+        )
+      ))
+      .and_return(empty_search_results)
+
+    StandardRecord.netsuite_poll(
+      import_all: true,
+      body_fields_only: true,
+      page_size: 13
+    )
   end
 
   skip "should poll and then get_list on saved search" do

data/spec/models/routines_spec.rb

@@ -7,7 +7,7 @@ require 'spec_helper'
 describe NetSuiteRails::Routines do
   describe '#company_contact_match' do
     it "matches on first and last name first" do
-
+      # CompanyContactMatch.match
     end
 
     it "matches on email if no name match is found" do

data/spec/models/transformations_spec.rb

@@ -68,5 +68,14 @@ describe NetSuiteRails::Transformations do
     netsuite_email = ' example,second@example.com '
     transformed_netsuite_email = NetSuiteRails::Transformations.email(netsuite_email, :push)
     expect(transformed_netsuite_email.to_s).to eq('examplesecond@example.com')
+
+    netsuite_email = 'boom.@gmail.com'
+    transformed_netsuite_email = NetSuiteRails::Transformations.email(netsuite_email, :push)
+    expect(transformed_netsuite_email.to_s).to eq('boom@gmail.com')
+  end
+
+  it 'truncates gift card code' do
+    code = Faker::Lorem.characters(10)
+    expect(NetSuiteRails::Transformations.gift_card_code(code, :push).size).to eq(9)
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: netsuite_rails
 version: !ruby/object:Gem::Version
-  version: 0.3.5
+  version: 0.3.6
 platform: ruby
 authors:
 - Michael Bianco
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-28 00:00:00.000000000 Z
+date: 2017-03-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: netsuite