netsuite_rails 0.3.4 → 0.3.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f2f2197544aa8884365eda94c0b6d23069430e0e
-  data.tar.gz: 65012b398bc868048b9de452df38820ac102f383
+  metadata.gz: e4bc78784fc838d1ba5ca38b3d83ce0f0007bde4
+  data.tar.gz: dbdf80d06619156e86871566b1b4e7e728d8571b
 SHA512:
-  metadata.gz: c486c007a6d97f0633e82a2d37a7b57321de8115e0a99c80331978b86137b649820bc7bd28c17c6223adfaca23ccf11c1df2fcf2cc1dca4f8409362cdce2b6f2
-  data.tar.gz: 87ef0a329e7ed7af87244d1b058dde0f390e5d887628dc200ee0f49c8d79f4aec525c879da73111003ced628549294d35261315adf0c453e0c0d27264b073423
+  metadata.gz: b246f111c66ac0c86d53c4b7164ace112a2fc22fe15ba664efd13063d59d149ba01824e484664995c28431e14fc0133c451b3389550fe0a9a7c1541cf962b08e
+  data.tar.gz: 60923ddc839b756f3a563e00e65138d5b4bd9003b200edc30111289f8ed75150b5164bdc9bbc00e5c6897c09195d19257ff5a521f52e4317ecb5c39b9a5bbc3f

data/lib/netsuite_rails/record_sync/push_manager.rb

@@ -252,7 +252,7 @@ module NetSuiteRails
         end
 
         def is_active_record_model?(local_record)
-          local_record.class.ancestors.include?(ActiveRecord::Base)
+          defined?(::ActiveRecord::Base) && local_record.class.ancestors.include?(ActiveRecord::Base)
         end
 
       end

data/lib/netsuite_rails/record_sync.rb

@@ -200,7 +200,7 @@ module NetSuiteRails
             netsuite_record.send(netsuite_field)
           end
 
-          if field_value.blank?
+          if field_value.nil?
             # TODO possibly nil out the local value?
             next
           end
@@ -218,7 +218,7 @@ module NetSuiteRails
 
           # TODO should we just check for nil? vs present?
 
-          if field_hints.has_key?(local_field) && field_value.present?
+          if field_hints.has_key?(local_field) && !field_value.nil?
             field_value = NetSuiteRails::Transformations.transform(field_hints[local_field], field_value, :pull)
           end
 

data/lib/netsuite_rails/routines/company_contact_match.rb

@@ -3,8 +3,7 @@ module NetSuiteRails
     module CompanyContactMatch
       extend self
 
-      def match(company_customer, contact_data)
-        # TODO set page size to a large number for this search
+      def match(company_customer, contact_data, update_contact_name: false, update_contact_email: false)
         search = NetSuite::Records::Contact.search({
           customerJoin: [
             {
@@ -14,13 +13,17 @@ module NetSuiteRails
                 NetSuite::Records::Customer.new(internal_id: company_customer.internal_id)
               ]
             }
-          ]
+          ],
+
+          preferences: {
+            page_size: 1_000
+          }
         })
 
         match_data = {
-          email: contact_data[:email].dup,
-          first_name: contact_data[:first_name].dup,
-          last_name: contact_data[:last_name].dup
+          email: (contact_data[:email] || '').dup,
+          first_name: (contact_data[:first_name] || '').dup,
+          last_name: (contact_data[:last_name] || '').dup
         }
 
         match_data.
@@ -38,6 +41,13 @@ module NetSuiteRails
           # if no email match & name data is present try fuzzy matching
           if match_data[:first_name] && match_data[:last_name] && !contact_first_name.empty? && !contact_last_name.empty?
 
+            # TODO add logging for these interactions with NetSuite
+            if update_contact_email && order_payload[:email].present? && contact.email != order_payload[:email]
+              if !result.update(email: order_payload[:email])
+                raise "error updating email on contact"
+              end
+            end
+
             # TODO consider `self.fuzzy_name_matches?(contact_first_name, contact_last_name, match_data[:first_name], match_data[:last_name])`
             if contact_first_name == match_data[:first_name] && contact_last_name == match_data[:last_name]
               return contact
@@ -46,29 +56,31 @@ module NetSuiteRails
         end
 
         # try email match second
-        # search.results.each do |contact|
-        #   contact_first_name = contact.first_name.downcase.strip rescue ''
-        #   contact_last_name = contact.last_name.downcase.strip rescue ''
-
-        #   # match on email
-        #   if match_data[:email] && contact.email && contact.email.downcase.strip == match_data[:email]
-        #     if match_data[:first_name] != contact_first_name || match_data[:last_name] != contact_last_name
-        #       # first name and/or last name did not match the input, update contact information
-
-        #       result = contact.update(
-        #         # use the first & last name from the payload; the match_data versions have been transformed
-        #         first_name: order_payload[:shipping_address][:firstname],
-        #         last_name: order_payload[:shipping_address][:lastname]
-        #       )
-
-        #       unless result
-        #         raise 'error updating name on contact placing order'
-        #       end
-        #     end
-
-        #     return contact
-        #   end
-        # end
+        search.results.each do |contact|
+          contact_first_name = contact.first_name.downcase.strip rescue ''
+          contact_last_name = contact.last_name.downcase.strip rescue ''
+
+          # match on email
+          if match_data[:email] && contact.email && contact.email.downcase.strip == match_data[:email]
+            if match_data[:first_name] != contact_first_name || match_data[:last_name] != contact_last_name
+              # first name and/or last name did not match the input, update contact information
+
+              if update_contact_name
+                result = contact.update(
+                  # use the first & last name from the payload; the match_data versions have been transformed
+                  first_name: order_payload[:shipping_address][:firstname],
+                  last_name: order_payload[:shipping_address][:lastname]
+                )
+
+                unless result
+                  raise 'error updating name on contact placing order'
+                end
+              end
+            end
+
+            return contact
+          end
+        end
 
         nil
       end

data/lib/netsuite_rails/transformations.rb

@@ -30,6 +30,11 @@ module NetSuiteRails
           # eliminate the extension if the number is still too long
           formatted_phone.gsub!(/x.*$/, '') if formatted_phone.size > 22
 
+          # phone numbers less than 7 digits throw a fatal error
+          if formatted_phone.size < 7
+            return nil
+          end
+
           formatted_phone
         else
           phone

data/netsuite_rails.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |s|
   s.name          = "netsuite_rails"
-  s.version       = "0.3.4"
+  s.version       = "0.3.5"
   s.authors       = ["Michael Bianco"]
   s.email         = ["mike@cliffsidemedia.com"]
   s.summary       = %q{Write Rails applications that integrate with NetSuite}

data/spec/models/record_sync_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 describe NetSuiteRails::RecordSync do
   include ExampleModels
-  
+
   context 'custom records' do
     it "should properly pull the NS rep" do
       allow(NetSuite::Records::CustomRecord).to receive(:get).with(hash_including(:internal_id => 234, type_id: 123))
@@ -13,4 +13,24 @@ describe NetSuiteRails::RecordSync do
       expect(NetSuite::Records::CustomRecord).to have_received(:get)
     end
   end
+
+  it 'properly extracts common record types' do
+    fake_customer_data = {
+      :is_inactive => false,
+      :phone => "123 456 7891",
+      :company_name => "Great Company",
+      :email => nil
+    }
+
+    expect(NetSuite::Records::Customer).to receive(:get)
+      .and_return(NetSuite::Records::Customer.new(fake_customer_data))
+
+    standard_record = StandardRecord.new netsuite_id: 123
+    standard_record.netsuite_pull
+
+    expect(standard_record.is_deleted).to eq(false)
+    expect(standard_record.phone).to eq(fake_customer_data[:phone])
+    expect(standard_record.company).to eq(fake_customer_data[:company_name])
+    expect(standard_record.email).to eq(fake_customer_data[:email])
+  end
 end

data/spec/models/routines_spec.rb

@@ -0,0 +1,23 @@
+require 'spec_helper'
+
+# TODO https://github.com/NetSweet/netsuite_rails/issues/16
+# there are still some unresolved issues with NS datetime/date conversions
+# the tests + implementation may still not be correct.
+
+describe NetSuiteRails::Routines do
+  describe '#company_contact_match' do
+    it "matches on first and last name first" do
+
+    end
+
+    it "matches on email if no name match is found" do
+
+    end
+
+    it "returns nil if no match is found" do
+
+    end
+
+    # TODO also handle updating contact information
+  end
+end

data/spec/models/transformations_spec.rb

@@ -13,6 +13,12 @@ describe NetSuiteRails::Transformations do
     NetSuiteRails::Configuration.netsuite_instance_time_zone_offset -6
   end
 
+  it 'nils out short phone numbers' do
+    short_phone_number = '  301908  '
+
+    expect(NetSuiteRails::Transformations.phone(short_phone_number)).to be_nil
+  end
+
   it 'handles very long phone numbers' do
     long_phone_number = '+1 (549)-880-4834 ext. 51077'
 

data/spec/support/example_models.rb

@@ -4,18 +4,20 @@ module ExampleModels
     example_group.class_eval do
       before do
 
-        define_model :standard_record, phone: :string, netsuite_id: :integer do
+        define_model :standard_record, email: :string, company: :string, phone: :string, netsuite_id: :integer, is_deleted: :boolean do
           include NetSuiteRails::RecordSync
 
           netsuite_record_class NetSuite::Records::Customer
           netsuite_sync :read_write
           netsuite_field_map({
+            :is_deleted => :is_inactive,
             :phone => :phone,
             :company => Proc.new do |local, netsuite, direction|
+              # NOTE this could be done by a simple mapping!
               if direction == :push
-
+                netsuite.company_name = local.company
               else
-
+                local.company = netsuite.company_name
               end
             end
           })

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: netsuite_rails
 version: !ruby/object:Gem::Version
-  version: 0.3.4
+  version: 0.3.5
 platform: ruby
 authors:
 - Michael Bianco
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-31 00:00:00.000000000 Z
+date: 2016-07-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: netsuite
@@ -122,6 +122,7 @@ files:
 - spec/models/poll_trigger_spec.rb
 - spec/models/record_sync/push_manager_spec.rb
 - spec/models/record_sync_spec.rb
+- spec/models/routines_spec.rb
 - spec/models/spec_helper_spec.rb
 - spec/models/sync_trigger_spec.rb
 - spec/models/transformations_spec.rb
@@ -162,6 +163,7 @@ test_files:
 - spec/models/poll_trigger_spec.rb
 - spec/models/record_sync/push_manager_spec.rb
 - spec/models/record_sync_spec.rb
+- spec/models/routines_spec.rb
 - spec/models/spec_helper_spec.rb
 - spec/models/sync_trigger_spec.rb
 - spec/models/transformations_spec.rb