netsuite 0.8.11 → 0.8.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6137faebee57aa9e3bdaa9cca35d82765f5e9943075eb09bc8bd867b1893ad6b
-  data.tar.gz: 8ee0308ee67c2dcd440ea17a1107220e394b5b1e15829f76b47ca2769d4be9f2
+  metadata.gz: 6f61f6e044bec13cb11de64e320044febb52108b63214d28cb6446ae98e172f9
+  data.tar.gz: 93a84083918815d7407a1464a4462a448f35751a37d1972cc6ff35b518a17ff7
 SHA512:
-  metadata.gz: a297cc64a543bdf34c086432c78a36b038205998794ae67a968c3c9bdd506a99bfd7a1048bb8aec821fd2edd1c2d89ce715719f035e1a09e5f4b38b560df98b6
-  data.tar.gz: a536956ed7da89d0fa0e7ec2dcaeba3539ec5dcbddbb3c9249a3b17b93caadaa13b9cba9b7cbe6f0a9b9de786541e4bc190e2771bef03c6cec71d1881c79f7e9
+  metadata.gz: 914d9e8b9effdfc2815de7907404d89b9ddf71b03ab08a78f95c762de470a63f5c51c4af138bc326cad2757ce0e5e076cbd0695330794c324d1e224d1ab04b17
+  data.tar.gz: ba72989cd165db27b6420b4b09e93c2aec018bf27e10b516872068cebf20c2405dd17d4015f45beeb274f8d27bc1db7e8d0074795c03c8ae070a9e2ec08dd5b0

data/.github/workflows/codeql-analysis.yml

@@ -38,7 +38,7 @@ jobs:
 
     steps:
     - name: Checkout repository
-      uses: actions/checkout@v2
+      uses: actions/checkout@v3
 
     # Initializes the CodeQL tools for scanning.
     - name: Initialize CodeQL

data/HISTORY.md

@@ -4,6 +4,15 @@
 
 ### Fixed
 
+## 0.8.12
+
+### Added
+
+* Add NullFieldList record (to credit memos and invoices) (#529)
+* Add `get_deleted` action to item records (#530)
+* Add `get_deleted` action to Employee records (#531)
+* Remove monkey patched `lower_camelcase` method on String (#533)
+
 ## 0.8.11
 
 ### Added

data/README.md

@@ -4,13 +4,13 @@
 
 # NetSuite SuiteTalk API Ruby Gem
 
-* This gem will act as a wrapper around the NetSuite SuiteTalk WebServices API.
+* This gem will act as a wrapper around the NetSuite SuiteTalk Web Services API.
 * The gem does not cover the entire API, only the subset contributors have used so far. Please submit a PR for any functionality that's missing!
 * NetSuite is a complex system. There's a lot to learn and sparse resources available to learn from. Here's a list of [NetSuite Development Resources](https://github.com/NetSweet/netsuite/wiki/NetSuite-Development-Resources).
 
 # Help & Support
 
-Join the [slack channel](http://opensuite-slackin.herokuapp.com) for help with any NetSuite issues. Please do not post usage questions as issues in GitHub.
+Join the [Slack channel](http://opensuite-slackin.herokuapp.com) for help with any NetSuite issues. Please do not post usage questions as issues in GitHub.
 
 There is some additional helpful resources for NetSuite development [listed here](https://dashboard.suitesync.io/docs/resources#netsuite).
 
@@ -36,20 +36,20 @@ gem 'netsuite'
 
 If you'd like more accurate time conversion support, include the `tzinfo` gem.
 
-This gem is built for ruby 2.6.x+, but should work on older versions down to 1.9. There's a [1-8-stable](https://github.com/NetSweet/netsuite/tree/1-8-stable) branch for ruby 1.8.x support.
+This gem is built for Ruby 2.6.x+, but should work on older versions down to 1.9. There's a [1-8-stable](https://github.com/NetSweet/netsuite/tree/1-8-stable) branch for Ruby 1.8.x support.
 
 ## Configuration
 
-The most important thing you'll need is your NetSuite account ID. Not sure how to find your account id? [Here's a guide.](http://mikebian.co/find-netsuite-web-services-account-number/)
+The most important thing you'll need is your NetSuite account ID. Not sure how to find your account ID? [Here's a guide.](http://mikebian.co/find-netsuite-web-services-account-number/)
 
 How you connect to NetSuite has changed a lot over the years and differs between API versions. For instance:
 
 * Older API versions (~2015) allowed authentication via username and password
-* Newever API versions (> 2016) still allowed for username and password authentication, but required an application ID
+* Newer API versions (> 2016) still allowed for username and password authentication, but required an application ID
 * "OAuth", which requires four separate keys to be manually generated, was supported sometime after 2015
 * API versions greater than 2018_2 require `endpoint` to be set directly ([more info](https://github.com/NetSweet/netsuite/pull/473))
 
-Here's an example connection configuration. You don't want to actually use username + password config; token based authentication is detailed below in a separate section:
+Here's an example connection configuration. You don't want to actually use username + password config; Token Based Authentication is detailed [in a separate section](#token-based-authentication):
 
 ```ruby
 NetSuite.configure do
@@ -60,13 +60,13 @@ NetSuite.configure do
   api_version '2018_2'
 
   # password-based login information
-  # in most cases you should use token based authentication instead
+  # in most cases you should use Token Based Authentication instead
   email 'email@example.com'
   password 'password'
   role 10
 
-  # recent API versions require a account-specific endpoint o be set
-  # use `NetSuite::Utilities.data_center_url('TSTDRV1576318')` to retrieve wsdl URL
+  # recent API versions require an account-specific endpoint to be set
+  # use `NetSuite::Utilities.data_center_url('TSTDRV1576318')` to retrieve WSDL URL
   # you'll want to do this in a background process and strip the protocol out of the return string
   wsdl_domain 'tstdrv1576318.suitetalk.api.netsuite.com'
 
@@ -87,17 +87,17 @@ NetSuite.configure do
 
   api_version	'2018_2'
 
-  # optionally specify full wsdl URL (to switch to sandbox, for example)
+  # optionally specify full WSDL URL (to switch to sandbox, for example)
   wsdl          "https://webservices.sandbox.netsuite.com/wsdl/v#{api_version}_0/netsuite.wsdl"
 
-  # if your datacenter is being switched, you'll have to manually set your wsdl location
+  # if your datacenter is being switched, you'll have to manually set your WSDL location
   wsdl          "https://webservices.na2.netsuite.com/wsdl/v#{api_version}_0/netsuite.wsdl"
 
   # or specify the wsdl_domain if you want to specify the datacenter and let the configuration
   # construct the full wsdl location - e.g. "https://#{wsdl_domain}/wsdl/v#{api_version}_0/netsuite.wsdl"
   wsdl_domain   "webservices.na2.netsuite.com"
 
-  # often the netsuite servers will hang which would cause a timeout exception to be raised
+  # often the NetSuite servers will hang which would cause a timeout exception to be raised
   # if you don't mind waiting (e.g. processing NS via a background worker), increasing the timeout should fix the issue
   read_timeout  100_000
 
@@ -111,7 +111,7 @@ NetSuite.configure do
   # log_level   :debug
 
   # password-based login information
-  # in most cases you should use token based authentication instead
+  # in most cases you should use Token Based Authentication instead
   email    	  'email@domain.com'
   password 	  'password'
   account   	'12345'
@@ -124,7 +124,7 @@ NetSuite.configure do
 end
 ```
 
-If are using username + password authentication (which you shouldn't be!) *and* you'd like to use a API endpoints greater than 2015_1 you'll need to specify an application ID:
+If you are using username + password authentication (which you shouldn't be!) *and* you'd like to use an API endpoint greater than 2015_1, you'll need to specify an application ID:
 
 ```ruby
 NetSuite::Configuration.soap_header = {
@@ -134,9 +134,9 @@ NetSuite::Configuration.soap_header = {
 }
 ```
 
-### Token based Authentication
+### Token Based Authentication
 
-OAuth credentials are supported and the recommended authentication approach. [Learn more about how to set up token based authentication here](http://mikebian.co/using-netsuites-token-based-authentication-with-suitetalk/).
+OAuth credentials are supported and the recommended authentication approach. [Learn more about how to set up Token Based Authentication here](http://mikebian.co/using-netsuites-token-based-authentication-with-suitetalk/).
 
 ```ruby
 NetSuite.configure do
@@ -152,7 +152,7 @@ NetSuite.configure do
   # oauth does not work with API versions less than 2015_2
   api_version      '2016_2'
 
-  # the endpoint indicated in the > 2018_2 wsdl is invalid
+  # the endpoint indicated in the > 2018_2 WSDL is invalid
   # you must set the endpoint directly
   # https://github.com/NetSweet/netsuite/pull/473
   endpoint "https://#{wsdl_domain}/services/NetSuitePort_#{api_version}"
@@ -284,6 +284,20 @@ NetSuite::Records::BaseRefList.get_select_value(
 )
 ```
 
+## Null Fields
+
+```ruby
+# updating a field on a record to be null
+invoice = NetSuite::Records::Invoice.get(12345)
+invoice.update(null_field_list: 'shipMethod')
+
+# updating multiple fields on a record to be null
+invoice.update(null_field_list: ['shipAddressList', 'shipMethod'])
+
+# updating a custom fields on a record to be null, using custom field ID
+invoice.update(null_field_list: 'custBody9')
+```
+
 ## Searching
 
 ```ruby
@@ -300,7 +314,7 @@ search = NetSuite::Records::Customer.search({
 
 `open https://system.netsuite.com/app/common/entity/custjob.nl?id=#{search.results.first.internal_id}`
 
-# find the avalara tax item. Some records don't support search.
+# find the Avalara tax item. Some records don't support search.
 all_sales_taxes = NetSuite::Utilities.backoff { NetSuite::Records::SalesTaxItem.get_all }
 ns_tax_code = all_sales_taxes.detect { |st| st.item_id == 'AVATAX' }
 
@@ -411,13 +425,13 @@ NetSuite::Records::SalesOrder.search({
     ]
   },
 
-  # the column syntax is a WIP. This will change in the future
+  # the column syntax is a WIP. This will change in the future.
   columns: {
     'tranSales:basic' => [
       'platformCommon:internalId/' => {},
       'platformCommon:email/' => {},
       'platformCommon:tranDate/' => {},
-      # If you include columns that are only part of the *SearchRowBasic (ie. TransactionSearchRowBasic), 
+      # If you include columns that are only part of the *SearchRowBasic (ie. TransactionSearchRowBasic),
       # they'll be readable on the resulting record just like regular fields (my_record.close_date).
       'platformCommon:closeDate/' => {}
     ],
@@ -593,6 +607,53 @@ deposit.payment = 20
 deposit.add
 ```
 
+## Getting Deleted Records
+
+```ruby
+response = NetSuite::Records::LotNumberedInventoryItem.get_deleted({
+  criteria: [
+    {
+      # If you don't specify a type criteria, you'll get all deleted records,
+      # regardless of the type of record you called this on.
+      field: 'type',
+      operator: 'anyOf',
+      value: 'lotNumberedInventoryItem',
+    }
+  ],
+})
+
+Array(response.body.fetch(:deleted_record_list)).first
+# => {
+#      :deleted_date => Wed, 16 Feb 2022 17:43:45 -0800,
+#      :record => {
+#        :name => "My Item",
+#        :@internal_id => "12485",
+#        :@type => "lotNumberedInventoryItem",
+#        :"@xsi:type" => "platformCore:RecordRef"
+#      }
+#    }
+
+# deleted_record_list could be:
+#   nil - No records matching criteria were deleted
+#   Hash - A single record matching criteria was deleted
+#   Array - Multiple records matching criteria were deleted
+
+# Simple pagination
+page = 1
+begin
+  response = NetSuite::Records::LotNumberedInventoryItem.get_deleted({
+    criteria: [
+      # your criteria
+    ],
+    page: page,
+  })
+
+  # Do your thing with response.body.fetch(:deleted_record_list)
+
+  page += 1
+end until page > Integer(response.fetch(:total_pages))
+```
+
 ## Non-standard Operations
 
 ```ruby

data/lib/netsuite/actions/delete.rb

@@ -21,7 +21,7 @@ module NetSuite
       end
 
       def soap_type
-        @object.class.to_s.split('::').last.lower_camelcase
+        NetSuite::Support::Records.netsuite_type(@object)
       end
 
       # <soap:Body>

data/lib/netsuite/actions/delete_list.rb

@@ -40,7 +40,7 @@ module NetSuite
             }
           end
         else
-          type = @klass.to_s.split('::').last.lower_camelcase
+          type = NetSuite::Support::Records.netsuite_type(@klass)
           record_type = 'platformCore:RecordRef'
 
           list.map do |internal_id|

data/lib/netsuite/actions/get.rb

@@ -21,7 +21,7 @@ module NetSuite
       end
 
       def soap_type
-        @klass.to_s.split('::').last.lower_camelcase
+        NetSuite::Support::Records.netsuite_type(@klass)
       end
 
       # <soap:Body>

data/lib/netsuite/actions/get_deleted.rb

@@ -20,7 +20,7 @@ module NetSuite
       end
 
       def soap_type
-        @object.class.to_s.split('::').last.lower_camelcase
+        NetSuite::Support::Records.netsuite_type(@object)
       end
 
       # <soap:Body>

data/lib/netsuite/actions/get_list.rb

@@ -33,7 +33,7 @@ module NetSuite
             }
           end
         else
-          type = @klass.to_s.split('::').last.lower_camelcase
+          type = NetSuite::Support::Records.netsuite_type(@klass)
           record_type = 'platformCore:RecordRef'
 
           list.map do |internal_id|

data/lib/netsuite/actions/initialize.rb

@@ -28,12 +28,12 @@ module NetSuite
       def request_body
         {
           'platformMsgs:initializeRecord' => {
-            'platformCore:type'      => @klass.to_s.split('::').last.lower_camelcase,
+            'platformCore:type'      => NetSuite::Support::Records.netsuite_type(@klass),
             'platformCore:reference' => {},
             :attributes!             => {
               'platformCore:reference' => {
                 'internalId' => @object.internal_id,
-                :type        => @object.class.to_s.split('::').last.lower_camelcase
+                :type        => NetSuite::Support::Records.netsuite_type(@object)
               }
             }
           }

data/lib/netsuite/actions/search.rb

@@ -26,7 +26,7 @@ module NetSuite
           .update(NetSuite::Configuration.soap_header)
           .merge(
             (@options.delete(:preferences) || {}).inject({'platformMsgs:SearchPreferences' => {}}) do |h, (k, v)|
-              h['platformMsgs:SearchPreferences'][k.to_s.lower_camelcase] = v
+              h['platformMsgs:SearchPreferences'][NetSuite::Utilities::Strings.lower_camelcase(k.to_s)] = v
               h
             end
           )

data/lib/netsuite/records/assembly_item.rb

@@ -7,7 +7,7 @@ module NetSuite
       include Support::Actions
       include Namespaces::ListAcct
 
-      actions :get, :get_list, :get_select_value, :add, :delete, :update, :upsert, :upsert_list, :search
+      actions :get, :get_deleted, :get_list, :get_select_value, :add, :delete, :update, :upsert, :upsert_list, :search
 
       fields :auto_lead_time, :auto_preferred_stock_level, :auto_reorder_point, :available_to_partners, :average_cost, :build_entire_assembly,
         :copy_description, :cost, :cost_estimate, :cost_estimate_type, :cost_estimate_units, :cost_units, :costing_method,

data/lib/netsuite/records/cash_refund_item.rb

@@ -6,7 +6,7 @@ module NetSuite
       include Support::Records
       include Namespaces::TranCust
 
-      fields :amount, :rate, :quantity, :is_taxable, :order_line, :line, :description
+      fields :amount, :gross_amt, :rate, :quantity, :is_taxable, :order_line, :line, :description
       field :custom_field_list,    CustomFieldList
 
       record_refs :item, :klass, :price

data/lib/netsuite/records/credit_memo.rb

@@ -23,6 +23,7 @@ module NetSuite
       field :item_list,                CreditMemoItemList
       field :apply_list,               CreditMemoApplyList
       field :ship_group_list,          SalesOrderShipGroupList
+      field :null_field_list,          NullFieldList
 
       # field :bill_address_list,
       field :transaction_bill_address, BillAddress

data/lib/netsuite/records/description_item.rb

@@ -7,12 +7,12 @@ module NetSuite
       include Support::Actions
       include Namespaces::ListAcct
 
-      actions :get, :get_list, :add, :delete, :search, :update, :upsert
+      actions :get, :get_deleted, :get_list, :add, :delete, :search, :update, :upsert
 
       fields  :available_to_partners, :created_date, :description, :display_name, :include_children, :is_inactive, :item_id, :last_modified_date
 
       record_refs :custom_form, :department, :issue_product, :klass, :location
-      
+
       field :custom_field_list, CustomFieldList
       field :subsidiary_list, RecordRefList
       field :translations_list, TranslationList

data/lib/netsuite/records/discount_item.rb

@@ -7,7 +7,7 @@ module NetSuite
       include Support::Actions
       include Namespaces::ListAcct
 
-      actions :get, :get_list, :add, :update, :delete, :search, :upsert
+      actions :get, :get_deleted, :get_list, :add, :update, :delete, :search, :upsert
 
       fields :available_to_partners, :created_date, :description, :display_name, :include_children, :is_inactive, :is_pre_tax,
         :item_id, :last_modified_date, :non_posting, :rate, :upc_code, :vendor_name

data/lib/netsuite/records/employee.rb

@@ -9,7 +9,7 @@ module NetSuite
 
       # https://system.netsuite.com/help/helpcenter/en_US/srbrowser/Browser2014_1/script/record/employee.html
 
-      actions :get, :get_list, :add, :update, :upsert, :upsert_list, :delete, :search
+      actions :get, :get_deleted, :get_list, :add, :update, :upsert, :upsert_list, :delete, :search
 
       fields :alt_name, :phone, :first_name, :last_name, :is_inactive, :email, :give_access, :send_email, :is_support_rep,
              :birth_date, :hire_date, :last_review_date, :next_review_date, :title, :home_phone, :office_phone,

data/lib/netsuite/records/inventory_item.rb

@@ -20,7 +20,7 @@ module NetSuite
       #     }
       #  ]
       #
-      actions :get, :get_list, :add, :delete, :search, :update, :upsert, :update_list
+      actions :get, :get_deleted, :get_list, :add, :delete, :search, :update, :upsert, :update_list
 
       fields :auto_lead_time,
             :auto_preferred_stock_level,

data/lib/netsuite/records/invoice.rb

@@ -38,6 +38,7 @@ module NetSuite
       field :custom_field_list,        CustomFieldList
       field :shipping_address,         Address
       field :billing_address,          Address
+      field :null_field_list,          NullFieldList
 
       read_only_fields :sub_total, :discount_total, :total, :recognized_revenue, :amount_remaining, :amount_paid,
                        :alt_shipping_cost, :gift_cert_applied, :handling_cost, :alt_handling_cost

data/lib/netsuite/records/item_group.rb

@@ -7,13 +7,13 @@ module NetSuite
       include Support::Actions
       include Namespaces::ListAcct
 
-      actions :get, :get_list, :add, :delete, :search, :update, :upsert
+      actions :get, :get_deleted, :get_list, :add, :delete, :search, :update, :upsert
 
       fields :available_to_partners, :created_date, :description, :display_name, :include_children, :include_start_end_lines,
              :is_inactive, :is_vsoe_bundle, :item_id, :last_modified_date, :print_items, :upc_code, :vendor_name
 
       record_refs :custom_form, :default_item_ship_method, :department, :issue_product, :item_ship_method_list, :klass, :location, :parent
-      
+
       field :custom_field_list, CustomFieldList
       # TODO field :item_carrier, ShippingCarrier
       field :member_list, ItemMemberList

data/lib/netsuite/records/kit_item.rb

@@ -7,7 +7,7 @@ module NetSuite
       include Support::Actions
       include Namespaces::ListAcct
 
-      actions :get, :get_list, :add, :delete, :search, :update, :upsert
+      actions :get, :get_deleted, :get_list, :add, :delete, :search, :update, :upsert
 
       fields :available_to_partners, :cost_estimate, :created_date, :defer_rev_rec, :description, :display_name,
         :dont_show_price, :enforce_min_qty_internally, :exclude_from_sitemap, :featured_description, :handling_cost,

data/lib/netsuite/records/lot_numbered_assembly_item.rb

@@ -7,7 +7,7 @@ module NetSuite
       include Support::Actions
       include Namespaces::ListAcct
 
-      actions :get, :get_list, :get_select_value, :add, :delete, :update, :upsert, :upsert_list, :search
+      actions :get, :get_deleted, :get_list, :get_select_value, :add, :delete, :update, :upsert, :upsert_list, :search
 
       fields :auto_lead_time, :auto_preferred_stock_level, :auto_reorder_point, :available_to_partners, :average_cost, :build_entire_assembly,
         :copy_description, :cost, :cost_estimate, :cost_estimate_type, :cost_estimate_units, :cost_units, :costing_method,

data/lib/netsuite/records/lot_numbered_inventory_item.rb

@@ -27,7 +27,7 @@ module NetSuite
       # TODO: field :site_category_list, SiteCategoryList
       field :translations_list, TranslationList
 
-      actions :get, :get_list, :add, :delete, :search, :update, :upsert, :update_list
+      actions :get, :get_deleted, :get_list, :add, :delete, :search, :update, :upsert, :update_list
 
       record_refs :alternate_demand_source_item,
                   :asset_account,

data/lib/netsuite/records/non_inventory_purchase_item.rb

@@ -7,7 +7,7 @@ module NetSuite
       include Support::Actions
       include Namespaces::ListAcct
 
-      actions :get, :get_list, :add, :delete, :search, :upsert
+      actions :get, :get_deleted, :get_list, :add, :delete, :search, :upsert
 
       fields :available_to_partners, :cost_estimate, :cost_estimate_type, :cost_estimate_units, :country_of_manufacture,
         :created_date, :display_name, :dont_show_price, :enforce_min_qty_internally, :exclude_from_sitemap,

data/lib/netsuite/records/non_inventory_resale_item.rb

@@ -7,7 +7,7 @@ module NetSuite
       include Support::Actions
       include Namespaces::ListAcct
 
-      actions :get, :get_list, :add, :delete, :search, :upsert, :update
+      actions :get, :get_deleted, :get_list, :add, :delete, :search, :upsert, :update
 
       fields :amortization_period,
             :available_to_partners,

data/lib/netsuite/records/non_inventory_sale_item.rb

@@ -7,7 +7,7 @@ module NetSuite
       include Support::Actions
       include Namespaces::ListAcct
 
-      actions :get, :get_list, :add, :delete, :search, :update, :upsert
+      actions :get, :get_deleted, :get_list, :add, :delete, :search, :update, :upsert
 
       fields :available_to_partners,
             :contingent_revenue_handling,

data/lib/netsuite/records/null_field_list.rb

@@ -0,0 +1,15 @@
+module NetSuite
+  module Records
+    class NullFieldList
+      include Support::Fields
+      include Support::Records
+      include Namespaces::PlatformCore
+
+      fields :name
+
+      def initialize(attributes = {})
+        initialize_from_attributes_hash(attributes)
+      end
+    end
+  end
+end

data/lib/netsuite/records/other_charge_sale_item.rb

@@ -7,7 +7,7 @@ module NetSuite
       include Support::Actions
       include Namespaces::ListAcct
 
-      actions :get, :get_list, :add, :update, :delete, :upsert, :search
+      actions :get, :get_deleted, :get_list, :add, :update, :delete, :upsert, :search
 
       attr_reader   :internal_id
       attr_accessor :external_id

data/lib/netsuite/records/payment_item.rb

@@ -7,7 +7,7 @@ module NetSuite
       include Support::Actions
       include Namespaces::ListAcct
 
-      actions :get, :get_list, :add, :delete, :search, :update, :upsert
+      actions :get, :get_deleted, :get_list, :add, :delete, :search, :update, :upsert
 
       fields :available_to_partners, :created_date, :description, :display_name, :include_children, :is_inactive, :item_id, :last_modified_date, :undep_funds
 
@@ -15,7 +15,7 @@ module NetSuite
 
       field :custom_field_list, CustomFieldList
       field :subsidiary_list, RecordRefList
-      
+
       # TODO custom records need to be implemented
       field :translations_list, TranslationList
 

data/lib/netsuite/records/record_ref.rb

@@ -21,7 +21,7 @@ module NetSuite
           record = attributes_or_record
           @internal_id = record.internal_id if record.respond_to?(:internal_id)
           @external_id = record.external_id if record.respond_to?(:external_id)
-          @type        = record.class.to_s.split('::').last.lower_camelcase
+          @type        = NetSuite::Support::Records.netsuite_type(record)
         end
       end
 

data/lib/netsuite/records/serialized_assembly_item.rb

@@ -7,7 +7,7 @@ module NetSuite
       include Support::Actions
       include Namespaces::ListAcct
 
-      actions :get, :get_list, :add, :delete, :search, :update, :upsert
+      actions :get, :get_deleted, :get_list, :add, :delete, :search, :update, :upsert
 
       fields :alternate_demand_source_item,
         :asset_account,

data/lib/netsuite/records/serialized_inventory_item.rb

@@ -7,7 +7,7 @@ module NetSuite
       include Support::Actions
       include Namespaces::ListAcct
 
-      actions :get, :get_list, :add, :delete, :search, :update, :upsert
+      actions :get, :get_deleted, :get_list, :add, :delete, :search, :update, :upsert
 
       record_refs :soft_descriptor,
         :stock_unit,

data/lib/netsuite/records/service_resale_item.rb

@@ -7,7 +7,7 @@ module NetSuite
       include Support::Actions
       include Namespaces::ListAcct
 
-      actions :get, :get_list, :add, :update, :delete, :upsert, :search
+      actions :get, :get_deleted, :get_list, :add, :update, :delete, :upsert, :search
 
       fields :amortization_period,
             :available_to_partners,

data/lib/netsuite/records/service_sale_item.rb

@@ -7,7 +7,7 @@ module NetSuite
       include Support::Actions
       include Namespaces::ListAcct
 
-      actions :get, :get_list, :add, :update, :delete, :upsert, :search
+      actions :get, :get_deleted, :get_list, :add, :update, :delete, :upsert, :search
 
       fields :available_to_partners, :cost_estimate, :cost_estimate_type, :cost_estimate_units, :create_job, :created_date,
         :display_name, :dont_show_price, :enforce_min_qty_internally, :exclude_from_sitemap, :featured_description,

data/lib/netsuite/records/subtotal_item.rb

@@ -7,12 +7,12 @@ module NetSuite
       include Support::Actions
       include Namespaces::ListAcct
 
-      actions :get, :get_list, :add, :delete, :search, :update, :upsert
+      actions :get, :get_deleted, :get_list, :add, :delete, :search, :update, :upsert
 
       fields :available_to_partners, :created_date, :description, :include_children, :is_inactive, :item_id, :last_modified_date
 
       record_refs :custom_form, :department, :issue_product, :klass, :location
-      
+
       field :custom_field_list, CustomFieldList
       field :subsidiary_list, RecordRefList
       field :translations_list, TranslationList
@@ -32,4 +32,3 @@ module NetSuite
     end
   end
 end
-		

data/lib/netsuite/support/records.rb

@@ -6,8 +6,8 @@ module NetSuite
 
       def to_record
         attributes.reject { |k,v| self.class.read_only_fields.include?(k) || self.class.search_only_fields.include?(k) }.inject({}) do |hash, (k,v)|
-          kname = "#{record_namespace}:"
-          kname += k == :klass ? 'class' : k.to_s.lower_camelcase
+          kname = "#{v.is_a?(NetSuite::Records::NullFieldList) ? v.record_namespace : record_namespace}:"
+          kname += k == :klass ? 'class' : NetSuite::Utilities::Strings.lower_camelcase(k.to_s)
 
           to_attributes!(hash, kname, v)
 
@@ -38,13 +38,13 @@ module NetSuite
         if v.kind_of?(NetSuite::Records::RecordRef) && v.type
           hash[:attributes!] ||= {}
           hash[:attributes!][kname] ||= {}
-          hash[:attributes!][kname]['type'] = v.type.lower_camelcase
+          hash[:attributes!][kname]['type'] = NetSuite::Utilities::Strings.lower_camelcase(v.type)
         end
 
         if v.kind_of?(NetSuite::Records::CustomRecordRef) && v.type_id
           hash[:attributes!] ||= {}
           hash[:attributes!][kname] ||= {}
-          hash[:attributes!][kname]['typeId'] = v.type_id.lower_camelcase
+          hash[:attributes!][kname]['typeId'] = NetSuite::Utilities::Strings.lower_camelcase(v.type_id)
         end
       end
 
@@ -53,11 +53,11 @@ module NetSuite
       end
 
       def netsuite_type
-        record_type_without_namespace.lower_camelcase
+        Records.netsuite_type(self)
       end
 
       def record_type_without_namespace
-        "#{self.class.to_s.split('::').last}"
+        Records.record_type_without_namespace(self)
       end
 
       def refresh(credentials = {})
@@ -75,6 +75,15 @@ module NetSuite
         self
       end
 
+      def self.netsuite_type(obj)
+        NetSuite::Utilities::Strings.lower_camelcase(record_type_without_namespace(obj))
+      end
+
+      def self.record_type_without_namespace(obj)
+        klass = obj.is_a?(Class) ? obj : obj.class
+        "#{klass.to_s.split('::').last}"
+      end
+
     end
   end
 end

data/lib/netsuite/support/sublist.rb

@@ -35,7 +35,7 @@ module NetSuite
       end
 
       def to_record
-        rec = { "#{record_namespace}:#{sublist_key.to_s.lower_camelcase}" => send(self.sublist_key).map(&:to_record) }
+        rec = { "#{record_namespace}:#{NetSuite::Utilities::Strings.lower_camelcase(sublist_key.to_s)}" => send(self.sublist_key).map(&:to_record) }
 
         if !replace_all.nil?
           rec["#{record_namespace}:replaceAll"] = !!replace_all

data/lib/netsuite/utilities/strings.rb

@@ -0,0 +1,15 @@
+module NetSuite
+  module Utilities
+    module Strings
+      class << self
+        def lower_camelcase(obj)
+          str = obj.is_a?(String) ? obj.dup : obj.to_s
+          str.gsub!(/\/(.?)/) { "::#{$1.upcase}" }
+          str.gsub!(/(?:_+|-+)([a-z]|[0-9])/) { $1.upcase }
+          str.gsub!(/(\A|\s)([A-Z])/) { $1 + $2.downcase }
+          str
+        end
+      end
+    end
+  end
+end

data/lib/netsuite/version.rb

@@ -1,3 +1,3 @@
 module NetSuite
-  VERSION = '0.8.11'
+  VERSION = '0.8.12'
 end

data/lib/netsuite.rb

@@ -5,9 +5,9 @@ require 'netsuite/version'
 require 'netsuite/errors'
 require 'netsuite/utilities'
 require 'netsuite/utilities/data_center'
+require 'netsuite/utilities/strings'
 require 'netsuite/rest/utilities/roles'
 require 'netsuite/rest/utilities/request'
-require 'netsuite/core_ext/string/lower_camelcase'
 
 module NetSuite
   autoload :Configuration, 'netsuite/configuration'
@@ -225,6 +225,7 @@ module NetSuite
     autoload :NonInventoryResaleItem,           'netsuite/records/non_inventory_resale_item'
     autoload :Note,                             'netsuite/records/note'
     autoload :NoteType,                         'netsuite/records/note_type'
+    autoload :NullFieldList,                    'netsuite/records/null_field_list'
     autoload :Opportunity,                      'netsuite/records/opportunity'
     autoload :OpportunityItem,                  'netsuite/records/opportunity_item'
     autoload :OpportunityItemList,              'netsuite/records/opportunity_item_list'

data/netsuite.gemspec

@@ -20,5 +20,5 @@ Gem::Specification.new do |gem|
   gem.add_dependency 'savon', '>= 2.3.0'
 
   gem.add_development_dependency 'rspec', '~> 3.11.0'
-  gem.add_development_dependency 'rake', '~> 13'
+  gem.add_development_dependency 'rake', '~> 12.3.3'
 end

data/spec/netsuite/records/cash_refund_item_spec.rb

@@ -5,7 +5,7 @@ describe NetSuite::Records::CashRefundItem do
 
   it 'has all the right fields' do
     [
-      :amount
+      :amount, :gross_amt, :rate, :quantity, :is_taxable, :order_line, :line, :description
     ].each do |field|
       expect(item).to have_field(field)
     end

data/spec/netsuite/records/credit_memo_spec.rb

@@ -20,6 +20,20 @@ describe NetSuite::Records::CreditMemo do
     end
   end
 
+  it 'has all the right fields with specific classes' do
+    {
+      custom_field_list: NetSuite::Records::CustomFieldList,
+      item_list: NetSuite::Records::CreditMemoItemList,
+      apply_list: NetSuite::Records::CreditMemoApplyList,
+      ship_group_list: NetSuite::Records::SalesOrderShipGroupList,
+      null_field_list: NetSuite::Records::NullFieldList,
+      transaction_bill_address: NetSuite::Records::BillAddress,
+      billing_address: NetSuite::Records::Address,
+    }.each do |field, klass|
+      expect(memo).to have_field(field, klass)
+    end
+  end
+
   it 'has all the right record refs' do
     [
       :account, :bill_address_list, :created_from, :custom_form, :department, :discount_item, :entity, :gift_cert,

data/spec/netsuite/records/invoice_spec.rb

@@ -32,6 +32,20 @@ describe NetSuite::Records::Invoice do
     end
   end
 
+  it 'has all the right fields with specific classes' do
+    {
+      transaction_bill_address: NetSuite::Records::BillAddress,
+      transaction_ship_address: NetSuite::Records::ShipAddress,
+      item_list: NetSuite::Records::InvoiceItemList,
+      custom_field_list: NetSuite::Records::CustomFieldList,
+      shipping_address: NetSuite::Records::Address,
+      billing_address: NetSuite::Records::Address,
+      null_field_list: NetSuite::Records::NullFieldList,
+    }.each do |field, klass|
+      expect(invoice).to have_field(field, klass)
+    end
+  end
+
   it 'has all the right read_only_fields' do
     [
       :sub_total, :discount_total, :total, :alt_handling_cost, :alt_shipping_cost, :gift_cert_applied,

data/spec/netsuite/records/null_field_list_spec.rb

@@ -0,0 +1,30 @@
+require 'spec_helper'
+
+describe NetSuite::Records::RecordRef do
+  let(:null_field_list) { NetSuite::Records::NullFieldList.new }
+
+  describe '#to_record' do
+    it 'can represent itself as a SOAP record for single value' do
+      null_field_list.name = 'blah'
+      record = {
+        'platformCore:name' => 'blah'
+      }
+      expect(null_field_list.to_record).to eql(record)
+    end
+
+    it 'can represent itself as a SOAP record for multiple values' do
+      null_field_list.name = ['blah', 'foo']
+      record = {
+        'platformCore:name' => ['blah', 'foo']
+      }
+      expect(null_field_list.to_record).to eql(record)
+    end
+  end
+
+  describe '#record_type' do
+    it 'returns a string of the SOAP type' do
+      expect(null_field_list.record_type).to eql('platformCore:NullFieldList')
+    end
+  end
+
+end

data/spec/netsuite/support/records_spec.rb

@@ -4,11 +4,14 @@ module Foo
   module Bar
     class Baz
       include NetSuite::Support::Fields
+      include NetSuite::Support::RecordRefs
       include NetSuite::Support::Records
+      include NetSuite::Namespaces::TranSales
 
-      def attributes
-        { :source => 'Google', :total => 100.0 }
-      end
+      fields :source, :total
+      field :null_field_list, NetSuite::Records::NullFieldList
+
+      record_ref :related_record
     end
   end
 end
@@ -16,18 +19,41 @@ end
 describe NetSuite::Support::Records do
   let(:instance) { Foo::Bar::Baz.new }
 
-  describe '#record_type' do
+  describe '#to_record' do
     it 'returns a hash of attributes to be used in a SOAP request' do
+      instance.source = 'Google'
+      instance.total = 100.0
+
       expect(instance.to_record).to eql({
-        'platformCore:source' => 'Google',
-        'platformCore:total'  => 100.0
+        'tranSales:source' => 'Google',
+        'tranSales:total'  => 100.0
+      })
+    end
+
+    it 'uses the records namespace for the outer elements namespace and the field values namespace for the inner elements namespace' do
+      instance.related_record = NetSuite::Records::RecordRef.new(name: 'blah')
+
+      expect(instance.to_record).to eq({
+        'tranSales:relatedRecord' => {
+          'platformCore:name' => 'blah',
+        },
+      })
+    end
+
+    it 'uses the fields namespace for the outer elements namespace for NullFieldList value' do
+      instance.null_field_list.name = 'source'
+
+      expect(instance.to_record).to eq({
+        'platformCore:nullFieldList' => {
+          'platformCore:name' => 'source',
+        },
       })
     end
   end
 
   describe '#record_type' do
     it 'returns a string of the record type to be used in a SOAP request' do
-      expect(instance.record_type).to eql('platformCore:Baz')
+      expect(instance.record_type).to eql('tranSales:Baz')
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: netsuite
 version: !ruby/object:Gem::Version
-  version: 0.8.11
+  version: 0.8.12
 platform: ruby
 authors:
 - Ryan Moran
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-03-27 00:00:00.000000000 Z
+date: 2022-04-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: savon
@@ -45,14 +45,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '13'
+        version: 12.3.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '13'
+        version: 12.3.3
 description: NetSuite SuiteTalk API Wrapper
 email:
 - ryan.moran@gmail.com
@@ -92,7 +92,6 @@ files:
 - lib/netsuite/actions/upsert.rb
 - lib/netsuite/actions/upsert_list.rb
 - lib/netsuite/configuration.rb
-- lib/netsuite/core_ext/string/lower_camelcase.rb
 - lib/netsuite/errors.rb
 - lib/netsuite/namespaces/act_sched.rb
 - lib/netsuite/namespaces/comm_general.rb
@@ -272,6 +271,7 @@ files:
 - lib/netsuite/records/non_inventory_sale_item.rb
 - lib/netsuite/records/note.rb
 - lib/netsuite/records/note_type.rb
+- lib/netsuite/records/null_field_list.rb
 - lib/netsuite/records/opportunity.rb
 - lib/netsuite/records/opportunity_item.rb
 - lib/netsuite/records/opportunity_item_list.rb
@@ -376,6 +376,7 @@ files:
 - lib/netsuite/support/sublist.rb
 - lib/netsuite/utilities.rb
 - lib/netsuite/utilities/data_center.rb
+- lib/netsuite/utilities/strings.rb
 - lib/netsuite/version.rb
 - netsuite.gemspec
 - spec/netsuite/actions/add_spec.rb
@@ -486,6 +487,7 @@ files:
 - spec/netsuite/records/non_inventory_sale_item_spec.rb
 - spec/netsuite/records/note_spec.rb
 - spec/netsuite/records/note_type_spec.rb
+- spec/netsuite/records/null_field_list_spec.rb
 - spec/netsuite/records/partner_spec.rb
 - spec/netsuite/records/payment_item_spec.rb
 - spec/netsuite/records/payment_method_spec.rb
@@ -723,6 +725,7 @@ test_files:
 - spec/netsuite/records/non_inventory_sale_item_spec.rb
 - spec/netsuite/records/note_spec.rb
 - spec/netsuite/records/note_type_spec.rb
+- spec/netsuite/records/null_field_list_spec.rb
 - spec/netsuite/records/partner_spec.rb
 - spec/netsuite/records/payment_item_spec.rb
 - spec/netsuite/records/payment_method_spec.rb

data/lib/netsuite/core_ext/string/lower_camelcase.rb

@@ -1,9 +0,0 @@
-class String
-  def lower_camelcase
-    str = dup
-    str.gsub!(/\/(.?)/) { "::#{$1.upcase}" }
-    str.gsub!(/(?:_+|-+)([a-z]|[0-9])/) { $1.upcase }
-    str.gsub!(/(\A|\s)([A-Z])/) { $1 + $2.downcase }
-    str
-  end
-end