netscaler 0.8.2 → 0.8.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0f321e41e7221c693af56061306bfba1717b37d1
-  data.tar.gz: 13c296e2b99235f9a362153cfb62aa993d125528
+  metadata.gz: dbc215e89d20371590562dfd5776de2cb5cc26f5
+  data.tar.gz: 357329039b92c07c81f472cd89d2a5163a27bd11
 SHA512:
-  metadata.gz: 0d7cf910d8486f7913ba92a1fde176cf40eafd011f209f3cf5028b7f18468aabf1c3d84a87f10132cd021c3b67e8f92c81aa4c2ef37af2f20be7f0da0bd6ba83
-  data.tar.gz: 1704633cf06ba86f728214f61a57de9e78b3ce496576caa606bcd9f3c29f7cb5aff350bc3897d6971941a222903b8d8e3971346c4e0077e6441fb2735d2dda63
+  metadata.gz: 353a7edf02ddde19e4efe1d8af19a7305eb2cd8d50fd5def6d9af19befbd4494c65c29298dc365ad8879f53a8c99ea1fe3f5cdafe797c953e2e4a1c558258358
+  data.tar.gz: b814c7748005b344e7b6dd4f734fdbbd063ad81119a7bb7a3c21b695581748427aa10faac93f2de822ed18de665e68d18457744bbaadc8b6cda5a8adb40252fb

data/Gemfile

@@ -1,19 +1,14 @@
-source "http://rubygems.org"
-# Add dependencies required to use your gem here.
-# Example:
-#   gem "activesupport", ">= 2.3.5"
+source 'http://rubygems.org'
+gem 'rest-client', '2.0.2'
 
-# Add dependencies to develop your gem here.
-# Include everything needed to run rake, tests, features, etc.
 group :development do
   gem 'rspec', '~> 3.2'
-  gem 'rdoc', '~> 4.2'
+  gem 'rdoc', '~> 5.1.0'
   gem 'bundler'
   gem 'jeweler', '~> 2.3.5'
-  gem 'simplecov', '~> 0.10'
-  gem 'simplecov-rcov'
 end
 
-gem 'nokogiri', '~> 1.6.7.2'
-gem 'rest-client', '~> 2.0'
-gem 'json', '~> 2.0.2'
+group :test do
+  gem 'simplecov', '~> 0.15.1', :require => false
+  gem 'codecov', :require => false
+end

data/Gemfile.lock

@@ -1,9 +1,12 @@
 GEM
   remote: http://rubygems.org/
   specs:
-    addressable (2.5.1)
-      public_suffix (~> 2.0, >= 2.0.2)
+    addressable (2.4.0)
     builder (3.2.3)
+    codecov (0.1.10)
+      json
+      simplecov
+      url
     descendants_tracker (0.0.4)
       thread_safe (~> 0.3, >= 0.3.1)
     diff-lcs (1.3)
@@ -13,52 +16,48 @@ GEM
     faraday (0.9.2)
       multipart-post (>= 1.2, < 3)
     git (1.3.0)
-    github_api (0.11.3)
-      addressable (~> 2.3)
-      descendants_tracker (~> 0.0.1)
+    github_api (0.16.0)
+      addressable (~> 2.4.0)
+      descendants_tracker (~> 0.0.4)
       faraday (~> 0.8, < 0.10)
-      hashie (>= 1.2)
-      multi_json (>= 1.7.5, < 2.0)
-      nokogiri (~> 1.6.0)
-      oauth2
-    hashie (3.5.5)
+      hashie (>= 3.4)
+      mime-types (>= 1.16, < 3.0)
+      oauth2 (~> 1.0)
+    hashie (3.5.6)
     highline (1.7.8)
     http-cookie (1.0.3)
       domain_name (~> 0.5)
-    jeweler (2.3.5)
+    jeweler (2.3.7)
       builder
-      bundler (>= 1.0)
+      bundler (>= 1)
       git (>= 1.2.5)
-      github_api (~> 0.11.0)
+      github_api (~> 0.16.0)
       highline (>= 1.6.15)
       nokogiri (>= 1.5.10)
       psych (~> 2.2)
       rake
       rdoc
       semver2
-    json (2.0.4)
+    json (2.1.0)
     jwt (1.5.6)
-    mime-types (3.1)
-      mime-types-data (~> 3.2015)
-    mime-types-data (3.2016.0521)
-    mini_portile2 (2.0.0)
-    multi_json (1.12.1)
+    mime-types (2.99.3)
+    mini_portile2 (2.3.0)
+    multi_json (1.12.2)
     multi_xml (0.6.0)
     multipart-post (2.0.0)
     netrc (0.11.0)
-    nokogiri (1.6.7.2)
-      mini_portile2 (~> 2.0.0.rc2)
-    oauth2 (1.3.1)
-      faraday (>= 0.8, < 0.12)
+    nokogiri (1.8.1)
+      mini_portile2 (~> 2.3.0)
+    oauth2 (1.4.0)
+      faraday (>= 0.8, < 0.13)
       jwt (~> 1.0)
       multi_json (~> 1.3)
       multi_xml (~> 0.5)
       rack (>= 1.2, < 3)
     psych (2.2.4)
-    public_suffix (2.0.5)
     rack (2.0.3)
-    rake (12.0.0)
-    rdoc (4.3.0)
+    rake (12.1.0)
+    rdoc (5.1.0)
     rest-client (2.0.2)
       http-cookie (>= 1.0.2, < 2.0)
       mime-types (>= 1.16, < 4.0)
@@ -77,31 +76,28 @@ GEM
       rspec-support (~> 3.6.0)
     rspec-support (3.6.0)
     semver2 (3.4.2)
-    simplecov (0.14.1)
+    simplecov (0.15.1)
       docile (~> 1.1.0)
       json (>= 1.8, < 3)
       simplecov-html (~> 0.10.0)
-    simplecov-html (0.10.1)
-    simplecov-rcov (0.2.3)
-      simplecov (>= 0.4.1)
+    simplecov-html (0.10.2)
     thread_safe (0.3.6)
     unf (0.1.4)
       unf_ext
     unf_ext (0.0.7.4)
+    url (0.3.2)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
   bundler
+  codecov
   jeweler (~> 2.3.5)
-  json (~> 2.0.2)
-  nokogiri (~> 1.6.7.2)
-  rdoc (~> 4.2)
-  rest-client (~> 2.0)
+  rdoc (~> 5.1.0)
+  rest-client (= 2.0.2)
   rspec (~> 3.2)
-  simplecov (~> 0.10)
-  simplecov-rcov
+  simplecov (~> 0.15.1)
 
 BUNDLED WITH
    1.14.6

data/LICENSE.txt

@@ -1,4 +1,4 @@
-Copyright (c) 2014 Gravity.com, Inc
+Copyright (c) 2017 Jarrett Irons
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/README.md

@@ -1,4 +1,5 @@
-[![Build Status](https://travis-ci.org/GravityLabs/netscaler.svg?branch=master)](https://travis-ci.org/GravityLabs/netscaler)
+[![Build Status](https://travis-ci.org/bitflingr/netscaler.svg?branch=master)](https://travis-ci.org/bitflingr/netscaler)
+[![codecov](https://codecov.io/gh/bitflingr/netscaler/branch/master/graph/badge.svg)](https://codecov.io/gh/bitflingr/netscaler)
 
 # Netscaler Gem
 
@@ -82,6 +83,6 @@ Otherwise if there are features that are missing or bugs in the code that need f
 
 ## Copyright
 
-Copyright (c) 2014 Gravity.com, Inc. See LICENSE.txt for
+Copyright (c) 2017 Jarrett Irons. See LICENSE.txt for
 further details.
 

data/Rakefile

@@ -15,7 +15,7 @@ require 'jeweler'
 Jeweler::Tasks.new do |gem|
   # gem is a Gem::Specification... see http://docs.rubygems.org/read/chapter/20 for more options
   gem.name = 'netscaler'
-  gem.homepage = 'http://github.com/GravityLabs/netscaler'
+  gem.homepage = 'http://github.com/bitflingr/netscaler'
   gem.license = 'MIT'
   gem.summary = 'Netscaler api working against the Citrix Nitro api.'
   gem.description = 'Netscaler api working against the Citrix Nitro api.  Currently supports Nitro 9.3.  Hope to add support for 10.X.  Currently has support for som basics such as adding servers/services/servicegroups.'
@@ -38,7 +38,7 @@ end
 #   spec.rcov = true
 # end
 
-task :default => :spec
+task :default => [:spec]
 
 require 'rdoc/task'
 Rake::RDocTask.new do |rdoc|
@@ -51,3 +51,15 @@ Rake::RDocTask.new do |rdoc|
 end
 
 CLOBBER.include('coverage')
+
+
+namespace :codecov do
+  desc 'Uploads the latest simplecov result set to codecov.io'
+  task :upload do
+    require 'simplecov'
+    require 'codecov'
+
+    formatter = SimpleCov::Formatter::Codecov.new
+    formatter.format(SimpleCov::ResultMerger.merged_result)
+  end
+end

data/VERSION

@@ -1 +1 @@
-0.8.2
+0.8.3

data/lib/netscaler/cs/vserver.rb

@@ -43,7 +43,7 @@ module Netscaler
         elsif payload == {} then
           return @netscaler.adapter.get('stat/csvserver')
         else
-          raise ArgumentError, 'payload cannot be null' if payload.nil?
+          raise ArgumentError, 'payload supplied must have been missing :name'
         end
       end
 

data/lib/netscaler/lb/vserver.rb

@@ -43,7 +43,7 @@ module Netscaler
         elsif payload == {} then
           return @netscaler.adapter.get('stat/lbvserver')
         else
-          raise ArgumentError, 'payload cannot be null' if payload.nil?
+          raise ArgumentError, 'payload supplied must have been missing :name'
         end
       end
 

data/lib/netscaler/lb/vserver/bind.rb

@@ -20,7 +20,7 @@ module Netscaler
 
         def responder_policy(payload)
           raise ArgumentError, 'payload cannot be null' if payload.nil?
-          validate_payload(payload, [:name, :policyname, :priority])
+          validate_payload(payload, [:name, :policyName, :priority])
           return @netscaler.adapter.post_no_body("config/lbvserver_responderpolicy_binding/#{payload['name']}?action=bind/", {'params' => {'action' => 'bind'}, 'lbvserver_responderpolicy_binding' => payload})
         end
       end

data/lib/netscaler/lb/vserver/unbind.rb

@@ -19,6 +19,11 @@ module Netscaler
           return @netscaler.adapter.post_no_body("config/lbvserver_service_binding/#{payload['name']}?action=bind/", {'params' => {'action' => 'unbind'}, 'lbvserver_rewritepolicy_binding' => payload})
         end
 
+        def responder_policy(payload)
+          raise ArgumentError, 'payload cannot be null' if payload.nil?
+          validate_payload(payload, [:name, :policyName])
+          return @netscaler.adapter.post_no_body("config/lbvserver_service_binding/#{payload['name']}?action=bind/", {'params' => {'action' => 'unbind'}, 'lbvserver_rewritepolicy_binding' => payload})
+        end
 
       end
     end

data/lib/netscaler/service.rb

@@ -60,10 +60,8 @@ module Netscaler
       if payload[:name] != nil then
         validate_payload(payload, [:name])
         @netscaler.adapter.get("stat/service/#{payload[:name]}")
-      elsif payload == {} then
-        @netscaler.adapter.get('stat/service')
       else
-        raise ArgumentError, 'payload cannot be null' if payload.nil?
+        @netscaler.adapter.get('stat/service')
       end
     end
 

data/lib/netscaler/system/interface.rb

@@ -11,10 +11,8 @@ module Netscaler
         if payload[:name] != nil then
           validate_payload(payload, [:name])
           return @netscaler.adapter.get("config/interface/#{payload[:name]}")
-        elsif payload == {} then
-          return @netscaler.adapter.get('config/interface/')
         else
-          raise ArgumentError, 'payload supplied must have been missing :name'
+          return @netscaler.adapter.get('config/interface/')
         end
       end
 
@@ -23,10 +21,8 @@ module Netscaler
         if payload[:name] != nil then
           validate_payload(payload, [:name])
           return @netscaler.adapter.get("stat/interface/#{payload[:name]}")
-        elsif payload == {} then
-          return @netscaler.adapter.get('stat/interface')
         else
-          raise ArgumentError, 'payload cannot be null' if payload.nil?
+          return @netscaler.adapter.get('stat/interface')
         end
       end
 

data/netscaler.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: netscaler 0.8.2 ruby lib
+# stub: netscaler 0.8.3 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "netscaler".freeze
-  s.version = "0.8.2"
+  s.version = "0.8.3"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]
   s.authors = ["Jeremy Custenborder".freeze, "David Andrew".freeze, "Jarrett Irons".freeze]
-  s.date = "2017-05-22"
+  s.date = "2017-09-27"
   s.description = "Netscaler api working against the Citrix Nitro api.  Currently supports Nitro 9.3.  Hope to add support for 10.X.  Currently has support for som basics such as adding servers/services/servicegroups.".freeze
   s.email = ["jeremy@scarcemedia.com".freeze, "david.andrew@webtrends.com".freeze, "jarrett.irons@gmail.com".freeze]
   s.extra_rdoc_files = [
@@ -70,8 +70,11 @@ Gem::Specification.new do |s|
     "netscaler.gemspec",
     "spec/cspolicylabel_spec.rb",
     "spec/csvserver_spec.rb",
+    "spec/interface_spec.rb",
+    "spec/lbmonitor_spec.rb",
     "spec/lbvserver_spec.rb",
     "spec/netscaler_spec.rb",
+    "spec/node_spec.rb",
     "spec/policy_stringmap_spec.rb",
     "spec/responder_spec.rb",
     "spec/rewrite_spec.rb",
@@ -83,7 +86,7 @@ Gem::Specification.new do |s|
     "spec/sslvserver_spec.rb",
     "spec/systemfile_spec.rb"
   ]
-  s.homepage = "http://github.com/GravityLabs/netscaler".freeze
+  s.homepage = "http://github.com/bitflingr/netscaler".freeze
   s.licenses = ["MIT".freeze]
   s.rubygems_version = "2.6.11".freeze
   s.summary = "Netscaler api working against the Citrix Nitro api.".freeze
@@ -92,36 +95,24 @@ Gem::Specification.new do |s|
     s.specification_version = 4
 
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
-      s.add_runtime_dependency(%q<nokogiri>.freeze, ["~> 1.6.7.2"])
-      s.add_runtime_dependency(%q<rest-client>.freeze, ["~> 2.0"])
-      s.add_runtime_dependency(%q<json>.freeze, ["~> 2.0.2"])
+      s.add_runtime_dependency(%q<rest-client>.freeze, ["= 2.0.2"])
       s.add_development_dependency(%q<rspec>.freeze, ["~> 3.2"])
-      s.add_development_dependency(%q<rdoc>.freeze, ["~> 4.2"])
+      s.add_development_dependency(%q<rdoc>.freeze, ["~> 5.1.0"])
       s.add_development_dependency(%q<bundler>.freeze, [">= 0"])
       s.add_development_dependency(%q<jeweler>.freeze, ["~> 2.3.5"])
-      s.add_development_dependency(%q<simplecov>.freeze, ["~> 0.10"])
-      s.add_development_dependency(%q<simplecov-rcov>.freeze, [">= 0"])
     else
-      s.add_dependency(%q<nokogiri>.freeze, ["~> 1.6.7.2"])
-      s.add_dependency(%q<rest-client>.freeze, ["~> 2.0"])
-      s.add_dependency(%q<json>.freeze, ["~> 2.0.2"])
+      s.add_dependency(%q<rest-client>.freeze, ["= 2.0.2"])
       s.add_dependency(%q<rspec>.freeze, ["~> 3.2"])
-      s.add_dependency(%q<rdoc>.freeze, ["~> 4.2"])
+      s.add_dependency(%q<rdoc>.freeze, ["~> 5.1.0"])
       s.add_dependency(%q<bundler>.freeze, [">= 0"])
       s.add_dependency(%q<jeweler>.freeze, ["~> 2.3.5"])
-      s.add_dependency(%q<simplecov>.freeze, ["~> 0.10"])
-      s.add_dependency(%q<simplecov-rcov>.freeze, [">= 0"])
     end
   else
-    s.add_dependency(%q<nokogiri>.freeze, ["~> 1.6.7.2"])
-    s.add_dependency(%q<rest-client>.freeze, ["~> 2.0"])
-    s.add_dependency(%q<json>.freeze, ["~> 2.0.2"])
+    s.add_dependency(%q<rest-client>.freeze, ["= 2.0.2"])
     s.add_dependency(%q<rspec>.freeze, ["~> 3.2"])
-    s.add_dependency(%q<rdoc>.freeze, ["~> 4.2"])
+    s.add_dependency(%q<rdoc>.freeze, ["~> 5.1.0"])
     s.add_dependency(%q<bundler>.freeze, [">= 0"])
     s.add_dependency(%q<jeweler>.freeze, ["~> 2.3.5"])
-    s.add_dependency(%q<simplecov>.freeze, ["~> 0.10"])
-    s.add_dependency(%q<simplecov-rcov>.freeze, [">= 0"])
   end
 end
 

data/spec/csvserver_spec.rb

@@ -38,27 +38,36 @@ describe Netscaler::Cs::Vserver do
     end
   end
 
-  context 'when using the show method in Cs::Vserver' do
+  context 'when using the show|stat method in Cs::Vserver' do
     it 'with no param used it will return all vservers' do
-      result = connection.cs.vserver.show
-      expect(result).to be_kind_of(Hash)
+      expect(connection.cs.vserver.show).to be_kind_of(Hash)
+      expect(connection.cs.vserver.stat).to be_kind_of(Hash)
     end
 
     it 'supplying the name parameter will return Hash' do
-      result = connection.cs.vserver.show :name => 'foo'
-      expect(result).to be_kind_of(Hash)
+      expect(connection.cs.vserver.show :name => 'foo').to be_kind_of(Hash)
+      expect(connection.cs.vserver.stat :name => 'foo').to be_kind_of(Hash)
     end
 
     it 'when showing a particular lb vserver string is invalid' do
       expect {
         connection.cs.vserver.show('asdf')
       }.to raise_error(TypeError, /conver(t|sion)/)
+
+      expect {
+        connection.cs.vserver.stat('asdf')
+      }.to raise_error(TypeError, /conver(t|sion)/)
+
     end
 
     it 'when showing a particular lb vserver :name is required' do
       expect {
         connection.cs.vserver.show(:foo => 'bar')
       }.to raise_error(ArgumentError, /name/)
+
+      expect {
+        connection.cs.vserver.stat(:foo => 'bar')
+      }.to raise_error(ArgumentError, /name/)
     end
   end
 
@@ -127,7 +136,13 @@ describe Netscaler::Cs::Vserver do
       expect(result).to be_kind_of(Hash)
       unbind_result = connection.cs.vserver.unbind.cs_policy :name => 'foo'
       expect(unbind_result).to be_kind_of(Hash)
+    end
+  end
 
+  context 'when []binding default lb vserver to cs vserver' do
+    it 'should return a Hash if all required args are supplied' do
+      result = connection.cs.vserver.bind.lbvserver :name => 'foo', :lbvserver =>'bar'
+      expect(result).to be_kind_of(Hash)
     end
   end
 

data/spec/interface_spec.rb

@@ -0,0 +1,26 @@
+require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
+require 'netscaler'
+require 'netscaler/mock_adapter'
+
+describe Netscaler::Lb::Monitor do
+
+  connection = Netscaler::Connection.new 'hostname' => 'foo', 'password' => 'bar', 'username' => 'bar'
+  connection.adapter = Netscaler::MockAdapter.new :body => '{ "errorcode": 0, "message": "Done" }'
+
+  %w(stat show).each do |toggle_action|
+    context "when #{toggle_action}ing a interface" do
+      it 'return hash when name is not supplied' do
+        expect(
+          connection.system.interface.send(toggle_action)
+               ).to be_kind_of(Hash)
+      end
+
+
+      it 'return hash when supplied all required params' do
+        result = connection.system.interface.send(toggle_action, {:name => 'foo'})
+        expect(result).to be_kind_of(Hash)
+      end
+    end
+  end
+end
+

data/spec/lbmonitor_spec.rb

@@ -0,0 +1,106 @@
+require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
+require 'netscaler'
+require 'netscaler/mock_adapter'
+
+describe Netscaler::Lb::Monitor do
+
+  connection = Netscaler::Connection.new 'hostname' => 'foo', 'password' => 'bar', 'username' => 'bar'
+  connection.adapter = Netscaler::MockAdapter.new :body => '{ "errorcode": 0, "message": "Done" }'
+
+  %w(add remove).each do |toggle_action|
+    context "when #{toggle_action}ing a lbmonitor" do
+      it 'a monitorName is required' do
+        expect {
+          connection.lb.monitor.send(toggle_action, {:type => 'HTTP'})
+        }.to raise_error(ArgumentError, /monitorName/)
+      end
+
+      it 'a type is required' do
+        expect {
+          connection.lb.monitor.send(toggle_action, {:monitorName => 'foo'})
+        }.to raise_error(ArgumentError, /type/)
+      end
+
+      it 'return hash when supplied all required params' do
+        result = connection.lb.monitor.send(toggle_action, {:monitorName => 'foo', :type => 'HTTP'})
+        expect(result).to be_kind_of(Hash)
+      end
+    end
+  end
+
+  %w(bind unbind).each do |toggle_action|
+    context "when #{toggle_action}ing a lbmonitor" do
+      it 'a monitorName is required' do
+        expect {
+          connection.lb.monitor.send(toggle_action, {:type => 'HTTP'})
+        }.to raise_error(ArgumentError, /monitorName/)
+      end
+
+      it 'a entityName is required' do
+        expect {
+          connection.lb.monitor.send(toggle_action, {:entityName => 'HTTP'})
+        }.to raise_error(ArgumentError, /monitorName/)
+      end
+
+      it 'a monitorName is required' do
+        expect {
+          connection.lb.monitor.send(toggle_action, {:entityType => 'HTTP'})
+        }.to raise_error(ArgumentError, /monitorName/)
+      end
+
+      it 'a entityType only accepts service[group] as acceptable values' do
+        expect {
+          connection.lb.monitor.send(toggle_action, {:monitorName => 'foo', :entityName => 'bar', :entityType => 'HTTP'})
+        }.to raise_error(ArgumentError, /entityType/)
+      end
+
+      it 'a returns when supplied all required params' do
+        expect(
+               connection.lb.monitor.send(toggle_action, {
+                 :monitorName => 'foo',
+                 :entityName => 'bar',
+                 :entityType => 'service'})
+               ).to be_kind_of(Hash)
+      end
+    end
+
+    context 'when showing a lbmonitor' do
+      it 'a monitorName is required' do
+        expect {
+          connection.lb.monitor.show :blah => 'foo'
+        }.to raise_error(ArgumentError, /monitorName/)
+      end
+
+      it 'return hash when supplied all required params' do
+        result = connection.lb.monitor.show :monitorName => 'foo'
+        expect(result).to be_kind_of(Hash)
+      end
+    end
+
+    context 'when showing bindings of a lbmonitor' do
+      it 'a monitorName is required' do
+        expect {
+          connection.lb.monitor.show_binding :entityType => 'foo'
+        }.to raise_error(ArgumentError, /monitorName/)
+      end
+
+      it 'a entityType is required' do
+        expect {
+          connection.lb.monitor.show_binding :monitorName => 'HTTP'
+        }.to raise_error(ArgumentError, /entityType/)
+      end
+
+      it 'returns error if entityType does not equal service or servicegroup' do
+        expect{connection.lb.monitor.show_binding :monitorName => 'foo', :entityType => 'HTTP'}.to raise_error(ArgumentError, /entityType/)
+      end
+
+      it 'return hash when supplied all required params' do
+        result = connection.lb.monitor.show_binding :monitorName => 'foo', :entityType => 'service'
+        expect(result).to be_kind_of(Hash)
+      end
+
+    end
+
+  end
+end
+

data/spec/lbvserver_spec.rb

@@ -38,27 +38,37 @@ describe Netscaler::Lb::Vserver do
     end
   end
 
-  context 'when using the show method in Lb::Vserver' do
+  context 'when show|stat method in Lb::Vserver' do
     it 'with no param used it will return all vservers' do
-      result = connection.lb.vserver.show
-      expect(result).to be_kind_of(Hash)
+      expect(connection.lb.vserver.show).to be_kind_of(Hash)
+      expect(connection.lb.vserver.stat).to be_kind_of(Hash)
     end
 
     it 'supplying the name parameter will return Hash' do
-      result = connection.lb.vserver.show :name => 'foo'
-      expect(result).to be_kind_of(Hash)
+      expect(connection.lb.vserver.show :name => 'foo').to be_kind_of(Hash)
+      expect(connection.lb.vserver.stat :name => 'foo').to be_kind_of(Hash)
     end
 
     it 'when showing a particular lb vserver string is invalid' do
       expect {
         connection.lb.vserver.show('asdf')
       }.to raise_error(TypeError, /conver(t|sion)/)
+
+      expect {
+        connection.lb.vserver.stat('asdf')
+      }.to raise_error(TypeError, /conver(t|sion)/)
+
     end
 
     it 'when showing a particular lb vserver :name is required' do
       expect {
         connection.lb.vserver.show(:foo => 'bar')
       }.to raise_error(ArgumentError, /name/)
+      #This should be updated to match the show method.
+      expect {
+        connection.lb.vserver.stat(:foo => 'bar')
+      }.to raise_error(ArgumentError, /name/)
+
     end
   end
 
@@ -81,7 +91,7 @@ describe Netscaler::Lb::Vserver do
     end
   end
 
-  context 'when showing lbvserver bindings' do
+  context 'when show lbvserver bindings' do
     it 'should throw an error if there is no arg' do
       expect {
         connection.lb.vserver.show_binding()
@@ -172,4 +182,42 @@ describe Netscaler::Lb::Vserver do
     end
   end
 
-end
+  context 'when [un]binding responder policies to lb vserver' do
+    it 'should throw an error if :name arg is not given' do
+      expect {
+        connection.lb.vserver.bind.responder_policy :policyName => 'bar', :priority => '10'
+      }.to raise_error(ArgumentError, /name/)
+
+      expect {
+        connection.lb.vserver.unbind.responder_policy :policyName => 'bar', :priority => '10'
+      }.to raise_error(ArgumentError, /name/)
+
+    end
+
+    it 'should throw an error if :policyName arg is not given' do
+      expect {
+        connection.lb.vserver.bind.responder_policy :name => 'foo', :priority => '10'
+      }.to raise_error(ArgumentError, /policyName/)
+
+      expect {
+        connection.lb.vserver.unbind.responder_policy :name => 'foo', :priority => '10'
+      }.to raise_error(ArgumentError, /policyName/)
+    end
+
+    it 'should throw an error if :priority arg is not given' do
+      expect {
+        connection.lb.vserver.bind.responder_policy :name => 'foo', :policyName => 'bar'
+      }.to raise_error(ArgumentError, /priority/)
+    end
+
+    it 'should return a Hash if all require arguments are supplied' do
+      expect(
+        connection.lb.vserver.bind.responder_policy :name => 'foo', :policyName => 'bar', :priority => '10'
+      ).to be_kind_of(Hash)
+      expect(
+        connection.lb.vserver.unbind.responder_policy :name => 'foo', :policyName => 'bar'
+      ).to be_kind_of(Hash)
+    end
+  end
+
+end

data/spec/node_spec.rb

@@ -0,0 +1,38 @@
+require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
+require 'netscaler'
+require 'netscaler/mock_adapter'
+
+describe Netscaler::Lb::Monitor do
+
+  connection = Netscaler::Connection.new 'hostname' => 'foo', 'password' => 'bar', 'username' => 'bar'
+  connection.adapter = Netscaler::MockAdapter.new :body => '{ "errorcode": 0, "message": "Done" }'
+
+  context 'when .show a ha.node' do
+    it 'a id is required' do
+      expect {
+        connection.ha.node.show :id => nil
+      }.to raise_error(ArgumentError, /id/)
+    end
+
+    it 'returns a Hash object if all necessary args are supplied.' do
+      expect(
+        connection.ha.node.show(:id => 'foo_80')
+      ).to be_kind_of(Hash)
+    end
+
+    it 'returns a Hash object if 0 args are supplied' do
+      expect(
+        connection.ha.node.show
+      ).to be_kind_of(Hash)
+    end
+  end
+
+  context 'when .stat a ha.node' do
+    it 'returns a Hash object if 0 args are supplied' do
+      expect(
+        connection.ha.node.stat
+      ).to be_kind_of(Hash)
+    end
+
+  end
+end

data/spec/server_spec.rb

@@ -85,4 +85,23 @@ describe Netscaler::Server do
       expect(result).to be_kind_of(Hash)
     end
   end
+
+
+  context 'when show a service' do
+    it 'server is required' do
+      expect {
+        connection.server.show(:bar => 'foo')
+      }.to raise_error(ArgumentError, /server/)
+    end
+
+    it 'returns a Hash object if all necessary args are supplied' do
+      result = connection.server.show(:server => 'foo')
+      expect(result).to be_kind_of(Hash)
+    end
+
+    it 'returns a Hash object if 0 args are supplied' do
+      result = connection.server.show
+      expect(result).to be_kind_of(Hash)
+    end
+  end
 end

data/spec/service_spec.rb

@@ -2,7 +2,7 @@ require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
 require 'netscaler'
 require 'netscaler/mock_adapter'
 
-describe Netscaler::Server do
+describe Netscaler::Service do
   connection = Netscaler::Connection.new 'hostname'=> 'foo', 'password' => 'bar', 'username'=> 'bar'
   connection.adapter = Netscaler::MockAdapter.new :body => '{ "errorcode": 0, "message": "Done" }'
 
@@ -11,6 +11,9 @@ describe Netscaler::Server do
       expect {
         connection.service.add(:serverName => 'foo', :serviceType => 'HTTP', :port => '80')
       }.to raise_error(ArgumentError, /name/)
+      expect {
+        connection.service.remove(:serverName => 'foo', :serviceType => 'HTTP', :port => '80')
+      }.to raise_error(ArgumentError, /name/)
     end
 
     it 'a serverName is required' do
@@ -31,11 +34,73 @@ describe Netscaler::Server do
       }.to raise_error(ArgumentError, /port/)
     end
 
-
     it 'returns a Hash object if all necessary args are supplied' do
       result = connection.service.add(:name => 'foo_80', :serverName => 'foo', :serviceType => 'HTTP', :port => '80')
       expect(result).to be_kind_of(Hash)
     end
   end
 
+  context 'when removing a new service' do
+    it 'a name is required' do
+      expect {
+        connection.service.remove(:serverName => 'foo', :serviceType => 'HTTP', :port => '80')
+      }.to raise_error(ArgumentError, /name/)
+    end
+
+    it 'returns a Hash object if all necessary args are supplied' do
+      result = connection.service.remove(:name => 'foo_80')
+      expect(result).to be_kind_of(Hash)
+    end
+  end
+
+  context 'when show a service' do
+    it 'serviceName is required' do
+      expect {
+        connection.service.show(:name => 'foo')
+      }.to raise_error(ArgumentError, /serviceName/)
+    end
+
+    it 'returns a Hash object if all necessary args are supplied' do
+      result = connection.service.show(:serviceName => 'foo_80')
+      expect(result).to be_kind_of(Hash)
+    end
+
+    it 'returns a Hash object if 0 args are supplied' do
+      result = connection.service.show
+      expect(result).to be_kind_of(Hash)
+    end
+  end
+
+  context 'when stat a service' do
+    it 'returns a Hash object if all necessary args are supplied' do
+      result = connection.service.stat(:name => 'foo_80')
+      expect(result).to be_kind_of(Hash)
+    end
+
+    it 'returns a Hash object if 0 args are supplied' do
+      result = connection.service.stat
+      expect(result).to be_kind_of(Hash)
+    end
+  end
+
+  context 'when enable|disable|show_binding a service' do
+    it 'returns a Hash object if all necessary args are supplied' do
+      expect(connection.service.show_binding(:name => 'foo_80')).to be_kind_of(Hash)
+      expect(connection.service.enable(:name => 'foo_80')).to be_kind_of(Hash)
+      expect(connection.service.disable(:name => 'foo_80')).to be_kind_of(Hash)
+    end
+
+    it 'returns an error when 0 arguments are supplied.' do
+      expect {
+        connection.service.show_binding
+      }.to raise_error(ArgumentError, /wrong number/)
+      expect {
+        connection.service.enable
+      }.to raise_error(ArgumentError, /wrong number/)
+      expect {
+        connection.service.disable
+      }.to raise_error(ArgumentError, /wrong number/)
+
+    end
+  end
 end

data/spec/servicegroup_spec.rb

@@ -8,7 +8,6 @@ describe Netscaler::ServiceGroup do
   connection.adapter = Netscaler::MockAdapter.new :body => '{ "errorcode": 0, "message": "Done" }'
 
   context 'when adding a new servicegroup' do
-
     it 'a name is required' do
       expect {
         connection.servicegroups.add({ 'serviceType' => 'tcp' })
@@ -21,10 +20,13 @@ describe Netscaler::ServiceGroup do
       }.to raise_error(ArgumentError, /serviceType/)
     end
 
+    it 'returns a Hash object if all necessary args are supplied' do
+      result = connection.servicegroups.add :serviceGroupName => 'foo', 'serviceType' => 'bar'
+      expect(result).to be_kind_of(Hash)
+    end
   end
 
   context 'when removing a servicegroup' do
-
     it 'has to require a serviceGroupName' do
       expect {
         connection.servicegroups.remove()
@@ -35,15 +37,13 @@ describe Netscaler::ServiceGroup do
     end
 
     it 'returns a Hash object if all necessary args are supplied' do
-      result = connection.servicegroups.show_bindings :serviceGroupName => 'foo'
+      result = connection.servicegroups.remove :serviceGroupName => 'foo'
       expect(result).to be_kind_of(Hash)
     end
-
   end
 
 
   context 'when binding a new server to servicegroup' do
-
     it 'a Service group name is required' do
       expect {
         connection.servicegroups.bind({ 'port'=> '8080', 'ip' => '199.199.199.199' })
@@ -62,10 +62,13 @@ describe Netscaler::ServiceGroup do
       }.to raise_error(ArgumentError, /port/)
     end
 
+    it 'returns a Hash object if all necessary args are supplied' do
+      result = connection.servicegroups.bind :serviceGroupName => 'foo', :port => '80', :serverName => 'foo_80'
+      expect(result).to be_kind_of(Hash)
+    end
   end
 
   context 'when unbinding a server from servicegroup' do
-
     it 'a Service group name is required' do
       expect {
         connection.servicegroups.unbind({ 'port' => '8080', 'ip' => '199.199.199.199' })
@@ -84,11 +87,14 @@ describe Netscaler::ServiceGroup do
       }.to raise_error(ArgumentError, /port/)
     end
 
+    it 'returns a Hash object if all necessary args are supplied' do
+      result = connection.servicegroups.unbind :serviceGroupName => 'foo', :port => '80', :serverName => 'foo_80'
+      expect(result).to be_kind_of(Hash)
+    end
   end
 
   %w(enable disable).each do |toggle_action|
     context "when running servicegroup.#{toggle_action}" do
-
       it ':serviceGroupName is required' do
         expect {
           connection.servicegroups.send(toggle_action, {})
@@ -99,11 +105,9 @@ describe Netscaler::ServiceGroup do
         result = connection.servicegroups.send(toggle_action, :serviceGroupName => 'foo')
         expect(result).to be_kind_of(Hash)
       end
-
     end
 
     context "when #{toggle_action} a server in servicegroup" do
-
       it ':serviceGroupName is required' do
         expect {
           connection.servicegroups.send("#{toggle_action}_server", {:serverName => 'foo', :port => '80'})
@@ -126,7 +130,6 @@ describe Netscaler::ServiceGroup do
         result = connection.servicegroups.send("#{toggle_action}_server", {:serviceGroupName => 'bar', :serverName => 'foo', :port => '80'})
         expect(result).to be_kind_of(Hash)
       end
-
     end
 
 

data/spec/spec_helper.rb

@@ -1,10 +1,9 @@
 require 'simplecov'
-require 'simplecov-rcov'
+require 'codecov'
 
 class SimpleCov::Formatter::MergedFormatter
   def format(result)
     SimpleCov::Formatter::HTMLFormatter.new.format(result)
-    SimpleCov::Formatter::RcovFormatter.new.format(result)
   end
 end
 

data/spec/sslcertkey_spec.rb

@@ -31,4 +31,17 @@ describe Netscaler::System::File do
       expect(result).to be_kind_of(Hash)
     end
   end
+
+  context 'when removing a certkey' do
+    it 'a certkey is required' do
+      expect {
+        connection.ssl.certkey.remove :foo => 'bar'
+      }.to raise_error(ArgumentError, /certkey/)
+    end
+
+    it 'return hash when supplied all required params' do
+      result = connection.ssl.certkey.remove :certkey => 'foo'
+      expect(result).to be_kind_of(Hash)
+    end
+  end
 end

data/spec/sslvserver_spec.rb

@@ -182,4 +182,33 @@ describe Netscaler::Cs::Vserver do
 
     end
   end
+
+  context 'when [un]binding ecccurve to ssl vserver' do
+    it 'should throw an error if :vservername arg is not given' do
+      expect {
+        connection.ssl.vserver.bind.ecccurve :ecccurvename => 'foo'
+      }.to raise_error(ArgumentError, /vservername/)
+      expect {
+        connection.ssl.vserver.unbind.ecccurve :policyname => 'foo'
+      }.to raise_error(ArgumentError, /vservername/)
+    end
+
+    it 'should throw an error if :ecccurvename arg is not given' do
+      expect {
+        connection.ssl.vserver.bind.ecccurve :vservername => 'foo'
+      }.to raise_error(ArgumentError, /ecccurvename/)
+      expect {
+        connection.ssl.vserver.unbind.ecccurve :vservername => 'foo'
+      }.to raise_error(ArgumentError, /ecccurvename/)
+    end
+
+    it 'should return a Hash if all require arguments are supplied' do
+      result = connection.ssl.vserver.bind.ecccurve :vservername => 'foo', :ecccurvename => 'bar'
+      expect(result).to be_kind_of(Hash)
+      unbind_result = connection.ssl.vserver.unbind.ecccurve :vservername => 'foo', :ecccurvename => 'bar'
+      expect(unbind_result).to be_kind_of(Hash)
+
+    end
+  end
+
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: netscaler
 version: !ruby/object:Gem::Version
-  version: 0.8.2
+  version: 0.8.3
 platform: ruby
 authors:
 - Jeremy Custenborder
@@ -10,48 +10,20 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-22 00:00:00.000000000 Z
+date: 2017-09-27 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: nokogiri
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.6.7.2
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.6.7.2
 - !ruby/object:Gem::Dependency
   name: rest-client
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.0'
-- !ruby/object:Gem::Dependency
-  name: json
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
         version: 2.0.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
         version: 2.0.2
 - !ruby/object:Gem::Dependency
@@ -74,14 +46,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: 5.1.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: 5.1.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -110,34 +82,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 2.3.5
-- !ruby/object:Gem::Dependency
-  name: simplecov
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.10'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.10'
-- !ruby/object:Gem::Dependency
-  name: simplecov-rcov
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 description: Netscaler api working against the Citrix Nitro api.  Currently supports
   Nitro 9.3.  Hope to add support for 10.X.  Currently has support for som basics
   such as adding servers/services/servicegroups.
@@ -202,8 +146,11 @@ files:
 - netscaler.gemspec
 - spec/cspolicylabel_spec.rb
 - spec/csvserver_spec.rb
+- spec/interface_spec.rb
+- spec/lbmonitor_spec.rb
 - spec/lbvserver_spec.rb
 - spec/netscaler_spec.rb
+- spec/node_spec.rb
 - spec/policy_stringmap_spec.rb
 - spec/responder_spec.rb
 - spec/rewrite_spec.rb
@@ -214,7 +161,7 @@ files:
 - spec/sslcertkey_spec.rb
 - spec/sslvserver_spec.rb
 - spec/systemfile_spec.rb
-homepage: http://github.com/GravityLabs/netscaler
+homepage: http://github.com/bitflingr/netscaler
 licenses:
 - MIT
 metadata: {}