netprospex 0.0.1 → 0.0.2

data/.gitignore

@@ -15,3 +15,4 @@ spec/reports
 test/tmp
 test/version_tmp
 tmp
+.rvmrc

data/Rakefile

@@ -1 +1,4 @@
 require "bundler/gem_tasks"
+require "rspec/core/rake_task"
+RSpec::Core::RakeTask.new('spec')
+task :default => :spec

data/lib/netprospex/client.rb

@@ -26,9 +26,9 @@ module NetProspex
     def api_base
       @api_base ||= case NetProspex.environment
       when :production
-        "http://api.netprospex.com/1.1"
+        "http://api.netprospex.com/#{NetProspex.version}"
       when :sandbox
-        "http://api-sb.netprospex.com/1.1"
+        "http://api-sb.netprospex.com/#{NetProspex.version}"
       end
     end
 

data/lib/netprospex/configuration.rb

@@ -1,15 +1,21 @@
 module NetProspex
   module Configuration
     attr_accessor :consumer_key, :consumer_secret
-    attr_reader :environment
+    attr_reader :environment, :version
+
     def environment=(env)
-      if [:production, :sandbox].include? env
+      env = env.to_sym
+      if [:production, :sandbox].include?(env)
         @environment = env
       else
-        raise NetProspex::ConfigurationError.new("Unknown environment")
+        raise NetProspex::ConfigurationError.new("Unknown environment #{env}")
       end
     end
 
+    def version=(v)
+      @version = v
+    end
+
     def self.extended(base)
       base.reset
     end
@@ -18,6 +24,7 @@ module NetProspex
       self.consumer_key = nil
       self.consumer_secret = nil
       self.environment = :production
+      self.version = "1.1"
     end
 
     def configure

data/lib/netprospex/middleware/raise_exceptions.rb

@@ -5,7 +5,8 @@ module NetProspex
     class RaiseExceptions < Faraday::Middleware
       def call(environment)
         @app.call(environment).on_complete do |env|
-          next unless env[:body].is_a?(Hash) && (error = env[:body][:response][:error])
+          next unless env[:body].is_a?(Hash) && env[:body][:response][:error]
+          error = env[:body][:response][:error]
           case error[:code]
           when "ACL"
             raise NetProspex::AccessDenied.new(error[:message])
@@ -23,6 +24,8 @@ module NetProspex
             raise NetProspex::ZeroBalanceError.new(error[:message])
           when "FAULT","UNX"
             raise NetProspex::ApiError.new(error[:message])
+          else
+            raise NetProspex::ApiError.new(error[:message])
           end
         end
       end

data/lib/netprospex/version.rb

@@ -1,3 +1,3 @@
 module NetProspex
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/spec/netprospex/client_spec.rb

@@ -10,9 +10,17 @@ describe NetProspex::Client do
       c.environment = :sandbox
     end
   end
+  after(:each) { NetProspex.reset }
 
   let(:client) { NetProspex::Client.new(ENV['NETPROSPEX_USER_TOKEN'], ENV['NETPROSPEX_USER_SECRET']) }
 
+  it "builds the version into the api url" do
+    NetProspex.configure { |c| c.version = "9.9" }
+    stub = stub_request(:get, %r(api-sb\.netprospex\.com/9\.9/.*)).to_return(body: '{"response":{}}', headers: {'Content-Type' => 'application/json'})
+    client.get("/industries.json")
+    stub.should have_been_requested
+  end
+
   it "makes GET requests" do
     VCR.use_cassette("industries") do
       client.get("/industries.json")

data/spec/netprospex/configuration_spec.rb

@@ -2,16 +2,24 @@ require "spec_helper"
 require_relative "../../lib/netprospex.rb"
 
 describe NetProspex::Configuration do
+  after(:each) { NetProspex.reset }
+
   it "can be configured" do
     expect {
       NetProspex.configure do |config|
         config.consumer_key = "foo"
         config.consumer_secret = "bar"
         config.environment = :sandbox
+        config.version = "1.1"
       end
     }.to_not raise_exception
   end
 
+  it "stores the api version" do
+    NetProspex.configure { |config| config.version = "9.9" }
+    NetProspex.version.should == "9.9"
+  end
+
   it "validates environment" do
     expect {
       NetProspex.configure do |config|
@@ -19,4 +27,9 @@ describe NetProspex::Configuration do
       end
     }.to raise_exception(NetProspex::ConfigurationError)
   end
+
+  it "accepts environment as a string" do
+    NetProspex.configure { |config| config.environment = "sandbox" }
+    NetProspex.environment.should == :sandbox
+  end
 end

data/spec/netprospex/middleware/raise_exceptions_spec.rb

@@ -80,4 +80,14 @@ describe NetProspex::Middleware::RaiseExceptions do
       puts client.get('/person/list.json', organization_name: 'Pardot')
     }.to raise_exception(NetProspex::ApiError)
   end
+
+  it "raises ApiError for version error" do
+    stub_request(:get, %r(api-sb\.netprospex\.com/1\.1/person/list\.json)).to_return(
+      body: '{"response":{"version":"1.1","responseId":"8A3837BF-AB10-F3B4-EA19-0606207939CE","responseType":"error","request":{"startTime":"2013-09-04 09:18:21","requestType":"person_list","url":"\/1.1\/person\/list.json?firstName=Bob&lastName=Colananni&preview=1","userId":"1aebe6ed-6c79-11e2-a4df-f04da23ce7b0"},"transaction":{"accountId":"1ad39da8-6c79-11e2-a4df-f04da23ce7b0","accountStartBalance":100000,"accountEndBalance":null},"error":{"message":"invalid API version=1.1","code":"ARG"},"debug":{"requestTime":0.0185089111328}}}',
+      headers: {'Content-Type' => 'application/json'}
+    )
+    expect {
+      puts client.get('/person/list.json', organization_name: 'Pardot')
+    }.to raise_exception(NetProspex::ApiError)
+  end
 end

data/spec/vcr_helper.rb

@@ -3,7 +3,7 @@ require "vcr"
 VCR.configure do |c|
   c.cassette_library_dir = "fixtures/cassettes"
   c.hook_into :webmock
-  c.default_cassette_options  = { :record => :new_episodes }
+  c.default_cassette_options  = { :record => :once }
   c.configure_rspec_metadata!
   c.filter_sensitive_data('<NETPROSPEX_KEY>') { ENV['NETPROSPEX_KEY'] }
   c.filter_sensitive_data('<NETPROSPEX_SECRET>') { ENV['NETPROSPEX_SECRET'] }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: netprospex
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-21 00:00:00.000000000 Z
+date: 2013-09-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler