netflix-spectator-rb 0.1.3 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a7fd3c80e6d722432cca59966b94d081ab3c50175fc07e7297d3ada52d55bce9
-  data.tar.gz: 98fce8bb5978b4a2338dce4a236ee89d2b232820e0f4e605eba9e1f198ebe20d
+  metadata.gz: 7461adb6e33f0392ecc42b7752f0c0bd0fb0dc5ab45f14d4415ee95937b08fc4
+  data.tar.gz: dc35ff0a6588a74d87b4b2cb8f4ef42118bea937c659c626c4945eea8c795920
 SHA512:
-  metadata.gz: 8b396d6dd9f6d0a75af5f807b675758730991c980e84527f1d437383d25c84a8e9ee92986b19d780c0bd4fa95c20a5d245e6a2724e20d96f3b62f1613f048918
-  data.tar.gz: 3fe4dcf3f86ad2e8d91d0f0bb98b925aa4b0e4838b48cc5fb71436e24a50b4ea746ab8904ec5231e13a714ec28231f6db6be8352b7a55eec57817fd6b871d87a
+  metadata.gz: 15a0f31a565eee773ba07d0e36b081b121d982e71f4650d2a2c57b80fc999f7c3c41b129dcd5f9a79f35ffbb4370cc937a98e6fbb9c978f5c524653092bfc93b
+  data.tar.gz: 89cccad50469ed909cea9f85a80187053f20431e04ce2a2f942d1f096e11b6c872c9d6033e1f2107c8edacaa76fb865e2f8c705829f7f96e025ec3d989d210f4

data/.gitignore

@@ -7,3 +7,4 @@
 /spec/reports/
 /tmp/
 *.gem
+Gemfile.lock

data/.travis.yml

@@ -1,4 +1,3 @@
-sudo: false
 language: ruby
 rvm:
 - 2.5.1

data/Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }

data/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bundler/gem_tasks'
 require 'rake/testtask'
 require 'rubocop/rake_task'

data/bin/console

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'bundler/setup'
 require 'spectator'

data/lib/spectator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spectator/version'
 require 'spectator/registry'
 require 'spectator/meter_id'

data/lib/spectator/atomic_number.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Spectator
   # Thread safe number operations
   class AtomicNumber

data/lib/spectator/clock.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Spectator
   # A timing source that can be used to access the current time as an object,
   # and a high resolution monotonic time

data/lib/spectator/counter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spectator/atomic_number'
 require 'spectator/measure'
 

data/lib/spectator/distribution_summary.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spectator/atomic_number'
 
 module Spectator
@@ -19,7 +21,8 @@ module Spectator
 
     # Update the statistics kept by the summary with the specified amount.
     def record(amount)
-      return if amount < 0
+      return if amount.negative?
+
       @count.add_and_get(1)
       @total_amount.add_and_get(amount)
       @total_sq.add_and_get(amount * amount)

data/lib/spectator/gauge.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spectator/atomic_number'
 require 'spectator/measure'
 

data/lib/spectator/http.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'json'
 require 'net/http'
 

data/lib/spectator/measure.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Spectator
   # This immutable class represents a measurement sampled from a meter
   class Measure

data/lib/spectator/meter_id.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Spectator
   # Identifier for a meter or Measure
   class MeterId

data/lib/spectator/registry.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spectator/clock'
 require 'spectator/counter'
 require 'spectator/distribution_summary'
@@ -9,7 +11,9 @@ require 'spectator/timer'
 module Spectator
   # Registry to manage a set of meters
   class Registry
-    attr_reader :config, :clock, :publisher, :common_tags
+    DEFAULT_BATCH_SIZE = 10_000
+
+    attr_reader :config, :clock, :publisher, :common_tags, :batch_size
 
     # Initialize the registry using the given config, and clock
     # The default clock is the SystemClock
@@ -20,7 +24,7 @@ module Spectator
     #  :uri the endpoint for the aggregator service
     def initialize(config, clock = SystemClock.new)
       @config = config
-      @batch_size = config[:batch_size] || 10_000
+      @batch_size = config[:batch_size] || DEFAULT_BATCH_SIZE
       @clock = clock
       @meters = {}
       @common_tags = to_symbols(config[:common_tags]) || {}
@@ -163,7 +167,7 @@ module Spectator
 
       @should_stop = true
       Spectator.logger.info('Stopping spectator')
-      @publish_thread.kill if @publish_thread
+      @publish_thread&.kill
 
       @started = false
       Spectator.logger.info('Sending last batch of metrics before exiting')
@@ -172,31 +176,27 @@ module Spectator
 
     ADD_OP = 0
     MAX_OP = 10
-    UNKNOWN_OP = -1
-    OPS = { count: ADD_OP,
-            totalAmount: ADD_OP,
-            totalTime: ADD_OP,
-            totalOfSquares: ADD_OP,
-            percentile: ADD_OP,
-            max: MAX_OP,
-            gauge: MAX_OP,
-            activeTasks: MAX_OP,
-            duration: MAX_OP }.freeze
+    COUNTER_STATS = %i[count totalAmount totalTime
+                       totalOfSquares percentile].freeze
+
     # Get the operation to be used for the given Measure
     # Gauges are aggregated using MAX_OP, counters with ADD_OP
     def op_for_measurement(measure)
-      stat = measure.id.tags.fetch(:statistic, :unknown)
-      OPS.fetch(stat, UNKNOWN_OP)
+      stat = measure.id.tags.fetch(:statistic, '')
+      if COUNTER_STATS.include? stat
+        ADD_OP
+      else
+        MAX_OP
+      end
     end
 
     # Gauges are sent if they have a value
     # Counters if they have a number of increments greater than 0
     def should_send(measure)
       op = op_for_measurement(measure)
-      return measure.value > 0 if op == ADD_OP
-      return !measure.value.nan? if op == MAX_OP
+      return measure.value.positive? if op == ADD_OP
 
-      false
+      !measure.value.nan?
     end
 
     # Build a string table from the list of measurements

data/lib/spectator/timer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spectator/atomic_number'
 require 'spectator/clock'
 
@@ -20,7 +22,8 @@ module Spectator
     # Update the statistics kept by this timer. If the amount of nanoseconds
     # passed is negative, the value will be ignored.
     def record(nanos)
-      return if nanos < 0
+      return if nanos.negative?
+
       @count.add_and_get(1)
       @total_time.add_and_get(nanos)
       @total_sq.add_and_get(nanos * nanos)

data/lib/spectator/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Spectator
-  VERSION = '0.1.3'.freeze
+  VERSION = '0.2.1'
 end

data/netflix-spectator-rb.gemspec

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 
 lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
@@ -23,7 +24,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_development_dependency 'bundler', '~> 1.16'
+  spec.add_development_dependency 'bundler', '~> 2.0'
   spec.add_development_dependency 'minitest', '~> 5.0'
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'rubocop', '~> 0.55'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: netflix-spectator-rb
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.2.1
 platform: ruby
 authors:
 - Daniel Muino
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-10-05 00:00:00.000000000 Z
+date: 2019-07-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.16'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.16'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
@@ -78,7 +78,6 @@ files:
 - ".rubocop.yml"
 - ".travis.yml"
 - Gemfile
-- Gemfile.lock
 - LICENSE
 - OSSMETADATA
 - README.md

data/Gemfile.lock

@@ -1,46 +0,0 @@
-PATH
-  remote: .
-  specs:
-    netflix-spectator-rb (0.1.3)
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    ast (2.4.0)
-    docile (1.3.0)
-    json (2.1.0)
-    minitest (5.11.3)
-    parallel (1.12.1)
-    parser (2.5.1.0)
-      ast (~> 2.4.0)
-    powerpack (0.1.1)
-    rainbow (3.0.0)
-    rake (10.5.0)
-    rubocop (0.55.0)
-      parallel (~> 1.10)
-      parser (>= 2.5)
-      powerpack (~> 0.1)
-      rainbow (>= 2.2.2, < 4.0)
-      ruby-progressbar (~> 1.7)
-      unicode-display_width (~> 1.0, >= 1.0.1)
-    ruby-progressbar (1.9.0)
-    simplecov (0.16.1)
-      docile (~> 1.1)
-      json (>= 1.8, < 3)
-      simplecov-html (~> 0.10.0)
-    simplecov-html (0.10.2)
-    unicode-display_width (1.3.2)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  bundler (~> 1.16)
-  minitest (~> 5.0)
-  netflix-spectator-rb!
-  rake (~> 10.0)
-  rubocop (~> 0.55)
-  simplecov
-
-BUNDLED WITH
-   1.16.1