net_http_timeout_errors 0.1.0 → 0.2.0

data/README.md

@@ -2,7 +2,7 @@
 
 Tired of having to rescue an ever-growing list of Net::HTTP timeout error types?
 
-Just include this gem and then do:
+Just load this gem and then do:
 
 ``` ruby
 begin
@@ -28,6 +28,8 @@ rescue AnotherError, *NetHttpTimeoutErrors.all
 end
 ```
 
+You can still get at the original error through `NetHttpTimeoutError#original_error`.
+
 Did we miss an error? Please add it!
 
 

data/lib/net_http_timeout_errors.rb

@@ -12,10 +12,16 @@ end
 class NetHttpTimeoutErrors
   def self.all
     [
+      EOFError,
       Errno::ECONNREFUSED,
       Errno::ECONNRESET,
       Errno::EHOSTUNREACH,
+      Errno::EINVAL,
       Errno::EPIPE,
+      Errno::ETIMEDOUT,
+      Net::HTTPBadResponse,
+      Net::HTTPHeaderSyntaxError,
+      Net::ProtocolError,
       SocketError,
       Timeout::Error,
     ]

data/lib/net_http_timeout_errors/version.rb

@@ -1,3 +1,3 @@
 class NetHttpTimeoutErrors
-  VERSION = "0.1.0"
+  VERSION = "0.2.0"
 end

data/spec/net_http_timeout_errors_spec.rb

@@ -3,15 +3,7 @@ require "net_http_timeout_errors"
 
 describe NetHttpTimeoutErrors, ".all" do
   it "has some" do
-    NetHttpTimeoutErrors.all.wont_be_empty
-  end
-
-  # No assertions; more like runnable documentation.
-  it "works splatted" do
-    begin
-      raise an_error
-    rescue ZeroDivisionError, *NetHttpTimeoutErrors.all
-    end
+    assert_includes NetHttpTimeoutErrors.all, some_timeout_error
   end
 end
 
@@ -19,7 +11,7 @@ describe NetHttpTimeoutErrors, ".conflate" do
   it "turns any handled error into a NetHttpTimeoutError" do
     assert_raises(NetHttpTimeoutError) do
       NetHttpTimeoutErrors.conflate do
-        raise an_error
+        raise some_timeout_error
       end
     end
   end
@@ -35,14 +27,14 @@ describe NetHttpTimeoutErrors, ".conflate" do
   it "keeps the original error" do
     begin
       NetHttpTimeoutErrors.conflate do
-        raise an_error
+        raise some_timeout_error
       end
     rescue => e
-      assert_instance_of Timeout::Error, e.original_error
+      assert_instance_of some_timeout_error, e.original_error
     end
   end
 end
 
-def an_error
-  Timeout::Error
+def some_timeout_error
+  SocketError
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: net_http_timeout_errors
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
   prerelease: 
 platform: ruby
 authors: