net-ping 1.1.0 → 1.1.1

data/CHANGES

@@ -1,3 +1,9 @@
+== 1.1.1 - 15-Jun-2006
+* Fixed a bug in PingTCP (bad variable name).  Thanks go to Anoop Chandran
+  for the spot.
+* Minor variable name refactoring.
+* Minor test updates.
+
 == 1.1.0 - 17-Jul-2005
 * Fixed a bug in the PingHTTP#ping method where I was accidentally passing
   the timeout value instead of the port number as the third argument to

data/doc/ping.txt

@@ -201,5 +201,5 @@ Ping#warning
 
 == Author
    Daniel J. Berger
-   djberg96 at yahoo dot com
+   djberg96 at gmail dot com
    imperator on IRC (irc.freenode.net)

data/lib/net/ping.rb

@@ -4,7 +4,7 @@ require "timeout"
 module Net
    # An abstract base class.  Do not instantiate directly.
    class Ping
-      VERSION = "1.1.0"
+      VERSION = "1.1.1"
       attr_accessor :host, :port, :timeout
       attr_reader :exception, :warning
       
@@ -60,27 +60,27 @@ module Net
       def ping
          super
          success = false
-         t = nil
+         tcp = nil
          begin
             Timeout.timeout(@timeout){
                begin
-                  t = TCPSocket.new(@host,@port)
-               rescue Errno::ECONNREFUSED => e
+                  tcp = TCPSocket.new(@host,@port)
+               rescue Errno::ECONNREFUSED => err
                   if @@econnrefused == true
                      success = true
                   else
-                     @exception = e
+                     @exception = err
                   end
-               rescue Exception => e
-                  @exception = e
+               rescue Exception => err
+                  @exception = err
                else
                   success = true
                end
             }
-         rescue TimeoutError => t
-            @exception = t
+         rescue Timeout::Error => err
+            @exception = err
          ensure
-            t.close if t
+            tcp.close if tcp
          end
          success
       end
@@ -100,22 +100,22 @@ module Net
       def ping
          super
          success = false
-         u = UDPSocket.open
+         udp = UDPSocket.open
          a = []
          begin
             Timeout.timeout(@timeout){
-               u.connect(@host,@port)
-               u.send(@data,0)
-               a = u.recvfrom(64)
+               udp.connect(@host, @port)
+               udp.send(@data, 0)
+               a = udp.recvfrom(64)
             }
-         rescue Exception => e
-            @exception = e
+         rescue Exception => err
+            @exception = err
          else
             if a[0] == @data
                success = true
             end
          ensure
-            u.close if u
+            udp.close if udp
          end
          success
       end
@@ -215,8 +215,8 @@ module Net
 
          begin
             resp = HTTP.get_response(uri.host, uri.path, @port)
-         rescue Exception => e
-            @exception = e
+         rescue Exception => err
+            @exception = err
          else
             case resp
                when Net::HTTPSuccess, Net::HTTPOK

data/test/tc_pingexternal.rb

@@ -23,7 +23,7 @@ class TC_PingExternal < Test::Unit::TestCase
    end
 
    def test_version
-      assert_equal("1.0.1", PingExternal::VERSION, "Bad version constant")
+      assert_equal("1.1.1", PingExternal::VERSION, "Bad version constant")
    end
    
    def test_ping

data/test/tc_pinghttp.rb

@@ -22,7 +22,7 @@ class TC_PingHTTP < Test::Unit::TestCase
    end
 
    def test_version
-      assert_equal("1.1.0", PingHTTP::VERSION, "Bad version constant")
+      assert_equal("1.1.1", PingHTTP::VERSION, "Bad version constant")
    end
    
    def test_ping

data/test/tc_pingtcp.rb

@@ -21,7 +21,7 @@ class TC_PingTCP < Test::Unit::TestCase
    end
 
    def test_version
-      assert_equal("1.0.1", PingTCP::VERSION, "Bad version constant")
+      assert_equal("1.1.1", PingTCP::VERSION, "Bad version constant")
    end
    
    def test_ping
@@ -32,8 +32,9 @@ class TC_PingTCP < Test::Unit::TestCase
    end
 
    def test_ping_ecr_false
+      msg = "+this test may fail depending on your network environment+"
       PingTCP.ecr = false
-      assert_equal(false, @tcp.ping?)
+      assert_equal(false, @tcp.ping?, msg)
       assert_equal(false, @tcp.exception.nil?, "Bad exception data")
    end
 

data/test/tc_pingudp.rb

@@ -24,7 +24,7 @@ class TC_PingUDP < Test::Unit::TestCase
    end
 
    def test_version
-      assert_equal("1.0.1", PingUDP::VERSION, "Bad version constant")
+      assert_equal("1.1.1", PingUDP::VERSION, "Bad version constant")
    end
    
    def test_ping

metadata

@@ -3,11 +3,11 @@ rubygems_version: 0.8.11
 specification_version: 1
 name: net-ping
 version: !ruby/object:Gem::Version 
-  version: 1.1.0
-date: 2005-07-18 00:00:00 -06:00
+  version: 1.1.1
+date: 2006-06-15 00:00:00 -06:00
 summary: A ping interface for Ruby
 require_paths: 
-  - lib
+- lib
 email: djberg96@gmail.com
 homepage: http://www.rubyforge.org/projects/shards
 rubyforge_project: 
@@ -18,35 +18,39 @@ bindir: bin
 has_rdoc: true
 required_ruby_version: !ruby/object:Gem::Version::Requirement 
   requirements: 
-    - 
-      - ">"
-      - !ruby/object:Gem::Version 
-        version: 0.0.0
+  - - ">"
+    - !ruby/object:Gem::Version 
+      version: 0.0.0
   version: 
 platform: ruby
 signing_key: 
 cert_chain: 
 authors: 
-  - Daniel J. Berger
+- Daniel J. Berger
 files: 
-  - lib/net/ping.rb
-  - README
-  - CHANGES
-  - MANIFEST
-  - test/tc_pingtcp.rb
-  - test/tc_pingudp.rb
-  - test/tc_pingexternal.rb
-  - test/ts_ping.rb
-  - test/tc_pinghttp.rb
-  - doc/ping.txt
+- lib/net/ping.rb
+- README
+- CHANGES
+- MANIFEST
+- test/tc_pingtcp.rb
+- test/tc_pingudp.rb
+- test/tc_pingexternal.rb
+- test/ts_ping.rb
+- test/tc_pinghttp.rb
+- doc/ping.txt
 test_files: 
-  - test/ts_ping.rb
+- test/ts_ping.rb
 rdoc_options: []
+
 extra_rdoc_files: 
-  - README
-  - CHANGES
-  - doc/ping.txt
+- README
+- CHANGES
+- doc/ping.txt
 executables: []
+
 extensions: []
+
 requirements: []
-dependencies: []
+
+dependencies: []
+