net-http-persistent 3.0.1 → 3.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 544b6c4e52caee7104e021181a7ab8723a625e239820297b7e6d87934c7e0e0e
-  data.tar.gz: 03e9df91b7e30d25886c30a650f9e6feb8fa7d945cf5e61b19d416bfe46eff6a
+  metadata.gz: 8dc2ad1abe3b0e82c9a23ed65f74425262d7ef4209768c8e309af861628179d9
+  data.tar.gz: d34075303f6bbb7483bfd05e8054ecbd839a371c6ef5d29c844d21bd50834316
 SHA512:
-  metadata.gz: 38b3695f98f1bae796fb0b51b12d992b621ac9d0d8b6e9f885c9327a91d994acdfa18e37018bf5a7a28bf52e11413194b027dd332d3605f913c66f847402d683
-  data.tar.gz: 32420e4a50e91fcac562ab34b1c383a7ce529d0c6646a802e4625f5f61b4c017ef6640d4e466bd803d4a5d0172d577cd05ef1979a450ef326af68a76de4f709a
+  metadata.gz: ed24bcd001852e4ade23285d7a7912735d8db4e1f6088e0ea0b8e037c49035fc2dce0efba6e0326a8a745453f503a6f23bf52fe472995dcc9d9ada7b6e177991
+  data.tar.gz: 73f7dffd85bbe34cc71086aa352e12cd203b26480126b1f9dfefe4c722215dbcae9707bcfcb6b880c1f542cb2b1299e7a423f18504aa9964c9ac2ba3b6300325

checksums.yaml.gz.sig

@@ -0,0 +1,2 @@
+x"%<���5������?�^_���ru�/]�-��>ʝ�qH�O�R,��0����$W�	N�Xζ~���o�^��Z�7,���0�J�A�8ڽ0�]�m�M����v9�74��m_na���)���'+�o��X6-k���'�_
+h����.��*�R|RU�Ջ��;�o"��X�e0	�k�3�шɑ�p�����wo�ΪK��C�dÈ%aIFD�C�`(.,"[�g���_�+��ŵ�s�Ъ�

data/.travis.yml

@@ -2,14 +2,23 @@
 after_script:
 - rake travis:after -t
 before_script:
-- gem install hoe-travis --no-rdoc --no-ri
+- gem install hoe-travis --no-document
 - rake travis:before -t
 language: ruby
 notifications:
   email:
   - drbrain@segment7.net
 rvm:
-- 2.1.10
-- 2.2.5
-- 2.3.1
+- 2.1
+- 2.2
+- 2.3
+- 2.4
+- 2.5
+- 2.6
 script: rake travis
+install: "" # avoid running default bundler install
+
+matrix:
+  include:
+  - rvm: "2.6"
+    env: TRAVIS_MATRIX=pipeline

data/Gemfile

@@ -0,0 +1,15 @@
+# -*- ruby -*-
+
+# DO NOT EDIT THIS FILE. Instead, edit Rakefile, and run `rake bundler:gemfile`.
+
+source "https://rubygems.org/"
+
+gem "connection_pool", "~>2.2"
+
+gem "minitest", "~>5.11", :group => [:development, :test]
+gem "hoe-bundler", "~>1.5", :group => [:development, :test]
+gem "hoe-travis", "~>1.4", ">=1.4.1", :group => [:development, :test]
+gem "rdoc", ">=4.0", "<7", :group => [:development, :test]
+gem "hoe", "~>3.17", :group => [:development, :test]
+
+# vim: syntax=ruby

data/History.txt

@@ -1,4 +1,41 @@
-=== 3.0
+=== 3.1.0 2019-07-24
+
+New features:
+* Support ruby 2.6 Net::HTTP#write_timeout=.  Pull request #99 by Víctor
+  Roldán Betancort.
+* Support setting TLS min/max version.  Pull request #94 by Bart.
+
+Bug fixes:
+* Reduce potential for memory leak through Hash default proc bindings.  Pull
+  request #64 by Dominic Metzger.
+* Test proxy auto detection from no_proxy in ENV.  Pull request #60 by
+  HINOHARA Hiroshi.
+* Add missing timestamp for 3.0 release.  Pull request #78 by Joe Van Dyk.
+* Support IPv6 URLs in proxy checks.  Pull request #82 by Nicolás Sanguinetti.
+* Use Net::HTTPGenericRequest#method to check idempotence for improved
+  compatibility.  Pull request #83 by Fotos Georgiadis.
+* Run net-http-pipeline tests in travis.  Pull request #86 by T.J. Schuck.
+* Correct +no_proxy+ support to override Net::HTTP proxy fallback.  Pull
+  request #88 by Jared Kauppila.
+* Mitigate memory leak when combined with faraday.  Pull request #105 by Yohei
+  Kitamura.
+* Set default connection pool size for Windows.  Pull request #90 by Jared
+  Kauppila.
+* Fix missing +name:+ argument in documentation.  Pull requests #85 by T.J.
+  Schuck, #84 by James White.
+* Fix memory leak from connection pooling.  Pull request #97 by Aaron
+  Patterson.
+* Update tests for minitest assert_equal deprecation.  Pull request #92 by
+  Olle Jonsson.
+* Fix typo in Net::HTTP::Persistent#pipeline.  Pull request #91 by Kazuma
+  Furuhashi.
+
+Other:
+* Added bundler hoe plugin.  Pull request #103 by Michael Grosser.
+* Updated ruby versions in Travis CI.  Pull request #93 by Olle Jonsson.  Pull
+  request #103 by Michael Grosser.
+
+=== 3.0 2016-10-05
 
 Breaking changes:
 

data/Manifest.txt

@@ -1,6 +1,7 @@
 .autotest
 .gemtest
 .travis.yml
+Gemfile
 History.txt
 Manifest.txt
 README.rdoc

data/Rakefile

@@ -1,8 +1,8 @@
 # -*- ruby -*-
 
-require 'rubygems'
 require 'hoe'
 
+Hoe.plugin :bundler
 Hoe.plugin :git
 Hoe.plugin :minitest
 Hoe.plugin :travis
@@ -20,8 +20,12 @@ Hoe.spec 'net-http-persistent' do
   rdoc_locations <<
     'docs.seattlerb.org:/data/www/docs.seattlerb.org/net-http-persistent/'
 
-  dependency 'connection_pool', '~> 2.2'
-  dependency 'minitest',        '~> 5.2', :development
+  dependency 'connection_pool',   '~> 2.2'
+  dependency 'minitest',          '~> 5.2', :development
+  dependency 'hoe-bundler',       '~> 1.5', :development
+  dependency 'hoe-travis',        ['~> 1.4', '>= 1.4.1'], :development
+  dependency 'net-http-pipeline', '~> 1.0' if
+    ENV['TRAVIS_MATRIX'] == 'pipeline'
 end
 
 # vim: syntax=Ruby

data/lib/net/http/persistent.rb

@@ -202,12 +202,16 @@ class Net::HTTP::Persistent
   ##
   # The default connection pool size is 1/4 the allowed open files.
 
-  DEFAULT_POOL_SIZE = Process.getrlimit(Process::RLIMIT_NOFILE).first / 4
+  if Gem.win_platform? then
+    DEFAULT_POOL_SIZE = 256
+  else
+    DEFAULT_POOL_SIZE = Process.getrlimit(Process::RLIMIT_NOFILE).first / 4
+  end
 
   ##
   # The version of Net::HTTP::Persistent you are using
 
-  VERSION = '3.0.1'
+  VERSION = '3.1.0'
 
   ##
   # Exceptions rescued for automatic retry on ruby 2.0.0.  This overlaps with
@@ -406,6 +410,11 @@ class Net::HTTP::Persistent
 
   attr_accessor :read_timeout
 
+  ##
+  # Seconds to wait until writing one block.  See Net::HTTP#write_timeout
+
+  attr_accessor :write_timeout
+
   ##
   # By default SSL sessions are reused to avoid extra SSL handshakes.  Set
   # this to false if you have problems communicating with an HTTPS server
@@ -530,6 +539,7 @@ class Net::HTTP::Persistent
     @keep_alive       = 30
     @open_timeout     = nil
     @read_timeout     = nil
+    @write_timeout    = nil
     @idle_timeout     = 5
     @max_requests     = nil
     @socket_options   = []
@@ -623,10 +633,13 @@ class Net::HTTP::Persistent
   def connection_for uri
     use_ssl = uri.scheme.downcase == 'https'
 
-    net_http_args = [uri.host, uri.port]
+    net_http_args = [uri.hostname, uri.port]
 
-    net_http_args.concat @proxy_args if
-      @proxy_uri and not proxy_bypass? uri.host, uri.port
+    if @proxy_uri and not proxy_bypass? uri.hostname, uri.port then
+      net_http_args.concat @proxy_args
+    else
+      net_http_args.concat [nil, nil, nil, nil]
+    end
 
     connection = @pool.checkout net_http_args
 
@@ -643,6 +656,7 @@ class Net::HTTP::Persistent
     end
 
     http.read_timeout = @read_timeout if @read_timeout
+    http.write_timeout = @write_timeout if @write_timeout && http.respond_to?(:write_timeout=)
     http.keep_alive_timeout = @idle_timeout if @idle_timeout
 
     return yield connection
@@ -739,9 +753,8 @@ class Net::HTTP::Persistent
   # Is +req+ idempotent according to RFC 2616?
 
   def idempotent? req
-    case req
-    when Net::HTTP::Delete, Net::HTTP::Get, Net::HTTP::Head,
-         Net::HTTP::Options, Net::HTTP::Put, Net::HTTP::Trace then
+    case req.method
+    when 'DELETE', 'GET', 'HEAD', 'OPTIONS', 'PUT', 'TRACE' then
       true
     end
   end
@@ -929,7 +942,7 @@ class Net::HTTP::Persistent
   # If a block is passed #request behaves like Net::HTTP#request (the body of
   # the response will not have been read).
   #
-  # +req+ must be a Net::HTTPRequest subclass (see Net::HTTP for a list).
+  # +req+ must be a Net::HTTPGenericRequest subclass (see Net::HTTP for a list).
   #
   # If there is an error and the request is idempotent according to RFC 2616
   # it will be retried automatically.

data/lib/net/http/persistent/pool.rb

@@ -20,6 +20,9 @@ class Net::HTTP::Persistent::Pool < ConnectionPool # :nodoc:
 
     if stack.empty?
       @available.push conn, connection_args: net_http_args
+
+      Thread.current[@key].delete(net_http_args)
+      Thread.current[@key] = nil if Thread.current[@key].empty?
     end
 
     nil

data/lib/net/http/persistent/timed_stack_multi.rb

@@ -1,10 +1,20 @@
 class Net::HTTP::Persistent::TimedStackMulti < ConnectionPool::TimedStack # :nodoc:
 
+  ##
+  # Returns a new hash that has arrays for keys
+  #
+  # Using a class method to limit the bindings referenced by the hash's
+  # default_proc
+
+  def self.hash_of_arrays # :nodoc:
+    Hash.new { |h,k| h[k] = [] }
+  end
+
   def initialize(size = 0, &block)
     super
 
     @enqueued = 0
-    @ques = Hash.new { |h, k| h[k] = [] }
+    @ques = self.class.hash_of_arrays
     @lru = {}
     @key = :"connection_args-#{object_id}"
   end

data/test/test_net_http_persistent.rb

@@ -120,7 +120,7 @@ class TestNetHttpPersistent < Minitest::Test
   def basic_connection
     raise "#{@uri} is not HTTP" unless @uri.scheme.downcase == 'http'
 
-    net_http_args = [@uri.host, @uri.port]
+    net_http_args = [@uri.host, @uri.port, nil, nil, nil, nil]
 
     connection = Net::HTTP::Persistent::Connection.allocate
     connection.ssl_generation = @http.ssl_generation
@@ -152,7 +152,7 @@ class TestNetHttpPersistent < Minitest::Test
   def ssl_connection
     raise "#{@uri} is not HTTPS" unless @uri.scheme.downcase == 'https'
 
-    net_http_args = [@uri.host, @uri.port]
+    net_http_args = [@uri.host, @uri.port, nil, nil, nil, nil]
 
     connection = Net::HTTP::Persistent::Connection.allocate
     connection.ssl_generation = @http.ssl_generation
@@ -279,7 +279,7 @@ class TestNetHttpPersistent < Minitest::Test
       c
     end
 
-    stored = @http.pool.checkout ['example.com', 80]
+    stored = @http.pool.checkout ['example.com', 80, nil, nil, nil, nil]
 
     assert_same used, stored
   end
@@ -395,6 +395,14 @@ class TestNetHttpPersistent < Minitest::Test
     end
   end
 
+  def test_connection_for_ipv6
+    uri = URI.parse 'https://[::1]/'
+
+    @http.connection_for uri do |c|
+      assert_equal '::1', c.http.address
+    end
+  end
+
   def test_connection_for_host_down
     c = basic_connection
     def (c.http).start; raise Errno::EHOSTDOWN end
@@ -538,6 +546,21 @@ class TestNetHttpPersistent < Minitest::Test
     assert stored
   end
 
+  def test_connection_for_no_proxy_from_env
+    ENV['http_proxy'] = 'proxy.example'
+    ENV['no_proxy'] = 'localhost, example.com,'
+    ENV['proxy_user'] = 'johndoe'
+    ENV['proxy_password'] = 'muffins'
+
+    http = Net::HTTP::Persistent.new proxy: :ENV
+
+    http.connection_for @uri do |c|
+      assert c.http.started?
+      refute c.http.proxy?
+      refute c.http.proxy_from_env?
+    end
+  end
+
   def test_connection_for_refused
     Net::HTTP.use_connect :refused_connect
 
@@ -728,7 +751,16 @@ class TestNetHttpPersistent < Minitest::Test
     assert @http.idempotent? Net::HTTP::Put.new '/'
     assert @http.idempotent? Net::HTTP::Trace.new '/'
 
+    assert @http.idempotent? Net::HTTPGenericRequest.new('DELETE', false, true, '/')
+    assert @http.idempotent? Net::HTTPGenericRequest.new('GET', false, true, '/')
+    assert @http.idempotent? Net::HTTPGenericRequest.new('HEAD', false, false, '/')
+    assert @http.idempotent? Net::HTTPGenericRequest.new('OPTIONS', false, false, '/')
+    assert @http.idempotent? Net::HTTPGenericRequest.new('PUT', true, true, '/')
+    assert @http.idempotent? Net::HTTPGenericRequest.new('TRACE', false, true, '/')
+
     refute @http.idempotent? Net::HTTP::Post.new '/'
+
+    refute @http.idempotent? Net::HTTPGenericRequest.new('POST', true, true, '/')
   end
 
   def test_normalize_uri
@@ -751,7 +783,7 @@ class TestNetHttpPersistent < Minitest::Test
     skip 'net-http-pipeline not installed' unless defined?(Net::HTTP::Pipeline)
 
     cached = basic_connection
-    cached.start
+    cached.http.start
 
     requests = [
       Net::HTTP::Get.new((@uri + '1').request_uri),

metadata

@@ -1,14 +1,35 @@
 --- !ruby/object:Gem::Specification
 name: net-http-persistent
 version: !ruby/object:Gem::Version
-  version: 3.0.1
+  version: 3.1.0
 platform: ruby
 authors:
 - Eric Hodel
 autorequire: 
 bindir: bin
-cert_chain: []
-date: 2019-04-29 00:00:00.000000000 Z
+cert_chain:
+- |
+  -----BEGIN CERTIFICATE-----
+  MIIDNjCCAh6gAwIBAgIBBjANBgkqhkiG9w0BAQsFADBBMRAwDgYDVQQDDAdkcmJy
+  YWluMRgwFgYKCZImiZPyLGQBGRYIc2VnbWVudDcxEzARBgoJkiaJk/IsZAEZFgNu
+  ZXQwHhcNMTkwNDA4MjEwOTU2WhcNMjAwNDA3MjEwOTU2WjBBMRAwDgYDVQQDDAdk
+  cmJyYWluMRgwFgYKCZImiZPyLGQBGRYIc2VnbWVudDcxEzARBgoJkiaJk/IsZAEZ
+  FgNuZXQwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQCbbgLrGLGIDE76
+  LV/cvxdEzCuYuS3oG9PrSZnuDweySUfdp/so0cDq+j8bqy6OzZSw07gdjwFMSd6J
+  U5ddZCVywn5nnAQ+Ui7jMW54CYt5/H6f2US6U0hQOjJR6cpfiymgxGdfyTiVcvTm
+  Gj/okWrQl0NjYOYBpDi+9PPmaH2RmLJu0dB/NylsDnW5j6yN1BEI8MfJRR+HRKZY
+  mUtgzBwF1V4KIZQ8EuL6I/nHVu07i6IkrpAgxpXUfdJQJi0oZAqXurAV3yTxkFwd
+  g62YrrW26mDe+pZBzR6bpLE+PmXCzz7UxUq3AE0gPHbiMXie3EFE0oxnsU3lIduh
+  sCANiQ8BAgMBAAGjOTA3MAkGA1UdEwQCMAAwCwYDVR0PBAQDAgSwMB0GA1UdDgQW
+  BBS5k4Z75VSpdM0AclG2UvzFA/VW5DANBgkqhkiG9w0BAQsFAAOCAQEAP5FfXeij
+  /fkvIZDdN0LV1ES3Thqoz4aQFbJv1Gf3VccYMs7/Rop5oWBOtiHMIVc855bgv5fx
+  uzRtuwiuiq1mZ6IZWkFnEw+vi+M6Q5e/8v+dhej1r7rPW71y4I1wH972O8qiuRXZ
+  EVu1y+fPhNAu6OTMgVtgkijEuA9d4OQ2xusF/YKWkaVkjrdHcDAEaquxYUKrswxM
+  DohqfAYWGDt2dmCWfRWTsBLm3p3R0mwKe8uOy4gSwcvG5SG57oSZoxrAN9CgsJoR
+  P+3YOaiDtZ7g4lYXhpJrMooDnoWr4TPbGIVuq0xfPlFinjBH0o1W+LfGS+3aCN6b
+  jT8g+1iKSQKJYA==
+  -----END CERTIFICATE-----
+date: 2019-07-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: connection_pool
@@ -38,6 +59,40 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '5.11'
+- !ruby/object:Gem::Dependency
+  name: hoe-bundler
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.5'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.5'
+- !ruby/object:Gem::Dependency
+  name: hoe-travis
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.4'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.4.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.4'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.4.1
 - !ruby/object:Gem::Dependency
   name: rdoc
   requirement: !ruby/object:Gem::Requirement
@@ -95,6 +150,7 @@ files:
 - ".autotest"
 - ".gemtest"
 - ".travis.yml"
+- Gemfile
 - History.txt
 - Manifest.txt
 - README.rdoc
@@ -126,7 +182,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.1
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Manages persistent connections using Net::HTTP plus a speed fix for Ruby

metadata.gz.sig

@@ -0,0 +1,2 @@
+x�L��)��0�嫗f[f+K�Ն�ʺ�,&��L6�9�4�m(��hρ�X�O`�w�/���OX��S�#y�j6c(ܜ6�qB��k��_��W;��D�6������*�ϴ��mV_�+��R\���H@
+��O�+)#�tB]�/�����崯���[���1x#w�M׳$�W�>�nb���}8�O�