net-http-persistent 2.9.3 → 2.9.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6486434d410797711f183ac5f05b2549d36abb07
-  data.tar.gz: e9b3fc2c439abd9c3d948e07981854b22c2bb3f7
+  metadata.gz: 21b9c2d72e25672250e7d4544bed635d05a583cd
+  data.tar.gz: 8baa746d3b463cc46282e93e1c95fea48ce34de7
 SHA512:
-  metadata.gz: 129d67362f41194c03d6ef28ac6a6964b54be83c7f4eead857b445afdc4a0c6f64f99153af45f9d3453266869db7b2f12a0db033b4edda3fa8dd747448462a0b
-  data.tar.gz: e4cf01fdfaadc12b9f2c9af916e6c62b4001b8256df14eea9a92ea4297335aceffa67d1a6a686f01dcd8f4932adc2b2ca0dc567fd735bdfa5ce6885f8d2f49b1
+  metadata.gz: 34d31b4bb74a92791b8091bec2e098935440b522a22a00cf189a7d48652415a4729496758c30af51ce38cd1c227b3414040cb3396b348dcc355634f5fb1d012d
+  data.tar.gz: 6afc70cd26e21e4d7fbce7d5531543ba55df0da22dd2b4ac5f697b34290f567167afc3a76a98fd7faa351e539f94cf1d2dae0295f0840036d482a6537bd0271f

checksums.yaml.gz.sig

@@ -1,2 +1,2 @@
-�Ӡ���}P��9Z�d=.^��	y����+�@��ٴ}��ো�d��t����_B�=Z
��@%}%^t�s:z��
�� �V��,�ח=2�o�W���jzV'"���q�?A5t
-#v�ПD�m�||ge���I#1,�������7��,�s����x���D�c[�;�E����^�Q�fr����^�NQ��+�7���Ӿ��J�{��� SƧ!�{��N������9J��1.L�P*C�``J
+.Nj�^K�^;Y�Q�-_�Q�a�Jm�cݭ���|���t�W� P��A{��X��'5�]1��]Ǵt���H�ҫu�Y���
+?�

data/History.txt

@@ -1,3 +1,8 @@
+=== 2.9.4 / 2014-02-10
+
+* Bug fixes
+  * Improve proxy escaping from 2.9.2.  Pull request #59 by Mislav Marohnić.
+
 === 2.9.3 / 2014-02-06
 
 * Bug fixes

data/lib/net/http/persistent.rb

@@ -203,7 +203,7 @@ class Net::HTTP::Persistent
   ##
   # The version of Net::HTTP::Persistent you are using
 
-  VERSION = '2.9.3'
+  VERSION = '2.9.4'
 
   ##
   # Exceptions rescued for automatic retry on ruby 2.0.0.  This overlaps with
@@ -864,14 +864,11 @@ class Net::HTTP::Persistent
     @no_proxy.clear
 
     if @proxy_uri then
-      @proxy_uri.user = unescape @proxy_uri.user
-      @proxy_uri.password = unescape @proxy_uri.password
-
       @proxy_args = [
         @proxy_uri.host,
         @proxy_uri.port,
-        @proxy_uri.user,
-        @proxy_uri.password,
+        unescape(@proxy_uri.user),
+        unescape(@proxy_uri.password),
       ]
 
       @proxy_connection_id = [nil, *@proxy_args].join ':'

data/test/test_net_http_persistent.rb

@@ -507,13 +507,15 @@ class TestNetHttpPersistent < Minitest::Test
 
   def test_connection_for_proxy_unescaped
     uri = URI.parse 'http://proxy.example'
-    uri.user     = 'john%24doe'
-    uri.password = 'muf%24fins'
+    uri.user = 'john%40doe'
+    uri.password = 'muf%3Afins'
+    uri.freeze
 
     http = Net::HTTP::Persistent.new nil, uri
+    c = http.connection_for @uri
 
-    assert_equal 'john$doe', http.proxy_uri.user
-    assert_equal 'muf$fins', http.proxy_uri.password
+    assert_includes conns[1].keys,
+                    'example.com:80:proxy.example:80:john@doe:muf:fins'
   end
 
   def test_connection_for_proxy_host_down

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: net-http-persistent
 version: !ruby/object:Gem::Version
-  version: 2.9.3
+  version: 2.9.4
 platform: ruby
 authors:
 - Eric Hodel
@@ -30,7 +30,7 @@ cert_chain:
   KDyY1VIazVgoC8XvR4h/95/iScPiuglzA+DBG1hip1xScAtw05BrXyUNrc9CEMYU
   wgF94UVoHRp6ywo8I7NP3HcwFQDFNEZPNGXsng==
   -----END CERTIFICATE-----
-date: 2014-02-07 00:00:00.000000000 Z
+date: 2014-02-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest