net-http-persistent 2.4 → 2.4.1

data/History.txt

@@ -1,3 +1,13 @@
+=== 2.4.1 / 2012-02-03
+
+* Bug fix
+  * When FakeWeb or WebMock are loaded SSL sessions will not be reused to
+    prevent breakage of testing frameworks.  Issue #13 by Matt Brictson, pull
+    request #14 by Zachary Scott
+  * SSL connections are reset when the SSL parameters change.
+    Mechanize issue #194 by dsisnero
+  * Last-use times are now cleaned up in #shutdown.
+
 === 2.4 / 2012-01-31
 
 * Minor Enhancement

data/lib/net/http/persistent.rb

@@ -149,7 +149,7 @@ class Net::HTTP::Persistent
   ##
   # The version of Net::HTTP::Persistent you are using
 
-  VERSION = '2.4'
+  VERSION = '2.4.1'
 
   ##
   # Error class for errors raised by Net::HTTP::Persistent.  Various
@@ -161,19 +161,19 @@ class Net::HTTP::Persistent
   ##
   # This client's OpenSSL::X509::Certificate
 
-  attr_accessor :certificate
+  attr_reader :certificate
 
   ##
   # An SSL certificate authority.  Setting this will set verify_mode to
   # VERIFY_PEER.
 
-  attr_accessor :ca_file
+  attr_reader :ca_file
 
   ##
-  # An SSL certificate store. Setting this will override the default
-  # certificate store. See verify_mode for more information.
+  # An SSL certificate store.  Setting this will override the default
+  # certificate store.  See verify_mode for more information.
 
-  attr_accessor :cert_store
+  attr_reader :cert_store
 
   ##
   # Where this instance's connections live in the thread local variables
@@ -230,7 +230,7 @@ class Net::HTTP::Persistent
   ##
   # This client's SSL private key
 
-  attr_accessor :private_key
+  attr_reader :private_key
 
   ##
   # The URL through which requests will be proxied
@@ -267,6 +267,11 @@ class Net::HTTP::Persistent
 
   attr_reader :socket_options
 
+  ##
+  # Where this instance's SSL connections live in the thread local variables
+
+  attr_reader :ssl_generation_key # :nodoc:
+
   ##
   # Where this instance's last-use times live in the thread local variables
 
@@ -275,21 +280,18 @@ class Net::HTTP::Persistent
   ##
   # SSL verification callback.  Used when ca_file is set.
 
-  attr_accessor :verify_callback
+  attr_reader :verify_callback
 
   ##
   # HTTPS verify mode.  Defaults to OpenSSL::SSL::VERIFY_PEER which verifies
   # the server certificate.
   #
-  # If no certificate, ca_file or cert_store is set the default system
-  # certificate store is used.
-  #
-  # To disable server certificate validation set to OpenSSL::SSL::VERIFY_NONE,
-  # but this is a bad idea as it disables SSL protections.
+  # If no ca_file or cert_store is set the default system certificate store is
+  # used.
   #
   # You can use +verify_mode+ to override any default values.
 
-  attr_accessor :verify_mode
+  attr_reader :verify_mode
 
   ##
   # Enable retries of non-idempotent requests that change data (e.g. POST
@@ -302,6 +304,8 @@ class Net::HTTP::Persistent
 
   attr_accessor :retry_change_requests
 
+  attr_reader :ssl_generation # :nodoc:
+
   ##
   # Creates a new Net::HTTP::Persistent.
   #
@@ -353,9 +357,10 @@ class Net::HTTP::Persistent
       Socket.const_defined? :TCP_NODELAY
 
     key = ['net_http_persistent', name].compact
-    @connection_key = [key, 'connections'].join('_').intern
-    @request_key    = [key, 'requests'].join('_').intern
-    @timeout_key    = [key, 'timeouts'].join('_').intern
+    @connection_key     = [key, 'connections'    ].join('_').intern
+    @ssl_generation_key = [key, 'ssl_generations'].join('_').intern
+    @request_key        = [key, 'requests'       ].join('_').intern
+    @timeout_key        = [key, 'timeouts'       ].join('_').intern
 
     @certificate        = nil
     @ca_file            = nil
@@ -363,20 +368,61 @@ class Net::HTTP::Persistent
     @verify_callback    = nil
     @verify_mode        = OpenSSL::SSL::VERIFY_PEER
     @cert_store         = nil
+
+    @ssl_generation     = 0 # incremented when SSL session variables change
     @reuse_ssl_sessions = true
 
     @retry_change_requests = false
   end
 
+  ##
+  # Sets this client's OpenSSL::X509::Certificate
+
+  def certificate= certificate
+    @certificate = certificate
+
+    reconnect_ssl
+  end
+
+  ##
+  # Sets the SSL certificate authority file.
+
+  def ca_file= file
+    @ca_file = file
+
+    reconnect_ssl
+  end
+
+  ##
+  # Overrides the default SSL certificate store used for verifying
+  # connections.
+
+  def cert_store= store
+    @cert_store = store
+
+    reconnect_ssl
+  end
+
   ##
   # Creates a new connection for +uri+
 
   def connection_for uri
-    Thread.current[@connection_key] ||= {}
-    Thread.current[@request_key]    ||= Hash.new 0
-    Thread.current[@timeout_key]    ||= Hash.new EPOCH
+    Thread.current[@ssl_generation_key] ||= Hash.new { |h,k| h[k] = {} }
+    Thread.current[@connection_key]     ||= {}
+    Thread.current[@request_key]        ||= Hash.new 0
+    Thread.current[@timeout_key]        ||= Hash.new EPOCH
+
+    use_ssl = uri.scheme.downcase == 'https'
 
-    connections = Thread.current[@connection_key]
+    if use_ssl then
+      ssl_generation = @ssl_generation
+
+      ssl_cleanup ssl_generation
+
+      connections = Thread.current[@ssl_generation_key][ssl_generation]
+    else
+      connections = Thread.current[@connection_key]
+    end
 
     net_http_args = [uri.host, uri.port]
     connection_id = net_http_args.join ':'
@@ -391,7 +437,7 @@ class Net::HTTP::Persistent
     unless connection = connections[connection_id] then
       connections[connection_id] = http_class.new(*net_http_args)
       connection = connections[connection_id]
-      ssl connection if uri.scheme.downcase == 'https'
+      ssl connection if use_ssl
     else
       last_used = Thread.current[@timeout_key][connection.object_id]
       reset connection unless last_used > max_age
@@ -452,7 +498,12 @@ class Net::HTTP::Persistent
   end
 
   def http_class # :nodoc:
-    @reuse_ssl_sessions ? Net::HTTP::Persistent::SSLReuse : Net::HTTP
+    if [:FakeWeb, :WebMock].any? { |klass| Object.const_defined?(klass) } or
+      not @reuse_ssl_sessions then
+        Net::HTTP
+    else
+      Net::HTTP::Persistent::SSLReuse
+    end
   end
 
   ##
@@ -543,6 +594,15 @@ class Net::HTTP::Persistent
     connection.pipeline requests, &block
   end
 
+  ##
+  # Sets this client's SSL private key
+
+  def private_key= key
+    @private_key = key
+
+    reconnect_ssl
+  end
+
   ##
   # Creates a URI for an HTTP proxy server from ENV variables.
   #
@@ -570,6 +630,13 @@ class Net::HTTP::Persistent
     uri
   end
 
+  ##
+  # Forces reconnection of SSL connections.
+
+  def reconnect_ssl
+    @ssl_generation += 1
+  end
+
   ##
   # Finishes then restarts the Net::HTTP +connection+
 
@@ -685,8 +752,13 @@ class Net::HTTP::Persistent
       end
     end if connections
 
+    ssl_generation = reconnect_ssl
+
+    ssl_cleanup ssl_generation
+
     thread[@connection_key] = nil
     thread[@request_key]    = nil
+    thread[@timeout_key]    = nil
   end
 
   ##
@@ -762,6 +834,44 @@ application:
                             end
   end
 
+  ##
+  # Finishes all connections that existed before the given SSL parameter
+  # +generation+.
+
+  def ssl_cleanup generation
+    (0...ssl_generation).each do |generation|
+      ssl_conns = Thread.current[@ssl_generation_key].delete generation
+
+      ssl_conns.each_value do |ssl_conn|
+        finish ssl_conn
+
+        Thread.current[@timeout_key].delete ssl_conn.object_id
+      end if ssl_conns
+    end
+  end
+
+  ##
+  # Sets the HTTPS verify mode.  Defaults to OpenSSL::SSL::VERIFY_PEER.
+  #
+  # Setting this to VERIFY_NONE is a VERY BAD IDEA and should NEVER be used.
+  # Securely transfer the correct certificate and update the default
+  # certificate store or set the ca file instead.
+
+  def verify_mode= verify_mode
+    @verify_mode = verify_mode
+
+    reconnect_ssl
+  end
+
+  ##
+  # SSL verification callback.
+
+  def verify_callback= callback
+    @verify_callback = callback
+
+    reconnect_ssl
+  end
+
 end
 
 require 'net/http/persistent/ssl_reuse'

data/test/test_net_http_persistent.rb

@@ -92,6 +92,8 @@ class TestNetHttpPersistent < MiniTest::Unit::TestCase
   end
 
   def basic_connection
+    raise "#{@uri} is not HTTP" unless @uri.scheme.downcase == 'http'
+
     c = BasicConnection.new
     conns["#{@uri.host}:#{@uri.port}"] = c
     c
@@ -122,6 +124,17 @@ class TestNetHttpPersistent < MiniTest::Unit::TestCase
     Thread.current[@http.request_key] ||= {}
   end
 
+  def ssl_conns
+    Thread.current[@http.ssl_generation_key] ||= Hash.new { |h,k| h[k] = {} }
+  end
+
+  def ssl_connection generation = 0
+    raise "#{@uri} is not HTTPS" unless @uri.scheme.downcase == 'https'
+    c = BasicConnection.new
+    ssl_conns[generation]["#{@uri.host}:#{@uri.port}"] = c
+    c
+  end
+
   def touts
     Thread.current[@http.timeout_key] ||= Hash.new Net::HTTP::Persistent::EPOCH
   end
@@ -150,6 +163,27 @@ class TestNetHttpPersistent < MiniTest::Unit::TestCase
     assert_equal proxy_uri, http.proxy_uri
   end
 
+  def test_ca_file_equals
+    @http.ca_file = :ca_file
+
+    assert_equal :ca_file, @http.ca_file
+    assert_equal 1, @http.ssl_generation
+  end
+
+  def test_cert_store_equals
+    @http.cert_store = :cert_store
+
+    assert_equal :cert_store, @http.cert_store
+    assert_equal 1, @http.ssl_generation
+  end
+
+  def test_certificate_equals
+    @http.certificate = :cert
+
+    assert_equal :cert, @http.certificate
+    assert_equal 1, @http.ssl_generation
+  end
+
   def test_connection_for
     @http.open_timeout = 123
     @http.read_timeout = 321
@@ -253,6 +287,26 @@ class TestNetHttpPersistent < MiniTest::Unit::TestCase
     assert_match %r%host down%, e.message
   end
 
+  def test_connection_for_http_class_with_fakeweb
+    Object.send :const_set, :FakeWeb, nil
+    c = @http.connection_for @uri
+    assert_instance_of Net::HTTP, c
+  ensure
+    if Object.const_defined?(:FakeWeb) then
+      Object.send :remove_const, :FakeWeb
+    end
+  end
+
+  def test_connection_for_http_class_with_webmock
+    Object.send :const_set, :WebMock, nil
+    c = @http.connection_for @uri
+    assert_instance_of Net::HTTP, c
+  ensure
+    if Object.const_defined?(:WebMock) then
+      Object.send :remove_const, :WebMock
+    end
+  end
+
   def test_connection_for_name
     http = Net::HTTP::Persistent.new 'name'
     uri = URI.parse 'http://example/'
@@ -325,6 +379,28 @@ class TestNetHttpPersistent < MiniTest::Unit::TestCase
     assert c.use_ssl?
   end
 
+  def test_connection_for_ssl_cached
+    @uri = URI.parse 'https://example.com/path'
+
+    cached = ssl_connection 0
+
+    c = @http.connection_for @uri
+
+    assert_same cached, c
+  end
+
+  def test_connection_for_ssl_cached_reconnect
+    @uri = URI.parse 'https://example.com/path'
+
+    cached = ssl_connection
+
+    @http.reconnect_ssl
+
+    c = @http.connection_for @uri
+
+    refute_same cached, c
+  end
+
   def test_connection_for_ssl_case
     uri = URI.parse 'HTTPS://example.com/path'
     c = @http.connection_for uri
@@ -407,16 +483,16 @@ class TestNetHttpPersistent < MiniTest::Unit::TestCase
     refute @http.idempotent? Net::HTTP::Post.new '/'
   end
 
+  def test_max_age
+    assert_in_delta Time.now - 5, @http.max_age
+  end
+
   def test_normalize_uri
     assert_equal 'http://example',  @http.normalize_uri('example')
     assert_equal 'http://example',  @http.normalize_uri('http://example')
     assert_equal 'https://example', @http.normalize_uri('https://example')
   end
 
-  def test_max_age
-    assert_in_delta Time.now - 5, @http.max_age
-  end
-
   def test_pipeline
     skip 'net-http-pipeline not installed' unless defined?(Net::HTTP::Pipeline)
 
@@ -436,6 +512,13 @@ class TestNetHttpPersistent < MiniTest::Unit::TestCase
     assert_equal '/2', responses.last
   end
 
+  def test_private_key_equals
+    @http.private_key = :private_key
+
+    assert_equal :private_key, @http.private_key
+    assert_equal 1, @http.ssl_generation
+  end
+
   def test_proxy_from_env
     ENV['HTTP_PROXY']      = 'proxy.example'
     ENV['HTTP_PROXY_USER'] = 'johndoe'
@@ -476,69 +559,10 @@ class TestNetHttpPersistent < MiniTest::Unit::TestCase
     assert_nil uri
   end
 
-  def test_reset
-    c = basic_connection
-    c.start
-    touts[c.object_id] = Time.now
-    reqs[c.object_id]  = 5
-
-    @http.reset c
+  def test_reconnect_ssl
+    result = @http.reconnect_ssl
 
-    assert c.started?
-    assert c.finished?
-    assert c.reset?
-    assert_nil reqs[c.object_id]
-    assert_equal Net::HTTP::Persistent::EPOCH, touts[c.object_id]
-  end
-
-  def test_reset_io_error
-    c = basic_connection
-    touts[c.object_id] = Time.now
-    reqs[c.object_id] = 5
-
-    @http.reset c
-
-    assert c.started?
-    assert c.finished?
-  end
-
-  def test_reset_host_down
-    c = basic_connection
-    touts[c.object_id] = Time.now
-    def c.start; raise Errno::EHOSTDOWN end
-    reqs[c.object_id] = 5
-
-    e = assert_raises Net::HTTP::Persistent::Error do
-      @http.reset c
-    end
-
-    assert_match %r%host down%, e.message
-  end
-
-  def test_reset_refused
-    c = basic_connection
-    touts[c.object_id] = Time.now
-    def c.start; raise Errno::ECONNREFUSED end
-    reqs[c.object_id] = 5
-
-    e = assert_raises Net::HTTP::Persistent::Error do
-      @http.reset c
-    end
-
-    assert_match %r%connection refused%, e.message
-  end
-
-  def test_ssl_error
-    uri = URI.parse 'https://example.com/path'
-    c = @http.connection_for uri
-    def c.request(*)
-      raise OpenSSL::SSL::SSLError, "SSL3_WRITE_PENDING:bad write retry"
-    end
-
-    e = assert_raises Net::HTTP::Persistent::Error do
-      @http.request uri
-    end
-    assert_match %r%bad write retry%, e.message
+    assert_equal 1, result
   end
 
   def test_request
@@ -744,6 +768,17 @@ class TestNetHttpPersistent < MiniTest::Unit::TestCase
     assert c.finished?
   end
 
+  def test_request_post
+    c = connection
+
+    post = Net::HTTP::Post.new @uri.path
+
+    @http.request @uri, post
+    req = c.req
+
+    assert_same post, req
+  end
+
   def test_request_reset
     c = basic_connection
     def c.request(*a) raise Errno::ECONNRESET end
@@ -796,21 +831,94 @@ class TestNetHttpPersistent < MiniTest::Unit::TestCase
     assert_match %r%too many connection resets%, e.message
   end
 
-  def test_request_post
-    c = connection
+  def test_request_ssl_error
+    uri = URI.parse 'https://example.com/path'
+    c = @http.connection_for uri
+    def c.request(*)
+      raise OpenSSL::SSL::SSLError, "SSL3_WRITE_PENDING:bad write retry"
+    end
 
-    post = Net::HTTP::Post.new @uri.path
+    e = assert_raises Net::HTTP::Persistent::Error do
+      @http.request uri
+    end
+    assert_match %r%bad write retry%, e.message
+  end
 
-    @http.request @uri, post
-    req = c.req
+  def test_reset
+    c = basic_connection
+    c.start
+    touts[c.object_id] = Time.now
+    reqs[c.object_id]  = 5
 
-    assert_same post, req
+    @http.reset c
+
+    assert c.started?
+    assert c.finished?
+    assert c.reset?
+    assert_nil reqs[c.object_id]
+    assert_equal Net::HTTP::Persistent::EPOCH, touts[c.object_id]
+  end
+
+  def test_reset_host_down
+    c = basic_connection
+    touts[c.object_id] = Time.now
+    def c.start; raise Errno::EHOSTDOWN end
+    reqs[c.object_id] = 5
+
+    e = assert_raises Net::HTTP::Persistent::Error do
+      @http.reset c
+    end
+
+    assert_match %r%host down%, e.message
+  end
+
+  def test_reset_io_error
+    c = basic_connection
+    touts[c.object_id] = Time.now
+    reqs[c.object_id] = 5
+
+    @http.reset c
+
+    assert c.started?
+    assert c.finished?
+  end
+
+  def test_reset_refused
+    c = basic_connection
+    touts[c.object_id] = Time.now
+    def c.start; raise Errno::ECONNREFUSED end
+    reqs[c.object_id] = 5
+
+    e = assert_raises Net::HTTP::Persistent::Error do
+      @http.reset c
+    end
+
+    assert_match %r%connection refused%, e.message
+  end
+
+  def test_retry_change_requests_equals
+    get  = Net::HTTP::Get.new('/')
+    post = Net::HTTP::Post.new('/')
+
+    refute @http.retry_change_requests
+
+    assert @http.can_retry?(get)
+    refute @http.can_retry?(post)
+
+    @http.retry_change_requests = true
+
+    assert @http.retry_change_requests
+
+    assert @http.can_retry?(get)
+    assert @http.can_retry?(post)
   end
 
   def test_shutdown
+    ssl_conns
     c = connection
     cs = conns
     rs = reqs
+    ts = touts
 
     orig = @http
     @http = Net::HTTP::Persistent.new 'name'
@@ -818,35 +926,25 @@ class TestNetHttpPersistent < MiniTest::Unit::TestCase
 
     orig.shutdown
 
+    @http = orig
+
     assert c.finished?
     refute c2.finished?
 
     refute_same cs, conns
     refute_same rs, reqs
-  end
-
-  def test_shutdown_not_started
-    c = basic_connection
-    def c.finish() raise IOError end
-
-    conns["#{@uri.host}:#{@uri.port}"] = c
-
-    @http.shutdown
+    refute_same ts, touts
 
-    assert_nil Thread.current[@http.connection_key]
-    assert_nil Thread.current[@http.request_key]
+    assert_empty reqs
+    assert_empty touts
   end
 
-  def test_shutdown_no_connections
-    @http.shutdown
-
-    assert_nil Thread.current[@http.connection_key]
-    assert_nil Thread.current[@http.request_key]
-  end
+  def test_shutdown_in_all_threads
+    ssl_conns
 
-  def test_shutdown_thread
     t = Thread.new do
       c = connection
+      ssl_conns
       conns
       reqs
 
@@ -859,9 +957,11 @@ class TestNetHttpPersistent < MiniTest::Unit::TestCase
 
     c = connection
 
-    @http.shutdown t
+    assert_nil @http.shutdown_in_all_threads
 
-    refute c.finished?
+    assert c.finished?
+    assert_nil Thread.current[@http.connection_key]
+    assert_nil Thread.current[@http.request_key]
 
     t.run
     assert t.value.finished?
@@ -869,7 +969,42 @@ class TestNetHttpPersistent < MiniTest::Unit::TestCase
     assert_nil t[@http.request_key]
   end
 
-  def test_shutdown_in_all_threads
+  def test_shutdown_no_connections
+    ssl_conns
+
+    @http.shutdown
+
+    assert_nil Thread.current[@http.connection_key]
+    assert_nil Thread.current[@http.request_key]
+  end
+
+  def test_shutdown_not_started
+    ssl_conns
+
+    c = basic_connection
+    def c.finish() raise IOError end
+
+    conns["#{@uri.host}:#{@uri.port}"] = c
+
+    @http.shutdown
+
+    assert_nil Thread.current[@http.connection_key]
+    assert_nil Thread.current[@http.request_key]
+  end
+
+  def test_shutdown_ssl
+    @uri = URI 'https://example'
+
+    @http.connection_for @uri
+
+    @http.shutdown
+
+    assert_empty ssl_conns
+  end
+
+  def test_shutdown_thread
+    ssl_conns
+
     t = Thread.new do
       c = connection
       conns
@@ -884,11 +1019,9 @@ class TestNetHttpPersistent < MiniTest::Unit::TestCase
 
     c = connection
 
-    assert_nil @http.shutdown_in_all_threads
+    @http.shutdown t
 
-    assert c.finished?
-    assert_nil Thread.current[@http.connection_key]
-    assert_nil Thread.current[@http.request_key]
+    refute c.finished?
 
     t.run
     assert t.value.finished?
@@ -932,7 +1065,7 @@ class TestNetHttpPersistent < MiniTest::Unit::TestCase
     assert_equal store, c.cert_store
   end
 
-  def test_default_cert_store
+  def test_ssl_cert_store_default
     @http.verify_mode = OpenSSL::SSL::VERIFY_PEER
 
     c = Net::HTTP.new 'localhost', 80
@@ -994,16 +1127,36 @@ class TestNetHttpPersistent < MiniTest::Unit::TestCase
     end
   end
 
-  def test_can_retry_change_requests
-    get  = Net::HTTP::Get.new('/')
-    post = Net::HTTP::Post.new('/')
-    assert @http.can_retry?(get)
-    refute @http.retry_change_requests
-    refute @http.can_retry?(post)
-    @http.retry_change_requests = true
-    assert @http.can_retry?(get)
-    assert @http.retry_change_requests
-    assert @http.can_retry?(post)
+  def test_ssl_cleanup
+    uri1 = URI.parse 'https://one.example'
+    uri2 = URI.parse 'https://two.example'
+
+    c1 = @http.connection_for uri1
+
+    touts[c1.object_id] = Time.now
+    reqs[c1.object_id] = 5
+
+    @http.reconnect_ssl
+
+    @http.ssl_cleanup @http.ssl_generation
+
+    assert_empty ssl_conns
+    assert_empty touts
+    assert_empty reqs # sanity check, performed by #finish
+  end
+
+  def test_verify_callback_equals
+    @http.verify_callback = :verify_callback
+
+    assert_equal :verify_callback, @http.verify_callback
+    assert_equal 1, @http.ssl_generation
+  end
+
+  def test_verify_mode_equals
+    @http.verify_mode = :verify_mode
+
+    assert_equal :verify_mode, @http.verify_mode
+    assert_equal 1, @http.ssl_generation
   end
 
 end

data/test/test_net_http_persistent_ssl_reuse.rb

@@ -75,6 +75,7 @@ class TestNetHttpPersistentSSLReuse < MiniTest::Unit::TestCase
   def test_ssl_connection_reuse
     @http = Net::HTTP::Persistent::SSLReuse.new @host, @port
     @http.use_ssl = true
+    @http.verify_mode = OpenSSL::SSL::VERIFY_PEER
     @http.verify_callback = proc do |_, store_ctx|
       store_ctx.current_cert.to_der == @cert.to_der
     end

metadata

@@ -1,12 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: net-http-persistent
 version: !ruby/object:Gem::Version 
-  hash: 11
+  hash: 29
   prerelease: 
   segments: 
   - 2
   - 4
-  version: "2.4"
+  - 1
+  version: 2.4.1
 platform: ruby
 authors: 
 - Eric Hodel
@@ -35,7 +36,7 @@ cert_chain:
   YJY7T/W2n+eWy8WuPhzVUkyzguj0bQe27NDeabgCh2mHd4Hynk2AkYh8MQ==
   -----END CERTIFICATE-----
 
-date: 2012-01-31 00:00:00 Z
+date: 2012-02-04 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: minitest