net-http-persistent 1.8 → 1.8.1

data/History.txt

@@ -1,3 +1,9 @@
+=== 1.8.1 / 2011-08-08
+
+* Bug Fix
+  * Requests with OpenSSL errors are retried now.  Pull Request #5 by James
+    Tucker.
+
 === 1.8 / 2011-06-27
 
 * Minor Enhancement

data/README.txt

@@ -1,12 +1,12 @@
 = net-http-persistent
 
-* http://seattlerb.rubyforge.org/net-http-persistent
+* http://docs.seattlerb.org/net-http-persistent
 * https://github.com/drbrain/net-http-persistent
 
 == DESCRIPTION:
 
-Manages persistent connections using Net::HTTP plus a speed fix for 1.8.  It's
-thread-safe too!
+Manages persistent connections using Net::HTTP plus a speed fix for Ruby 1.8.
+It's thread-safe too!
 
 Using persistent HTTP connections can dramatically increase the speed of HTTP.
 Creating a new HTTP connection for every request involves an extra TCP
@@ -14,14 +14,14 @@ round-trip and causes TCP congestion avoidance negotiation to start over.
 
 Net::HTTP supports persistent connections with some API methods but does not
 handle reconnection gracefully.  net-http-persistent supports reconnection
-according to RFC 2616.
+and retry according to RFC 2616.
 
 == FEATURES/PROBLEMS:
 
 * Supports SSL
 * Thread-safe
 * Pure ruby
-* Timeout-less speed boost for 1.8 (by Aaron Patterson)
+* Timeout-less speed boost for Ruby 1.8 (by Aaron Patterson)
 
 == INSTALL:
 

data/lib/net/http/persistent.rb

@@ -1,4 +1,5 @@
 require 'net/http'
+require 'net/https'
 require 'net/http/faster'
 require 'uri'
 require 'cgi' # for escaping
@@ -42,7 +43,7 @@ class Net::HTTP::Persistent
   ##
   # The version of Net::HTTP::Persistent use are using
 
-  VERSION = '1.8'
+  VERSION = '1.8.1'
 
   ##
   # Error class for errors raised by Net::HTTP::Persistent.  Various
@@ -435,7 +436,7 @@ class Net::HTTP::Persistent
       retry
     rescue IOError, EOFError, Timeout::Error,
            Errno::ECONNABORTED, Errno::ECONNRESET, Errno::EPIPE,
-           Errno::EINVAL => e
+           Errno::EINVAL, OpenSSL::SSL::SSLError => e
 
       if retried or not can_retry? req
         due_to = "(due to #{e.message} - #{e.class})"
@@ -506,7 +507,6 @@ class Net::HTTP::Persistent
   # Enables SSL on +connection+
 
   def ssl connection
-    require 'net/https'
     connection.use_ssl = true
 
     # suppress warning but allow override

data/test/test_net_http_persistent.rb

@@ -473,6 +473,19 @@ class TestNetHttpPersistent < MiniTest::Unit::TestCase
     assert_match %r%connection refused%, e.message
   end
 
+  def test_ssl_error
+    uri = URI.parse 'https://example.com/path'
+    c = @http.connection_for uri
+    def c.request(*)
+      raise OpenSSL::SSL::SSLError, "SSL3_WRITE_PENDING:bad write retry"
+    end
+
+    e = assert_raises Net::HTTP::Persistent::Error do
+      @http.request uri
+    end
+    assert_match %r%bad write retry%, e.message
+  end
+
   def test_request
     @http.headers['user-agent'] = 'test ua'
     c = connection

metadata

@@ -1,12 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: net-http-persistent
 version: !ruby/object:Gem::Version 
-  hash: 31
+  hash: 53
   prerelease: 
   segments: 
   - 1
   - 8
-  version: "1.8"
+  - 1
+  version: 1.8.1
 platform: ruby
 authors: 
 - Eric Hodel
@@ -35,7 +36,7 @@ cert_chain:
   x52qPcexcYZR7w==
   -----END CERTIFICATE-----
 
-date: 2011-06-27 00:00:00 Z
+date: 2011-08-09 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: minitest
@@ -69,8 +70,8 @@ dependencies:
   type: :development
   version_requirements: *id002
 description: |-
-  Manages persistent connections using Net::HTTP plus a speed fix for 1.8.  It's
-  thread-safe too!
+  Manages persistent connections using Net::HTTP plus a speed fix for Ruby 1.8.
+  It's thread-safe too!
   
   Using persistent HTTP connections can dramatically increase the speed of HTTP.
   Creating a new HTTP connection for every request involves an extra TCP
@@ -78,7 +79,7 @@ description: |-
   
   Net::HTTP supports persistent connections with some API methods but does not
   handle reconnection gracefully.  net-http-persistent supports reconnection
-  according to RFC 2616.
+  and retry according to RFC 2616.
 email: 
 - drbrain@segment7.net
 executables: []
@@ -99,9 +100,11 @@ files:
 - lib/net/http/faster.rb
 - lib/net/http/persistent.rb
 - test/test_net_http_persistent.rb
-homepage: http://seattlerb.rubyforge.org/net-http-persistent
+homepage: http://docs.seattlerb.org/net-http-persistent
 licenses: []
 
+metadata: {}
+
 post_install_message: 
 rdoc_options: 
 - --main
@@ -129,9 +132,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: net-http-persistent
-rubygems_version: 1.8.5
+rubygems_version: 1.8.6
 signing_key: 
-specification_version: 3
-summary: Manages persistent connections using Net::HTTP plus a speed fix for 1.8
+specification_version: 4
+summary: Manages persistent connections using Net::HTTP plus a speed fix for Ruby 1.8
 test_files: 
 - test/test_net_http_persistent.rb