net-http-ntlm 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b136952fd078c094ec85c2e78dd3d7d9a4debabe199dab0bd85f13665cb4a4ff
-  data.tar.gz: b53ab6adf869d124c1e9e4cfdf51737c54225e0f9f18872f661d95cbe148ee84
+  metadata.gz: d17690754e29faf36ce1bdb21ec366a0be3ff33340c68cf5c912ff2c8229cf03
+  data.tar.gz: c9a048d0a4867e6497bad06f7fe29efd4d8024ec2af235f2078469d10ba64228
 SHA512:
-  metadata.gz: ca6f9132f7300130f80e56a1ea41c92154f0e84a149beaee084436bed54364de622d52d3a1a297a934d19d0da6e43fcf7c31cfd045ebaa038da7f9be670b9603
-  data.tar.gz: 745928e94699848e2a6480badecb5f9be7251417bc6644c606d64d96957bd64be69ddd3eb1a6b9f51a4a94a1fb09eb69c47315d6bf7abfe93b6b922dd290c027
+  metadata.gz: 9705c91a52c549047ac737a433f56882b2334226a68e5c01e512766f1abbcd21665b46ba55f825a95974dcaa36359c0a81d700c8d3586fba9495d0e8cb1c5055
+  data.tar.gz: 282522d98b79f2b87cd933ca49b57b531c3d72a3d7e5a2800ffd522fd641d614304f9d245410d19a47f8c6c9faec9b0ecf4692bbc40e89dc503295e32222632c

data/.github/workflows/ci.yml

@@ -1,14 +1,5 @@
 name: CI
-
-on:
-  push:
-    branches:
-      - main
-  pull_request:
-  pull_request_target:
-    branches:
-      - main
-
+on: [push, pull_request]
 jobs:
   ci:
     name: CI
@@ -16,17 +7,22 @@ jobs:
       matrix:
         os-version: [ 'ubuntu-latest' ]
         ruby-version:
-          - 2.5
-          - 2.6
-          - 2.7
           - 3.0
-      fail-fast: true
+          - 3.1
+          - 3.2
+        include:
+          - ruby-version: '3.1'
+            coverage: 'true'
+      fail-fast: false
 
     runs-on: ${{ matrix.os-version }}
 
+    env:
+      COVERAGE: "${{matrix.coverage}}"
+
     steps:
       - name: Checkout code
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
@@ -35,10 +31,11 @@ jobs:
           bundler-cache: true
 
       - name: Run bundler-audit
-        run: bundle exec bundler-audit
-
-      # - name: Run rubocop
-      #   run: bundle exec rubocop
+        run: |
+          bundle exec bundler-audit update
+          bundle exec bundler-audit
 
       - name: Run rspec
-        run: bundle exec rspec
+        env:
+          OPENSSL_CONF: etc/openssl.cnf
+        run: bundle exec rspec

data/.github/workflows/release.yml

@@ -0,0 +1,39 @@
+name: Release
+on:
+  push:
+    branches:
+      - main
+jobs:
+  release-please:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: GoogleCloudPlatform/release-please-action@v2
+        id: release
+        with:
+          release-type: ruby
+          package-name: release-please-demo
+          bump-minor-pre-major: true
+          version-file: "lib/net/http/ntlm/version.rb"
+      # Checkout code if release was created
+      - uses: actions/checkout@v2
+        if: ${{ steps.release.outputs.release_created }}
+      # Setup ruby if a release was created
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 3.1
+        if: ${{ steps.release.outputs.release_created }}
+      # Bundle install
+      - run: bundle install
+        if: ${{ steps.release.outputs.release_created }}
+      # Publish
+      - name: publish gem
+        env:
+          RUBYGEMS_API_KEY: ${{ secrets.RUBYGEMS_API_KEY }}
+        run: |
+          mkdir -p $HOME/.gem
+          touch $HOME/.gem/credentials
+          chmod 0600 $HOME/.gem/credentials
+          printf -- "---\n:rubygems_api_key: ${RUBYGEMS_API_KEY}\n" > $HOME/.gem/credentials
+          gem build *.gemspec
+          gem push *.gem
+        if: ${{ steps.release.outputs.release_created }}

data/.gitignore

@@ -62,4 +62,6 @@ build-iPhoneSimulator/
 .tool-versions
 
 # MacOS
-.DS_Store
+.DS_Store
+
+Gemfile.lock

data/.simplecov

@@ -3,3 +3,8 @@
 SimpleCov.start do
   add_filter '/spec/'
 end
+
+if ENV['CI'] == 'true' && ENV['COVERAGE'] == 'true'
+  require 'codecov'
+  SimpleCov.formatter = SimpleCov::Formatter::Codecov
+end

data/CHANGELOG.md

@@ -0,0 +1,8 @@
+# Changelog
+
+## [0.2.0](https://www.github.com/at-point/net-http-ntlm/compare/v0.1.0...v0.2.0) (2023-12-04)
+
+
+### Features
+
+* Drop Ruby 2.x support

data/README.md

@@ -1,5 +1,7 @@
 # net-http-ntlm
 [![CI](https://github.com/at-point/net-http-ntlm/actions/workflows/ci.yml/badge.svg?branch=main)](https://github.com/at-point/net-http-ntlm/actions/workflows/ci.yml)
+[![Coverage](https://codecov.io/gh/at-point/net-http-ntlm/branch/main/graph/badge.svg?token=B9C9BRLWR6)](https://codecov.io/gh/at-point/net-http-ntlm)
+[![Gem Version](https://badge.fury.io/rb/net-http-ntlm.svg)](https://badge.fury.io/rb/net-http-ntlm)
 
 Adds NTLM authentication to HTTP requests using the rubyntlm gem.
 A drop-in replacement for ruby-ntlm with NTLMv2 support.
@@ -7,11 +9,10 @@ A drop-in replacement for ruby-ntlm with NTLMv2 support.
 NTLM authentication is used in Microsoft's server products,
 such as MS Exchange Server and IIS.
 
-Install
--------
+## Install
 
 ```sh
-$ sudo gem install net-http-ntlm
+gem install net-http-ntlm
 ```
 
 If you'd rather install net-http-ntlm using `bundler`, add a line for it in your Gemfile:
@@ -20,19 +21,26 @@ If you'd rather install net-http-ntlm using `bundler`, add a line for it in your
 gem 'net-http-ntlm'
 ```
 
-Usage
------
+## Note about Ruby 3 and OpenSSL 3
+
+NTLM potentially uses legacy ciphers, which need to be enabled explicitly.
+
+You can either create a custom OpenSSL profile in Ruby or load a custom SSL
+configuration by setting `OPENSSL_CONF=` before Ruby loads.
+
+There's an example in the [Github Actions][.github/workflows/ci.yml]
+
+## Usage
 
 ```rb
-require 'ntlm/http'
+require 'net/http/ntlm'
 http = Net::HTTP.new('www.example.com')
 request = Net::HTTP::Get.new('/')
 request.ntlm_auth('User', 'Domain', 'Password')
 response = http.request(request)
 ```
 
-References
-----------
+## References
 
- * rubyntlm: https://github.com/WinRb/rubyntlm
- * ruby-ntlm: https://github.com/macks/ruby-ntlm
+*   rubyntlm: https://github.com/WinRb/rubyntlm
+*   ruby-ntlm: https://github.com/macks/ruby-ntlm

data/lib/net/http/ntlm/transport.rb

@@ -13,7 +13,7 @@ module Net::HTTP::NTLM::Transport
   # @param body [String] Request body
   # @yield [Net::HTTPResponse] Passes the HTTP response object to the block
   # @return [Net::HTTPResponse] The HTTP response object
-  def request_with_ntlm(req, body = nil, &block) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity, Metrics/MethodLength
+  def request_with_ntlm(req, body = nil, &block)
     # If we don't have NTLM credentials, handle as regular request
     return request_without_ntlm_auth(req, body, &block) unless req.ntlm_auth_user
 

data/lib/net/http/ntlm/version.rb

@@ -3,5 +3,5 @@
 require 'net/http'
 
 module Net::HTTP::NTLM
-  VERSION = '0.1.0'
+  VERSION = '0.2.0'
 end

data/net-http-ntlm.gemspec

@@ -11,7 +11,7 @@ Gem::Specification.new do |spec|
   spec.summary       = 'NTLM authentication for Net::HTTP'
   spec.description   = 'Adds NTLM authentication support for Net::HTTP using rubyntlm'
   spec.homepage      = 'https://github.com/at-point/net-http-ntlm'
-  spec.required_ruby_version = Gem::Requirement.new('>= 2.5.0')
+  spec.required_ruby_version = Gem::Requirement.new('>= 3.0.0')
 
   spec.metadata['homepage_uri'] = spec.homepage
   spec.metadata['source_code_uri'] = 'https://github.com/at-point/net-http-ntlm'
@@ -20,7 +20,7 @@ Gem::Specification.new do |spec|
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
   spec.files = Dir.chdir(File.expand_path(__dir__)) do
-    `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
+    `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features|etc)/}) }
   end
   spec.bindir        = 'exe'
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
@@ -28,9 +28,10 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency 'rubyntlm', '~> 0.6'
 
-  spec.add_development_dependency 'bundler-audit', '~> 0.8'
-  spec.add_development_dependency 'rake', '~> 12.0'
+  spec.add_development_dependency 'bundler-audit', '~> 0.9'
+  spec.add_development_dependency 'codecov'
+  spec.add_development_dependency 'rake', '~> 13.0'
   spec.add_development_dependency 'rspec', '~> 3.0'
-  spec.add_development_dependency 'rubocop', '~> 1.0'
   spec.add_development_dependency 'simplecov'
+
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: net-http-ntlm
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Simon Schmid
-autorequire:
+autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-05-27 00:00:00.000000000 Z
+date: 2023-12-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubyntlm
@@ -30,56 +30,56 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '0.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '0.9'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: codecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '12.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '12.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
-  name: rubocop
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -102,12 +102,12 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".github/workflows/ci.yml"
+- ".github/workflows/release.yml"
 - ".gitignore"
 - ".rspec"
-- ".rubocop.yml"
 - ".simplecov"
+- CHANGELOG.md
 - Gemfile
-- Gemfile.lock
 - LICENSE
 - README.md
 - Rakefile
@@ -127,7 +127,7 @@ metadata:
   homepage_uri: https://github.com/at-point/net-http-ntlm
   source_code_uri: https://github.com/at-point/net-http-ntlm
   changelog_uri: https://github.com/at-point/net-http-ntlm/blob/main/CHANGELOG.md
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -135,16 +135,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.5.0
+      version: 3.0.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project:
-rubygems_version: 2.7.6
-signing_key:
+rubygems_version: 3.3.26
+signing_key: 
 specification_version: 4
 summary: NTLM authentication for Net::HTTP
 test_files: []

data/.rubocop.yml

@@ -1,15 +0,0 @@
-AllCops:
-  TargetRubyVersion: 2.5
-  Exclude:
-    - bin/*
-
-Style/ClassAndModuleChildren:
-  Enabled: false
-
-Layout/LineLength:
-  Exclude:
-    - spec/**/*
-
-Metrics/BlockLength:
-  Exclude:
-    - spec/**/*

data/Gemfile.lock

@@ -1,70 +0,0 @@
-PATH
-  remote: .
-  specs:
-    net-http-ntlm (0.1.0)
-      rubyntlm (~> 0.6)
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    ast (2.4.2)
-    bundler-audit (0.8.0)
-      bundler (>= 1.2.0, < 3)
-      thor (~> 1.0)
-    diff-lcs (1.4.4)
-    docile (1.4.0)
-    parallel (1.20.1)
-    parser (3.0.1.1)
-      ast (~> 2.4.1)
-    rainbow (3.0.0)
-    rake (12.3.3)
-    regexp_parser (2.1.1)
-    rexml (3.2.5)
-    rspec (3.10.0)
-      rspec-core (~> 3.10.0)
-      rspec-expectations (~> 3.10.0)
-      rspec-mocks (~> 3.10.0)
-    rspec-core (3.10.1)
-      rspec-support (~> 3.10.0)
-    rspec-expectations (3.10.1)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.10.0)
-    rspec-mocks (3.10.2)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.10.0)
-    rspec-support (3.10.2)
-    rubocop (1.15.0)
-      parallel (~> 1.10)
-      parser (>= 3.0.0.0)
-      rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.8, < 3.0)
-      rexml
-      rubocop-ast (>= 1.5.0, < 2.0)
-      ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.6.0)
-      parser (>= 3.0.1.1)
-    ruby-progressbar (1.11.0)
-    rubyntlm (0.6.3)
-    simplecov (0.21.2)
-      docile (~> 1.1)
-      simplecov-html (~> 0.11)
-      simplecov_json_formatter (~> 0.1)
-    simplecov-html (0.12.3)
-    simplecov_json_formatter (0.1.3)
-    thor (1.1.0)
-    unicode-display_width (2.0.0)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  bundler-audit (~> 0.8)
-  net-http-ntlm!
-  rake (~> 12.0)
-  rspec (~> 3.0)
-  rubocop (~> 1.0)
-  simplecov
-
-BUNDLED WITH
-   2.1.4