nepali_number 0.1.1 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 53c5a8948ff5001b817cf6d50aa1eb976b40d1f196f64aaf41247829f4df8ff9
-  data.tar.gz: 2111bea2826bb3dac0b07f43eae8f092ebb5846bcfbdc19eba2a5b6142725d5a
+  metadata.gz: a820051dbeea8f45d3a9f5b8e23b170f3d2339827cbbf94a9a81c0074cb7bf95
+  data.tar.gz: 69652253a7c525b58b6f41d67f7663e0193adf1083ecf36fcdb4b51ce9584a19
 SHA512:
-  metadata.gz: 5701edfaaf508c38c20918212873035448218361bbd5a47da860c04a22060ff1fadd07c7d33e97cb7d0617385eb36893fcd9a70f8db9a70c631da84a4ff4ef8a
-  data.tar.gz: e4cc344934ac8fd2d2033bb17eab1e1fa94a02e789beb176116b168f38ee6e27f5f8824a2125a15d642d026650f8a927b436280eb62dba862e837522d9291f5f
+  metadata.gz: 4c6b68ff373bfef520a3bbe2d9f6a88ddad7b910d203a775dac8d39d5b245e3c6d67636a28d4b9eb1494f8d0ec9d4ee3c57614fff70ed2434de74fdf80c4b357
+  data.tar.gz: 86c53d7f1287b9b6ae95c21ce6a1e262f3e6b45dfbb344c2e60a46375fdcfb73fbb1f21acc6e60bc98370bd1e5110a7d51984926cff2252d47f5ed597282ff8f

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## [0.2.0] - 2026-10-05
+
+- Fix whole `BigDecimal` values rendering with a phantom decimal place. `BigDecimal#to_s("F")` always emits at least one digit after the point, so `NepaliNumber.format(BigDecimal("10"))` returned `"10.0"` and `BigDecimal("100.00")` returned `"100.0"`. Whole values now render as whole numbers: `"10"`, `"1,00,000"`. This also reaches `NepaliNumber.currency`, where whole money previously gained a `.0`.
+- A value that genuinely carries a fraction is unchanged (`BigDecimal("10.5")` still formats as `"10.5"`). Truncating or rounding a fraction stays the caller's decision; the formatter no longer invents one.
+
 ## [0.1.1] - 2026-09-06
 
 - Change default currency symbol from `रु.` to `रु` and remove the default space, so `NepaliNumber.currency(100)` now returns `रु100` (matching `रु1.45` style per Wikipedia/NPR convention).

data/README.md

@@ -22,6 +22,18 @@ NepaliNumber.format("123456.78")
 # => "1,23,456.78"
 ```
 
+A `BigDecimal` with no fractional part formats as a whole number, whatever scale
+its literal carried. One that genuinely has a fraction keeps it, so rounding or
+truncating stays the caller's decision rather than the formatter's.
+
+```ruby
+NepaliNumber.format(BigDecimal("100.0000"))
+# => "100"
+
+NepaliNumber.format(BigDecimal("10.5"))
+# => "10.5"
+```
+
 ### Currency
 
 ```ruby
@@ -63,9 +75,49 @@ When Rails is loaded, NepaliNumber adds explicit helpers:
 
 ## Development
 
-After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake test` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
+After checking out the repo, run `bin/setup` (or `bundle install`) to install dependencies. You can also run `bin/console` for an interactive prompt.
+
+### Running tests
+
+```sh
+bundle install
+bundle exec rake test      # Minitest (test/test_nepali_number.rb)
+bundle exec rake standard  # lint (Standard Ruby)
+bundle exec rake           # runs test + standard
+```
+
+### Publishing to RubyGems
+
+This repo uses custom release tasks (`Rakefile:19`) — `bundler/gem_tasks` release is not used.
+
+```sh
+# 0. Ensure a clean working tree
+git status --porcelain  # must be empty
+
+# 1. Bump version in lib/nepali_number/version.rb:4
+bundle exec rake release:bump[patch]  # or [minor], [major], or [0.2.0]
+# 2. Update CHANGELOG.md and commit
+git add lib/nepali_number/version.rb CHANGELOG.md
+git commit -m "Bump version to X.Y.Z"
+
+# 3. Verify, build, and print publish commands
+bundle exec rake release:prepare  # runs release:check_clean, test, standard, build
+# -> builds pkg/nepali_number-X.Y.Z.gem (pkg/ is gitignored)
+
+# 4. Push to RubyGems (MFA OTP required)
+bundle exec gem push pkg/nepali_number-X.Y.Z.gem --otp <6-digit-code>
+# gem push uses credentials in ~/.local/share/gem/credentials (see `gem env`)
+
+# 5. Tag and push tag
+git tag vX.Y.Z
+git push origin vX.Y.Z
+```
+
+Tips:
 
-To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and the created tag, and push the `.gem` file to [rubygems.org](https://rubygems.org).
+- `bundle exec rake release:build` — build only.
+- `bundle exec rake release:commands` — print artifact path and `gem push` / `git tag` commands without running checks.
+- To install locally without publishing: `bundle exec rake install`.
 
 ## Contributing
 

data/lib/nepali_number/formatter.rb

@@ -23,12 +23,28 @@ module NepaliNumber
 
       private
 
+      # BigDecimal#to_s("F") always emits at least one decimal place, so a value
+      # carrying no fraction at all -- BigDecimal("10") -- came out as "10.0". That
+      # is an artifact of the rendering, not the number: it made whole share
+      # quantities read as fractional, and it did the same to whole money.
+      #
+      # A value that does carry a fraction keeps it. Callers that need a fraction
+      # rounded or dropped decide that themselves; the formatter's job is to not
+      # invent one.
       def normalize(number)
-        return number.to_s("F") if number.is_a?(BigDecimal)
+        return normalize_bigdecimal(number) if number.is_a?(BigDecimal)
 
         number.to_s.delete(",")
       end
 
+      def normalize_bigdecimal(number)
+        return number.to_i.to_s if number.frac.zero?
+
+        # to_s("F") keeps the full precision here, which is the point -- only the
+        # trailing ".0" of a whole value was ever wrong.
+        number.to_s("F")
+      end
+
       def group_integer(integer, delimiter)
         return integer if integer.length <= 3
 

data/lib/nepali_number/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module NepaliNumber
-  VERSION = "0.1.1"
+  VERSION = "0.2.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: nepali_number
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - Saroj Maharjan (zoras)
@@ -69,7 +69,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.19
+rubygems_version: 4.0.22
 specification_version: 4
 summary: Nepali number formatting, humanization, digit conversion, and currency helpers.
 test_files: []