negative_captcha 0.3.3 → 0.4

data/README.markdown

@@ -46,9 +46,6 @@ You can let bundler install Negative Captcha by adding this line to your applica
 gem 'negative_captcha'
 ```
 
-And then execute:
-
-    bundle install
 
 ### Controller Hooks
 
@@ -64,10 +61,14 @@ In the same controller include the following private method:
 private
   def setup_negative_captcha
     @captcha = NegativeCaptcha.new(
-      :secret => NEGATIVE_CAPTCHA_SECRET, #A secret key entered in environment.rb. 'rake secret' will give you a good one.
-      :spinner => request.remote_ip, 
-      :fields => [:name, :email, :body], #Whatever fields are in your form 
-      :params => params
+      # A secret key entered in environment.rb. 'rake secret' will give you a good one.
+      secret: NEGATIVE_CAPTCHA_SECRET,
+      spinner: request.remote_ip,
+      # Whatever fields are in your form
+      fields: [:name, :email, :body],
+      # If you wish to override the default CSS styles (position: absolute; left: -2000px;) used to position the fields off-screen
+      css: "display: none",
+      params: params
     )
   end
 ```
@@ -76,11 +77,15 @@ Modify your POST action(s) to check for the validity of the negative captcha for
 
 ```ruby
 def create
-  @comment = Comment.new(@captcha.values) #Decrypted params
+  # Decrypted params are stored in @captcha.values
+  @comment = Comment.new(@captcha.values)
+
+  # @captcha.valid? will return false if a bot submitted the form
   if @captcha.valid? && @comment.save
     redirect_to @comment
   else
-    flash[:notice] = @captcha.error if @captcha.error 
+    # @captcha.error will explain what went wrong
+    flash[:notice] = @captcha.error if @captcha.error
     render :action => 'new'
   end
 end
@@ -89,14 +94,14 @@ end
 ### Automated tests
 
 To make all field ids and names predictable for tests,
-simply add the following line in config/environments/test.rb
+simply add the following line in your spec helper.
 
 ```ruby
 NegativeCaptcha.test_mode = true
 ```
 
-This will ensure that a field named email will not generate a hash but a field name test-email instead.
-A tool like cucumber can now bypass this security while still going through the captcha workflow.
+This will ensure that a field named `email` will not be referred to by a hash but by `test-email` instead.
+A tool like capybara can now bypass this security while still going through the captcha workflow.
 
 ### Form Example
 
@@ -104,19 +109,20 @@ Modify your form to include the honeypots and other fields. You can probably lea
 
 ```erb
 <% form_tag comments_path do -%>
+  <%# The `negative_captcha` call gives us the honeypots, spinners and whatnot %>
   <%= raw negative_captcha(@captcha) %>
   <ul class="contact_us">
     <li>
       <%= negative_label_tag(@captcha, :name, 'Name:') %>
-      <%= negative_text_field_tag @captcha, :name %>
+      <%= negative_text_field_tag(@captcha, :name) %>
     </li>
     <li>
       <%= negative_label_tag(@captcha, :email, 'Email:') %>
-      <%= negative_text_field_tag @captcha, :email %>
+      <%= negative_text_field_tag(@captcha, :email) %>
     </li>
     <li>
       <%= negative_label_tag(@captcha, :body, 'Your Comment:') %>
-      <%= negative_text_area_tag @captcha, :body %>
+      <%= negative_text_area_tag(@captcha, :body) %>
     </li>
     <li>
       <%= submit_tag %>

data/lib/negative_captcha/view_helpers.rb

@@ -14,7 +14,7 @@ module ActionView
           negative_captcha.values[field],
           options
         ) +
-          content_tag('div', :style => 'position: absolute; left: -2000px;') do
+          content_tag('div', :style => negative_captcha.css) do
           text_field_tag(field, '', :tabindex => '999', :autocomplete => 'off')
         end.html_safe
       end
@@ -25,7 +25,7 @@ module ActionView
           negative_captcha.values[field],
           options
         ) +
-          content_tag('div', :style => 'position: absolute; left: -2000px;') do
+          content_tag('div', :style => negative_captcha.css) do
           text_area_tag(field, '', :tabindex => '999', :autocomplete => 'off')
         end.html_safe
       end
@@ -36,7 +36,7 @@ module ActionView
           negative_captcha.values[field],
           options
         ) +
-        content_tag('div', :style => 'position: absolute; left: -2000px;') do
+        content_tag('div', :style => negative_captcha.css) do
           hidden_field_tag(field, '', :tabindex => '999')
         end.html_safe
       end
@@ -46,7 +46,7 @@ module ActionView
           negative_captcha.fields[field],
           options.merge(:value => negative_captcha.values[field])
         ) +
-        content_tag('div', :style => 'position: absolute; left: -2000px;') do
+        content_tag('div', :style => negative_captcha.css) do
           file_field_tag(field, :tabindex => '999')
         end
       end
@@ -57,7 +57,7 @@ module ActionView
           negative_captcha.values[field],
           options
         ) +
-        content_tag('div', :style => 'position: absolute; left: -2000px;') do
+        content_tag('div', :style => negative_captcha.css) do
           check_box_tag(field, '', :tabindex => '999')
         end
       end
@@ -68,7 +68,7 @@ module ActionView
           negative_captcha.values[field],
           options
         ) +
-        content_tag('div', :style => 'position: absolute; left: -2000px;') do
+        content_tag('div', :style => negative_captcha.css) do
           password_field_tag(field, '', :tabindex => '999')
         end.html_safe
       end

data/lib/negative_captcha.rb

@@ -7,6 +7,7 @@ class NegativeCaptcha
     :values,
     :secret,
     :spinner,
+    :css,
     :message,
     :timestamp,
     :error
@@ -30,6 +31,8 @@ class NegativeCaptcha
       ([timestamp, secret] + Array(opts[:spinner])).join('-')
     )
 
+    self.css = opts[:css] || "position: absolute; left: -2000px;"
+
     self.message = opts[:message] || <<-MESSAGE
 Please try again.
 This usually happens because an automated script attempted to submit this form.
@@ -56,7 +59,7 @@ This usually happens because an automated script attempted to submit this form.
   end
 
   def valid?
-    error.nil? || error == "" || error.empty?
+    error.blank?
   end
 
   def process(params)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: negative_captcha
 version: !ruby/object:Gem::Version
-  version: 0.3.3
+  version: '0.4'
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-06-18 00:00:00.000000000 Z
+date: 2014-12-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack