negative_captcha 0.3 → 0.3.1

data/README.markdown

@@ -73,6 +73,15 @@ Modify your POST action(s) to check for the validity of the negative captcha for
         render :action => 'new'
       end
     end
+### Automated tests
+
+To make all field ids and names predictable for tests,
+simply add the following line in config/environments/test.rb
+    
+    NegativeCaptcha.test_mode = true
+
+This will ensure that a field named email will not generate a hash but a field name test-email instead.
+A tool like cucumber can now bypass this security while still going through the captcha workflow.
 
 ### Form Example
 

data/lib/negative_captcha.rb

@@ -10,6 +10,11 @@ class NegativeCaptcha
     :timestamp,
     :error
 
+  @@test_mode = false
+  def self.test_mode=(value)
+    class_variable_set(:@@test_mode, value)
+  end
+
   def initialize(opts)
     self.secret = opts[:secret] ||
       Digest::MD5.hexdigest("this_is_a_secret_key")
@@ -30,7 +35,7 @@ This usually happens because an automated script attempted to submit this form.
     MESSAGE
 
     self.fields = opts[:fields].inject({}) do |hash, field_name|
-      hash[field_name] = Digest::MD5.hexdigest(
+      hash[field_name] = @@test_mode ? "test-#{field_name}" : Digest::MD5.hexdigest(
         [field_name, spinner, secret].join('-')
       )
 
@@ -60,7 +65,7 @@ This usually happens because an automated script attempted to submit this form.
       self.error = "Error: Invalid timestamp.  #{message}"
     elsif params[:spinner] != spinner
       self.error = "Error: Invalid spinner.  #{message}"
-    elsif fields.keys.detect {|name| params[name] && params[name].length > 0}
+    elsif fields.keys.detect {|name| params[name] && params[name] =~ /\S/}
       self.error = <<-ERROR
 Error: Hidden form fields were submitted that should not have been. #{message}
       ERROR

data/lib/negative_captcha/view_helpers.rb

@@ -36,9 +36,9 @@ module ActionView
           negative_captcha.values[field],
           options
         ) +
-          "<div style='position: absolute; left: -2000px;'>" +
-          hidden_field_tag(field, '', :tabindex => '999') +
-          "</div>".html_safe
+        content_tag('div', :style => 'position: absolute; left: -2000px;') do
+          hidden_field_tag(field, '', :tabindex => '999')
+        end.html_safe
       end
 
       def negative_password_field_tag(negative_captcha, field, options={})
@@ -47,9 +47,9 @@ module ActionView
           negative_captcha.values[field],
           options
         ) +
-          "<div style='position: absolute; left: -2000px;'>" +
-          password_field_tag(field, '', :tabindex => '999') +
-          "</div>".html_safe
+        content_tag('div', :style => 'position: absolute; left: -2000px;') do
+          password_field_tag(field, '', :tabindex => '999')
+        end.html_safe
       end
 
       def negative_label_tag(negative_captcha, field, name, options={})

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: negative_captcha
 version: !ruby/object:Gem::Version
-  version: '0.3'
+  version: 0.3.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-06-01 00:00:00.000000000 Z
+date: 2012-11-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack