neetob 0.2.7 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 44fc7447c47930d63937f671b215e6e74de9b913f754df9ad4a591e625d84f0e
-  data.tar.gz: e0a3ea5d9e64e44545d2f22b0120ee397fdb9235f7c6e60ef3704a18f8d79954
+  metadata.gz: 129689cbd6ed773bb8b33aced3e726123662c5cc772c52287a3464bf63fe324b
+  data.tar.gz: ea5801918efe691ab99c985315fded011149eab7dc0082481d4c6ce6f41c2594
 SHA512:
-  metadata.gz: fd471b240cdab4e99c1dab47bb104c108324613507a5943a3b206785c98949382efef27a980c63d3a7b4c3633f3a62fa911074420176c6e57e3d64a91c608b60
-  data.tar.gz: 35cd801899082fc2e999a4f5075da10bd22b06d21a1c36252c03c007a70b97a1332d65191f4480b5bd5b1fa44466a844809c78b99fa06d7d16064b60a936bde5
+  metadata.gz: 6e933f42dc569195d856c707ac01911e71538057afcd4d447ab50242330a498d2fb31f769f1375a03bd3fbbad0e105dd24094ad642e74ed2cea0fdf751b5c5e4
+  data.tar.gz: 8a543540b8974374280c0b2781b99c7819918d34c0248b53dd85d0792d05004b4de407717d5bbd3a87881604672d1c714b11986f6642efb1af360a0952bb34e6

data/CHANGELOG.md

@@ -1,5 +1,17 @@
 ## [Unreleased]
 
+## [0.3.0](https://www.github.com/bigbinary/neetob/compare/v0.2.7...v0.3.0) (2023-03-23)
+
+
+### Features
+
+* Added command to audit neeto products db-schema. ([#230](https://www.github.com/bigbinary/neetob/issues/230)) ([1401abc](https://www.github.com/bigbinary/neetob/commit/1401abc77e3dedfbf156266a328de7a3d4fe6bb0))
+
+
+### Bug Fixes
+
+* Enhanced compliance fix command ([#225](https://www.github.com/bigbinary/neetob/issues/225)) ([a41c95c](https://www.github.com/bigbinary/neetob/commit/a41c95c435173f331a2872ca5a9192c38fc04e22))
+
 ### [0.2.7](https://www.github.com/bigbinary/neetob/compare/v0.2.6...v0.2.7) (2023-03-16)
 
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    neetob (0.2.7)
+    neetob (0.3.0)
       dotenv (~> 2.8.1)
       launchy (~> 2.5.0)
       octokit (~> 4.0)
@@ -164,7 +164,7 @@ GEM
       method_source (~> 1.0)
     public_suffix (5.0.0)
     racc (1.6.1)
-    rack (2.2.6.2)
+    rack (2.2.6.4)
     rack-test (2.0.2)
       rack (>= 1.3)
     rails (7.0.4)

data/lib/neetob/cli/code/audit.rb

@@ -0,0 +1,56 @@
+# frozen_string_literal: true
+
+require_relative "../github/base"
+
+module Neetob
+  class CLI
+    module Code
+      class Audit < Github::Base
+        attr_accessor :sandbox, :apps
+
+        def initialize(apps, sandbox = false)
+          super()
+          @apps = apps
+          @sandbox = sandbox
+        end
+
+        def run
+          matching_apps = find_all_matching_apps_or_repos(apps, :github, sandbox)
+          ui.info("\nListing apps and their tables that doesn't have uuid as primary key type:-")
+          has_found_tables_without_uuid = false
+          matching_apps.each do |app|
+            begin
+              db_schema = Base64.decode64(client.contents(app, path: "./db/schema.rb").content)
+              tables_without_uuid = find_tables_without_uuid_as_primary_key(db_schema).compact
+              if !tables_without_uuid.nil?
+                has_found_tables_without_uuid = true
+                print_app_and_tables(app, tables_without_uuid)
+              end
+            rescue Octokit::NotFound
+              ui.error("There is no \"db/schema.rb\" file in the \"#{app}\" app.")
+            rescue StandardError => e
+              ExceptionHandler.new(e).process
+            end
+          end
+          ui.info("No apps found to have tables without uuid as primary key type") if !has_found_tables_without_uuid
+        end
+
+        private
+
+          def find_tables_without_uuid_as_primary_key(db_schema)
+            create_table_regex = /create_table.*?,\s*force:\s*:cascade\s*do\s*\|t\|/
+            db_schema.scan(create_table_regex).map do |create_table_line|
+              !create_table_line.include?("id: :uuid") ? create_table_line.scan(/"([^"]+)"/).flatten.first : nil
+            end
+          end
+
+          def print_app_and_tables(app, tables)
+            ui.info("\n#{app}:-")
+            tables.each do |table|
+              ui.say(" ↳#{table}")
+            end
+          end
+      end
+    end
+  end
+end

data/lib/neetob/cli/code/commands.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+require "thor"
+require_relative "audit"
+
+module Neetob
+  class CLI
+    module Code
+      class Commands < Thor
+        desc "audit", "Audit code base of neeto products to ensure they are properly maintained."
+        option :apps, type: :array, aliases: "-a", required: true, desc: "Neeto app names. Can be matched using the '*' wildcard. Example: \"neeto*\" \"neeto-cal-web\", also providing \"all\" as value matches all neeto product apps."
+        def audit
+          Audit.new(options[:apps], options[:sandbox]).run
+        end
+      end
+    end
+  end
+end

data/lib/neetob/cli/github/gems/release.rb

@@ -23,7 +23,7 @@ module Neetob
             matching_gems.each do |gem|
               ui.info("\nWorking on #{gem}\n")
               begin
-                clone_repo_in_tmp_dir("bigbinary/#{gem}")
+                shallow_clone_repo_in_tmp_dir("bigbinary/#{gem}")
                 build_gem(gem)
                 release_gem(gem)
                 if $?.success?

data/lib/neetob/cli/github/make_pr/base.rb

@@ -28,8 +28,8 @@ module Neetob
               repo.split("/").last
             end
 
-            def clone_repo_in_tmp_dir(repo)
-              `git clone --quiet git@github.com:#{repo}.git /tmp/neetob/#{repo_name_without_org_suffix(repo)}`
+            def shallow_clone_repo_in_tmp_dir(repo)
+              `git clone --quiet --depth 1 git@github.com:#{repo}.git /tmp/neetob/#{repo_name_without_org_suffix(repo)}`
             end
 
             def add_commmit_and_push_changes(repo)

data/lib/neetob/cli/github/make_pr/compliance_fix.rb

@@ -16,28 +16,32 @@ module Neetob
             @repos = repos
             @sandbox = sandbox
             @should_fix_nanos = should_fix_nanos
+            @failed_repos = []
           end
 
           def run
             matching_repos = should_fix_nanos ?
               add_org_suffix(find_all_matching_gems) :
               find_all_matching_apps_or_repos(repos, :github, sandbox)
+            @failed_repos = matching_repos
             delete_and_create_temp_neetob_dir
             matching_repos.each do |repo|
               ui.info("\nWorking on #{repo}\n")
               begin
-                clone_repo_in_tmp_dir(repo)
+                shallow_clone_repo_in_tmp_dir(repo)
                 check_and_delete_remote_branch(repo)
                 bundle_install(repo)
                 fix_neeto_audit(repo)
                 ui.info(add_commmit_and_push_changes(repo))
                 delete_local_feature_branch(repo)
-                res = client.create_pull_request(repo, "main", BRANCH_NAME, PR_TITLE)
+                pull_request = client.create_pull_request(repo, "main", BRANCH_NAME, PR_TITLE)
                 ui.success("PR created in \"#{repo}\" project successfully.")
+                @failed_repos.delete(repo)
               rescue StandardError => e
                 ExceptionHandler.new(e).process
               end
             end
+            print_failed_repos if @failed_repos.length > 0
             `rm -rf /tmp/neetob`
           end
 
@@ -50,6 +54,13 @@ module Neetob
             def fix_neeto_audit(repo)
               `#{cd_to_repo_in_tmp_dir(repo)} && bundle exec neeto-audit -a`
             end
+
+            def print_failed_repos
+              ui.info("\nCompliance fix failed for repos:-")
+              @failed_repos.each do |repo|
+                ui.error(repo)
+              end
+            end
         end
       end
     end

data/lib/neetob/cli/github/make_pr/script.rb

@@ -29,7 +29,7 @@ module Neetob
             matching_repos.each do |repo|
               ui.info("\n  Working on #{repo}  \n")
               begin
-                clone_repo_in_tmp_dir(repo)
+                shallow_clone_repo_in_tmp_dir(repo)
                 check_and_delete_remote_branch(repo)
                 update_script_file_permissions
                 execute_script(repo)

data/lib/neetob/cli/users/commands.rb

@@ -14,7 +14,7 @@ module Neetob
         end
 
         desc "commits", "List the commits of a user across the neeto apps"
-        option :apps, type: :array, aliases: "-a", default: ["*"], desc: "Github app names. Can be matched using the '*' wildcard. Example: \"neeto*\" \"neeto-cal-web\", also providing \"all\" as value matches all neeto repos."
+        option :apps, type: :array, aliases: "-a", default: ["*"], desc: "Github app names. Can be matched using the '*' wildcard. Example: \"neeto*\" \"neeto-cal-web\", also providing \"all\" as value matches all neeto apps."
         option :author, type: :string, required: true, desc: "Github username of the person whose commits you want to list"
         option :duration, type: :string, required: true, desc: "Duration for which you want to list the commits. Example: \"6.months\" \"10.days\""
         def commits

data/lib/neetob/cli.rb

@@ -9,6 +9,7 @@ module Neetob
     require_relative "cli/users/commands"
     require_relative "cli/fetchorupdate_repos/execute"
     require_relative "cli/local/commands"
+    require_relative "cli/code/commands"
 
     class_option :sandbox,
       {
@@ -32,6 +33,9 @@ module Neetob
     desc "local", "Interact with the local neeto repos"
     subcommand "local", Local::Commands
 
+    desc "code", "Interact with code base of neeto products"
+    subcommand "code", Code::Commands
+
     desc "make_repos_uptodate", "Uptodate all neeto repos"
     def make_repos_uptodate
       FetchorupdateRepos::Execute.new(options[:sandbox]).run

data/lib/neetob/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Neetob
-  VERSION = "0.2.7"
+  VERSION = "0.3.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: neetob
 version: !ruby/object:Gem::Version
-  version: 0.2.7
+  version: 0.3.0
 platform: ruby
 authors:
 - Udai Gupta
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-03-16 00:00:00.000000000 Z
+date: 2023-03-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thor
@@ -112,6 +112,8 @@ files:
 - lib/neetob.rb
 - lib/neetob/cli.rb
 - lib/neetob/cli/base.rb
+- lib/neetob/cli/code/audit.rb
+- lib/neetob/cli/code/commands.rb
 - lib/neetob/cli/fetchorupdate_repos/execute.rb
 - lib/neetob/cli/github/auth.rb
 - lib/neetob/cli/github/base.rb