nebulous 0.1.0 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7bd0a6f4d3f113c1f2d6538c030f2c88b750530a
-  data.tar.gz: a740e101add3bc77b8b0640b6bbffb034ca9df4f
+  metadata.gz: 29c4fbaeb91217e7196b9966ed06a349400a3d57
+  data.tar.gz: d1105b5b854fc279c757426c894bae1fc914b329
 SHA512:
-  metadata.gz: 07905a4a8ab161501018832be757ee6ec8d8b5d737ac4be332ed99bce006aecd8817a6683fc6caa44bf43240295c4d64d4786e596bb388db535e339b741a0753
-  data.tar.gz: b051ab11fb60c9b0130263134c07babb2127cc241a928dfe90c4b9c17fb999d9e33b2afe86e44094d0ec5c5ffa1e6af18e3289aaace4e19fd4063631f2a4ed9f
+  metadata.gz: 84645b05c28bbab1f3e5626377b0502f1aaa495d944197a44e8e767ed0c600726354ea0931f39ab48a016bf3577d497d89305c8aa06e813b530614186958c6f3
+  data.tar.gz: 455a43562135c5608bf8d7ef2de39a57df35cc39de43d017fc8efc7415cc0b0d2542a85dff4d3603e0ddc27409de661b733abea31521a30c008cafed73344131

data/lib/nebulous/delimiter_detector.rb

@@ -62,7 +62,15 @@ module Nebulous
     end
 
     def readline
-      File.open(path, &:readline).encode(encoding, invalid: :replace)
+      ln = ''
+
+      File.open(path, 'r') do |io|
+        while ln.chomp.empty?
+          ln += io.readline
+        end
+      end
+
+      ln.encode(encoding, invalid: :replace)
     end
   end
 end

data/lib/nebulous/input/parsing.rb

@@ -7,11 +7,12 @@ module Nebulous
       end
 
       def raw_headers
-        Row.parse(readline, options)
+        ln = read_complete_line
+        Row.parse(ln, options)
       end
 
       def read_headers
-        @headers ||= Row.headers(readline, options) if options[:headers]
+        @headers ||= Row.headers(read_complete_line, options)
       end
 
       def chunk

data/lib/nebulous/input/reader.rb

@@ -7,7 +7,7 @@ module Nebulous
 
       def read_complete_line
         ln = readline
-        while ln.count(options.quote_char) % 2 == 1
+        while ln.empty? || ln.count(options.quote_char) % 2 == 1
           ln += readline
         end
         ln

data/lib/nebulous/parser.rb

@@ -35,7 +35,7 @@ module Nebulous
 
     def process(&block)
       @index = 0
-      read_headers
+      read_headers if options[:headers]
       iterate(&block)
     ensure
       reset

data/lib/nebulous/version.rb

@@ -1,3 +1,3 @@
 module Nebulous
-  VERSION = '0.1.0'.freeze
+  VERSION = '0.1.2'.freeze
 end

data/spec/nebulous/parser_spec.rb

@@ -32,6 +32,18 @@ describe Nebulous::Parser do
             ["First name", "Last name", "From", "Access", "Qty"]
           )
         end
+
+        context 'around empty lines' do
+          let(:path) do
+            './spec/support/assets/crlf-comma-delimited-emptyline.csv'
+          end
+
+          it 'returns expected headers' do
+            expect(parser.headers).to eq(
+              ["First name", "Last name", "From", "Access", "Qty"]
+            )
+          end
+        end
       end
     end
 

data/spec/support/assets/crlf-comma-delimited-emptyline.csv

@@ -0,0 +1,22 @@
+
+First name,Last name,From,Access,Qty
+どーもありがとう,ミスター·ロボット,VIP,VIP,2
+Meghan,Koch,VIP,VIP,5
+Genoveva,Dare,Zach Graves,vip,5
+Eulalia,Stiedemann,VIP,GA,2
+Kaylie,Lakin,Vans,VIP,1
+Grace,Nienow,Vans,VIP,5
+Alberto,Upton,Vans,VIP,5
+Saige,Larson,Fan Club,VIP,4
+Virginie,Lindgren,Zach Graves,VIP,5 passes
+Ahmad,Bins,Vans,VIP,4
+Sydni,Turcotte,Vans,VIP,5
+Aylin,McLaughlin,Fan Club,GA,1
+Jimmy,Hoppe,Zach Graves,GA,5
+Isabell,Hills,Vans,VIP,4
+Chad,Anderson,Zach Graves,GA,4
+Arnold,Yundt,VIP,VIP,5
+Cary,Halvorson,Vans,GA,1
+Jedidiah,Feest,Zach Graves,GA,0
+Carol,Reilly,Zach Graves,VIP,2
+Heidi,Wunsch,Zach Graves,VIP,2 passes

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: nebulous
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.2
 platform: ruby
 authors:
 - Zach Graves
@@ -128,6 +128,7 @@ files:
 - spec/support/assets/clrf-batches.csv
 - spec/support/assets/cr-comma-delimited.csv
 - spec/support/assets/cr-lf-comma-delimited.csv
+- spec/support/assets/crlf-comma-delimited-emptyline.csv
 - spec/support/assets/crlf-comma-delimited.csv
 - spec/support/assets/crlf-dolla-delimited.csv
 - spec/support/assets/crlf-pipe-delimited.csv
@@ -167,6 +168,7 @@ test_files:
 - spec/support/assets/clrf-batches.csv
 - spec/support/assets/cr-comma-delimited.csv
 - spec/support/assets/cr-lf-comma-delimited.csv
+- spec/support/assets/crlf-comma-delimited-emptyline.csv
 - spec/support/assets/crlf-comma-delimited.csv
 - spec/support/assets/crlf-dolla-delimited.csv
 - spec/support/assets/crlf-pipe-delimited.csv