ndr_error 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6440497a620814b5319ea8ef2b1148e859c21007
-  data.tar.gz: d4235e5696214f5fe9661b18dc110d515c8d6ae3
+  metadata.gz: 1473293877a02707de297dd4bf2bb9d4e6677c83
+  data.tar.gz: 5017fe856872644b397ce6b217b6fed2a16215ca
 SHA512:
-  metadata.gz: 3c8a4b468dfbc7608d4590bcf384717107e5ae94eb740c837e23a9bb17867d30bbb118eb8e6e464aa85105e9dc36f7ed490a1771b1415270a35b9419bc6ae822
-  data.tar.gz: 849eaeab781ae04f98101a5b1ef49c6644e636044f1c9dc48f0b1d04bf70592cec89e1518cf66e928bb91b8a3ec93e003b5f0ad3a9697fef8be74daab41b1423
+  metadata.gz: 7b6842c12f597933f241a5f064ff6f605693a2b87b69deb01c1c8921af388f6954a13c2801588235b0b49fb3112a9683d059cbb6a7144f7202c4eb4cd447e1bd
+  data.tar.gz: efe89ecde782650ba58a3bac3c7084281bda525d49e1f2157b0a9664691e88159ad3a88cdfa5be64a355992e934d71a41f7f4831c500b830598c52f4e9620afe

data/Rakefile

@@ -26,7 +26,7 @@ load 'rails/tasks/engine.rake'
 Bundler::GemHelper.install_tasks
 
 require 'rake/testtask'
-require 'ndr_support/tasks'
+require 'ndr_dev_support/tasks'
 
 Rake::TestTask.new(:test) do |t|
   t.libs << 'lib'

data/app/assets/javascripts/ndr_error/ndr_error.js

@@ -33,7 +33,7 @@ jQuery(function() {
 
     // Show search hints.
     $searchField.popover({
-      title: '<strong>Filter by user, error, and print</strong>',
+      title: '<strong>Filter by keywords</strong>',
       content: ' \
         Separate search terms with [ , ; / ]. \
         <em>Terms with two characters or less are ignored</em>.',

data/app/helpers/ndr_error/errors_helper.rb

@@ -55,7 +55,7 @@ module NdrError
       css << ' btn-xs' if small
 
       url = fingerprint.ticket_url
-      link_to(text, /^http/i.match(url) ? url : "http://#{url}", class: css)
+      link_to(text, /^http/i =~ url ? url : "http://#{url}", class: css)
     end
 
     def edit_button_for(fingerprint)

data/app/models/ndr_error/log.rb

@@ -32,9 +32,20 @@ module NdrError
     before_create :register_system
     before_create :set_uuid_primary_key
 
+    def self.text_columns
+      user_column = NdrError.user_column.to_s
+      %w(error_class description).tap do |text_columns|
+        # Allow searching of `user_column` if it is textual:
+        if :string == columns_hash[user_column].try(:type)
+          text_columns << user_column
+        else
+          fail SecurityError, "Column '#{user_column}' not found!"
+        end
+      end
+    end
+
     def self.filter_by_keywords(keywords)
-      columns    = %w(description error_class) << NdrError.user_column.to_s
-      fragment   = columns.map { |column| "lower(#{column}) LIKE lower(:key)" }.join(' OR ')
+      fragment   = text_columns.map { |column| "lower(#{column}) LIKE lower(:key)" }.join(' OR ')
       name_match = keywords.map { |part| sanitize_sql([fragment, key: "%#{part}%"]) }.join(' OR ')
 
       where(name_match)
@@ -135,7 +146,7 @@ module NdrError
       self[:parameters_yml] = yml_dump
     end
 
-    alias_method :set_parameters_yml, :parameters_yml=
+    alias set_parameters_yml parameters_yml=
 
     # Returns the params hash associated
     # with the request.
@@ -174,7 +185,7 @@ module NdrError
 
       if request
         sources = [:parameters, :request_parameters, :query_parameters]
-        sources.inject(params) { |a, e| a.merge!(request.send e) }
+        sources.inject(params) { |a, e| a.merge! request.send(e) }
 
         # Redact any sensitive parameters:
         params.each do |name, _value|

data/app/views/ndr_error/errors/index.html.erb

@@ -1,5 +1,5 @@
-<div class="container">
-  <div id="search_form_container" class="pull-right">
+<div class="row">
+  <div id="search_form_container" class="col-md-4 col-md-offset-8">
   <%= form_tag(error_fingerprints_path, method: :get) do %>
     <div class="input-group">
       <% if @keywords.any? %>
@@ -14,38 +14,44 @@
   </div>
 </div>
 
-<h1>
-  Listing Errors Types
-</h1>
+<div class="row">
+  <h1 class="col-md-12">
+    Listing Errors Types
+  </h1>
+</div>
 
-<table class="table table-bordered table-hover">
-  <thead>
-    <tr>
-      <th>Most Recent Occurrence</th>
-      <th>Error</th>
-    </tr>
-  </thead>
-  <tbody>
-  <% @fingerprints.each do |fingerprint| %>
-    <% latest = fingerprint.latest_occurrence %>
-    <tr>
-      <td>
-        <%= latest_timestamp_for(fingerprint) %>
-        <%= multiple_occurrences_badge_for(fingerprint) %><br>
-        <%= latest_user_for(fingerprint, @keywords) %>
-      </td>
-      <td>
-        <div class="pull-right">
-          <%= ticket_link_for(fingerprint, true) if fingerprint.ticket_url.present? %>
-        </div>
+<div class="row">
+  <div class="col-md-12">
+    <table class="table table-bordered table-hover">
+      <thead>
+        <tr>
+          <th>Most Recent Occurrence</th>
+          <th>Error</th>
+        </tr>
+      </thead>
+      <tbody>
+      <% @fingerprints.each do |fingerprint| %>
+        <% latest = fingerprint.latest_occurrence %>
+        <tr>
+          <td>
+            <%= latest_timestamp_for(fingerprint) %>
+            <%= multiple_occurrences_badge_for(fingerprint) %><br>
+            <%= latest_user_for(fingerprint, @keywords) %>
+          </td>
+          <td>
+            <div class="pull-right">
+              <%= ticket_link_for(fingerprint, true) if fingerprint.ticket_url.present? %>
+            </div>
 
-        <%= latest ? link_to_fingerprint(fingerprint, latest) : 'N/A' %><br>
-        <%= digest_for(fingerprint, @keywords) %>
-      </td>
-    </tr>
-  <% end %>
-  </tbody>
-</table>
+            <%= latest ? link_to_fingerprint(fingerprint, latest) : 'N/A' %><br>
+            <%= digest_for(fingerprint, @keywords) %>
+          </td>
+        </tr>
+      <% end %>
+      </tbody>
+    </table>
 
-<span class="pull-right text-muted"><%= pagination_summary_for(@fingerprints) %></span>
-<%= will_paginate(@fingerprints) %>
+    <span class="pull-right text-muted"><%= pagination_summary_for(@fingerprints) %></span>
+    <%= will_paginate(@fingerprints) %>
+  </div>
+</div>

data/lib/ndr_error/backtrace_compression.rb

@@ -45,7 +45,7 @@ module NdrError
       string = data || ''
 
       if NdrError.compress_backtrace
-        data   = Base64.decode64(string)
+        data = Base64.decode64(string)
         begin
           string = Zlib::Inflate.inflate(data)
         rescue

data/lib/ndr_error/logging.rb

@@ -2,7 +2,7 @@ module NdrError
   # Module to contain helpers for logging
   module Logging
     # Which attributes can be populated when manually logging an exception:
-    ANCILLARY_ATTRS_WHITELIST = [:user_id, :user_roles, :svn_revision]
+    ANCILLARY_ATTRS_WHITELIST = [:user_id, :user_roles, :svn_revision].freeze
 
     # Log the given `exception`.
     def log(exception, ancillary_data, request_object)

data/lib/ndr_error/version.rb

@@ -1,4 +1,5 @@
+# frozen_string_literal: true
 # Contains the version of NdrError. Sourced by the gemspec.
 module NdrError
-  VERSION = '1.0.0'
+  VERSION = '1.0.1'.freeze
 end