nbp_exchange 0.0.1 → 0.0.2

data/lib/nbp_exchange/currency.rb

@@ -2,9 +2,13 @@
 module NbpExchange
 
   class Currency
-    CurrencieNames = {
+    SymbolsNames = {
       'eur' => 'Euro',
-      'usd' => 'Dolar amerykański'
+      'usd' => 'Dolar amerykański',
+      'chf' => 'Frank szwajcarski',
+      'gbp' => 'Funt szterling',
+      'czk' => 'Korona czeska',
+      'jpy' => 'jen (Japonia)'
     }
 
     attr_reader :symbol
@@ -14,11 +18,11 @@ module NbpExchange
     end
 
     def name
-      @name ||= CurrencieNames[symbol]
+      @name ||= SymbolsNames[symbol]
     end
 
     def rate(date)
-      @rate ||= load_rate(date)
+      @rate = load_rate(date)
     end
 
     def self.available_currency_keys

data/lib/nbp_exchange/currency_xml.rb

@@ -16,7 +16,10 @@ module NbpExchange
     def xml_name
       page = open(dir_url)
       doc = Nokogiri::HTML(page.read)
-      name = doc.text[/^#{@date.to_s}.+/][/(\w+.xml)/, 1]
+
+      date_row = doc.text[/^#{@date.to_s}.+/]
+      name = date_row ? date_row[/(\w+.xml)/, 1] : nil
+
       raise NoXMLForThisDate if name.nil? || name.empty?
       name
     end

data/lib/nbp_exchange/version.rb

@@ -1,3 +1,3 @@
 module NbpExchange
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/spec/nbp_exchange/currency_spec.rb

@@ -12,11 +12,23 @@ module NbpExchange
     end
 
     describe "#rate" do
-      let(:expected){Rate.new(currency, EXCHANGE_DATE, 4.4146)}
+      context "When rate exists" do
+        let(:expected){Rate.new(currency, EXCHANGE_DATE, 4.4146)}
+
+        it "should return average rate for given date" do
+          r = currency.rate(EXCHANGE_DATE)
+          r.average_exchange_rate.should == expected.average_exchange_rate
+        end
+      end
+
+      context "when rate doesn't exists for this date" do
+
+        it "should raise error" do
+          lambda {
+            r = currency.rate("2001-01-01")
+          }.should raise_error(NbpExchange::NoXMLForThisDate)
+        end
 
-      it "should return average rate for given date" do
-        r = currency.rate(EXCHANGE_DATE)
-        r.average_exchange_rate.should == expected.average_exchange_rate
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: nbp_exchange
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-11-08 00:00:00.000000000Z
+date: 2011-11-09 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
-  requirement: &2155739640 !ruby/object:Gem::Requirement
+  requirement: &2157147220 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2155739640
+  version_requirements: *2157147220
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &2155738980 !ruby/object:Gem::Requirement
+  requirement: &2157145600 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2155738980
+  version_requirements: *2157145600
 - !ruby/object:Gem::Dependency
   name: vcr
-  requirement: &2155738360 !ruby/object:Gem::Requirement
+  requirement: &2157144260 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2155738360
+  version_requirements: *2157144260
 - !ruby/object:Gem::Dependency
   name: fakeweb
-  requirement: &2155737580 !ruby/object:Gem::Requirement
+  requirement: &2157143560 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,7 +54,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2155737580
+  version_requirements: *2157143560
 description: ! 'Get average exchange rate for PLN polski zloty from specific date.
   This lib wraps http://rss.nbp.pl/kursy/xml2/2011/a/dir.aspx site. '
 email: