nba-stats 0.1.4 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3ac2154b740552370d6d0dfebb632ccb7a9f46e6
-  data.tar.gz: 953eb7e370dfeb946cdd6dfb043e40b886037979
+  metadata.gz: e43371a99a71996e7735c6e5c2fd02912bc8a00f
+  data.tar.gz: 03a7804220468aafb1ec96a3e7d93c903add0b33
 SHA512:
-  metadata.gz: 46231e69e73e79c36738fa5083b0627cc061e125b489f59d253c74bf4b7623208af5a4e2d2a68d915ee7fde75c356efed71ae8d6acf1008e1b46d3155e9702e9
-  data.tar.gz: e66a99f593616322a37a6cc5520e42e91b7cccb359ade4c27e7972d77caef0a14742ae26324781fba58252dfbcaacd6f2cb326980789a3e5d918579a06fa322f
+  metadata.gz: e00aece67b40ab210427da70d05aecb1914983126fe1ed95c287d0c41975be3ac4dc6b80eea60e202b671ceb0257aa55631d195715808666f4e479c778109b52
+  data.tar.gz: 80074837c175dcd034201eeb9104bdd5076bd425767ba2c417d4d40f391cef44fd0404b4cce9636846c89a80129e00432edff0b451367011d16384ccbfcaa893

data/lib/nba_stats/cli.rb

@@ -10,20 +10,7 @@ class NbaStats::CLI
     puts "Input exit to leave this program."
     puts "Here's the list of current teams"
 
-    make_teams if NbaStats::Team.all.empty?
-
-    rows = [["Eastern Conference", "Western Conference"]]
-    west_teams = NbaStats::Team.western_names
-    east_teams = NbaStats::Team.eastern_names
-
-    i = 0
-    while i < 15
-      rows << [east_teams[i], west_teams[i]]
-      i += 1
-    end
-
-    team_table = Terminal::Table.new rows: rows
-    puts team_table
+    display_teams
 
     input = ""
     while input != "exit"
@@ -52,27 +39,47 @@ class NbaStats::CLI
     NbaStats::Team.create_from_collection(teams_array)
   end
 
+  def display_teams
+    make_teams if NbaStats::Team.all.empty?
+
+    rows = [["Eastern Conference", "Western Conference"]]
+    west_teams = NbaStats::Team.western_names
+    east_teams = NbaStats::Team.eastern_names
+
+    i = 0
+    while i < 15
+      rows << [east_teams[i], west_teams[i]]
+      i += 1
+    end
+
+    puts Terminal::Table.new rows: rows
+  end
+
   def display_roster(requested_team)
     team = NbaStats::Team.all.detect {|team| team.name == requested_team}
+
     team.add_players if team.players.empty?
+
     puts team.name + " roster:"
+
     rows = [["Number", "Name", "Position", "Height", "Experience"]]
     team.players.each do |player|
       rows << [player.number, player.name, player.position, player.height, player.experience]
     end
-    roster_table = Terminal::Table.new rows: rows
-    puts roster_table
+
+    puts Terminal::Table.new rows: rows
   end
 
   def display_player_stats(requested_player)
     player = NbaStats::Player.all.detect {|player| player.name == requested_player}
-    stats_hash = NbaStats::Scraper.get_player_stats(player)
-    player.add_player_stats(stats_hash)
+
+    player.add_player_stats
+
     rows = [["Points/Game", "Assists/Game", "Rebounds/Game", "Blocks/Game", "Steals/Game", "FG%", "3P%", "FT%", "Minutes/Game",]]
     rows << [player.points_pg, player.assists_pg, player.rebounds_pg, player.blocks_pg, player.steals_pg, player.fg_percentage, player.three_percentage, player.ft_percentage, player.minutes_pg]
+    
     puts "Here are #{player.name}'s 2015-16 stats: "
-    stats_table = Terminal::Table.new rows: rows
-    puts stats_table
+    puts Terminal::Table.new rows: rows
   end
 
 end

data/lib/nba_stats/player.rb

@@ -24,7 +24,8 @@ class NbaStats::Player
     end
   end
 
-  def add_player_stats(stats_hash)
+  def add_player_stats
+    stats_hash = NbaStats::Scraper.get_player_stats(self)
     stats_hash.each do |key,value|
       self.send("#{key}=", value)
     end

data/lib/nba_stats/scraper.rb

@@ -17,7 +17,7 @@ class NbaStats::Scraper
     assigned_teams = []
     teams.each do |team|
       name = team.text
-      team_url = "http://www.basketball-reference.com"+ team["href"]
+      team_url = "http://www.basketball-reference.com" + team["href"]
       hash = {name: name, team_url: team_url, conference: conference}
       assigned_teams << hash unless assigned_teams.include? hash
     end
@@ -35,11 +35,7 @@ class NbaStats::Scraper
       position = data_array[3]
       height = data_array[4]
       data_array[8] == "R" ? experience = "Rookie" : experience = data_array[8] + " Years"
-
-      #Below is messy workaround
-      #Cleaner player.css("a").first["href"] works outside of .each loop, but returns "undefined method '[]' for nil" inside .each
-      player_url = player.css("a").map {|element| element["href"]}.first
-      player_url = "http://www.basketball-reference.com" + player_url.to_s
+      player_url = "http://www.basketball-reference.com" + player.css("a").first["href"]
 
       hash = {name: name, number: number, position: position, height: height, experience: experience, player_url: player_url}
       players_array << hash
@@ -51,18 +47,17 @@ class NbaStats::Scraper
     page = open_page(player.player_url)
 
     season = page.css("table#per_game tr.full_table").last
-    stats_array = season.text.gsub("\n", "").strip.split("   ")
-
+    stats_array = season.text.split("\n").map {|x| x.strip}
     stats_hash = {
-      points_pg: stats_array[29], 
-      assists_pg: stats_array[24], 
-      rebounds_pg: stats_array[23], 
-      blocks_pg: stats_array[26], 
-      steals_pg: stats_array[25], 
-      minutes_pg: stats_array[7], 
-      fg_percentage: stats_array[10], 
-      three_percentage: stats_array[13], 
-      ft_percentage: stats_array[20]
+      points_pg: stats_array[30], 
+      assists_pg: stats_array[25], 
+      rebounds_pg: stats_array[24], 
+      blocks_pg: stats_array[27], 
+      steals_pg: stats_array[26], 
+      minutes_pg: stats_array[8], 
+      fg_percentage: stats_array[11], 
+      three_percentage: stats_array[14], 
+      ft_percentage: stats_array[21]
     }
 
   end

data/lib/nba_stats/team.rb

@@ -19,7 +19,7 @@ class NbaStats::Team
 
   def self.create_from_collection(teams_array)
     teams_array.each do |team|
-      new_team = NbaStats::Team.new(team) unless @@all.include? team
+      new_team = NbaStats::Team.new(team)
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: nba-stats
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors:
 - Alex Barron