navigable 1.3.0 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3a004a4e2480872ee2a0130049ad9ef937a051ce833e531ac7630e959619d810
-  data.tar.gz: e8da43504809998f63d4814e6e811210bed57e08da0fbeb129ed0cf6771d152b
+  metadata.gz: cb34750833af0f6d8cd1acbd902c18aac498d4f4ccc7395aaec1013f9a558b99
+  data.tar.gz: b7724f9edac3d02dd90c7f26b8a3713b2449700a3e89a68d43e439927d954571
 SHA512:
-  metadata.gz: d59a86ed9f40d4d1def574099592f46b4434f78deb0aa1b6e89d41fd6cc13d8c89db2393885bff1449113741c9e566cecd6d30848962c2afd6da6f23dbf29abf
-  data.tar.gz: c159acdb8be562e419540b01cccf1efb9df1b8dfa37f9fd85b7e6ac7a455fb54dd080c29d062b96460fb8f393688d15061ac10466b68dd83f0e025309a34aec3
+  metadata.gz: 202e9957715004b886d76be87d2b6c856809b4ca04b2f9a62432f460dc2c3f28f8cd31a13bd2cf85bfed329765c6082fb40ccee3ee0c666b930c499517c818ec
+  data.tar.gz: e7dfad712e84d3c7339ba71749c4525e36e1b087cccaaca074e6967b509fb192f70b750460881cbc7ba194955cde4dd687e21eb4bac3b3cefb2cb6e2e74f14af

data/README.md

@@ -32,22 +32,13 @@ A simple, highly-performant, Rack-based router.
 **[Navigable Server][server]** *(coming soon)*<br>
 A Rack-based server for building Ruby and Navigable web applications.
 
-</td>
-</tr>
-<tr height="140">
-<td width="130"><img alt="Telescope" src="https://raw.githubusercontent.com/first-try-software/navigable/main/assets/telescope.png"></td>
-<td>
-
-**Navigable API** *(coming soon)*<br>
-An extension of Navigable Server for building restful JSON APIs.
-
 </td>
 </tr>
 <tr height="140">
 <td width="130"><img alt="Map" src="https://raw.githubusercontent.com/first-try-software/navigable/main/assets/map.png"></td>
 <td>
 
-**Navigable GraphQL** *(coming soon)*<br>
+**[Navigable GraphQL][graphql]** *(coming soon)*<br>
 An extension of Navigable Server for building GraphQL APIs.
 
 </td>
@@ -195,12 +186,6 @@ Or install it yourself as:
 
     $ gem install navigable
 
-## Development
-
-After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
-
-To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
-
 ## Contributing
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/first-try-software/navigable.
@@ -222,4 +207,5 @@ Everyone interacting in the Navigable project's codebases, issue trackers, chat
 [wiki]: https://github.com/first-try-software/navigable/wiki
 [navigable]: https://github.com/first-try-software/navigable
 [router]: https://github.com/first-try-software/navigable-router
-[server]: https://github.com/first-try-software/navigable-server
+[server]: https://github.com/first-try-software/navigable-server
+[graphql]: https://github.com/first-try-software/navigable-graphql

data/lib/navigable.rb

@@ -1,5 +1,6 @@
 # frozen-string-literal: true
 
+require 'concurrent'
 require 'manufacturable'
 
 require 'navigable/version'

data/lib/navigable/command.rb

@@ -11,25 +11,28 @@ module Navigable
 
     def self.extended(base)
       base.extend(Manufacturable::Item)
+      base.extend(ClassMethods)
       base.include(Observable)
+      base.include(InstanceMethods)
+    end
 
-      base.instance_eval do
-        def corresponds_to(key)
-          super(key, TYPE)
-        end
+    module ClassMethods
+      def corresponds_to(key)
+        super(key, TYPE)
       end
+    end
 
-      base.class_eval do
-        attr_reader :params, :observers
+    module InstanceMethods
+      attr_reader :params, :observers, :resolver
 
-        def inject(params: {}, observers: [])
-          @params = params
-          @observers = observers
-        end
+      def inject(params: {}, observers: [], resolver: NullResolver.new)
+        @params = params
+        @observers = observers
+        @resolver = resolver
+      end
 
-        def execute
-          raise NotImplementedError.new(EXECUTE_NOT_IMPLEMENTED_MESSAGE)
-        end
+      def execute
+        raise NotImplementedError.new(EXECUTE_NOT_IMPLEMENTED_MESSAGE)
       end
     end
   end

data/lib/navigable/dispatcher.rb

@@ -25,7 +25,7 @@ module Navigable
     end
 
     def observers
-      Manufacturable.build_all(Observer::TYPE, key) { |observer| observer.inject(params: params) }.push(resolver)
+      Manufacturable.build_all(Observer::TYPE, key) { |observer| observer.inject(params: params) }
     end
 
     def command
@@ -33,7 +33,7 @@ module Navigable
     end
 
     def build_command
-      Manufacturable.build_one(Command::TYPE, key) { |command| command.inject(params: params, observers: observers) }
+      Manufacturable.build_one(Command::TYPE, key) { |command| command.inject(params: params, observers: observers, resolver: resolver) }
     end
   end
 end

data/lib/navigable/executor.rb

@@ -0,0 +1,9 @@
+# frozen-string-literal: true
+
+module Navigable
+  class Executor
+    def self.execute(&block)
+      ENV['CONCURRENT_OBSERVERS'] ? Concurrent.global_io_executor.post(&block) : block.call
+    end
+  end
+end

data/lib/navigable/observable.rb

@@ -1,39 +1,29 @@
 # frozen-string-literal: true
 
+require 'navigable/observer_map'
+require 'navigable/executor'
+
 module Navigable
   module Observable
     OBSERVERS_NOT_IMPLEMENTED_MESSAGE = 'Class must implement `observers` method.'
+    RESOLVER_NOT_IMPLEMENTED_MESSAGE = 'Class must implement `resolver` method.'
 
     def observers
       raise NotImplementedError.new(OBSERVERS_NOT_IMPLEMENTED_MESSAGE)
     end
 
-    def successfully(*args)
-      observers.each { |observer| observer.on_success(*args) }
-    end
-
-    def failed_to_validate(*args)
-      observers.each { |observer| observer.on_failure_to_validate(*args) }
-    end
-
-    def failed_to_find(*args)
-      observers.each { |observer| observer.on_failure_to_find(*args) }
+    def resolver
+      raise NotImplementedError.new(RESOLVER_NOT_IMPLEMENTED_MESSAGE)
     end
 
-    def failed_to_create(*args)
-      observers.each { |observer| observer.on_failure_to_create(*args) }
-    end
-
-    def failed_to_update(*args)
-      observers.each { |observer| observer.on_failure_to_update(*args) }
-    end
-
-    def failed_to_delete(*args)
-      observers.each { |observer| observer.on_failure_to_delete(*args) }
-    end
+    ObserverMap::METHODS.each_pair do |observable_method, observer_method|
+      define_method(observable_method) do |*args, **kwargs|
+        observers.each do |observer|
+          Navigable::Executor.execute { observer.send(observer_method, *args, **kwargs) }
+        end
 
-    def failed(*args)
-      observers.each { |observer| observer.on_failure(*args) }
+        resolver.send(observer_method, *args, **kwargs)
+      end
     end
   end
 end

data/lib/navigable/observer.rb

@@ -8,28 +8,30 @@ module Navigable
 
     def self.extended(base)
       base.extend(Manufacturable::Item)
+      base.extend(ClassMethods)
       base.include(ObserverInterface)
+      base.include(InstanceMethods)
+    end
 
-      base.instance_eval do
-        def observes_all_commands
-          corresponds_to_all(TYPE)
-        end
+    module ClassMethods
+      def observes_all_commands
+        corresponds_to_all(TYPE)
+      end
 
-        def observes(key)
-          corresponds_to(key, TYPE)
-        end
+      def observes(key)
+        corresponds_to(key, TYPE)
       end
+    end
 
-      base.class_eval do
-        attr_reader :params
+    module InstanceMethods
+      attr_reader :params
 
-        def inject(params: {})
-          @params = params
-        end
+      def inject(params: {})
+        @params = params
+      end
 
-        def observed_command_key
-          manufacturable_item_key
-        end
+      def observed_command_key
+        manufacturable_item_key
       end
     end
   end

data/lib/navigable/observer_interface.rb

@@ -1,13 +1,11 @@
 # frozen-string-literal: true
 
+require 'navigable/observer_map'
+
 module Navigable
   module ObserverInterface
-    def on_success(*args, **kwargs); end
-    def on_failure_to_validate(*args, **kwargs); end
-    def on_failure_to_find(*args, **kwargs); end
-    def on_failure_to_create(*args, **kwargs); end
-    def on_failure_to_update(*args, **kwargs); end
-    def on_failure_to_delete(*args, **kwargs); end
-    def on_failure(*args, **kwargs); end
+    ObserverMap::METHODS.values.each do |observer_method|
+      define_method(observer_method) { |*args, **kwargs| }
+    end
   end
 end

data/lib/navigable/observer_map.rb

@@ -0,0 +1,15 @@
+# frozen-string-literal: true
+
+module Navigable
+  class ObserverMap
+    METHODS = {
+      successfully: :on_success,
+      failed_to_validate: :on_failure_to_validate,
+      failed_to_find: :on_failure_to_find,
+      failed_to_create: :on_failure_to_create,
+      failed_to_update: :on_failure_to_update,
+      failed_to_delete: :on_failure_to_delete,
+      failed: :on_failure
+    }.freeze
+  end
+end

data/lib/navigable/resolver.rb

@@ -9,22 +9,24 @@ module Navigable
 
     def self.extended(base)
       base.extend(Manufacturable::Item)
+      base.extend(ClassMethods)
       base.include(ObserverInterface)
+      base.include(InstanceMethods)
+    end
 
-      base.instance_eval do
-        def default_resolver
-          default_manufacturable(TYPE)
-        end
+    module ClassMethods
+      def default_resolver
+        default_manufacturable(TYPE)
+      end
 
-        def resolves(key)
-          corresponds_to(key, TYPE)
-        end
+      def resolves(key)
+        corresponds_to(key, TYPE)
       end
+    end
 
-      base.class_eval do
-        def resolve
-          raise NotImplementedError.new(RESOLVE_NOT_IMPLEMENTED_MESSAGE)
-        end
+    module InstanceMethods
+      def resolve
+        raise NotImplementedError.new(RESOLVE_NOT_IMPLEMENTED_MESSAGE)
       end
     end
   end

data/lib/navigable/version.rb

@@ -1,5 +1,5 @@
 # frozen-string-literal: true
 
 module Navigable
-  VERSION = "1.3.0"
+  VERSION = "1.4.0"
 end

data/navigable.gemspec

@@ -24,6 +24,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
+  spec.add_dependency "concurrent-ruby", "~> 1.1.7"
   spec.add_dependency "manufacturable", "~> 1.5"
 
   spec.add_development_dependency "bundler", "~> 2.0"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: navigable
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.4.0
 platform: ruby
 authors:
 - Alan Ridlehoover
@@ -9,8 +9,22 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-09-29 00:00:00.000000000 Z
+date: 2020-10-04 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: concurrent-ruby
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.1.7
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.1.7
 - !ruby/object:Gem::Dependency
   name: manufacturable
   requirement: !ruby/object:Gem::Requirement
@@ -108,7 +122,6 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
-- ".ruby-version"
 - ".travis.yml"
 - CODE_OF_CONDUCT.md
 - Gemfile
@@ -120,10 +133,12 @@ files:
 - lib/navigable.rb
 - lib/navigable/command.rb
 - lib/navigable/dispatcher.rb
+- lib/navigable/executor.rb
 - lib/navigable/null_resolver.rb
 - lib/navigable/observable.rb
 - lib/navigable/observer.rb
 - lib/navigable/observer_interface.rb
+- lib/navigable/observer_map.rb
 - lib/navigable/resolver.rb
 - lib/navigable/version.rb
 - navigable.gemspec

data/.ruby-version

@@ -1 +0,0 @@
-2.7.1